GNU bug report logs - #21497
install from multiple sources to -t target uses incorrect folder on some sources

Previous Next

Package: coreutils;

Reported by: Chris Severance <aur.severach <at> spamgourmet.com>

Date: Wed, 16 Sep 2015 15:24:02 UTC

Severity: normal

Done: Pádraig Brady <P <at> draigBrady.com>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 21497 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>,
 Chris Severance <aur.severach <at> spamgourmet.com>, 21497 <at> debbugs.gnu.org
Cc: Coreutils <coreutils <at> gnu.org>
Subject: Re: bug#21497: install from multiple sources to -t target uses
 incorrect folder on some sources
Date: Sun, 3 Jan 2016 00:38:03 +0100
On 01/02/2016 11:28 PM, Pádraig Brady wrote:
> Subject: [PATCH 1/3] install: fix relative copies to absolute directory with
>  -D
> 
> * src/install.c (mkancesdirs_safe_wd): Unconditionally
> restore the current working directory when possible called
> multiple times (from install_file_in_dir()).

Minor nit:
  s/possible/possibly/ ?

The actual change, the test case and the other 2 patches look good to me.

Thanks & have a nice day,
Berny




This bug report was last modified 9 years and 221 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.