GNU bug report logs - #21440
25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions")

Previous Next

Full log

Message #17 received at 21440 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Stefan Kangas <stefan <at> marxist.se>, 21440 <at> debbugs.gnu.org,
 Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info
 "(elisp) Coding Conventions")
Date: Mon, 12 Jul 2021 05:56:50 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> But I don't know whether -unload-function has the same problems that
> -unload-hook had?

At least now (docstring of `unload-feature'):

| If a function `FEATURE-unload-function' is defined, this function
| calls it with no arguments, before doing anything else.  That function
| can do whatever is appropriate to undo the loading of the library.  If
| `FEATURE-unload-function' returns non-nil, that suppresses the
| standard unloading of the library.  Otherwise the standard unloading
| proceeds.

So it can now be controlled whether standard unloading stuff will still
be performed (last problem mentioned in my report -> solved).

This questionable paragraph is sill in the manual however:

   • If loading the file adds functions to hooks, define a function
     ‘FEATURE-unload-function’, where FEATURE is the name of the feature
     the package provides, and make it undo any such changes.  Using
     ‘unload-feature’ to unload the file will run this function.  *Note
     Unloading::.

I guess it is a bit outdated and this had been automated long ago,
although partially heuristically.  Instead it could say what typical
non-standard changes need to be handled in an unload-function.  It is
unrealistic that every author cares about implementing a non-heuristic
version of the automatic unloading code.

Or, say shortly what unloading actually already does of its own, and
that the library developer should care about the rest.


Thanks,

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.