Subject: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions")

From: Lars Ingebrigtsen <[email-masked]>
Date: Fri, 16 Jul 2021 11:01:43 +0200

Michael Heerdegen <[email-masked]> writes:

>> Well, it recommends writing an unload function, although this is rarely
>> necessary.  So it should say something about when it's necessary.
>
> Yes, exactly.

I've now clarified that section...

> The second paragraph of `unload-feature' has some good examples 

... but I don't think we need to go into details about what
unload-feature does in the Coding Conventions section in the manual.

> (should we add advices to that list btw?).

Hm...  does unload-feature remove advices?  Let's see..

Well, there's this:

(defun loadhist--unload-function (x)
  (let ((fun (cdr x)))
    (when (fboundp fun)
      (when (fboundp 'ad-unadvise)
	(ad-unadvise fun))

Hm...  but is that what it does?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no