From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 07:43:50 2015 Received: (at submit) by debbugs.gnu.org; 9 Sep 2015 11:43:50 +0000 Received: from localhost ([127.0.0.1]:53416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZdn4-0000kD-AQ for submit@debbugs.gnu.org; Wed, 09 Sep 2015 07:43:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49894) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZdn2-0000k5-6F for submit@debbugs.gnu.org; Wed, 09 Sep 2015 07:43:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZdn1-0008AF-59 for submit@debbugs.gnu.org; Wed, 09 Sep 2015 07:43:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZdn1-0008AB-3J for submit@debbugs.gnu.org; Wed, 09 Sep 2015 07:43:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZdn0-0001yN-7m for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 07:43:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZdmv-000860-4h for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 07:43:46 -0400 Received: from mout.web.de ([212.227.15.4]:49839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZdmu-00084r-VZ for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 07:43:41 -0400 Received: from drachen.dragon ([90.187.248.139]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0Lcxjk-1Yrodv0ivY-00iCZF for ; Wed, 09 Sep 2015 13:43:39 +0200 From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") Date: Wed, 09 Sep 2015 13:43:36 +0200 Message-ID: <87k2rzakd3.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:D7LWtD0DQkKQHHPHQT5cUEIJjvd8LsWCmGmt7B8DSif0lbOpo6s +C6XmzNmAeFp6Uq8SXoqri5GTIY93KAHjynO2qEGxdWrTRs0I5gPiGljRfzV69Mu7VVn8Sq HFlTUySz0ZZgB0aFfrQ91MByvHgpgFT0eWnMJxwXp/QDv37BK0EYtcLTyu8SWmqwkULv02v MjJtYLR7V9MZaLkQk/26Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:sosMcE16/z0=:FADKiKJqnj80QU4alC3pl+ i8q0FofCUt0/pBcUt24xeTJrXZpsrfskrPMMBovy/PyZRS0EvZ+VrtrC2iHSqDunqbtvEwVQ7 nU1sD36RncLvwC8q09HCKgfVG+7gNybJExNpcPcFbQ2GE8xQVmlQeZPoVanj6BCz0vMjoJHH/ tTq+hbaopjywHyWu09RbPoxl6rCUEKFz5HhrOY4LiWDo4xk50zcbkdmRIs1F5fg7hzz76IEUi egf57JKHVJ5A+kdgICI7zhwWGpD6MmLSh+e7AFmK1kRF3zaRLdpOO/g8+kLJ6jW+TIlNm7jTQ ltriRurR3HSnQoUMVDTpAW7pXwksnyXiFupbdFaoBPwPv7KhZffYBROwFlGMTRAr+Nr+JaQPM zfdaU/I/t4LpvFI2ufdLwD7zwAMZOGQq2vVUKT4N+UdpY8VEQbfT0s6tkfDBVGkRsa4q3+UYE /Wh6obCrX9EuL8/1B/Hcd/RxZwEUMEBk0BpsK2EF1quDwY6mJg7spNPLrbEyO3Ah+jZQ18Nbs 3dtI14LkHBc3MA9j5MGIOoQSaPzoGETeRnwApG5ejBNdvFL4nA3YLqcoCq551Rj+lI3FUcJMr mXF7ZLz5iA1mXbK6VuTmuH9ch1Or07V8qwgcztcVuwx9Jzb54J/kyYf6ngDUCNnZgPvoPW0ld +BST5ILbVSfRER9m2ZibFmnlqNvBRG6bIyYvHlZzg0jvwJV9C3kwiwVPMbpBDZ5dPdAGsp79d 8PDBkrpSzpoPkJTFjfZKfzOG5mxoUT2/Cvjrjg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hi, In (info "(elisp) Coding Conventions"): =E2=80=A2 If loading the file adds functions to hooks, define a function =E2=80=98FEATURE-unload-hook=E2=80=99, where FEATURE is the name of th= e feature the package provides, and make it undo any such changes. Using =E2=80=98unload-feature=E2=80=99 to unload the file will run this func= tion. *Note Unloading. A problematic tip: - it is unnecessary for that reason. AFAIK FEATURE's functions are removed automatically from hooks by `unload-feature'. - When you follow the advice, `unload-feature' will skip removing entries from `auto-mode-alist', so you would have to do that yourself. - Isn't `FEATURE-unload-function' the preferred thing to use today? The doc string of `unload-feature' doesn't even mention FEATURE-unload-hook variables. Seems it is discouraged to be used. BTW, I miss a comment what I should do if a feature added functions to the buffer local binding of a hook. Does `unload-feature' take care of that (doesn't seem so)? Nothing about this in (info "(elisp) Unloading"). Thanks, Michael. In GNU Emacs 25.0.50.19 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6) of 2015-09-07 Repository revision: af629df80605614c645ba6539bb98d4f1e990925 Windowing system distributor 'The X.Org Foundation', version 11.0.11702000 System Description: Debian GNU/Linux testing (stretch) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 09:53:12 2020 Received: (at 21440) by debbugs.gnu.org; 15 Aug 2020 13:53:12 +0000 Received: from localhost ([127.0.0.1]:54468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6wcS-0006VB-1K for submit@debbugs.gnu.org; Sat, 15 Aug 2020 09:53:12 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:34617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6wcN-0006Uc-0Q for 21440@debbugs.gnu.org; Sat, 15 Aug 2020 09:53:11 -0400 Received: by mail-yb1-f182.google.com with SMTP id u6so947723ybf.1 for <21440@debbugs.gnu.org>; Sat, 15 Aug 2020 06:53:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=dPijjKZIDFmqDkxhfm+4Djk3Dl3bYeUoY3AeKs+spmg=; b=hzv3PN//0r67ryrwypVwPxpL2sgf99+0fJitkEwM7zpmWLK2E25JBhzmTkR0DxJcGm 2zU00K6h+ctiuy2/ZI7TH2a3zEVKUe8+SGzmI1LXhxPwDxDc8NX6IHtgalaP1KVw+2r/ jknuMeHjuWz77quOWynzGCPpoEsZBGqo72jFMjIk3smpz7nDTydvHBMgVreG4yWdv+jS SmmEM1M92l4bve1nnayGd2CKU/QgXo4Ticeemd/7XT7WGZWV9BXK+P+hZhDApSa+A2/i /o2T8Ro0YOJ3T4Fg5/purahZLfxoCXEWm0lnGAGZ1KhdfzOf4J4BNi3OhtSEnJfvS8xv vTUA== X-Gm-Message-State: AOAM532iw+TRW3aLtGQdnyKeisFVWerhkTac+NHfA5XsHmGRkx9cTPHZ kUjQ4+4TLCdIOAVpQ8R5WvyiRtfmy36tHKeUdU8= X-Google-Smtp-Source: ABdhPJwqmHr+7hFfEQk89c3VicrU7m+e3er7c/oVuNry9dtAIhbjwhsS6wWFq0fEEwQwFFa9X/QuZKzQOKL6zI2hZs4= X-Received: by 2002:a25:4609:: with SMTP id t9mr9758349yba.231.1597499581182; Sat, 15 Aug 2020 06:53:01 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 15 Aug 2020 06:53:00 -0700 From: Stefan Kangas In-Reply-To: <87k2rzakd3.fsf@web.de> (Michael Heerdegen's message of "Wed, 09 Sep 2015 13:43:36 +0200") References: <87k2rzakd3.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sat, 15 Aug 2020 06:53:00 -0700 Message-ID: Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") To: Michael Heerdegen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 21440 Cc: 21440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Michael Heerdegen writes: > Hi, > > In (info "(elisp) Coding Conventions"): > > =E2=80=A2 If loading the file adds functions to hooks, define a functi= on > =E2=80=98FEATURE-unload-hook=E2=80=99, where FEATURE is the name of = the feature the > package provides, and make it undo any such changes. Using > =E2=80=98unload-feature=E2=80=99 to unload the file will run this fu= nction. *Note > Unloading. > > A problematic tip: > > - it is unnecessary for that reason. AFAIK FEATURE's functions are > removed automatically from hooks by `unload-feature'. > > - When you follow the advice, `unload-feature' will skip removing > entries from `auto-mode-alist', so you would have to do that yourself. > > - Isn't `FEATURE-unload-function' the preferred thing to use today? > The doc string of `unload-feature' doesn't even mention > FEATURE-unload-hook variables. Seems it is discouraged to be used. The above analysis seems correct to me. There should be no need to use `FEATURE-load-hook', in fact from reading `unload-feature' it seems worse. But I don't know too much about this, so I'm not sure if there's some fundamental aspect I'm overlooking. If the above is indeed true, we should probably just remove the advice from coding conventions. And it should be announced in NEWS, probably together with some warnings emitted by `unload-feature' if there is such a `FEATURE-unload-hook' defined. Is there anyone else who could provide some insight here? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 17 07:15:26 2020 Received: (at 21440) by debbugs.gnu.org; 17 Aug 2020 11:15:26 +0000 Received: from localhost ([127.0.0.1]:59416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7d6s-0006Fp-C5 for submit@debbugs.gnu.org; Mon, 17 Aug 2020 07:15:26 -0400 Received: from mout.gmx.net ([212.227.17.22]:40153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7d6p-0006Fa-MM for 21440@debbugs.gnu.org; Mon, 17 Aug 2020 07:15:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597662916; bh=RTsQoV/bwpW80aBnTRfgatqdKZGpMi9CFP/uHIYCJjo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=SF2+r7VcsA/hx9eJEsq1IiA/u5JJEt5zYjwtjctsr9q2P4GZTVZgy+JmXyTD+E/Dx gsDpoIm63JLXnVxIBZuBPJL4TWZ+8HJwZ4lAKfuyvd7VEHq8sP0oCgE1FkmC732eS9 g7qubbmRovs4B6wwzkGTSYuK+3iW/Kjh3nLw1g1s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.45.43]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MRTNF-1kM9I12lNN-00NOmb; Mon, 17 Aug 2020 13:15:16 +0200 From: Michael Albinus To: Stefan Kangas Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> Date: Mon, 17 Aug 2020 13:15:14 +0200 In-Reply-To: (Stefan Kangas's message of "Sat, 15 Aug 2020 06:53:00 -0700") Message-ID: <871rk5le0t.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:svpRw6L+N1tAwioAHoItB3gFSNgbwci24OMaMTMFSi9ef63L1WQ xLJsAhrMVM6FLq42cgNAB7AlPH5SS5s0i/tq/WivbYC1Ev8donYxceDTMnKMv+rchbP8xuq HJDAK32lJkWysg5eBD+fMWvx/dtJ+X7qnNQCgNMzuX/EwTzj7n8fCA8mIqXEQ+TzGho8QXy rTyba+py/TZ4PhKShI5sg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:KR3q6dpJulQ=:6duWJ7UqGZRHjplqhzAXNU xb6qTumE9+MXz1kIMyHW6Vrf1HXgc3bp0oA7eD/3JiHzNUJjsy9XmEFa58nLqT4jTWb82feGO gSAlMdsFvBgCChdgYTYcB3/7wGBf5PoO3vnCXEHfjGK7VLePrQLLhx/T+rplrGCSoenAv1oha v6Auxj9oKSeiec5liP2QoUwqntSErzu5G29L+uZXP8Ent4cDspn5iUm4a2jgd3082zvOg2+SG evYsEXq7n5FxVxcgAfv7oJiMzKJOhaulHkK+ZQP7wSkgdQ7rlRP+GI3Z0bPo0gxs86p7y3BUK nZQQKtSu4cHZT6waze69kNsR1ZwU9BaiaY5hKgigJU/tsMhDknHTEbt2kjdaDDUFHH+iK70uu DMYP/aUyjHqsoCfbbL8qxzgGw9T+8GYb32FFLeq5LBCOQ9rPkSZAqcsgBBWxfqTwGBBCHyUUP 3cVhTCwWvrg9lTkpS8+RVWyFYRwOEWfYuUZYcgR6X2gXbsLTbb7uHzfh/FfUn6TBkXT+IfMvt HCB9n+o7KJMAmrn9IqqccaTxVS/kbeHi6STpI0YOrDvA0b6QM3OWonp5o/zcx5HL3HTVZgFm0 p0yQJlsSiMEMAd5b4H9/cBfcZIkQotgciwznsbaFSdp8yuTf7PJN1V1VUx2FEGnsrAuGEpy76 RiZnpi78r294y8Ic/F+TvOfA9Y66flexb0MNMcuY5jZZetF6Og8GNltSPUuawwcLNi3eA2l8V GIQG7C5aYCnsWxx0q5h6J742gx4mb1ZF6DdVZZHZpxqQ7x5B/0iBkauW0QBkA0ok4hcL8Uq36 vSu0IMkubVDwcu6Ur+EOPWmrY0LCsZ8Lr1QZg2njQWpwlnWulfmE7o6yf0V9+EM+Y2QIkMsjU Mg9MKUj6Mrlbl1PNUDL0KxMdJXksr/qNmxaWgOEN6R9dfyMdADyAunUv4fnTKMs/DBlULLmj0 a4uYZ08vPHL7I/NcfCIBfcPFK5yjDzZqLxypkhVFmEvW3fhJe915rE2qblQECd+TzsBMk3fFC oPDUw48Py/xv5X6qCF00Id/4t8VYDL2vZsql0CObqw9bUetkH7aviz/pdVAegRAZjk6uu+6yl HtGbqLqeluoUseaag4LmCf6JW7KQgqszxQEnN16yR9p0yHjFV/+/FPQGS/3bQmG8CqZiY4co7 LymKhh63iGAS7+kR0mSE2IqlY9aiFT3mPcYWTA47W3t8KQVHOHbGB4a+HOG4/G2ou+akZA7eP jEVYMUMRnmE6fO9HKeXRn34pv5seZTSBoDFDipA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21440 Cc: Michael Heerdegen , 21440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: Hi, >> In (info "(elisp) Coding Conventions"): >> >> =E2=80=A2 If loading the file adds functions to hooks, define a funct= ion >> =E2=80=98FEATURE-unload-hook=E2=80=99, where FEATURE is the name of= the feature the >> package provides, and make it undo any such changes. Using >> =E2=80=98unload-feature=E2=80=99 to unload the file will run this f= unction. *Note >> Unloading. >> >> A problematic tip: >> >> - it is unnecessary for that reason. AFAIK FEATURE's functions are >> removed automatically from hooks by `unload-feature'. >> >> - When you follow the advice, `unload-feature' will skip removing >> entries from `auto-mode-alist', so you would have to do that yourself. >> >> - Isn't `FEATURE-unload-function' the preferred thing to use today? >> The doc string of `unload-feature' doesn't even mention >> FEATURE-unload-hook variables. Seems it is discouraged to be used. > > The above analysis seems correct to me. There should be no need to use > `FEATURE-load-hook', in fact from reading `unload-feature' it seems > worse. But I don't know too much about this, so I'm not sure if there's > some fundamental aspect I'm overlooking. > > If the above is indeed true, we should probably just remove the advice > from coding conventions. And it should be announced in NEWS, probably > together with some warnings emitted by `unload-feature' if there is such > a `FEATURE-unload-hook' defined. > > Is there anyone else who could provide some insight here? As a test, I've renamed `tramp-unload-hook' and all `tramp-FEATURE-unload-hook' variables to `tramp-unload-function' and `tramp-FEATURE-unload-function', respectively. The related test, `tramp-test45-unload', fails now. I haven't debugged further, but throwing a warning when `FEATURE-unload-hook' is used, looks premature to me. > Best regards, > Stefan Kangas Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 09:55:28 2021 Received: (at 21440) by debbugs.gnu.org; 8 Jul 2021 13:55:28 +0000 Received: from localhost ([127.0.0.1]:56379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1UUy-00068C-Co for submit@debbugs.gnu.org; Thu, 08 Jul 2021 09:55:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1UUw-0005u7-4f for 21440@debbugs.gnu.org; Thu, 08 Jul 2021 09:55:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MG3ulq6OHE1pfHGHHISnYbqo5zesJdMCOS9kwQ+Znpo=; b=JqIiq11wCcWj+ykTnXyrR5HGMt 5Bo9xEgtK+zH7W0loXmNquZWag4OiNXcVxGy6rUKSBWfH0mHhbqhKo7AHn96dwGjPvNmliQSz7PGQ gLVIsu4jE6c9qdUJHhvkgv1j3TMYDgyYPYReLbwV/COKb83q/DqEHUJuxIARCzEf8GNQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1UUc-0003Ia-Jr; Thu, 08 Jul 2021 15:55:09 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> X-Now-Playing: Yorkston, Thorne, Khan's _Navarasa: Nine Emotions_: "Westlin Winds" Date: Thu, 08 Jul 2021 15:55:01 +0200 In-Reply-To: <871rk5le0t.fsf@gmx.de> (Michael Albinus's message of "Mon, 17 Aug 2020 13:15:14 +0200") Message-ID: <87r1g8syfe.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: >>> • If loading the file adds functions to hooks, define a function >>> ‘FEATURE-unload-hook’, where FEATURE is the name of the feature the >>> package provides, and make it undo any such chang [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21440 Cc: Michael Heerdegen , 21440@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: >>> =E2=80=A2 If loading the file adds functions to hooks, define a func= tion >>> =E2=80=98FEATURE-unload-hook=E2=80=99, where FEATURE is the name o= f the feature the >>> package provides, and make it undo any such changes. Using >>> =E2=80=98unload-feature=E2=80=99 to unload the file will run this = function. *Note >>> Unloading. [...] > As a test, I've renamed `tramp-unload-hook' and all > `tramp-FEATURE-unload-hook' variables to `tramp-unload-function' and > `tramp-FEATURE-unload-function', respectively. The related test, > `tramp-test45-unload', fails now. I haven't debugged further, but > throwing a warning when `FEATURE-unload-hook' is used, looks premature > to me. The quoted text no longer exists in Emacs 28 -- it now refers to -unload-function. Because: commit 8da810f91b11a258a7ed0f5315292143072881d8 Author: Eli Zaretskii AuthorDate: Mon Nov 7 19:39:54 2016 +0200 Commit: Eli Zaretskii CommitDate: Mon Nov 7 19:39:54 2016 +0200 Don't refer to obsolete FEATURE-unload-hook =20=20=20=20 * doc/lispref/tips.texi (Coding Conventions): Refer to FEATURE-unload-function rather than its obsolete variant FEATURE-unload-hook. (Bug#24890) But I don't know whether -unload-function has the same problems that -unload-hook had? And I see that there's still a lot of things called -unload-hook in Emacs... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 23:57:03 2021 Received: (at 21440) by debbugs.gnu.org; 12 Jul 2021 03:57:04 +0000 Received: from localhost ([127.0.0.1]:36187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2n43-00014I-Lg for submit@debbugs.gnu.org; Sun, 11 Jul 2021 23:57:03 -0400 Received: from mout.web.de ([212.227.17.11]:43391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2n3y-00013i-Di for 21440@debbugs.gnu.org; Sun, 11 Jul 2021 23:57:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1626062211; bh=cWKWAoABdxkn0MVaTF9AF12uOuBsxTWvkbcE5pZXhpA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=pfSVa3qGvokEGrphq5KTCS1uuGW9Qfe30P99Yvf8ou5FOJC1bfNPCPaPjoW95hDs9 DKYCenmACUkzEDokqGzyFzCPRfXp8DuXkVE+MDjLabAFmjL0K2LndwUMnPga+Z4JRR PWz+9sjBpai1viA1Nj5Pz8kE58xJkPZNtAN7lmQo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MPpE6-1m6coj1rPu-004xCn; Mon, 12 Jul 2021 05:56:51 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> Date: Mon, 12 Jul 2021 05:56:50 +0200 In-Reply-To: <87r1g8syfe.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 08 Jul 2021 15:55:01 +0200") Message-ID: <87bl78w5fh.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:qrSiQby1wqXcy4Z1wn0ICqkS2uWsAhEMhdWl713ynPai9Y3mm8o sWKtgNByeJ7kVywYoCOyMZe3YQP/XC1BK/ewh4zswhmEIiljkSN/fJN/Dr6Ym3gGbaLS4Lg z2mFC+UutPZ1lazslJo+QQQqWZ/Oz2eG/ShpWLgX528agyUFa7BOmA4PGhto5XGr0HmNiIJ sMUXLShPRqKA1zi633plg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:9kAxKS/AiiY=:H+Bs8iy8S/pI40DGchRhJR 8QjHqJYeoBAffQC5UNDrYANJHSX7FQXQpUxBw3CgiCB80i9GLfIhUOnssxpN/T2JlQ4oBNdRn QOpJjuuDhw3sj7oWml2L17fay4SThgpScYLZ5QIuAeOJ94pgpUEo1FoOhoNmwM8Sv6pXKdXlr mtz2FBE0gpb3tr4VYGCwnNqDNPzGe/L9FkrrK8zZpPhmokPpJKRjt5gbLhUn8eHhvksgB/BJK DBlTQEUISU9VfVH6EWQMD7WNFhPDFcW29FstVHPgVTM4M9m2bfYqoe2/uKykPwYizcjokR2XQ uAyKbk84L3ZZcOA4yhr+WoP7T0mfpR27VE5KR/TmU/GtggGxdlAgLB51+jJsRWrJyxUnmYSts X1iqLY6wdW6ebbBqTurEFDgxUCfO27vvQL2dQcCPNitDRpY5JdnHGTIdLlPWqC5B4KnAXXq8v TVyXKQ/8MFMZrXssRmgYpchVZQJY5DzKpeYVRuXkqZNpJ5XpWAOYQLBQYuLV9pP76owf/N364 3Lhdq+DF2e+xcJFxwmYhoVysx8athcQNApLJFy5vOKM8OaFztQLZbPxFBSDuHNswkJrI9hFNV SarfDLsteAtra+8vs1Awe/+qHiCeaf0kh7JA4bpD8pOxHNiZhDBfPwtNX03OBOA/9CoX7JmRA Qaob4+OZDkXBae3W5ZG9b9eeUCEojCdO+xYiMOG2hEbAUB3cg/bxiMYTnjeWVG9PxI1VsFVys 40/Op3x3c/x9FVJzwragHLySo6PusiuPWcMfhR+4+1b0aRT78ufFOxPoIbYjIakQ6GhQb8RaF Nz7LTNkioRZnjna9FVbkNl3DNcb72N+W1+rFPnYeMDD3P2EYpNfq/Bm+xbhhXAlSVoBlvSt4F +RDg9OA4frAD1HCSfipph6qL/8TxXTA4phHzSkot45FYARNxy6SloKZo/cugeQPkrXwDRTmX9 o18wKMNqA+i6zMcQj4QGagQl7wdLLZF1g5rU5PWcoQTrrIBrpGorVnmx9RBpnM0JKt5KASIz8 VVJzQhBntP7FHjIXaGsDxr+8UDXXZWFH8cGiE92KNAgYx4VFYARLo/DyFdGSs8yVHMKZ0w8dd xPVE2IJe96EUROTX2J6rhxYZomsQUuJ+eApbIPAQLOLSrf5NUKo23PZXw== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 21440 Cc: Stefan Kangas , 21440@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > But I don't know whether -unload-function has the same problems that > -unload-hook had? At least now (docstring of `unload-feature'): | If a function `FEATURE-unload-function' is defined, this function | calls it with no arguments, before doing anything else. That function | can do whatever is appropriate to undo the loading of the library. If | `FEATURE-unload-function' returns non-nil, that suppresses the | standard unloading of the library. Otherwise the standard unloading | proceeds. So it can now be controlled whether standard unloading stuff will still be performed (last problem mentioned in my report -> solved). This questionable paragraph is sill in the manual however: =E2=80=A2 If loading the file adds functions to hooks, define a function =E2=80=98FEATURE-unload-function=E2=80=99, where FEATURE is the name o= f the feature the package provides, and make it undo any such changes. Using =E2=80=98unload-feature=E2=80=99 to unload the file will run this func= tion. *Note Unloading::. I guess it is a bit outdated and this had been automated long ago, although partially heuristically. Instead it could say what typical non-standard changes need to be handled in an unload-function. It is unrealistic that every author cares about implementing a non-heuristic version of the automatic unloading code. Or, say shortly what unloading actually already does of its own, and that the library developer should care about the rest. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 12 08:00:00 2021 Received: (at 21440) by debbugs.gnu.org; 12 Jul 2021 12:00:00 +0000 Received: from localhost ([127.0.0.1]:36653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2ubP-0006mH-Ok for submit@debbugs.gnu.org; Mon, 12 Jul 2021 08:00:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2ubO-0006m5-CP for 21440@debbugs.gnu.org; Mon, 12 Jul 2021 07:59:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48176) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2ubI-0001CT-I8; Mon, 12 Jul 2021 07:59:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1031 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2ubI-0004mi-5I; Mon, 12 Jul 2021 07:59:52 -0400 Date: Mon, 12 Jul 2021 14:59:45 +0300 Message-Id: <83y2abagjy.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87bl78w5fh.fsf@web.de> (message from Michael Heerdegen on Mon, 12 Jul 2021 05:56:50 +0200) Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> <87bl78w5fh.fsf@web.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21440 Cc: stefan@marxist.se, larsi@gnus.org, michael.albinus@gmx.de, 21440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Date: Mon, 12 Jul 2021 05:56:50 +0200 > Cc: Michael Albinus , 21440@debbugs.gnu.org, > Stefan Kangas > > Lars Ingebrigtsen writes: > > > But I don't know whether -unload-function has the same problems that > > -unload-hook had? > > At least now (docstring of `unload-feature'): > > | If a function `FEATURE-unload-function' is defined, this function > | calls it with no arguments, before doing anything else. That function > | can do whatever is appropriate to undo the loading of the library. If > | `FEATURE-unload-function' returns non-nil, that suppresses the > | standard unloading of the library. Otherwise the standard unloading > | proceeds. > > So it can now be controlled whether standard unloading stuff will still > be performed (last problem mentioned in my report -> solved). > > This questionable paragraph is sill in the manual however: > > • If loading the file adds functions to hooks, define a function > ‘FEATURE-unload-function’, where FEATURE is the name of the feature > the package provides, and make it undo any such changes. Using > ‘unload-feature’ to unload the file will run this function. *Note > Unloading::. > > I guess it is a bit outdated and this had been automated long ago, > although partially heuristically. I don't understand why you say this is outdated. What did I miss? > Instead it could say what typical non-standard changes need to be > handled in an unload-function. Isn't that what it says? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 12 08:05:25 2021 Received: (at 21440) by debbugs.gnu.org; 12 Jul 2021 12:05:25 +0000 Received: from localhost ([127.0.0.1]:36679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2ugf-0006ww-8l for submit@debbugs.gnu.org; Mon, 12 Jul 2021 08:05:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2ugd-0006wh-Et for 21440@debbugs.gnu.org; Mon, 12 Jul 2021 08:05:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0L0hQgsTS/MKKhMp2bpFtg59T9fdLtBn5yMuNwOvuT0=; b=I/Hr7ox9FVz2SCEgmmMpKNszvG fP2XLoWYIni5fpgqUkuA6lAQNLigZd7lui98FmhLPbQdtbK0ZdIjm8dCJ541ZaAYcSyt8KsmwZC6t aRQEgpC9cHs0CunLJ+cUx5I8kT6OZJ742nUEIFfBvT+Me3NBiYO2cEwfct/LmsRbwkEc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2ugU-0005rW-Cq; Mon, 12 Jul 2021 14:05:16 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> <87bl78w5fh.fsf@web.de> <83y2abagjy.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUWDSYoGDNPJEyh PoD////aMRICAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UHDAwAF/hiP5oAAAGpSURBVDjLbVSBkcMw CANPAHQBQzZI9t/tBdhJen33rpdYSAiwQ6SqrEqsRIwHzQ1VIda9WCOX17/Qz+LFGNpovaRiEi0B j5nAgIhrqBtC3N5S0jLJSfaBSHO7ap3h2rFMBkWLBVzwo9IQUonRzcCrK4IDspk8ogleXs3jSkpK xtEE6BhQO7GXklGU08uOMH+8nQ7kASdcqkoIaHvLHTuu3K3QMRswp1CO05zNU/mT1SI+oAWgLFXn 0LOMD8EmG6z7AqgAKGcnwskOsaclgp8TqiUZJ+rdAFqZWqhfuUqSFskVTWB9DbHMYirW03qAHA5G lo67Nw1YemO0cajhYcoymr3vjigBoLkpNY+1BnL4Pk1vIHVwat7Aygkfn1U2RwOzjcx1xAaoZ0nZ 0kKLLzCG7xxjnzdMJCNugO+KtcgP8ExgNPVtt1u47Oq6H1w0WN11cHekRSb+Nz/z30qygJ6K3kDx vO9ZH5wvv5kWB4PkiBr7w8JxvE5txhdQt8GFX3WsYjww7/ocjH0K/P4S5NWd1RD9Wdbh35t5023r fEO4yPM/HRAyx7+Azj+RezxNuL9l/wAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wNy0xMlQxMjow MDoyMiswMDowMHllJTAAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDctMTJUMTI6MDA6MjIrMDA6 MDAIOJ2MAAAAAElFTkSuQmCC X-Now-Playing: Boris with Merzbow's _Gensho (4)_: "Angel" Date: Mon, 12 Jul 2021 14:05:13 +0200 In-Reply-To: <83y2abagjy.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jul 2021 14:59:45 +0300") Message-ID: <87czrnu492.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> At least now (docstring of `unload-feature'): >> >> | If a function `FEATURE-unload-function' is defined, this function >> | calls it with no arguments, before doing anything else. That function >> [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21440 Cc: Michael Heerdegen , stefan@marxist.se, 21440@debbugs.gnu.org, michael.albinus@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> At least now (docstring of `unload-feature'): >>=20 >> | If a function `FEATURE-unload-function' is defined, this function >> | calls it with no arguments, before doing anything else. That function >> | can do whatever is appropriate to undo the loading of the library. If >> | `FEATURE-unload-function' returns non-nil, that suppresses the >> | standard unloading of the library. Otherwise the standard unloading >> | proceeds. >>=20 >> So it can now be controlled whether standard unloading stuff will still >> be performed (last problem mentioned in my report -> solved). Ah, right. >> This questionable paragraph is sill in the manual however: >>=20 >> =E2=80=A2 If loading the file adds functions to hooks, define a funct= ion >> =E2=80=98FEATURE-unload-function=E2=80=99, where FEATURE is the nam= e of the feature >> the package provides, and make it undo any such changes. Using >> =E2=80=98unload-feature=E2=80=99 to unload the file will run this f= unction. *Note >> Unloading::. >>=20 >> I guess it is a bit outdated and this had been automated long ago, >> although partially heuristically. > > I don't understand why you say this is outdated. What did I miss? > >> Instead it could say what typical non-standard changes need to be >> handled in an unload-function. > > Isn't that what it says? Well, it recommends writing an unload function, although this is rarely necessary. So it should say something about when it's necessary. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 21:23:09 2021 Received: (at 21440) by debbugs.gnu.org; 16 Jul 2021 01:23:09 +0000 Received: from localhost ([127.0.0.1]:50106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4CZJ-0003Tn-8B for submit@debbugs.gnu.org; Thu, 15 Jul 2021 21:23:09 -0400 Received: from mout.web.de ([217.72.192.78]:60413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4CZH-0003Ta-Vi for 21440@debbugs.gnu.org; Thu, 15 Jul 2021 21:23:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1626398581; bh=+HhJegLmkQKDKeB02hSdnD3Qfvo0QC6jecmRUFtmjqE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=YDnnpU3Rb92QuHVejDBd8L0szs1TTzJsDTEgQ02HKEvCdL9AFJ791T8SF6Zxv0H4h cJ+OpdCOwxHSENwZiNaHRyfkd3TvfUrV4KelDuDWnzGIk/BUQSQzR9NF8xXVqB/Y+Y il5vKks3W9jFfs8erpFtGyObLKNQQjZGmhZyN/qo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N4vRm-1l5WtN14ei-010ua7; Fri, 16 Jul 2021 03:23:01 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> <87bl78w5fh.fsf@web.de> <83y2abagjy.fsf@gnu.org> <87czrnu492.fsf@gnus.org> Date: Fri, 16 Jul 2021 03:23:00 +0200 In-Reply-To: <87czrnu492.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 12 Jul 2021 14:05:13 +0200") Message-ID: <87zgunuk5n.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:vayKCnSCQgAIKFhhUMHetlG7TKCbu4CFSOgpyL/9kL7D9SGTT2B KwWRb3L2feEym54LNQI+2jKBk5Qhdm2kyPEM9VkGKz4KgILy3gYadbQ0IzO6Xn7anXCDKWC gCO/Z62qkglPlV0tuk6TY2OB4B5biVtaAS/JMTp1BwIP4SJ4j84SLuYUThgT0+xFHw2SSwr yqv2eZD/cZOn5YxLb04Pw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UgHQ21Galy0=:RrC3LQWhjucWn3zNg3g4Xp WtJmlsAy9DJf+W3OTW9Fs2UmRT6VvqT/m+P6oHymEJEWnMFMpfSU+zxFkrOdC6+rSp0ZOpibX 5OU2ikkP/CQKeQq5MVleTUMwqgJQLsd/fXmAOv3Tl9Zj9S3PflAX9TnbLmnXrshPy+kme4myD ue/7vIQpc8pF9LbaLTmlUKmdW6NgWVFDmQdJNPIx0HY2/+hHZpFJRPKU5g0ae9OoAzidIpGKc czx1sE5xJKkLG9LftI44PIdj/ZOgxTvI5em8tG8263hgTe61AfvJPp3+SLKwc/8rXLOMotkvZ dD3mCCfg7LqOR9GLTt9hwttSB7EMz8w7jh9EfO7btzRznhJoOGL9bK7EjJa5UgjU5/MN/Uua4 CAkmxkuLo6kdKwSz8TqeyZpBTuL8nPOybWSn4qYyxW8WCLKuSPmOn9riQmEpOSNFFCpXSub5f Wax29c2icc9pt5fPBeVGjcJi6TNAJxMD3U1z2UtARvU5TzOf/rAY0UdcdxA8ij3bh5strQ1su UlbLV+slUdJJ7tJzTQMahv9jGDUkae0eR34sHAG6mZnjSrIFI23dT24U76qBVRz//bY8RWn9C A62VSmx0/joXPKPs8AVZFR4DkuEGVyQMhwRS+mrTIrHl6JospU3208dWCcF7UKY3uUg5ckRFH 5bnNdHe8ZTOg/IFSXSvusBbU8Y6G6fTgOuKuXCOiVgQCDuHl+uCKw03Urw173bBiYaSclr8jA xXagjvQmLk5ddkwlc8HP0sMTB26DtVBM9Wsg6lZNUK3zkxvrucTkUQUfhhdoRkpJn8jpoENwp hgGqBHk3MpnnhpiWG4IbV4RNzFiHmZlDb16XQuH3YquYeBYxs3J3zMh9OfVdNtpN+2kzrDcgG mCusENzuoJXUrnCO5Pez4kFuTj/hw7osGA69rQrBTCSeT2PRJRQIyNxfiVoiQhmzpBEKK+4P9 OYWRVzxJsvsaCj05miZU70MRfXUxjke2CJAQHCBgG2t/LCItUZu+HV6LWhuGPh+a0PVqg1QuO 3AyuQznKkBckCbEp/lOTrDmCyGUrKqkqdOMHYfoyK5BlNjdjxk4s9/QDAgzPRAaE/ieuIVXfw i0osuE0XS40DBuDCAJroVa6KvXn1YqbyYgR/71mpOMqmRcVsUlTo4PLww== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21440 Cc: stefan@marxist.se, Eli Zaretskii , michael.albinus@gmx.de, 21440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > > I don't understand why you say this is outdated. What did I miss? > > > >> Instead it could say what typical non-standard changes need to be > >> handled in an unload-function. > > > > Isn't that what it says? > > Well, it recommends writing an unload function, although this is rarely > necessary. So it should say something about when it's necessary. Yes, exactly. The second paragraph of `unload-feature' has some good examples (should we add advices to that list btw?). Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 16 05:01:56 2021 Received: (at 21440) by debbugs.gnu.org; 16 Jul 2021 09:01:56 +0000 Received: from localhost ([127.0.0.1]:50480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4JjI-0008GT-Du for submit@debbugs.gnu.org; Fri, 16 Jul 2021 05:01:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4JjF-0008GE-HW for 21440@debbugs.gnu.org; Fri, 16 Jul 2021 05:01:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yCARBZsl4yxVb3M3M6pFfB5wioVn7KmcEQwio9Vq0Z8=; b=Pe6N4sXgROjktdCHTExws3TKS8 EwrVj/txzVu3BnC+nX2pRqEgYZCdZv2v8B6XijYiw1WRaoAMLlZ98tYMB9GehtJ5GkV8KvfKOvZej 3c2c92tWlaxJ4oJK1uv/jJU0TmHLWQguzZLMa2b49Jm9V/4bV+xOZNGHXR2Wf8jv3Sow=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4Jj5-0002Hk-U2; Fri, 16 Jul 2021 11:01:46 +0200 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> <87bl78w5fh.fsf@web.de> <83y2abagjy.fsf@gnu.org> <87czrnu492.fsf@gnus.org> <87zgunuk5n.fsf@web.de> X-Now-Playing: Four Tet's _Sixteen Oceans_: "Love Salad" Date: Fri, 16 Jul 2021 11:01:43 +0200 In-Reply-To: <87zgunuk5n.fsf@web.de> (Michael Heerdegen's message of "Fri, 16 Jul 2021 03:23:00 +0200") Message-ID: <87o8b2d43s.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: >> Well, it recommends writing an unload function, although this is rarely >> necessary. So it should say something about when it's necessary. > > Yes, exactly. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21440 Cc: michael.albinus@gmx.de, Eli Zaretskii , stefan@marxist.se, 21440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Heerdegen writes: >> Well, it recommends writing an unload function, although this is rarely >> necessary. So it should say something about when it's necessary. > > Yes, exactly. I've now clarified that section... > The second paragraph of `unload-feature' has some good examples ... but I don't think we need to go into details about what unload-feature does in the Coding Conventions section in the manual. > (should we add advices to that list btw?). Hm... does unload-feature remove advices? Let's see.. Well, there's this: (defun loadhist--unload-function (x) (let ((fun (cdr x))) (when (fboundp fun) (when (fboundp 'ad-unadvise) (ad-unadvise fun)) Hm... but is that what it does? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 16 21:22:01 2021 Received: (at 21440) by debbugs.gnu.org; 17 Jul 2021 01:22:01 +0000 Received: from localhost ([127.0.0.1]:52588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4Z1l-000447-DD for submit@debbugs.gnu.org; Fri, 16 Jul 2021 21:22:01 -0400 Received: from mout.web.de ([212.227.15.14]:56157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4Z1j-00043u-Ez for 21440@debbugs.gnu.org; Fri, 16 Jul 2021 21:22:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1626484912; bh=GP5WnQdmSypj7vcnoXZjOIKYlqsDqCIfp+vGYD8h9AA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=e+57gxVAP52iJp9eoHiwvJ1AMlHyaB15i6lHuaxvmkjr9lY9FhSVPG8ElTerBZN2Q zgHfeLe1itwST1hGC5iTFOALBrdjVu7Y0Bs8iBBiy92s9CszOosG6OLfnIxqchVv43 XB4cAZpkaBele4+0PQB04/tq95srLs2PAy6kSTDE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MY6hU-1lZmcK1jma-00UpMi; Sat, 17 Jul 2021 03:21:52 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> <87bl78w5fh.fsf@web.de> <83y2abagjy.fsf@gnu.org> <87czrnu492.fsf@gnus.org> <87zgunuk5n.fsf@web.de> <87o8b2d43s.fsf@gnus.org> Date: Sat, 17 Jul 2021 03:21:51 +0200 In-Reply-To: <87o8b2d43s.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 16 Jul 2021 11:01:43 +0200") Message-ID: <87pmvhybtc.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:yF1ULKp8VALpKldPfruQ+ikoxPY95uPwXzTjEr/aNH64qDb5Kdn zmglYo+GxumFHXnZVyy+aqy/95Ta/UsN6MLG6dSCACiTu9Vh1404lHrlY8EkFq4sYDsICYB drGUB8ph87lZ6UIqH6ckCnjZuHPWexrq8cTIaZePBA199yrJ0n2ip8z4fu9cViy8kv2GIb9 oWstQnv7S4UB4KL/0PZ9Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:zACcu3svevA=:m6qZlya/UturhQgsTczDS4 wlgvVnw3ZMp5jPcufDsfLUNXO1a65i3LbdEH1pd0hL7slHwbUVX4AjRbxgnsr41KDi2KgsxRV QAfxhjQb+JOMD27OsblkTeA49BfpHCVPM1Oj2G021N8hNN1su8V8rjoaYZ1/UrUMcXeqA+Ijx l/Q3GlI6aaQNgOhsPmhi0hohMZWjiJ/5Smll5GaFQXeehAxgUz7b0gC+pHVFALbuLMIz3bTeK ZSF5bNoVwyY4KPfgDAi9xW9MyU7HJ3vMZOR1V32mf0Z0/p4qY7Q4hMn1edD6jJzOf/pvkQTyL cZ9eFq6pNOh2j47YFANNHO84xMx6BT4XVxHyiZxbuMwfuGO/pyMGhJtlz5JZrgIJatGsxEjU+ IPx885a2etXSah2w9IqPs+mA14N0+OknmZi2cI5U4KvX85VSEBeDggbRLEucGbz7DHu1e+J8w 9hvxwbAPD9xXkK0DnMeYiFvAPBUWaKr93SY9UJKrSjtRNMTFvbIj2zwqzMjkmUR+zDgbA2MC+ U4rva+LQ8FOAFecoWwyOttdScoHMg6fJ8qWnGEyC90GQALXME2oMGtj4dPVaUmbneh3bRbYGx AOzQbhcOXq4l8B93SADlmSYqBxawq/tFUAjIzh5XPxBFfGvRXpct59OUqxkHjJgM9k2tj86mP 4HgnSrkJRZmnX4eeQpHRZzCsuA/Wfa4sWSffAL94SWeQO35Su35GwZjbM8aQx8q+wyjSpgIH8 ItUKQjFr07rIEFzzzZW4KDXDgQDLPGGroQnLeCZCrDQbd9paGWZR+mB5pk3AyZGehCdAWk1CP 7bpZ8MJTQIgqqwXh07eR+KZDa1Zfaw9Mb9no/jmOP3HThloDfACKjXT21nPbtvGW6UKlb8u8N 2Ba0JtReDBMZCKDbIQt3gxf/NVRcjTSTAPesKQi6NEeq/y739oZWErLLJsUFa++4e6VQy/AWl U17pq3MW7MKbwBcBMsC6mAzk/jO29LbjUbtAQtVh3kS6PqM36/oz8bWWwxah69EWwzgIocYGV 9UIUp+Rh8HN2JSTNcK17TBo01icTT0LVu0Yc1Kesvs/PYWAUxfDnKEWqFiL2mqT5h9tGXb9US +rHCjOyvMXRp6zFAQcvTuiSFh6huaZYcEjkFMf4B3dQ9blcq/kDkGvyhg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21440 Cc: michael.albinus@gmx.de, Eli Zaretskii , stefan@marxist.se, 21440@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > I've now clarified that section... Thanks, Lars. > > (should we add advices to that list btw?). > > Hm... does unload-feature remove advices? Let's see.. > > Well, there's this: > > (defun loadhist--unload-function (x) > (let ((fun (cdr x))) > (when (fboundp fun) > (when (fboundp 'ad-unadvise) > (ad-unadvise fun)) > > Hm... but is that what it does? I don't think so. AFAIU this does not even effect nadvice advices, and treats only advises of functions defined by the feature. Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 16 21:35:21 2021 Received: (at 21440) by debbugs.gnu.org; 17 Jul 2021 01:35:21 +0000 Received: from localhost ([127.0.0.1]:52593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4ZEf-0004NS-K3 for submit@debbugs.gnu.org; Fri, 16 Jul 2021 21:35:21 -0400 Received: from mout.web.de ([212.227.15.3]:49597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4ZEa-0004NB-PJ for 21440@debbugs.gnu.org; Fri, 16 Jul 2021 21:35:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1626485710; bh=vCP0FUzoi2HObVJZ9pHWjRJNSjJD+Pnk1OaJB6ABOic=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=nFRIFplf+0giBjbGS3/xAhzOn4A6OmrcURnoryWNJytp+DuJoyQoqihC13esuw2d9 MG79TkOASEedp884bs6MJ85CwUwOnE0ISbSccjlwcLExVP4OMbvtZRDGIE+zzQyURI IT6elxSu8tA5x0sSf89fcx3J9/Iy8ecwjIbZNgT8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MgANG-1lTqls1GE2-00hw5u; Sat, 17 Jul 2021 03:35:10 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> <87bl78w5fh.fsf@web.de> <83y2abagjy.fsf@gnu.org> <87czrnu492.fsf@gnus.org> <87zgunuk5n.fsf@web.de> <87o8b2d43s.fsf@gnus.org> <87pmvhybtc.fsf@web.de> Date: Sat, 17 Jul 2021 03:35:09 +0200 In-Reply-To: <87pmvhybtc.fsf@web.de> (Michael Heerdegen's message of "Sat, 17 Jul 2021 03:21:51 +0200") Message-ID: <87lf65yb76.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:QVDcJBCi9xzgmZ3FI4sUV1HI4YS+08ltmJcUQ8UDLnCRWX8jFtX orkYVNCdl9pNt6lr3eY5H3kNJNjLQAaBDXSOHkkj7ocuDcbILFFl8up9mN9r+08Jar9zQ7c TQboiR5A7i/4h97l4D1O2rYqthOUFXRTMvODBhNHv3IecjI/usJfCVJvoeSaOAcVQNw7uXv wuo1v8yy0gKK3E8Mlrviw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:vuURKtdWyow=:lVoenSM1t1864O9Od8zaZX VOO1+8ps3xzdou9wZeHfubGFjnPytl4yuFxvz1dsrd+xv8I+PG8G9VuCAtiOnJ//T2Tct5XsO pI6Jl3QkwbcY7h8RcJwo1UFc6y8SBJAcH9BTB1Oz2h0cxHKWuhulbWS8hbZTlhwgR7dWBt3lg +fMwU4Fsx52JhIj06XdsFczArkOz0+UOHap0RcF7o3o8rprzgIL8cqdIsnZGRblX8tRzkT4eN s/Bs5Walx0aEN+ojjthvhGwF/Ra2SoapKpRXI33tnr02niipBHqOCF51ed97j/YVa3sWRlJcf ZcIBB7g9znk/Au3D9nRoqQoAtBLrD6aDFqGVbAVqgd0Kb9AmzjPI7/mrBs2j3tTFdUgwwmzAJ LY24XPk9RxZMu5UzUSIMrcUqPGy9FcrfECCg5PtJqsseMKJDvkO41e7tRj8Vhw515AmYkxo8h /XMEd1HhafP/JEZzQJrL0SEEi3py3RRgzQgHVLyXQnaZ9gkbkTT0fIyLQUqmUB2yUoSuEsTTH n/37+I9Q069hHTzDHooUnUkmLfyJEpHPTSyIOvoxRKBSA2mFZDXNx9Ha/9ms9kJj0kIPlmMX9 8IzMNgzaUirehG5cDczNHDEJECA6u6gAwp1lDnPnOfqGaZWrQ72A/S2pg4JLeUi2AFNffNlYB j5D1D47woIB1ShF5J3AD3Gg4ub4lC4a/8W9q/VEEZRo6Z3OoHKtez1qIPt6DW3Truw42wpitH CT0OSfgf6PWEAm1Pzq9WcKSohnq+JplgPqyu1JBo7PVZfqBOwNXhIaKJ1DppV+b/W2qnxYPDN R2KSViQpaLj1st5cIH+ayUIIuud1LNbFr8qiOXIbgqX4voSlfr2vmq39eq96WF43kbYPTZTTa auZf8ZXY5cfg4Gr/yVW0D/DUxuzq5EuJb97bHBAH7Sw1Wwj07ROeyDTLyWYMV9sTWMrxCaN/X JoDGzu4YnTXdlMZBONW4U30SGtdjdYLSIsprlg4NErKtwJHO9QMO9fbPgNouBevKZfgL5vseH QwjzqBAsZLT2H5S26LL5lKdSjDMx+kTRGnTGikUU6Wrl6TDwYCPDt9qszwndw6VeOSoXfn/00 yqxaQ70H7GS0iJSdwhKdOcVba8SB61OK8XueFbe+RcDxaYK2JpqhF34tg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21440 Cc: michael.albinus@gmx.de, 21440@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > > Hm... does unload-feature remove advices? Let's see.. > > > > Well, there's this: > > > > (defun loadhist--unload-function (x) > > [...] > > > > Hm... but is that what it does? > > I don't think so. AFAIU this does not even effect nadvice advices, > and treats only advises of functions defined by the feature. Here is a simple test file: #+begin_src emacs-lisp ;;; foo.el --- ... -*- lexical-binding: t -*- (defun my-foo--around-ad (f &rest args) 17 (apply f args)) (advice-add 'make-frame-command :around #'my-foo--around-ad) (provide 'foo) ;;; foo.el ends here #+end_src Load it, then M-x unload-feature foo RET -- and after that, C-x 5 2 errors. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 17 10:08:58 2021 Received: (at 21440) by debbugs.gnu.org; 17 Jul 2021 14:08:58 +0000 Received: from localhost ([127.0.0.1]:54418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4kzy-0001nV-1G for submit@debbugs.gnu.org; Sat, 17 Jul 2021 10:08:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4kzu-0001nB-R7 for 21440@debbugs.gnu.org; Sat, 17 Jul 2021 10:08:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JsHSmS6XQfBm+YWyIhlAagqkkrQd1WlgstvMrjfxt8U=; b=udZV1nDFd8GFOMmVt/QmNO8NKs HaxhIo8//S8pl9DnZGes2K1zrMKgmbNTLc/umSfoDBnq1ZkMExNsSBJGxBeivM0+Hapx1BpXlr+nT WIwDYep9c4pi/7d7BsJOA4Kp/BORfwEqlMYH7ruyL+A9AUe8+Ki8HZfQNbtIxPtfRl30=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4kzm-0007qF-E2; Sat, 17 Jul 2021 16:08:48 +0200 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> <87bl78w5fh.fsf@web.de> <83y2abagjy.fsf@gnu.org> <87czrnu492.fsf@gnus.org> <87zgunuk5n.fsf@web.de> <87o8b2d43s.fsf@gnus.org> <87pmvhybtc.fsf@web.de> <87lf65yb76.fsf@web.de> X-Now-Playing: SOPHIE's _OIL OF EVERY PEARL'S UN-INSIDES_: "Whole New World-Pretend World" Date: Sat, 17 Jul 2021 16:08:45 +0200 In-Reply-To: <87lf65yb76.fsf@web.de> (Michael Heerdegen's message of "Sat, 17 Jul 2021 03:35:09 +0200") Message-ID: <87mtql58ya.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: > Load it, then M-x unload-feature foo RET -- and after that, C-x 5 2 > errors. Right; it would indeed be good if that was fixed by `unload-feature'. Could you open a new bug report for that (as it's a somewhat separate issue from what this one is about)? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21440 Cc: michael.albinus@gmx.de, 21440@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Heerdegen writes: > Load it, then M-x unload-feature foo RET -- and after that, C-x 5 2 > errors. Right; it would indeed be good if that was fixed by `unload-feature'. Could you open a new bug report for that (as it's a somewhat separate issue from what this one is about)? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 17 10:09:05 2021 Received: (at control) by debbugs.gnu.org; 17 Jul 2021 14:09:05 +0000 Received: from localhost ([127.0.0.1]:54422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4l05-0001oD-97 for submit@debbugs.gnu.org; Sat, 17 Jul 2021 10:09:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4l04-0001nd-BH for control@debbugs.gnu.org; Sat, 17 Jul 2021 10:09:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QVshdHE3LAXdVkU4PZanrvrpj4sBfzqhDS1+FidVC5o=; b=PfQIx+XDS9KrYhKv94ig6VRjTf b35PNn0bqyNo6DO4B6r1TSLl1tjfIgk+W4b+fbWNk3SgYVdGwlvtp1eSBYLGYrN0ZHzzzG+dUN0zz 0nE3erDXQay4H/I5tB8yEnfi5EprWP1zXsEX5N8ec6bTD4DgnpLDQkSeDmYkH5J0S/nk=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4kzw-0007qT-Ri for control@debbugs.gnu.org; Sat, 17 Jul 2021 16:08:58 +0200 Date: Sat, 17 Jul 2021 16:08:56 +0200 Message-Id: <87lf6558xz.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #21440 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 21440 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 21440 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 20 22:45:37 2021 Received: (at 21440) by debbugs.gnu.org; 21 Jul 2021 02:45:37 +0000 Received: from localhost ([127.0.0.1]:35859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m62Eq-0004pT-Tw for submit@debbugs.gnu.org; Tue, 20 Jul 2021 22:45:37 -0400 Received: from mout.web.de ([212.227.17.12]:34145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m62Ep-0004pF-0g for 21440@debbugs.gnu.org; Tue, 20 Jul 2021 22:45:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1626835528; bh=2Dp7idnd1ydJ/PEFJlwFEKnESO3TuZyk0GhMBFlWmiA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Gvk4fHQChrRyoVCvzaPDBEFsEpeRFYdoodj+nVlrl7He7+WYkht0jQ9SdIUO/usyB sFfaD5m9tLauWiX6uZ3nQUonZ7ts0awcOFlWIHw5wWyxQHEXZiwVyAkNDylbFr+lGH S8w/fWhlAUiS4umivovMNPnu8bOVEpc4tJHPQ9qw= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M8hsl-1l9xfv1hLP-00wB8U; Wed, 21 Jul 2021 04:45:28 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> <87r1g8syfe.fsf@gnus.org> <87bl78w5fh.fsf@web.de> <83y2abagjy.fsf@gnu.org> <87czrnu492.fsf@gnus.org> <87zgunuk5n.fsf@web.de> <87o8b2d43s.fsf@gnus.org> <87pmvhybtc.fsf@web.de> <87lf65yb76.fsf@web.de> <87mtql58ya.fsf@gnus.org> Date: Wed, 21 Jul 2021 04:45:27 +0200 In-Reply-To: <87mtql58ya.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 17 Jul 2021 16:08:45 +0200") Message-ID: <87wnpk5qrc.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:bSjor4ZzW5gDQxr6O1UyrizT8TarcY7aUXRSYs3mF0aV3NPb7O7 fHu5u6rz01OSpKZRbIorC33rvPKfe+d1bCC3gyVb/mYJAjzCxoLXn2bmAb0XcAGXxWbLg7f gkmWDTunSVC70VyxD5kh5HrXMN9CgqkDrcoJqa/AGDlagRg62c2eS8un1I2GfLc+6Rb38UM 21wSnkJh8oMwHZj3VVvBg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:uEP/LCOJltw=:XagBUsWSCcDxWnRDhVzOEo aIHgf2k8JvunS5aVZi0M8x1LPaA51ceXS5TjWXs0/dGms9WGH2Cqzgv8JwPcH1qiTzBQ6mWIH 1BW+M92x52pgSrvJZvALTxkpWV0m0bhXaA93/1qNfmMT/5KVET3aOVHJBNT759Y7Cx2v2/fIo ooPUB7BBCZD0nq1V2EvMq1e1KrFtQ9zcqCywtgzqrqoK7RTkjs0yHV2lzOdVy8cCidzlVLi4y wQo/Zh3XNNRUVVqa6zGyostoxWBMJQBJwmnK0OPoyH8M+RdXWsW4QZ+3oZVe130mcyVy40233 S1d4TN/97LoxRn/osVRTOKnsqrjEepijq3Op2qlH29ZXCj5PppwYe49OgxvggJUstH9XOcnMi B1oLVVz4gzj17C77+GgaIVstOn9s0uM2fhnzZlc9fF9b/LVEGEvhjPobJ8Trf7YqhrtmVDO6l weKJ2Jvg2DGXs2OP+Bkqea4Mz7fNlze7pkZbJ4IvvzVYjlr9ly1S7YXUbjzSt1B1ickk04tV1 ePxSBAKBZh/uzdYpyeMnNcrKJ5ELcAwKt9c1ASEvmhELR+RrBHmnikDFHb2WpWhUKIxSJ16bu HIdK3wYxV0DcezgzSvPfHEz8h/m+yRlnyyTR9cYwPucnvsWkfEj6XsXJgKboTe2lD0kpmyhpP rbeUhODvt1usGbaLcTd+rs9x2Yxbqd7wz8cvtw3lIRalp6qiOTI2fT7GwlHn8qDv9F3aLUN4a IWhW+pUtW5606+WCbR0HQWc3oWRjDdr7FCLWVHmCjMdsMoRb1JscFCJ5ubzZuAWZ4RnvJibf1 1oUQRT7azrqULL3pXBu1qdNN7+xUwPIjk6bf4zDoFCzKOn8NEfusEXVNSGPuNTwHQlBXEgFsR VTUMV6i0CLtBxm/nlBuAxKiyZeZY+R84oCjmvoGEjwkGZQupjK3tMTwO44SjYHxmViHqyNliu z/24X/axc9Hn48xgILo5C9pVEBoyYnKh2acE2HhguhBxt0ieOnCrosZI+bG4cWxs9IIllipsU rNINxo1mJAWteUxMdGwdfHo2ieP99G9gsTIl2puAN8qGsGsksllHKLx2GYP4myeDH6vtiXSgE KUkMRqZiBBQB8My84K7plkadVF1u4x6Oy3JmpEOOsBYbC5iMUdMUmrfbQ== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 21440 Cc: michael.albinus@gmx.de, 21440@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Right; it would indeed be good if that was fixed by `unload-feature'. > Could you open a new bug report for that (as it's a somewhat separate > issue from what this one is about)? Done - see Bug#49674. Michael. From unknown Sun Jun 22 00:53:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Aug 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator