Subject: Re: bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted

From: Eli Zaretskii <[email-masked]>
Date: Wed, 16 Sep 2015 20:08:44 +0300

> From: Michael Albinus <[email-masked]>
> Cc: [email-masked],  [email-masked]
> Date: Wed, 16 Sep 2015 16:45:56 +0200
> 
> I've checked further. In `file-notify-test04-file-validity', you have
> also removed the final check for `file-notify-valid-p':
> 
>          ;; After deleting the parent, the descriptor must not be valid
>          ;; anymore.
> -        (should-not (file-notify-valid-p file-notify--test-desc)))
> +        (delete-directory temporary-file-directory t)
> +        (read-event nil nil 0.5))

Oops!

> Was this by intention?

No.

> The whole test case is about this check. And maybe this is also the
> reason that it passes now the remote test case, surprisingly.

Does it work for you if you add the test after read-event?  It fails
here, i.e. the watch is still valid.