From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 06 13:25:48 2015 Received: (at submit) by debbugs.gnu.org; 6 Sep 2015 17:25:48 +0000 Received: from localhost ([127.0.0.1]:50885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZYdhL-00019G-2A for submit@debbugs.gnu.org; Sun, 06 Sep 2015 13:25:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55163) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZYUZW-0000jq-IJ for submit@debbugs.gnu.org; Sun, 06 Sep 2015 03:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYUZV-0008OR-8t for submit@debbugs.gnu.org; Sun, 06 Sep 2015 03:41:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=5.0 tests=BAYES_50,URIBL_BLACK autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYUZV-0008ON-67 for submit@debbugs.gnu.org; Sun, 06 Sep 2015 03:41:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYUZU-0005VF-2l for bug-guile@gnu.org; Sun, 06 Sep 2015 03:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYUZQ-0008Jp-1s for bug-guile@gnu.org; Sun, 06 Sep 2015 03:41:04 -0400 Received: from cozmixng.sgk.iwate-u.ac.jp ([160.29.167.10]:48594 helo=mail.cozmixng.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYUZP-0008FP-N6 for bug-guile@gnu.org; Sun, 06 Sep 2015 03:40:59 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cozmixng.org (Postfix) with ESMTP id 8FF6615B2B3; Sun, 6 Sep 2015 16:40:47 +0900 (JST) Date: Sun, 06 Sep 2015 16:40:42 +0900 (JST) Message-Id: <20150906.164042.1330745461207243327.kou@cozmixng.org> To: bug-guile@gnu.org Subject: [PATCH] Remove needless mkstemp() check From: Kouhei Sutou X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Sun_Sep__6_16_40_42_2015_577)--" Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 06 Sep 2015 13:25:44 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) ----Next_Part(Sun_Sep__6_16_40_42_2015_577)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit There is mkstemp() check by AC_REPLACE_FUNCS() in configure.ac. If mkstemp() isn't found, mkstemp() is defined by gnulib-tool. But mkstemp() is always defined in libguile/mkstemp.c. If we define mkstemp() by gnulib-tool, mkstemp() is defined twice. It caused a link error. The situation is caused when we cross-compile Guile by MinGW because mkstemp() doesn't exist on Windows. Here is an error message on my environment: CCLD libguile-2.0.la ../lib/.libs/libgnu.a(mkstemp.o): In function `mkstemp': .../lib/mkstemp.c:48: multiple definition of `mkstemp' .libs/libguile_2.0_la-mkstemp.o:.../libguile/mkstemp.c:68: first defined here collect2: error: ld returned 1 exit status Makefile:2242: recipe for target 'libguile-2.0.la' failed make[3]: *** [libguile-2.0.la] Error 1 I attach a patch to fix this problem. ----Next_Part(Sun_Sep__6_16_40_42_2015_577)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Remove-needless-mkstemp-check.patch" >From 6fca60d595f464b7f505d9132087836ca48d4947 Mon Sep 17 00:00:00 2001 From: Kouhei Sutou Date: Sun, 6 Sep 2015 15:53:20 +0900 Subject: [PATCH] Remove needless mkstemp() check It causes build error on cross-compiling for Windows by the following multiple definitions error: CCLD libguile-2.0.la ../lib/.libs/libgnu.a(mkstemp.o): In function `mkstemp': .../lib/mkstemp.c:48: multiple definition of `mkstemp' .libs/libguile_2.0_la-mkstemp.o:.../libguile/mkstemp.c:68: first defined here collect2: error: ld returned 1 exit status Makefile:2242: recipe for target 'libguile-2.0.la' failed make[3]: *** [libguile-2.0.la] Error 1 * configure.ac: Remove mkstemp() check. mkstemp() is always defined in libguile/mkstemp.c. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 19e00d8..49e937b 100644 --- a/configure.ac +++ b/configure.ac @@ -1124,7 +1124,7 @@ if test "$enable_regex" = yes; then AC_DEFINE([ENABLE_REGEX], 1, [Define when regex support is enabled.]) fi -AC_REPLACE_FUNCS([strerror memmove mkstemp]) +AC_REPLACE_FUNCS([strerror memmove]) # Reasons for testing: # asinh, acosh, atanh, trunc - C99 standard, generally not available on -- 2.5.1 ----Next_Part(Sun_Sep__6_16_40_42_2015_577)---- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 18:59:53 2015 Received: (at 21425-done) by debbugs.gnu.org; 29 Oct 2015 22:59:53 +0000 Received: from localhost ([127.0.0.1]:44867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrwAj-0006GM-KH for submit@debbugs.gnu.org; Thu, 29 Oct 2015 18:59:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45973) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrwAh-0006GA-Pl for 21425-done@debbugs.gnu.org; Thu, 29 Oct 2015 18:59:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrwAe-0005ec-BL for 21425-done@debbugs.gnu.org; Thu, 29 Oct 2015 18:59:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLACK autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrwAe-0005eV-8f; Thu, 29 Oct 2015 18:59:48 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:57914 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZrwAd-0004q5-Ng; Thu, 29 Oct 2015 18:59:48 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Kouhei Sutou Subject: Re: bug#21425: [PATCH] Remove needless mkstemp() check References: <20150906.164042.1330745461207243327.kou@cozmixng.org> Date: Thu, 29 Oct 2015 23:59:45 +0100 In-Reply-To: <20150906.164042.1330745461207243327.kou@cozmixng.org> (Kouhei Sutou's message of "Sun, 06 Sep 2015 16:40:42 +0900 (JST)") Message-ID: <87ziz12sda.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 21425-done Cc: 21425-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Kouhei Sutou skribis: > There is mkstemp() check by AC_REPLACE_FUNCS() in > configure.ac. If mkstemp() isn't found, mkstemp() is defined > by gnulib-tool. > > But mkstemp() is always defined in libguile/mkstemp.c. If we > define mkstemp() by gnulib-tool, mkstemp() is defined > twice. It caused a link error. > > The situation is caused when we cross-compile Guile by MinGW > because mkstemp() doesn't exist on Windows. Indeed. I pushed as similar patch as efd8a43. Thank you! Ludo=E2=80=99. From unknown Sun Jun 15 08:41:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Nov 2015 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator