Subject: Re: bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p'

From: "Constantino Calancha" <[email-masked]>
Date: Wed, 02 Sep 2015 11:07:46 +0900

Hi Glenn,

i dont think is needed i just find more natural to be defined than not.
Its also elegant.

There are two files that may use that predicate:

simple.el
    2856:	       (not (or (bufferp output-buffer)  (stringp  
output-buffer))))
    3118:		 (not (or (bufferp output-buffer) (stringp output-buffer)))))

gnus-art.el:
    2800:	   ((not (or (bufferp (car handle)) (stringp (car handle)))))

On Wed, 02 Sep 2015 00:45:04 +0900, Glenn Morris <[email-masked]> wrote:

> Tino Calancha wrote:
>
>> Predicate `buffer-or-string-p' is declared but definition is missing in:
>> emacs-24.5/src/data.c
>
> I guess you are referring to the fact that src/data.c contains
>
>   DEFSYM (Qbuffer_or_string_p, "buffer-or-string-p")
>
> This is used in CHECK_STRING_OR_BUFFER in textprop.c.
> The simple presence of the DEFSYM is not by itself motivation for the
> addition of a "buffer-or-string-p" predicate.
>
> If you think such a thing is needed, you need to eg show how many places
> in the current lisp sources would use it. And then if added it needs to
> be documented too.