GNU bug report logs - #21390
24.5; Missing definition for predicate `buffer-or-string-p'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21390 in the body.
You can then email your comments to 21390 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: "C. Calancha" <f92capac <at> gmail.com>
Subject: 24.5; Missing definition for predicate `buffer-or-string-p'
Date: Tue, 1 Sep 2015 10:47:03 +0900 (JST)

[Message part 1 (text/plain, inline)]

Predicate `buffer-or-string-p' is declared but definition is missing in:
emacs-24.5/src/data.c



In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23)
 of 2015-08-30 on calancha-ilc.kek.jp
System Description:	Scientific Linux release 6.7 (Carbon)

Configured using:
 `configure --with-gif=no'

Important settings:
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: @im=none
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils xterm time-date tooltip electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 75908 4118)
 (symbols 48 17587 0)
 (miscs 40 31 88)
 (strings 32 9018 4405)
 (string-bytes 1 248942)
 (vectors 16 7095)
 (vector-slots 8 341333 33198)
 (floats 8 65 260)
 (intervals 56 156 0)
 (buffers 960 11)
 (heap 1024 22077 2012))

[data.patch (text/plain, attachment)]

Message #8 received at 21390 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: 21390 <at> debbugs.gnu.org
Cc: "C. Calancha" <f92capac <at> gmail.com>
Subject: Corrected patch
Date: Tue, 1 Sep 2015 11:39:15 +0900 (JST)

[Message part 1 (text/plain, inline)]

My previous patch would not work. I attach a corrected version which 
fix the issue.

[data.patch (text/plain, attachment)]

Message #11 received at 21390 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 21390 <at> debbugs.gnu.org
Subject: Re: bug#21390: 24.5;
 Missing definition for predicate `buffer-or-string-p'
Date: Tue, 01 Sep 2015 11:45:04 -0400

Tino Calancha wrote:

> Predicate `buffer-or-string-p' is declared but definition is missing in:
> emacs-24.5/src/data.c

I guess you are referring to the fact that src/data.c contains

  DEFSYM (Qbuffer_or_string_p, "buffer-or-string-p")

This is used in CHECK_STRING_OR_BUFFER in textprop.c.
The simple presence of the DEFSYM is not by itself motivation for the
addition of a "buffer-or-string-p" predicate.

If you think such a thing is needed, you need to eg show how many places
in the current lisp sources would use it. And then if added it needs to
be documented too.

Message #14 received at 21390 <at> debbugs.gnu.org (full text, mbox):

From: "Constantino Calancha" <f92capac <at> gmail.com>
To: "Glenn Morris" <rgm <at> gnu.org>
Cc: "21390 <at> debbugs.gnu.org" <21390 <at> debbugs.gnu.org>
Subject: Re: bug#21390: 24.5; Missing definition for predicate
 `buffer-or-string-p'
Date: Wed, 02 Sep 2015 11:07:46 +0900

Hi Glenn,

i dont think is needed i just find more natural to be defined than not.
Its also elegant.

There are two files that may use that predicate:

simple.el
   2856:	       (not (or (bufferp output-buffer)  (stringp  
output-buffer))))
   3118:		 (not (or (bufferp output-buffer) (stringp output-buffer)))))

gnus-art.el:
   2800:	   ((not (or (bufferp (car handle)) (stringp (car handle)))))



On Wed, 02 Sep 2015 00:45:04 +0900, Glenn Morris <rgm <at> gnu.org> wrote:

> Tino Calancha wrote:
>
>> Predicate `buffer-or-string-p' is declared but definition is missing in:
>> emacs-24.5/src/data.c
>
> I guess you are referring to the fact that src/data.c contains
>
>   DEFSYM (Qbuffer_or_string_p, "buffer-or-string-p")
>
> This is used in CHECK_STRING_OR_BUFFER in textprop.c.
> The simple presence of the DEFSYM is not by itself motivation for the
> addition of a "buffer-or-string-p" predicate.
>
> If you think such a thing is needed, you need to eg show how many places
> in the current lisp sources would use it. And then if added it needs to
> be documented too.

Message #19 received at 21390-done <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: 21390-done <at> debbugs.gnu.org
Subject: Re: bug#21390: 24.5;
 Missing definition for predicate `buffer-or-string-p'
Date: Thu, 18 May 2017 13:06:45 +0900

> Predicate `buffer-or-string-p' is declared but definition is missing in:
> emacs-24.5/src/data.c
It seems not very attractive proposal, so i am closing the report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.