GNU bug report logs - #21364
[PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#21364: closed ([PATCH] Add vc-activate (interactive) to
 activate VC mode on the current buffer)
Date: Wed, 02 Sep 2015 03:46:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 01 Sep 2015 23:45:16 -0400
with message-id <jwva8t5qygu.fsf-monnier+emacsbugs <at> gnu.org>
and subject line Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer
has caused the debbugs.gnu.org bug report #21364,
regarding [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
21364: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21364
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Caldwell <david <at> porkrind.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add vc-activate (interactive) to activate VC mode on the
 current buffer
Date: Thu, 27 Aug 2015 11:32:56 -0700

[Message part 3 (text/plain, inline)]

Hello,

Attached is a patch (in git am format) to add a new interactive function
`vc-activate`, which simply calls `vc-find-file-hook` to activate VC
mode on a buffer.

The motivation comes from the fact that I don't consistently use VC for
everything. I often pop back and forth to the command line, depending on
the situation. This ends up with a lot of "git add" commands being run
behind emacs's back. I've been using `M-x revert-buffer` or `C-x C-v`,
but both of them seem too harsh for what I really want, which is for VC
to just check again real quick. I could `M-: RET (vc-find-file-hook)`
but that doesn't roll off the tongue very well.

`vc-activate` is a nicely named interactive wrapper around
vc-find-file-hook so that I can just do `M-x vc-activate RET` and I'm in
business.

Thanks,
  David

[0001-Add-vc-activate-interactive-to-activate-VC-mode-on-t.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: David Caldwell <david <at> porkrind.org>
Cc: 21364-done <at> debbugs.gnu.org
Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC
 mode on the current buffer
Date: Tue, 01 Sep 2015 23:45:16 -0400

>> > Ok. The attached patch is updated to do just that. The only thing I
>> > noticed was that after aliasing, vc-find-file-hook shows up in M-x since
>> > the new function is interactive.

Actually, now I remember that in Emacs-25, M-x's completion was changed
to skip obsolete commands, so I installed your patch with
define-obsolete-function-alias.
Thank you.

BTW, I could still accept this patch as a tiny change, but it's already
the second one, so you should consider signing the copyright paperwork
before the next occasion.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.