From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 14:33:22 2015 Received: (at submit) by debbugs.gnu.org; 27 Aug 2015 18:33:23 +0000 Received: from localhost ([127.0.0.1]:40534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV1zG-00081J-C8 for submit@debbugs.gnu.org; Thu, 27 Aug 2015 14:33:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40312) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV1zD-00081A-5f for submit@debbugs.gnu.org; Thu, 27 Aug 2015 14:33:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZV1zC-000863-0U for submit@debbugs.gnu.org; Thu, 27 Aug 2015 14:33:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZV1zB-00085z-Te for submit@debbugs.gnu.org; Thu, 27 Aug 2015 14:33:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZV1zA-0006Xz-Tv for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2015 14:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZV1z6-000838-Ss for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2015 14:33:16 -0400 Received: from sa38.galvanix.net ([98.126.48.38]:51911 helo=kill.porkrind.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZV1z6-0007uV-Lf for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2015 14:33:12 -0400 Received: from porkrind.org (cpe-76-170-36-134.socal.res.rr.com [76.170.36.134]) by kill.porkrind.org (Postfix) with ESMTPS id E8C345F6CB for ; Thu, 27 Aug 2015 11:32:57 -0700 (PDT) Authentication-Results: kill.porkrind.org; dkim=pass (1536-bit key; unprotected) header.d=porkrind.org header.i=@porkrind.org header.b=qNfU/3R5; dkim-atps=neutral Received: from porkrind.org (localhost [127.0.0.1]) by porkrind.org (8.14.9/8.14.9/Debian-4) with ESMTP id t7RIWuvp015841 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Aug 2015 11:32:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=porkrind.org; s=apoptygma; t=1440700377; bh=uB7ZJ9rK+PLwP7vxWQ0JSbuqs/ntmw+a0kNatK1873c=; h=From:Date:To:Subject:From; b=qNfU/3R58T6boLAXDJgHnJKuvtWefov3ERb1sr0zYdHjmNvLisoChqtUgg3TSzVO0 XIALTRFPatEN+0VclRAzZ/yOE61bpnXEqO2AOO445qIeqtzPawYPzZ4S6Eie0oSMB+ 1QAEHdnOjMJTQ+mtUq2zw7u7up2sQzJqtvaHejGDH0kvhG4zf/5RmgAjDjewAKCx+S 2oFcW97piShFnXjtY0rlrOzfHEaiZIr4HvtLYfGzA+OhRZilJzRv/YRE1g5 Received: (from david@localhost) by porkrind.org (8.14.9/8.14.9/Submit) id t7RIWuhU015840; Thu, 27 Aug 2015 11:32:56 -0700 From: David Caldwell Date: Thu, 27 Aug 2015 11:32:56 -0700 To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: <20150827183246.GA15564@porkrind.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, Attached is a patch (in git am format) to add a new interactive function `vc-activate`, which simply calls `vc-find-file-hook` to activate VC mode on a buffer. The motivation comes from the fact that I don't consistently use VC for everything. I often pop back and forth to the command line, depending on the situation. This ends up with a lot of "git add" commands being run behind emacs's back. I've been using `M-x revert-buffer` or `C-x C-v`, but both of them seem too harsh for what I really want, which is for VC to just check again real quick. I could `M-: RET (vc-find-file-hook)` but that doesn't roll off the tongue very well. `vc-activate` is a nicely named interactive wrapper around vc-find-file-hook so that I can just do `M-x vc-activate RET` and I'm in business. Thanks, David --qMm9M+Fa2AknHoGS Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Add-vc-activate-interactive-to-activate-VC-mode-on-t.patch" >From 627c54175d9287143499ed42be91d3fcc42a74b1 Mon Sep 17 00:00:00 2001 From: David Caldwell Date: Thu, 27 Aug 2015 11:04:51 -0700 Subject: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer (which may have been added to revision control behind Emacs's back). * lisp/vc/vc-hooks.el (vc-activate): New; interactive way to activate VC mode on the current buffer. --- lisp/vc/vc-hooks.el | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index bae9919..1c12b01 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -851,6 +851,11 @@ current, and kill the buffer that visits the link." (add-hook 'find-file-hook 'vc-find-file-hook) +(defun vc-activate () + "Activate VC mode on current buffer if appropriate." + (interactive) + (vc-find-file-hook)) + (defun vc-kill-buffer-hook () "Discard VC info about a file when we kill its buffer." (when buffer-file-name (vc-file-clearprops buffer-file-name))) -- 2.5.0 --qMm9M+Fa2AknHoGS-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 22:23:11 2015 Received: (at 21364) by debbugs.gnu.org; 28 Aug 2015 02:23:11 +0000 Received: from localhost ([127.0.0.1]:40686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV9Jv-0007cy-JN for submit@debbugs.gnu.org; Thu, 27 Aug 2015 22:23:11 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26377) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV9Ju-0007cq-6a for 21364@debbugs.gnu.org; Thu, 27 Aug 2015 22:23:10 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CdDQA731xV/5P+d0tcgxCEAshgBAICgTw9EAEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtAQSzP4FFI2GBWoFZIoJ4AQEB X-IPAS-Result: A0CdDQA731xV/5P+d0tcgxCEAshgBAICgTw9EAEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtAQSzP4FFI2GBWoFZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161636775" Received: from 75-119-254-147.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([75.119.254.147]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Aug 2015 22:23:07 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 17662AE0D6; Thu, 27 Aug 2015 22:23:07 -0400 (EDT) From: Stefan Monnier To: David Caldwell Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: References: <20150827183246.GA15564@porkrind.org> Date: Thu, 27 Aug 2015 22:23:07 -0400 In-Reply-To: <20150827183246.GA15564@porkrind.org> (David Caldwell's message of "Thu, 27 Aug 2015 11:32:56 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The motivation comes from the fact that I don't consistently use VC for > everything. I often pop back and forth to the command line, depending on > the situation. This ends up with a lot of "git add" commands being run > behind emacs's back. I've been using `M-x revert-buffer` or `C-x C-v`, > but both of them seem too harsh for what I really want, which is for VC > to just check again real quick. I could `M-: RET (vc-find-file-hook)` > but that doesn't roll off the tongue very well. Rather than vc-activate, I think you want a more general function, which *refreshes* the VC state (i.e. the state afterwards may be "inactive" if the file is not under the control of a VCS, for example). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 22:44:03 2015 Received: (at 21364) by debbugs.gnu.org; 28 Aug 2015 02:44:03 +0000 Received: from localhost ([127.0.0.1]:40702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV9e7-00086p-Dn for submit@debbugs.gnu.org; Thu, 27 Aug 2015 22:44:03 -0400 Received: from sa38.galvanix.net ([98.126.48.38]:43058 helo=kill.porkrind.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV9e4-00086I-Q2 for 21364@debbugs.gnu.org; Thu, 27 Aug 2015 22:44:01 -0400 Received: from porkrind.org (cpe-76-170-36-134.socal.res.rr.com [76.170.36.134]) by kill.porkrind.org (Postfix) with ESMTPS id EB2425F142; Thu, 27 Aug 2015 19:43:48 -0700 (PDT) Authentication-Results: kill.porkrind.org; dkim=pass (1536-bit key; unprotected) header.d=porkrind.org header.i=@porkrind.org header.b=So6lItLS; dkim-atps=neutral Received: from [10.0.0.10] (black.local [10.0.0.10]) (authenticated bits=0) by porkrind.org (8.14.9/8.14.9/Debian-4) with ESMTP id t7S2hklT000826 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 27 Aug 2015 19:43:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=porkrind.org; s=apoptygma; t=1440729827; bh=NflrsGEUV4vEZJpBni5Y30HeRXj5QOIjioFGn7aDlz8=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=So6lItLSFFEg1P49Uvqay+eOnE3+PmGOLkcfzIg/JNm2FoJxYPCIYl8rQKC5jYzFy GpaGl+MWL5cFdJBOGAgrSdNSTGAXvPsPN3DmSMTthaej63alkptcIRkZblgiUeTIk8 n6VGdBrJ8ps3o9m//Z52D2bHfnAIpxwnYaihcp8FEKTohi/DXnazTfpuHUHO498EFo OWT4Tc6+HABtPAwxH+jCIPRshblM9H5ZQBVFisGbvsGGp0CujrNaB5EgHpo Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer To: Stefan Monnier References: <20150827183246.GA15564@porkrind.org> From: David Caldwell X-Enigmail-Draft-Status: N1110 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAQAAAD9CzEMAAAACXBIWXMAAAsTAAALEwEAmpwY AAAABGdBTUEAALGOfPtRkwAAACBjSFJNAAB6JQAAgIMAAPn/AACA6QAAdTAAAOpgAAA6mAAAF2+S X8VGAAABiklEQVR42rRYSZIDIQwzLv7/ZXLoEAzeBKG7ag4DRhZeBKQ0Qr5imLWCrKwn0HImc1Mx aAvmmc/cuAT7RMYws6v/gHeb0p4/y5792GJJlLZWOPgsdV5NaRes4Xe4632sLljD7wKv1Ta74H/h MxecN1Rc2TatYcP7zb+6WFfN/zMSHg1Ymuxjrzd+DuLw6Nlekggt1hvr7KK9tRIX85jjM6GTYhfv nzXH3jBdYc4koueBs66M+Xv9O9n5ML4urWssjGeMY3if3bzGSvk30BQ46OOaxJjLCpzPJAzXrOrD z5VFh58TIiwESIiCHNxxwPTy97qDei8YdpVdyYEv6EQcK8n+iTyE/Cn1eoe7HwN+F56oErVSGtJY Q1sR2ehaUHfjvJuv0tL7qAzEbBmfF2IHrVi8zp9N0pZtQZZHOXp/sLW4+hqKvm3iccaPwP3XgnKX n8/YtVeOsnenRG7VCBFlZ5fe3LOyANCVdGAIwDs7tTXGF4hIk15/iAfSgv2UkNFItSszOG3Ha7r0 GQBerhBkHOAzmQAAAABJRU5ErkJggg== Message-ID: <55DFCAE1.1040103@porkrind.org> Date: Thu, 27 Aug 2015 19:43:45 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:40.0) Gecko/20100101 Thunderbird/40.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms080507070604000305000803" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on kill.porkrind.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a cryptographically signed message in MIME format. --------------ms080507070604000305000803 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/27/15 7:23 PM, Stefan Monnier wrote: >> The motivation comes from the fact that I don't consistently use VC fo= r >> everything. I often pop back and forth to the command line, depending = on >> the situation. This ends up with a lot of "git add" commands being run= >> behind emacs's back. I've been using `M-x revert-buffer` or `C-x C-v`,= >> but both of them seem too harsh for what I really want, which is for V= C >> to just check again real quick. I could `M-: RET (vc-find-file-hook)` >> but that doesn't roll off the tongue very well. >=20 > Rather than vc-activate, I think you want a more general function, whic= h > *refreshes* the VC state (i.e. the state afterwards may be "inactive" i= f > the file is not under the control of a VCS, for example). Turns out vc-find-file-hook already deactivates the VC state--I tested by doing $ git rm --cached test && commit -m 'test' followed by `M-x vc-activate` and the VC successfully went away on my open 'test' buffer. So it sounds like maybe it's just a question of the name? -David --------------ms080507070604000305000803 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC DGAwggYkMIIFDKADAgECAgMM240wDQYJKoZIhvcNAQELBQAwgYwxCzAJBgNVBAYTAklMMRYw FAYDVQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZp Y2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJt ZWRpYXRlIENsaWVudCBDQTAeFw0xNTAyMDUwMTUxNDdaFw0xNjAyMDYwMDAzMTNaMEAxGzAZ BgNVBAMMEmRhdmlkQHBvcmtyaW5kLm9yZzEhMB8GCSqGSIb3DQEJARYSZGF2aWRAcG9ya3Jp bmQub3JnMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA7HjIR+hHVT+RlXpDQWHt fHToCo718aI00KKtR3fVlcFbFTcrkhZd52HvZvoZPLfV2IkSEMZKEnd3f17iqq5KUXGkvQja WWYv5/7T7cIA+uZJb1mJOQ33tj8Q0esRuPs+VJ6r0DE27ddOgbbUxvCaNGY4FrncDsxexl7Y GL1ktB6UMNvap+p8H5P4lDdOMfKyY6Ovdv2BfQB1s952HSyzfcuwtr2Dl7HwHE7ydvY3qBwA RMkXKfdsnMLiJlFtYfUGvoVG22OiyjDI5iSfTd1SSWzULqHYI3LI3JbqeU0KFuzETqYVJu2N PsyFPnob2YHytuUBqOleL0sZLgw/SVUK3QIDAQABo4IC2DCCAtQwCQYDVR0TBAIwADALBgNV HQ8EBAMCBLAwHQYDVR0lBBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMB0GA1UdDgQWBBRUTg7k NtqALyJsfdStcjsUsot4ZjAfBgNVHSMEGDAWgBRTcu2SnODaywFcfH6WNU7y1LhRgjAdBgNV HREEFjAUgRJkYXZpZEBwb3JrcmluZC5vcmcwggFMBgNVHSAEggFDMIIBPzCCATsGCysGAQQB gbU3AQIDMIIBKjAuBggrBgEFBQcCARYiaHR0cDovL3d3dy5zdGFydHNzbC5jb20vcG9saWN5 LnBkZjCB9wYIKwYBBQUHAgIwgeowJxYgU3RhcnRDb20gQ2VydGlmaWNhdGlvbiBBdXRob3Jp dHkwAwIBARqBvlRoaXMgY2VydGlmaWNhdGUgd2FzIGlzc3VlZCBhY2NvcmRpbmcgdG8gdGhl IENsYXNzIDEgVmFsaWRhdGlvbiByZXF1aXJlbWVudHMgb2YgdGhlIFN0YXJ0Q29tIENBIHBv bGljeSwgcmVsaWFuY2Ugb25seSBmb3IgdGhlIGludGVuZGVkIHB1cnBvc2UgaW4gY29tcGxp YW5jZSBvZiB0aGUgcmVseWluZyBwYXJ0eSBvYmxpZ2F0aW9ucy4wNgYDVR0fBC8wLTAroCmg J4YlaHR0cDovL2NybC5zdGFydHNzbC5jb20vY3J0dTEtY3JsLmNybDCBjgYIKwYBBQUHAQEE gYEwfzA5BggrBgEFBQcwAYYtaHR0cDovL29jc3Auc3RhcnRzc2wuY29tL3N1Yi9jbGFzczEv Y2xpZW50L2NhMEIGCCsGAQUFBzAChjZodHRwOi8vYWlhLnN0YXJ0c3NsLmNvbS9jZXJ0cy9z dWIuY2xhc3MxLmNsaWVudC5jYS5jcnQwIwYDVR0SBBwwGoYYaHR0cDovL3d3dy5zdGFydHNz bC5jb20vMA0GCSqGSIb3DQEBCwUAA4IBAQBMmgOPFdwSDYffO7sdYy5Irnpbw9BhOCJASvkT 65jaikhKlgE6JY5a/7n+XZV7WoSbwRqweuxnE/ckudCBx8bAmAmbleUp1JfCpGW1afLwzK+2 3PthXbf3HQ7TP0EGZaMIDwitiCwlpo86vQRK7mtkAOfzr5PbDDwPVn9A4MkvP73UQc1J4qBI XBxgpfIIwv5bJv6IbQOHryHZBVC0utWkGmkxXseEaRzKNI08CHVBILO20F7y11LVc/GWRwqw erWBnb+XrHdH7Gkyezj3ogFnDG3f+UnB5oxxS4EKAg3vV9oVPT7UmcRz7mDoB06QpY3BUmi/ qB3atQffT1h5N+7KMIIGNDCCBBygAwIBAgIBHjANBgkqhkiG9w0BAQUFADB9MQswCQYDVQQG EwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwg Q2VydGlmaWNhdGUgU2lnbmluZzEpMCcGA1UEAxMgU3RhcnRDb20gQ2VydGlmaWNhdGlvbiBB dXRob3JpdHkwHhcNMDcxMDI0MjEwMTU1WhcNMTcxMDI0MjEwMTU1WjCBjDELMAkGA1UEBhMC SUwxFjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENl cnRpZmljYXRlIFNpZ25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDEgUHJpbWFyeSBJ bnRlcm1lZGlhdGUgQ2xpZW50IENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA xwmDzM4t2BqxKaQuE6uWvooyg4ymiEGWVUet1G8SD+rqvyNH4QrvnEIaFHxOhESip7vMz39S cLpNLbL1QpOlPW/tFIzNHS3qd2XRNYG5Sv9RcGE+T4qbLtsjjJbi6sL7Ls/f/X9ftTyhxvxW kf8KW37iKrueKsxw2HqolH7GM6FX5UfNAwAu4ZifkpmZzU1slBhyWwaQPEPPZRsWoTb7q8hm gv6Nv3Hg9rmA1/VPBIOQ6SKRkHXG0Hhmq1dOFoAFI411+a/9nWm5rcVjGcIWZ2v/43Yksq60 jExipA4l5uv9/+Hm33mbgmCszdj/Dthf13tgAv2O83hLJ0exTqfrlwIDAQABo4IBrTCCAakw DwYDVR0TAQH/BAUwAwEB/zAOBgNVHQ8BAf8EBAMCAQYwHQYDVR0OBBYEFFNy7ZKc4NrLAVx8 fpY1TvLUuFGCMB8GA1UdIwQYMBaAFE4L7xqkQFulF2mHMMo0aEPQQa7yMGYGCCsGAQUFBwEB BFowWDAnBggrBgEFBQcwAYYbaHR0cDovL29jc3Auc3RhcnRzc2wuY29tL2NhMC0GCCsGAQUF BzAChiFodHRwOi8vd3d3LnN0YXJ0c3NsLmNvbS9zZnNjYS5jcnQwWwYDVR0fBFQwUjAnoCWg I4YhaHR0cDovL3d3dy5zdGFydHNzbC5jb20vc2ZzY2EuY3JsMCegJaAjhiFodHRwOi8vY3Js LnN0YXJ0c3NsLmNvbS9zZnNjYS5jcmwwgYAGA1UdIAR5MHcwdQYLKwYBBAGBtTcBAgEwZjAu BggrBgEFBQcCARYiaHR0cDovL3d3dy5zdGFydHNzbC5jb20vcG9saWN5LnBkZjA0BggrBgEF BQcCARYoaHR0cDovL3d3dy5zdGFydHNzbC5jb20vaW50ZXJtZWRpYXRlLnBkZjANBgkqhkiG 9w0BAQUFAAOCAgEACoMIfXirLAZcuGOMXq4cuSN3TaFx2H2GvD5VSy/6rV55BYHbWNaPeQn3 oBSU8KgQZn/Kck1JxbLpAxVCNtsxeW1R87ifhsYZ0qjdrA9anrW2MAWCtosmAOT4OxK9QPoS jCMxM3HbkZCDJgnlE8jMopH21BbyAYr7b5EfGRQJNtgWcvqSXwKHnTutR08+Kkn0KAkXCzeQ NLeA5LlYUzFyM7kPAp8pIRMQ+seHunmyG642S2+y/qHEdMuGIwpfz3eDF1PdctL04qYK/zu+ Qg1Bw0RwgigVZs/0c5HP2/e9DBHh7eSwtzYlk4AUr6yxLlcwSjOfOmKEQ/Q8tzh0IFiNu9IP uTGAPBn4CPxD0+Ru8T2wg8/s43R/PT3kd1OEqOJUl7q+h+r6fpvU0Fzxd2tC8Ga6fDEPme+1 Nbi+03pVjuZQKbGwKJ66gEn06WqaxVZC+J8hh/jR0k9mST1iAZPNYulcNJ8tKmVtjYsv0L1T Sm2+NwON58tO+pIVzu3DWwSEXSf+qkDavQam+QtEOZxLBXI++aMUEapSn+k3Lxm48ZCYfAWL b/Xj7F5JQMbZvCexglAbYR0kIHqW5DnsYSdMD/IplJMojx0NBrxJ3fN9dvX2Y6BIXRsF1du4 qESm4/3CKuyUV7p9DW3mPlHTGLvYxnyKQy7VFBkoLINszBrOUeIxggPtMIID6QIBATCBlDCB jDELMAkGA1UEBhMCSUwxFjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3Vy ZSBEaWdpdGFsIENlcnRpZmljYXRlIFNpZ25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNz IDEgUHJpbWFyeSBJbnRlcm1lZGlhdGUgQ2xpZW50IENBAgMM240wDQYJYIZIAWUDBAIBBQCg ggIpMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE1MDgyODAy NDM0NVowLwYJKoZIhvcNAQkEMSIEIOIREOBDs5qYUa7WK38mopitHkNFXQny2slitumtdITF MGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0D BzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwIC ASgwgaUGCSsGAQQBgjcQBDGBlzCBlDCBjDELMAkGA1UEBhMCSUwxFjAUBgNVBAoTDVN0YXJ0 Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNpZ25pbmcx ODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDEgUHJpbWFyeSBJbnRlcm1lZGlhdGUgQ2xpZW50 IENBAgMM240wgacGCyqGSIb3DQEJEAILMYGXoIGUMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UE ChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUg U2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0 ZSBDbGllbnQgQ0ECAwzbjTANBgkqhkiG9w0BAQEFAASCAQCPjk73EwtFbRHNL9D6cvQd6dPi lfK59/CUnCaLM3tnS+TUHLjBntYygHNsgO9OHyuF+d02UFDSE/FkttkEOBGJ4k2KPCov6cph tSTllRjKpamx2q3MUBHumA4CkZQvAldWpw+Tc9P/LiAiGIg38RhUBxQRZkDE8aUgd6jDRIWw soNavMPXTgy1wE0Bg1VR+XVMR1axgDYeEpqW9+M4eUVU42dmv4r1OGE10Mf1lclHT35BddGX UIBTKUngXUwzcoc88QEVRdR/AdAwxdo8rQBiFeBRrTu83sbYx/OwT8/3Lft/RhIrOgFUa/YH 8sqbvYxNc4DmVgnAgOcfXbslKHqXAAAAAAAA --------------ms080507070604000305000803-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 11:26:57 2015 Received: (at 21364) by debbugs.gnu.org; 29 Aug 2015 15:26:57 +0000 Received: from localhost ([127.0.0.1]:42221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVi1x-0002QR-Hn for submit@debbugs.gnu.org; Sat, 29 Aug 2015 11:26:57 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVi1w-0002QJ-BS for 21364@debbugs.gnu.org; Sat, 29 Aug 2015 11:26:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CXDQA731xV/8Fw3mhcgxCEAshgBAICgTw8EQEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEBBQEBAQEeizqFBQeELQWLRKlAI2GBWoFZIoJ4AQEB X-IPAS-Result: A0CXDQA731xV/8Fw3mhcgxCEAshgBAICgTw8EQEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEBBQEBAQEeizqFBQeELQWLRKlAI2GBWoFZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161793409" Received: from 104-222-112-193.cpe.teksavvy.com (HELO ceviche.home) ([104.222.112.193]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Aug 2015 11:26:55 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 72A106615C; Sat, 29 Aug 2015 11:26:55 -0400 (EDT) From: Stefan Monnier To: David Caldwell Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: References: <20150827183246.GA15564@porkrind.org> <55DFCAE1.1040103@porkrind.org> Date: Sat, 29 Aug 2015 11:26:55 -0400 In-Reply-To: <55DFCAE1.1040103@porkrind.org> (David Caldwell's message of "Thu, 27 Aug 2015 19:43:45 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > So it sounds like maybe it's just a question of the name? Looks like it, then, yes, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 13:39:31 2015 Received: (at 21364) by debbugs.gnu.org; 29 Aug 2015 17:39:31 +0000 Received: from localhost ([127.0.0.1]:42281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVk6F-0005XR-G8 for submit@debbugs.gnu.org; Sat, 29 Aug 2015 13:39:31 -0400 Received: from sa38.galvanix.net ([98.126.48.38]:35768 helo=kill.porkrind.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVk6C-0005XI-93 for 21364@debbugs.gnu.org; Sat, 29 Aug 2015 13:39:29 -0400 Received: from porkrind.org (cpe-76-170-36-134.socal.res.rr.com [76.170.36.134]) by kill.porkrind.org (Postfix) with ESMTPS id BD6305F146; Sat, 29 Aug 2015 10:39:20 -0700 (PDT) Authentication-Results: kill.porkrind.org; dkim=pass (1536-bit key; unprotected) header.d=porkrind.org header.i=@porkrind.org header.b=EAQik+it; dkim-atps=neutral Received: from [10.0.0.10] (black.local [10.0.0.10]) (authenticated bits=0) by porkrind.org (8.14.9/8.14.9/Debian-4) with ESMTP id t7THdIQW009803 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 29 Aug 2015 10:39:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=porkrind.org; s=apoptygma; t=1440869959; bh=YbhShTZMMzOXBQKGQdEWMOYY5WQwhRVtScRQlJyYz5c=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=EAQik+itU2AtNcqjUt7xAyyCWFDmbsj1rrs5/KGQpPSHMdTXrkU1PEMmwcxxLENk4 0cDe6wwAkINc2uwoloiWWetDlM4NZgex9ctYf90sO3jCPsRrtzNShEueahbXDrPNHx 7gv9bNhhgO8bdfR9URlA/bLV7Wvk0IvYLtxkDfLAsjr41Y4V3sdCX7ljl58D4V92v0 8FXq/hv7D0hjspBve46xbgi5t/Dw7EO+EVLeri4VuWWDWSnWv0uS3aryL0+ Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer To: Stefan Monnier References: <20150827183246.GA15564@porkrind.org> <55DFCAE1.1040103@porkrind.org> From: David Caldwell Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAQAAAD9CzEMAAAACXBIWXMAAAsTAAALEwEAmpwY AAAABGdBTUEAALGOfPtRkwAAACBjSFJNAAB6JQAAgIMAAPn/AACA6QAAdTAAAOpgAAA6mAAAF2+S X8VGAAABiklEQVR42rRYSZIDIQwzLv7/ZXLoEAzeBKG7ag4DRhZeBKQ0Qr5imLWCrKwn0HImc1Mx aAvmmc/cuAT7RMYws6v/gHeb0p4/y5792GJJlLZWOPgsdV5NaRes4Xe4632sLljD7wKv1Ta74H/h MxecN1Rc2TatYcP7zb+6WFfN/zMSHg1Ymuxjrzd+DuLw6Nlekggt1hvr7KK9tRIX85jjM6GTYhfv nzXH3jBdYc4koueBs66M+Xv9O9n5ML4urWssjGeMY3if3bzGSvk30BQ46OOaxJjLCpzPJAzXrOrD z5VFh58TIiwESIiCHNxxwPTy97qDei8YdpVdyYEv6EQcK8n+iTyE/Cn1eoe7HwN+F56oErVSGtJY Q1sR2ehaUHfjvJuv0tL7qAzEbBmfF2IHrVi8zp9N0pZtQZZHOXp/sLW4+hqKvm3iccaPwP3XgnKX n8/YtVeOsnenRG7VCBFlZ5fe3LOyANCVdGAIwDs7tTXGF4hIk15/iAfSgv2UkNFItSszOG3Ha7r0 GQBerhBkHOAzmQAAAABJRU5ErkJggg== Message-ID: <55E1EE45.8080306@porkrind.org> Date: Sat, 29 Aug 2015 10:39:17 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:40.0) Gecko/20100101 Thunderbird/40.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms050307060801040700080005" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on kill.porkrind.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a cryptographically signed message in MIME format. --------------ms050307060801040700080005 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/29/15 8:26 AM, Stefan Monnier wrote: >> So it sounds like maybe it's just a question of the name? >=20 > Looks like it, then, yes, I was hoping you'd have a suggestion :-). How about vc-buffer-refresh? It's not quite analogous to vc-dir-refresh, but it makes sense in itself. Also, I was thinking maybe it would make more sense to rename vc-find-file-hook to vc-buffer-refresh (making it interactive along the way) and then doing: (add-hook 'find-file-hook 'vc-buffer-refresh) Thoughts? -David --------------ms050307060801040700080005 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC DGAwggYkMIIFDKADAgECAgMM240wDQYJKoZIhvcNAQELBQAwgYwxCzAJBgNVBAYTAklMMRYw FAYDVQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZp Y2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJt ZWRpYXRlIENsaWVudCBDQTAeFw0xNTAyMDUwMTUxNDdaFw0xNjAyMDYwMDAzMTNaMEAxGzAZ BgNVBAMMEmRhdmlkQHBvcmtyaW5kLm9yZzEhMB8GCSqGSIb3DQEJARYSZGF2aWRAcG9ya3Jp bmQub3JnMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA7HjIR+hHVT+RlXpDQWHt fHToCo718aI00KKtR3fVlcFbFTcrkhZd52HvZvoZPLfV2IkSEMZKEnd3f17iqq5KUXGkvQja WWYv5/7T7cIA+uZJb1mJOQ33tj8Q0esRuPs+VJ6r0DE27ddOgbbUxvCaNGY4FrncDsxexl7Y GL1ktB6UMNvap+p8H5P4lDdOMfKyY6Ovdv2BfQB1s952HSyzfcuwtr2Dl7HwHE7ydvY3qBwA RMkXKfdsnMLiJlFtYfUGvoVG22OiyjDI5iSfTd1SSWzULqHYI3LI3JbqeU0KFuzETqYVJu2N PsyFPnob2YHytuUBqOleL0sZLgw/SVUK3QIDAQABo4IC2DCCAtQwCQYDVR0TBAIwADALBgNV HQ8EBAMCBLAwHQYDVR0lBBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMB0GA1UdDgQWBBRUTg7k NtqALyJsfdStcjsUsot4ZjAfBgNVHSMEGDAWgBRTcu2SnODaywFcfH6WNU7y1LhRgjAdBgNV HREEFjAUgRJkYXZpZEBwb3JrcmluZC5vcmcwggFMBgNVHSAEggFDMIIBPzCCATsGCysGAQQB gbU3AQIDMIIBKjAuBggrBgEFBQcCARYiaHR0cDovL3d3dy5zdGFydHNzbC5jb20vcG9saWN5 LnBkZjCB9wYIKwYBBQUHAgIwgeowJxYgU3RhcnRDb20gQ2VydGlmaWNhdGlvbiBBdXRob3Jp dHkwAwIBARqBvlRoaXMgY2VydGlmaWNhdGUgd2FzIGlzc3VlZCBhY2NvcmRpbmcgdG8gdGhl IENsYXNzIDEgVmFsaWRhdGlvbiByZXF1aXJlbWVudHMgb2YgdGhlIFN0YXJ0Q29tIENBIHBv bGljeSwgcmVsaWFuY2Ugb25seSBmb3IgdGhlIGludGVuZGVkIHB1cnBvc2UgaW4gY29tcGxp YW5jZSBvZiB0aGUgcmVseWluZyBwYXJ0eSBvYmxpZ2F0aW9ucy4wNgYDVR0fBC8wLTAroCmg J4YlaHR0cDovL2NybC5zdGFydHNzbC5jb20vY3J0dTEtY3JsLmNybDCBjgYIKwYBBQUHAQEE gYEwfzA5BggrBgEFBQcwAYYtaHR0cDovL29jc3Auc3RhcnRzc2wuY29tL3N1Yi9jbGFzczEv Y2xpZW50L2NhMEIGCCsGAQUFBzAChjZodHRwOi8vYWlhLnN0YXJ0c3NsLmNvbS9jZXJ0cy9z dWIuY2xhc3MxLmNsaWVudC5jYS5jcnQwIwYDVR0SBBwwGoYYaHR0cDovL3d3dy5zdGFydHNz bC5jb20vMA0GCSqGSIb3DQEBCwUAA4IBAQBMmgOPFdwSDYffO7sdYy5Irnpbw9BhOCJASvkT 65jaikhKlgE6JY5a/7n+XZV7WoSbwRqweuxnE/ckudCBx8bAmAmbleUp1JfCpGW1afLwzK+2 3PthXbf3HQ7TP0EGZaMIDwitiCwlpo86vQRK7mtkAOfzr5PbDDwPVn9A4MkvP73UQc1J4qBI XBxgpfIIwv5bJv6IbQOHryHZBVC0utWkGmkxXseEaRzKNI08CHVBILO20F7y11LVc/GWRwqw erWBnb+XrHdH7Gkyezj3ogFnDG3f+UnB5oxxS4EKAg3vV9oVPT7UmcRz7mDoB06QpY3BUmi/ qB3atQffT1h5N+7KMIIGNDCCBBygAwIBAgIBHjANBgkqhkiG9w0BAQUFADB9MQswCQYDVQQG EwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwg Q2VydGlmaWNhdGUgU2lnbmluZzEpMCcGA1UEAxMgU3RhcnRDb20gQ2VydGlmaWNhdGlvbiBB dXRob3JpdHkwHhcNMDcxMDI0MjEwMTU1WhcNMTcxMDI0MjEwMTU1WjCBjDELMAkGA1UEBhMC SUwxFjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENl cnRpZmljYXRlIFNpZ25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDEgUHJpbWFyeSBJ bnRlcm1lZGlhdGUgQ2xpZW50IENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA xwmDzM4t2BqxKaQuE6uWvooyg4ymiEGWVUet1G8SD+rqvyNH4QrvnEIaFHxOhESip7vMz39S cLpNLbL1QpOlPW/tFIzNHS3qd2XRNYG5Sv9RcGE+T4qbLtsjjJbi6sL7Ls/f/X9ftTyhxvxW kf8KW37iKrueKsxw2HqolH7GM6FX5UfNAwAu4ZifkpmZzU1slBhyWwaQPEPPZRsWoTb7q8hm gv6Nv3Hg9rmA1/VPBIOQ6SKRkHXG0Hhmq1dOFoAFI411+a/9nWm5rcVjGcIWZ2v/43Yksq60 jExipA4l5uv9/+Hm33mbgmCszdj/Dthf13tgAv2O83hLJ0exTqfrlwIDAQABo4IBrTCCAakw DwYDVR0TAQH/BAUwAwEB/zAOBgNVHQ8BAf8EBAMCAQYwHQYDVR0OBBYEFFNy7ZKc4NrLAVx8 fpY1TvLUuFGCMB8GA1UdIwQYMBaAFE4L7xqkQFulF2mHMMo0aEPQQa7yMGYGCCsGAQUFBwEB BFowWDAnBggrBgEFBQcwAYYbaHR0cDovL29jc3Auc3RhcnRzc2wuY29tL2NhMC0GCCsGAQUF BzAChiFodHRwOi8vd3d3LnN0YXJ0c3NsLmNvbS9zZnNjYS5jcnQwWwYDVR0fBFQwUjAnoCWg I4YhaHR0cDovL3d3dy5zdGFydHNzbC5jb20vc2ZzY2EuY3JsMCegJaAjhiFodHRwOi8vY3Js LnN0YXJ0c3NsLmNvbS9zZnNjYS5jcmwwgYAGA1UdIAR5MHcwdQYLKwYBBAGBtTcBAgEwZjAu BggrBgEFBQcCARYiaHR0cDovL3d3dy5zdGFydHNzbC5jb20vcG9saWN5LnBkZjA0BggrBgEF BQcCARYoaHR0cDovL3d3dy5zdGFydHNzbC5jb20vaW50ZXJtZWRpYXRlLnBkZjANBgkqhkiG 9w0BAQUFAAOCAgEACoMIfXirLAZcuGOMXq4cuSN3TaFx2H2GvD5VSy/6rV55BYHbWNaPeQn3 oBSU8KgQZn/Kck1JxbLpAxVCNtsxeW1R87ifhsYZ0qjdrA9anrW2MAWCtosmAOT4OxK9QPoS jCMxM3HbkZCDJgnlE8jMopH21BbyAYr7b5EfGRQJNtgWcvqSXwKHnTutR08+Kkn0KAkXCzeQ NLeA5LlYUzFyM7kPAp8pIRMQ+seHunmyG642S2+y/qHEdMuGIwpfz3eDF1PdctL04qYK/zu+ Qg1Bw0RwgigVZs/0c5HP2/e9DBHh7eSwtzYlk4AUr6yxLlcwSjOfOmKEQ/Q8tzh0IFiNu9IP uTGAPBn4CPxD0+Ru8T2wg8/s43R/PT3kd1OEqOJUl7q+h+r6fpvU0Fzxd2tC8Ga6fDEPme+1 Nbi+03pVjuZQKbGwKJ66gEn06WqaxVZC+J8hh/jR0k9mST1iAZPNYulcNJ8tKmVtjYsv0L1T Sm2+NwON58tO+pIVzu3DWwSEXSf+qkDavQam+QtEOZxLBXI++aMUEapSn+k3Lxm48ZCYfAWL b/Xj7F5JQMbZvCexglAbYR0kIHqW5DnsYSdMD/IplJMojx0NBrxJ3fN9dvX2Y6BIXRsF1du4 qESm4/3CKuyUV7p9DW3mPlHTGLvYxnyKQy7VFBkoLINszBrOUeIxggPtMIID6QIBATCBlDCB jDELMAkGA1UEBhMCSUwxFjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3Vy ZSBEaWdpdGFsIENlcnRpZmljYXRlIFNpZ25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNz IDEgUHJpbWFyeSBJbnRlcm1lZGlhdGUgQ2xpZW50IENBAgMM240wDQYJYIZIAWUDBAIBBQCg ggIpMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE1MDgyOTE3 MzkxN1owLwYJKoZIhvcNAQkEMSIEILNAXFDj5hnffI01uQL0GuDtZB7WB3ceHyJYUYbm7Y0s MGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0D BzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwIC ASgwgaUGCSsGAQQBgjcQBDGBlzCBlDCBjDELMAkGA1UEBhMCSUwxFjAUBgNVBAoTDVN0YXJ0 Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNpZ25pbmcx ODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDEgUHJpbWFyeSBJbnRlcm1lZGlhdGUgQ2xpZW50 IENBAgMM240wgacGCyqGSIb3DQEJEAILMYGXoIGUMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UE ChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUg U2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0 ZSBDbGllbnQgQ0ECAwzbjTANBgkqhkiG9w0BAQEFAASCAQCe/8oVA+1QMM7ztGWuPpoXTp2J Pds7JRanr7ossFVENo/vTHS4G2cIill88xprmWtDCMDUCHM3ot0dpM7VJITWnPdsPeu3/RX+ rehhIz4OzL5zdSSxVAmuZXBBT/hGixwwMLgrlWZfDmnPWUz4W0HYrOEJ3z5UYd+JUVdcYuj9 kUSYaxezc8P/3+ReyTojjOuBFAek9M3tBPqzvXEyenB3bbMBbA6OBAHnoHOVvBlVm0VeYcoB J0CzqFgh/ZH9oIptEQKn1m03qXHzV+2WhDOsO2vJhRHMwCa0ri8WGkSc1aqwaMBbd815M9n2 HNq23tD7Ea6jNnOsog6nc9vOYNHIAAAAAAAA --------------ms050307060801040700080005-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 22:11:51 2015 Received: (at 21364) by debbugs.gnu.org; 30 Aug 2015 02:11:51 +0000 Received: from localhost ([127.0.0.1]:42383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVs63-0001Bu-0Z for submit@debbugs.gnu.org; Sat, 29 Aug 2015 22:11:51 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26624) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVs61-0001Bn-Nh for 21364@debbugs.gnu.org; Sat, 29 Aug 2015 22:11:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CVDQA731xV/8Fw3mhcgxCEAsEVh0sEAgKBPDsSAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0BBLUEI2GBWoFZIoJ4AQEB X-IPAS-Result: A0CVDQA731xV/8Fw3mhcgxCEAsEVh0sEAgKBPDsSAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0BBLUEI2GBWoFZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161825346" Received: from 104-222-112-193.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.222.112.193]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Aug 2015 22:11:49 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E6B2FAE0BA; Sat, 29 Aug 2015 22:11:48 -0400 (EDT) From: Stefan Monnier To: David Caldwell Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: References: <20150827183246.GA15564@porkrind.org> <55DFCAE1.1040103@porkrind.org> <55E1EE45.8080306@porkrind.org> Date: Sat, 29 Aug 2015 22:11:48 -0400 In-Reply-To: <55E1EE45.8080306@porkrind.org> (David Caldwell's message of "Sat, 29 Aug 2015 10:39:17 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > How about vc-buffer-refresh? Hm... I think that makes it sound like it'll revert the buffer's content or something. How 'bout `vc-refresh-state'? > Also, I was thinking maybe it would make more sense to rename > vc-find-file-hook to vc-buffer-refresh (making it interactive along the > way) and then doing: > (add-hook 'find-file-hook 'vc-buffer-refresh) If the two are really identical, then yes, it makes sense to just rename the existing function and make it interactive. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 06:22:21 2015 Received: (at 21364) by debbugs.gnu.org; 30 Aug 2015 10:22:21 +0000 Received: from localhost ([127.0.0.1]:42497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVzki-0004TI-Of for submit@debbugs.gnu.org; Sun, 30 Aug 2015 06:22:21 -0400 Received: from sa38.galvanix.net ([98.126.48.38]:44959 helo=kill.porkrind.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVzke-0004T4-TT for 21364@debbugs.gnu.org; Sun, 30 Aug 2015 06:22:18 -0400 Received: from porkrind.org (cpe-76-170-36-134.socal.res.rr.com [76.170.36.134]) by kill.porkrind.org (Postfix) with ESMTPS id A454D5F357; Sun, 30 Aug 2015 03:22:09 -0700 (PDT) Authentication-Results: kill.porkrind.org; dkim=pass (1536-bit key; unprotected) header.d=porkrind.org header.i=@porkrind.org header.b=ADsA3tXd; dkim-atps=neutral Received: from porkrind.org (localhost [127.0.0.1]) by porkrind.org (8.14.9/8.14.9/Debian-4) with ESMTP id t7UAM7af007996 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 30 Aug 2015 03:22:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=porkrind.org; s=apoptygma; t=1440930127; bh=WDbu/lkRCr6LR+ZjJaqVZrH8b7vKNK/8EcMEIgeVL9w=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ADsA3tXdx8FHg6ELymCVKGivvB4QyU/DqmTIOHc97Tb9MtSKkn+RwRp59mh3AlKrv ZN16Bo4Dke8Xl5ISJUPh/P/s/i+mdEBO3pR3yxcQIeeeUAm2To3I91Zu55mD+Z3dNC +5pW7ISMF0wt9HySpFZWA0mjbqoO1CLPR2+NnixyCDAJ+5PZRh5KgMOqJ1M9RWgzr7 kuoVeE97vAB+h2kBmjoX8lTSFELzYm7J+j+S/XhCNMnFejJprBHeDAXJeym Received: (from david@localhost) by porkrind.org (8.14.9/8.14.9/Submit) id t7UAM7xM007995; Sun, 30 Aug 2015 03:22:07 -0700 Date: Sun, 30 Aug 2015 03:22:07 -0700 From: David Caldwell To: Stefan Monnier Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: <20150830102159.GA5832@porkrind.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="lrZ03NoBR/3+SXJZ" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,FAKE_REPLY_C, T_DKIM_INVALID,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on kill.porkrind.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > How 'bout `vc-refresh-state'? That sounds good to me. > > Also, I was thinking maybe it would make more sense to rename > > vc-find-file-hook to vc-buffer-refresh (making it interactive along the > > way) and then doing: > > > (add-hook 'find-file-hook 'vc-buffer-refresh) > > If the two are really identical, then yes, it makes sense to just rename > the existing function and make it interactive. Attached is a new patch that does just that (but calling the function vc-refresh-state. -David --lrZ03NoBR/3+SXJZ Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Rename-vc-find-file-hook-to-vc-refresh-state.patch" >From 2dcff538fdebc012aac03ab37105e5374a415641 Mon Sep 17 00:00:00 2001 From: David Caldwell Date: Sun, 30 Aug 2015 02:59:56 -0700 Subject: [PATCH] Rename vc-find-file-hook to vc-refresh-state and make it interactive. This is so one can `M-x vc-refresh state' if the file is added to or removed from version control behind Emacs's back. * lisp/vc/vc-hooks.el (vc-refresh-state): Rename from vc-find-file-hook and make interactive. --- lisp/vc/vc-hooks.el | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index bae9919..f5e9eb4 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -790,8 +790,9 @@ current, and kill the buffer that visits the link." (defun vc-default-find-file-hook (_backend) nil) -(defun vc-find-file-hook () - "Function for `find-file-hook' activating VC mode if appropriate." +(defun vc-refresh-state () + "Activate or deactivate VC mode as appropriate." + (interactive) ;; Recompute whether file is version controlled, ;; if user has killed the buffer and revisited. (when vc-mode @@ -838,18 +839,18 @@ current, and kill the buffer that visits the link." (vc-follow-link) (message "Followed link to %s" buffer-file-name) - (vc-find-file-hook)) + (vc-refresh-state)) (t (if (yes-or-no-p (format "Symbolic link to %s-controlled source file; follow link? " link-type)) (progn (vc-follow-link) (message "Followed link to %s" buffer-file-name) - (vc-find-file-hook)) + (vc-refresh-state)) (message "Warning: editing through the link bypasses version control") ))))))))) -(add-hook 'find-file-hook 'vc-find-file-hook) +(add-hook 'find-file-hook 'vc-refresh-state) (defun vc-kill-buffer-hook () "Discard VC info about a file when we kill its buffer." -- 2.5.0 --lrZ03NoBR/3+SXJZ-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 21:39:36 2015 Received: (at 21364) by debbugs.gnu.org; 31 Aug 2015 01:39:36 +0000 Received: from localhost ([127.0.0.1]:43232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWE4N-00052y-TF for submit@debbugs.gnu.org; Sun, 30 Aug 2015 21:39:36 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:41323) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWE4L-00052p-BD for 21364@debbugs.gnu.org; Sun, 30 Aug 2015 21:39:34 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CVDQA731xV//rn92hcgxCEAsEVh0sEAgKBPDsSAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0BBItEk1ODa5ICI2GBWoFZIoJ4AQEB X-IPAS-Result: A0CVDQA731xV//rn92hcgxCEAsEVh0sEAgKBPDsSAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0BBItEk1ODa5ICI2GBWoFZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161898481" Received: from 104-247-231-250.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.247.231.250]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 Aug 2015 21:39:32 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 19E76AE11E; Sun, 30 Aug 2015 21:39:32 -0400 (EDT) From: Stefan Monnier To: David Caldwell Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: References: <20150830102159.GA5832@porkrind.org> Date: Sun, 30 Aug 2015 21:39:32 -0400 In-Reply-To: <20150830102159.GA5832@porkrind.org> (David Caldwell's message of "Sun, 30 Aug 2015 03:22:07 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Attached is a new patch that does just that (but calling the function > vc-refresh-state. Looks good, thanks. See comments below. > -(defun vc-find-file-hook () > - "Function for `find-file-hook' activating VC mode if appropriate." > +(defun vc-refresh-state () > + "Activate or deactivate VC mode as appropriate." > + (interactive) I think vc-find-file-hook is called from various other places, so please add an obsolete alias for the old name. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 06:06:09 2015 Received: (at 21364) by debbugs.gnu.org; 31 Aug 2015 10:06:09 +0000 Received: from localhost ([127.0.0.1]:43452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWLya-0001Ru-9e for submit@debbugs.gnu.org; Mon, 31 Aug 2015 06:06:08 -0400 Received: from sa38.galvanix.net ([98.126.48.38]:57753 helo=kill.porkrind.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWLyW-0001Rk-QT for 21364@debbugs.gnu.org; Mon, 31 Aug 2015 06:06:06 -0400 Received: from porkrind.org (cpe-76-170-36-134.socal.res.rr.com [76.170.36.134]) by kill.porkrind.org (Postfix) with ESMTPS id 3C9A55F390; Mon, 31 Aug 2015 03:05:25 -0700 (PDT) Authentication-Results: kill.porkrind.org; dkim=pass (1536-bit key; unprotected) header.d=porkrind.org header.i=@porkrind.org header.b=jcb2t5BY; dkim-atps=neutral Received: from porkrind.org (localhost [127.0.0.1]) by porkrind.org (8.14.9/8.14.9/Debian-4) with ESMTP id t7VA5J76024779 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Aug 2015 03:05:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=porkrind.org; s=apoptygma; t=1441015520; bh=8uq2a6YvVNampDStqu7HWTVn1P+8fBThOxmN9iThJZI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=jcb2t5BYRySLNWmEg/RsVdZYIczWRwKpuwHJPtR82y1i4Iu6KP1iZ97bD/3MgnZXq P6yqct85EatvZAtjIWBzEf5+KfKV5jSB10ewMypNEy1FdRimnAfd/LPrNc/1aSEmgp lC3TGyafhKg5SotBIsq5TkIZWw8qe1O1G6R2P35YWLMXNFZjfCkjq08j0f8XbNPygL 6B5UQVCS/f65HU79w/nxWY4B6UeG+GA+3LeJ+cf3cTfFJzvdgbnPcS8Qfz/ Received: (from david@localhost) by porkrind.org (8.14.9/8.14.9/Submit) id t7VA5JhS024778; Mon, 31 Aug 2015 03:05:19 -0700 Date: Mon, 31 Aug 2015 03:05:19 -0700 From: David Caldwell To: Stefan Monnier Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: <20150831100511.GA24215@porkrind.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MGYHOYXEY6WxJCY8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,FAKE_REPLY_C, T_DKIM_INVALID,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on kill.porkrind.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > > -(defun vc-find-file-hook () > > - "Function for `find-file-hook' activating VC mode if appropriate." > > +(defun vc-refresh-state () > > + "Activate or deactivate VC mode as appropriate." > > + (interactive) > > I think vc-find-file-hook is called from various other places, so please > add an obsolete alias for the old name. Ok. The attached patch is updated to do just that. The only thing I noticed was that after aliasing, vc-find-file-hook shows up in M-x since the new function is interactive. The old one didn't, but I'm not sure it's worth the effort to change it. If you think it is, I'll give it a shot. -David --MGYHOYXEY6WxJCY8 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Rename-vc-find-file-hook-to-vc-refresh-state-and-obsolete.patch" >From 6cf0d2ad94666ffc14134541b6e7300f9d04ce67 Mon Sep 17 00:00:00 2001 From: David Caldwell Date: Sun, 30 Aug 2015 02:59:56 -0700 Subject: [PATCH] Rename vc-find-file-hook to vc-refresh-state and make it interactive. This is so one can `M-x vc-refresh state' if the file is added to or removed from version control behind Emacs's back. * lisp/vc/vc-hooks.el (vc-refresh-state): Rename from vc-find-file-hook and make interactive, retaining an obsolete alias. --- lisp/vc/vc-hooks.el | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index bae9919..18cdbdd 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -790,8 +790,9 @@ current, and kill the buffer that visits the link." (defun vc-default-find-file-hook (_backend) nil) -(defun vc-find-file-hook () - "Function for `find-file-hook' activating VC mode if appropriate." +(defun vc-refresh-state () + "Activate or deactivate VC mode as appropriate." + (interactive) ;; Recompute whether file is version controlled, ;; if user has killed the buffer and revisited. (when vc-mode @@ -838,18 +839,20 @@ current, and kill the buffer that visits the link." (vc-follow-link) (message "Followed link to %s" buffer-file-name) - (vc-find-file-hook)) + (vc-refresh-state)) (t (if (yes-or-no-p (format "Symbolic link to %s-controlled source file; follow link? " link-type)) (progn (vc-follow-link) (message "Followed link to %s" buffer-file-name) - (vc-find-file-hook)) + (vc-refresh-state)) (message "Warning: editing through the link bypasses version control") ))))))))) -(add-hook 'find-file-hook 'vc-find-file-hook) +(define-obsolete-function-alias 'vc-find-file-hook 'vc-refresh-state "25.1") + +(add-hook 'find-file-hook 'vc-refresh-state) (defun vc-kill-buffer-hook () "Discard VC info about a file when we kill its buffer." -- 2.5.0 --MGYHOYXEY6WxJCY8-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 13:45:39 2015 Received: (at 21364) by debbugs.gnu.org; 31 Aug 2015 17:45:39 +0000 Received: from localhost ([127.0.0.1]:43890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWT9G-000194-Tw for submit@debbugs.gnu.org; Mon, 31 Aug 2015 13:45:39 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:7365) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWT9E-00018w-Ra for 21364@debbugs.gnu.org; Mon, 31 Aug 2015 13:45:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CdDQA731xV//rn92hcgxCEAshgBAICgTw9EAEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEBBQEBAQEeizqFBQeELQEEtQQjYYFagVkigngBAQE X-IPAS-Result: A0CdDQA731xV//rn92hcgxCEAshgBAICgTw9EAEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEBBQEBAQEeizqFBQeELQEEtQQjYYFagVkigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161963348" Received: from 104-247-231-250.cpe.teksavvy.com (HELO pastel.home) ([104.247.231.250]) by ironport2-out.teksavvy.com with ESMTP; 31 Aug 2015 13:45:36 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1EFC962254; Mon, 31 Aug 2015 13:45:36 -0400 (EDT) From: Stefan Monnier To: David Caldwell Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: References: <20150831100511.GA24215@porkrind.org> Date: Mon, 31 Aug 2015 13:45:36 -0400 In-Reply-To: <20150831100511.GA24215@porkrind.org> (David Caldwell's message of "Mon, 31 Aug 2015 03:05:19 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Ok. The attached patch is updated to do just that. The only thing I > noticed was that after aliasing, vc-find-file-hook shows up in M-x since > the new function is interactive. Good point. So I guess we should define vc-find-file-hook as an obsolete function which just calls the new function. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 10:57:39 2015 Received: (at 21364) by debbugs.gnu.org; 1 Sep 2015 14:57:39 +0000 Received: from localhost ([127.0.0.1]:45209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWn0E-0005hr-Mp for submit@debbugs.gnu.org; Tue, 01 Sep 2015 10:57:39 -0400 Received: from sa38.galvanix.net ([98.126.48.38]:45011 helo=kill.porkrind.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWn0B-0005hi-BL for 21364@debbugs.gnu.org; Tue, 01 Sep 2015 10:57:36 -0400 Received: from porkrind.org (cpe-76-170-36-134.socal.res.rr.com [76.170.36.134]) by kill.porkrind.org (Postfix) with ESMTPS id E8FD45F139; Tue, 1 Sep 2015 07:56:59 -0700 (PDT) Authentication-Results: kill.porkrind.org; dkim=pass (1536-bit key; unprotected) header.d=porkrind.org header.i=@porkrind.org header.b=LP+WNeb7; dkim-atps=neutral Received: from porkrind.org (localhost [127.0.0.1]) by porkrind.org (8.14.9/8.14.9/Debian-4) with ESMTP id t81EuuoW027889 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 1 Sep 2015 07:56:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=porkrind.org; s=apoptygma; t=1441119417; bh=qXycUqYpSxb1RVfSQt8jviiZGFAX+Mxm/BYPQnm2lNc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=LP+WNeb7aQcvWeSHFjRkd1G8Lcwhdg+c4OMlluDvi0Vmh80tDhg3FNgjnY840lV7H lcy8ZU+Qsah1lj53Gfaa2U64oztx7lxoQUEBy2deVjHS7fSA6azEIOpOgEdYzw3o7q B7HHrF6Cz//ygPEPFOI+ui0lzDGeI1UMwd+wx4vF3izdliMAQkuX00Lr5tKsaDxlYr FAxV5HP2BNE/rMPk6YGB5FyRytymuEjrdjIacHvx9JEJWyna/t0zB8yCFgr Received: (from david@localhost) by porkrind.org (8.14.9/8.14.9/Submit) id t81Euu84027888; Tue, 1 Sep 2015 07:56:56 -0700 Date: Tue, 1 Sep 2015 07:56:56 -0700 From: David Caldwell To: Stefan Monnier Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: <20150901145649.GA27344@porkrind.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="+HP7ph2BbKc20aGI" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,FAKE_REPLY_C, T_DKIM_INVALID,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on kill.porkrind.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21364 Cc: 21364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > > Ok. The attached patch is updated to do just that. The only thing I > > noticed was that after aliasing, vc-find-file-hook shows up in M-x since > > the new function is interactive. > > Good point. So I guess we should define vc-find-file-hook as an > obsolete function which just calls the new function. Ok. Attached is an updated git am patch that does just that. -David --+HP7ph2BbKc20aGI Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Rename-vc-find-file-hook-to-vc-refresh-state-and-obsolete-wrapper.patch" >From c02a45346ed3dd83f24545e5cee0edc12f304c29 Mon Sep 17 00:00:00 2001 From: David Caldwell Date: Sun, 30 Aug 2015 02:59:56 -0700 Subject: [PATCH] Rename vc-find-file-hook to vc-refresh-state and make it interactive. This is so one can `M-x vc-refresh state' if the file is added to or removed from version control behind Emacs's back. * lisp/vc/vc-hooks.el (vc-refresh-state): Rename from vc-find-file-hook and make interactive, retaining an obsolete wrapper.. --- lisp/vc/vc-hooks.el | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index bae9919..edf20ae 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -790,8 +790,9 @@ current, and kill the buffer that visits the link." (defun vc-default-find-file-hook (_backend) nil) -(defun vc-find-file-hook () - "Function for `find-file-hook' activating VC mode if appropriate." +(defun vc-refresh-state () + "Activate or deactivate VC mode as appropriate." + (interactive) ;; Recompute whether file is version controlled, ;; if user has killed the buffer and revisited. (when vc-mode @@ -838,18 +839,23 @@ current, and kill the buffer that visits the link." (vc-follow-link) (message "Followed link to %s" buffer-file-name) - (vc-find-file-hook)) + (vc-refresh-state)) (t (if (yes-or-no-p (format "Symbolic link to %s-controlled source file; follow link? " link-type)) (progn (vc-follow-link) (message "Followed link to %s" buffer-file-name) - (vc-find-file-hook)) + (vc-refresh-state)) (message "Warning: editing through the link bypasses version control") ))))))))) -(add-hook 'find-file-hook 'vc-find-file-hook) +(defun vc-find-file-hook () + (vc-refresh-state)) + +(make-obsolete 'vc-find-file-hook 'vc-refresh-state "25.1") + +(add-hook 'find-file-hook 'vc-refresh-state) (defun vc-kill-buffer-hook () "Discard VC info about a file when we kill its buffer." -- 2.5.0 --+HP7ph2BbKc20aGI-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 23:45:21 2015 Received: (at 21364-done) by debbugs.gnu.org; 2 Sep 2015 03:45:21 +0000 Received: from localhost ([127.0.0.1]:45750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWyzA-0002lH-H3 for submit@debbugs.gnu.org; Tue, 01 Sep 2015 23:45:20 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:24644) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWyz7-0002l8-Rg for 21364-done@debbugs.gnu.org; Tue, 01 Sep 2015 23:45:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CdDQA731xV//rn92hcgxCEAshgBAICgTw9EAEBAQEBAQGBCkEFg10BAQMBViMQCzQSFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0BBJ8XkhSDWSNhgVqBWSKCeAEBAQ X-IPAS-Result: A0CdDQA731xV//rn92hcgxCEAshgBAICgTw9EAEBAQEBAQGBCkEFg10BAQMBViMQCzQSFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0BBJ8XkhSDWSNhgVqBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="162125890" Received: from 104-247-231-250.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.247.231.250]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 01 Sep 2015 23:45:16 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 6A112AE064; Tue, 1 Sep 2015 23:45:16 -0400 (EDT) From: Stefan Monnier To: David Caldwell Subject: Re: bug#21364: [PATCH] Add vc-activate (interactive) to activate VC mode on the current buffer Message-ID: References: <20150901145649.GA27344@porkrind.org> Date: Tue, 01 Sep 2015 23:45:16 -0400 In-Reply-To: <20150901145649.GA27344@porkrind.org> (David Caldwell's message of "Tue, 1 Sep 2015 07:56:56 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21364-done Cc: 21364-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> > Ok. The attached patch is updated to do just that. The only thing I >> > noticed was that after aliasing, vc-find-file-hook shows up in M-x since >> > the new function is interactive. Actually, now I remember that in Emacs-25, M-x's completion was changed to skip obsolete commands, so I installed your patch with define-obsolete-function-alias. Thank you. BTW, I could still accept this patch as a tiny change, but it's already the second one, so you should consider signing the copyright paperwork before the next occasion. Stefan From unknown Sun Jun 22 07:55:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 30 Sep 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator