GNU bug report logs - #2134
[PATCH] progmodes/compile.el: check global-font-lock-mode

Previous Next

Package: emacs;

Reported by: Jari Aalto <jari.aalto <at> cante.net>

Date: Sat, 31 Jan 2009 12:40:04 UTC

Severity: minor

Merged with 801

Found in version 23.0.60

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Richard M Stallman <rms <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 2134 <at> debbugs.gnu.org
Cc: jari.aalto <at> cante.net, 2134 <at> debbugs.gnu.org
Subject: bug#2134: [PATCH] progmodes/compile.el: check global-font-lock-mode
Date: Sun, 01 Feb 2009 17:49:07 -0500
    If you read the rest of the compile.el code, you'll see that it uses
    font-lock to do its job, which is why it's turned on unconditionally.

What's happening here is not clean.  Yes, compile.el needs to force
the Font Lock mechanism to work, all the time; but it should not show
the faces on the screen if the user disables Font Lock mode.

What this calls for is something like font-lock-syntactic-keywords.
Or a switch in Font Lock to say, "Unconditionally activate the Font
Lock mechanism, independent of whether Font Lock mode is enabled, but
store the faces in the `font-lock-face' property."  With that, the
mechanism will always find the errors, but the user can control
whether to display the highlighting.




This bug report was last modified 14 years and 178 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.