From unknown Wed Aug 20 03:11:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#2134 <2134@debbugs.gnu.org> To: bug#2134 <2134@debbugs.gnu.org> Subject: Status: [PATCH] progmodes/compile.el: check global-font-lock-mode Reply-To: bug#2134 <2134@debbugs.gnu.org> Date: Wed, 20 Aug 2025 10:11:45 +0000 retitle 2134 [PATCH] progmodes/compile.el: check global-font-lock-mode reassign 2134 emacs submitter 2134 Jari Aalto severity 2134 minor thanks From jari.aalto@cante.net Sat Jan 31 04:35:00 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 31 Jan 2009 12:35:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.0 required=4.0 tests=IMPRONONCABLE_2, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh03.mail.saunalahti.fi (emh03.mail.saunalahti.fi [62.142.5.109]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0VCYpKl026440 for ; Sat, 31 Jan 2009 04:34:52 -0800 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh03-2.mail.saunalahti.fi (Postfix) with SMTP id 4D23AEBBF0 for ; Sat, 31 Jan 2009 14:34:48 +0200 (EET) Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A0522E3E1C9; Sat, 31 Jan 2009 14:34:48 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh03.mail.saunalahti.fi (Postfix) with ESMTP id 3F188158A6E for ; Sat, 31 Jan 2009 14:34:47 +0200 (EET) Received: from [192.168.1.7] (helo=jondo.cante.net) by picasso.cante.net with esmtp (Exim 4.69) (envelope-from ) id 1LTF3d-0004LU-Fe for submit@emacsbugs.donarmstrong.com; Sat, 31 Jan 2009 14:34:45 +0200 Received: from jaalto by jondo.cante.net with local (Exim 4.69) (envelope-from ) id 1LTF3e-0003Jw-1s for submit@emacsbugs.donarmstrong.com; Sat, 31 Jan 2009 14:34:46 +0200 From: Jari Aalto To: submit@debbugs.gnu.org Subject: [PATCH] progmodes/compile.el: check global-font-lock-mode Date: Sat, 31 Jan 2009 14:34:46 +0200 Message-ID: <87tz7ffyc9.fsf@jondo.cante.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 192.168.1.7 X-SA-Exim-Mail-From: jari.aalto@cante.net X-SA-Exim-Scanned: No (on picasso.cante.net); SAEximRunCond expanded to false X-Antivirus: VAMS Tags: patch Here is patch to not to turn on font-lock unconditionally. Patch is against Emacs version control tree check out 2009-01-31. 2009-01-31 Jari Aalto * progmodes/compile.el (compilation-start): Run `font-lock-fontify-buffer' only if `global-font-lock-mode' is non-nil. >From 473ca5257db6da8da4d31e4b9a2682f0972cc8c1 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Sat, 31 Jan 2009 14:27:23 +0200 Subject: [PATCH] lisp/progmodes/compile.el: (compilation-start): check global-font-lock-mode Signed-off-by: Jari Aalto --- lisp/progmodes/compile.el | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 2554730..1259403 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1326,7 +1326,8 @@ Returns the compilation buffer created." ;; Without async subprocesses, the buffer is not yet ;; fontified, so fontify it now. (let ((font-lock-verbose nil)) ; shut up font-lock messages - (font-lock-fontify-buffer)) + (if global-font-lock-mode + (font-lock-fontify-buffer))) (set-buffer-modified-p nil) (message "Executing `%s'...done" command))) ;; Now finally cd to where the shell started make/grep/... -- 1.5.6.5 From monnier@iro.umontreal.ca Sat Jan 31 11:54:30 2009 Received: (at 2134) by emacsbugs.donarmstrong.com; 31 Jan 2009 19:54:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0VJsQ5r005583 for <2134@emacsbugs.donarmstrong.com>; Sat, 31 Jan 2009 11:54:28 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgMFAOs6hEnO+IQk/2dsb2JhbACBbsVrhBQGgmw X-IronPort-AV: E=Sophos;i="4.37,356,1231131600"; d="scan'208";a="33109404" Received: from 206-248-132-36.dsl.teksavvy.com (HELO pastel.home) ([206.248.132.36]) by ironport2-out.teksavvy.com with ESMTP; 31 Jan 2009 14:54:15 -0500 Received: by pastel.home (Postfix, from userid 20848) id 310BE8229; Sat, 31 Jan 2009 14:54:15 -0500 (EST) From: Stefan Monnier To: Jari Aalto Cc: 2134@debbugs.gnu.org Subject: Re: bug#2134: [PATCH] progmodes/compile.el: check global-font-lock-mode Message-ID: References: <87tz7ffyc9.fsf@jondo.cante.net> Date: Sat, 31 Jan 2009 14:54:15 -0500 In-Reply-To: <87tz7ffyc9.fsf@jondo.cante.net> (Jari Aalto's message of "Sat, 31 Jan 2009 14:34:46 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Here is patch to not to turn on font-lock unconditionally. Patch is > against Emacs version control tree check out 2009-01-31. If you read the rest of the compile.el code, you'll see that it uses font-lock to do its job, which is why it's turned on unconditionally. Stefan From jari.aalto@cante.net Sun Feb 1 02:46:33 2009 Received: (at 2134) by emacsbugs.donarmstrong.com; 1 Feb 2009 10:46:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,MURPHY_SEX_L2 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh02.mail.saunalahti.fi (emh02.mail.saunalahti.fi [62.142.5.108]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n11AkSJl030559 for <2134@emacsbugs.donarmstrong.com>; Sun, 1 Feb 2009 02:46:30 -0800 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh02-2.mail.saunalahti.fi (Postfix) with SMTP id 4D692EF208; Sun, 1 Feb 2009 12:46:27 +0200 (EET) Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A01A8B1BC76; Sun, 01 Feb 2009 12:46:27 +0200 Received: from jondo.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh03.mail.saunalahti.fi (Postfix) with ESMTP id 24172158A83; Sun, 1 Feb 2009 12:46:23 +0200 (EET) From: Jari Aalto To: Stefan Monnier Cc: 2134@debbugs.gnu.org Subject: Re: bug#2134: [PATCH] progmodes/compile.el: check global-font-lock-mode References: <87tz7ffyc9.fsf@jondo.cante.net> Date: Sun, 01 Feb 2009 12:46:22 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 31 Jan 2009 14:54:15 -0500") Message-ID: <87zlh68mf5.fsf@jondo.cante.net> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Antivirus: VAMS Stefan Monnier writes: >> Here is patch to not to turn on font-lock unconditionally. Patch is >> against Emacs version control tree check out 2009-01-31. > > If you read the rest of the compile.el code, you'll see that it uses > font-lock to do its job, which is why it's turned on unconditionally. > The buffer handling could be improved to work without font lock. In some cases the colors distract reading; thus font-lock is turned offm, but RET no longer intreprets the line. SUGGESTION There could be be alternative handler to read the current line and respond to RET (etc.) when font-lock is turned off. I'm supposing here that standard grep syntax would be easy to handle: default-directory: DIR FILE:LINE:MATCH Jari From rms@gnu.org Sun Feb 1 14:50:55 2009 Received: (at 2134) by emacsbugs.donarmstrong.com; 1 Feb 2009 22:50:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n11Moqr4018340 for <2134@emacsbugs.donarmstrong.com>; Sun, 1 Feb 2009 14:50:53 -0800 Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LTl7j-0005DN-6O; Sun, 01 Feb 2009 17:49:07 -0500 Content-Type: text/plain; charset=ISO-8859-15 From: Richard M Stallman To: Stefan Monnier , 2134@debbugs.gnu.org CC: jari.aalto@cante.net, 2134@debbugs.gnu.org In-reply-to: (message from Stefan Monnier on Sat, 31 Jan 2009 14:54:15 -0500) Subject: Re: bug#2134: [PATCH] progmodes/compile.el: check global-font-lock-mode Reply-to: rms@gnu.org References: Message-Id: Date: Sun, 01 Feb 2009 17:49:07 -0500 If you read the rest of the compile.el code, you'll see that it uses font-lock to do its job, which is why it's turned on unconditionally. What's happening here is not clean. Yes, compile.el needs to force the Font Lock mechanism to work, all the time; but it should not show the faces on the screen if the user disables Font Lock mode. What this calls for is something like font-lock-syntactic-keywords. Or a switch in Font Lock to say, "Unconditionally activate the Font Lock mechanism, independent of whether Font Lock mode is enabled, but store the faces in the `font-lock-face' property." With that, the mechanism will always find the errors, but the user can control whether to display the highlighting. From rgm@gnu.org Sun Feb 1 23:11:53 2009 Received: (at control) by emacsbugs.donarmstrong.com; 2 Feb 2009 07:11:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.0 required=4.0 tests=MURPHY_DRUGS_REL8, VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n127Bpnq013959 for ; Sun, 1 Feb 2009 23:11:52 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LTswV-0000VE-Ll; Mon, 02 Feb 2009 02:10:03 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18822.40011.133086.730105@fencepost.gnu.org> Date: Mon, 2 Feb 2009 02:10:03 -0500 From: Glenn Morris To: control Subject: control message X-Debbugs-No-Ack: yes reassign 2139 spam reassign 2142 spam reassign 2143 spam reassign 2141 emacs,cc-mode reassign 2135 emacs,rmail reassign 2137 emacs,rmail reassign 2150 emacs,rmail severity 2145 wishlist tags 2134 - patch merge 801 2134 From monnier@iro.umontreal.ca Mon Feb 2 09:08:58 2009 Received: (at 2134) by emacsbugs.donarmstrong.com; 2 Feb 2009 17:08:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12H8qW3002048 for <2134@emacsbugs.donarmstrong.com>; Mon, 2 Feb 2009 09:08:53 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AswEAD+3hknO+IQk/2dsb2JhbACBbsozhBQGgmw X-IronPort-AV: E=Sophos;i="4.37,366,1231131600"; d="scan'208";a="33208361" Received: from 206-248-132-36.dsl.teksavvy.com (HELO ceviche.home) ([206.248.132.36]) by ironport2-out.teksavvy.com with ESMTP; 02 Feb 2009 12:08:46 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 4F103B406D; Sun, 1 Feb 2009 17:54:47 -0500 (EST) From: Stefan Monnier To: Jari Aalto Cc: 2134@debbugs.gnu.org Subject: Re: bug#2134: [PATCH] progmodes/compile.el: check global-font-lock-mode Message-ID: References: <87tz7ffyc9.fsf@jondo.cante.net> <87zlh68mf5.fsf@jondo.cante.net> Date: Sun, 01 Feb 2009 17:54:47 -0500 In-Reply-To: <87zlh68mf5.fsf@jondo.cante.net> (Jari Aalto's message of "Sun, 01 Feb 2009 12:46:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >>> Here is patch to not to turn on font-lock unconditionally. Patch is >>> against Emacs version control tree check out 2009-01-31. >> >> If you read the rest of the compile.el code, you'll see that it uses >> font-lock to do its job, which is why it's turned on unconditionally. > The buffer handling could be improved to work without font lock. In some Yes, we indeed want that. Patches welcome. The way it could work (most likely) is by not hooking directly into font-lock but using after-change-functions instead (and then probably call font-lock-fontify-region (or somesuch function) from it), and only set the `font-lock-face' property rather than `face'. Another way to do that, would be to change font-lock-mode to allow "invisible" activation such that `font-lock-face' is not remapped to `face' and such that font-lock keywords end up adding entries to `font-lock-face' rather than to `face', so that the user can later on turn on font-lock-mode (in normal mode) at which point all the faces would be activated. That would be better. Stefan From rgm@gnu.org Tue Feb 3 19:44:48 2009 Received: (at control) by emacsbugs.donarmstrong.com; 4 Feb 2009 03:44:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n143ij0p005096 for ; Tue, 3 Feb 2009 19:44:46 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LUYfB-0005ye-MS; Tue, 03 Feb 2009 22:42:57 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18825.3777.585548.191552@fencepost.gnu.org> Date: Tue, 3 Feb 2009 22:42:57 -0500 From: Glenn Morris To: control Subject: control message merge 2156 2161 reassign 2184 emacs,ns forcemerge 801 2134 severity 2031 minor severity 2159 minor From jari.aalto@cante.net Sun Sep 13 07:22:10 2009 Received: (at control) by emacsbugs.donarmstrong.com; 13 Sep 2009 14:22:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.7 required=4.0 tests=AWL,MURPHY_DRUGS_REL8, VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh07.mail.saunalahti.fi (emh07.mail.saunalahti.fi [62.142.5.117]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8DEM8n4029400 for ; Sun, 13 Sep 2009 07:22:10 -0700 Received: from saunalahti-vams (vs3-10.mail.saunalahti.fi [62.142.5.94]) by emh07-2.mail.saunalahti.fi (Postfix) with SMTP id A7AA818D131 for ; Sun, 13 Sep 2009 17:22:07 +0300 (EEST) Received: from emh06.mail.saunalahti.fi ([62.142.5.116]) by vs3-10.mail.saunalahti.fi ([62.142.5.94]) with SMTP (gateway) id A06880A3BEB; Sun, 13 Sep 2009 17:22:07 +0300 Received: from jondo.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh06.mail.saunalahti.fi (Postfix) with ESMTP id 891C7E51A2 for ; Sun, 13 Sep 2009 17:22:06 +0300 (EEST) To: control@debbugs.gnu.org Subject: Bug#2134 change of tags / patch Mail-Copies-To: poster X-Bug-User-Agent: Emacs 23.1.1 and tinydebian.el 2009.0812.1741 From: Jari Aalto Date: Sun, 13 Sep 2009 17:22:06 +0300 Message-ID: <87ljkincvl.fsf@jondo.cante.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Antivirus: VAMS tags 2134 + patch thanks From rgm@gnu.org Wed Nov 4 14:01:42 2009 Received: (at control) by emacsbugs.donarmstrong.com; 4 Nov 2009 22:01:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA4M1e7A002782 for ; Wed, 4 Nov 2009 14:01:42 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1N5nv9-0000E4-Ub; Wed, 04 Nov 2009 17:01:39 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19185.63939.653937.427902@fencepost.gnu.org> Date: Wed, 4 Nov 2009 17:01:39 -0500 From: Glenn Morris To: control Subject: control severity 3631 minor severity 3267 minor reassign 3267 emacsbugs.donarmstrong.com severity 3481 minor severity 3644 minor severity 3722 wishlist severity 4360 minor tags 3613 wontfix tags 2134 = severity 4731 minor severity 3849 wishlist close 3564 merge 4668 3227 tags 2792 wontfix minor severity 4433 minor severity 4668 minor severity 4562 minor severity 3934 minor severity 3856 minor severity 3801 minor severity 3615 minor severity 3599 minor severity 3598 minor severity 3575 minor severity 3566 minor severity 3550 minor severity 3549 minor severity 3527 minor severity 3525 minor severity 3524 minor severity 3523 minor severity 3519 minor severity 3509 minor severity 3503 minor severity 3393 minor severity 3371 minor severity 3320 minor severity 3313 minor severity 3249 minor severity 3227 minor severity 3138 minor severity 3135 minor severity 3137 minor severity 3052 minor severity 3042 minor severity 2974 minor severity 2946 minor severity 2792 minor severity 1749 minor severity 1375 minor severity 1144 minor From unknown Wed Aug 20 03:11:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Feb 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator