<= p dir=3D"auto">Hi Anders,

I have tried reproducing this discrepancy using my patch = from #21330
on top of branch emacs-25.

Swedish layout, ns-alternate-modifier set to nil, LCmd-LA= lt-9 replies
"s-]".

Maybe you could check again as well?

Best regards,
Mikhail.

On 2 Jan 2016, at 9:08, Anders Lindgren wrote:

I found a case where the code in question is needed, which= none of the suggested patches handle correctly.

Steps= to repeat:

=C2=A0 =C2=A0=C2=A0(setq ns-alternat= e-modifier nil)

=C2=A0 =C2=A0 Press left CMD-ALT= -9

=C2=A0 =C2=A0 An unmodified Emacs replies &qu= ot;s-]" is not bound. (This assumes a Swedish keyboard layout, other= layouts would yield a different character, but the principle is the same= ).

=C2=A0 =C2=A0 With either of the two patches,= Emacs respond with "s-9" is not bound, which isn't correct= =2E

Unfortunately, I don't know how to disti= nguish between the cases where we need to strip away modifiers (C-s-a) an= d when we shouldn't, so I'm leaving this open for now.
=
=C2=A0 =C2=A0 -- Anders Lindgren

On Wed, Dec 30= , 2015 at 9:50 AM, Anders Lindgren <andlind@gmail.com> w= rote:
Hi,

I'm looking into a key binding bug on OS X reported multiple= times (19977, 21330, 21551). Two different patches have been submitted.<= /div>

The original code looks like:

=C2=A0 =C2=A0 =C2=A0 if (is_left_key)
=C2=A0 =C2=A0= =C2=A0 =C2=A0 {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 emacs_event= ->modifiers |=3D parse_solitary_modifier
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 (ns_command_modifier);

=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* if super (default), take input manager= 's word so things like
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0dvorak / qwerty layout work */
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 if (EQ (ns_command_modifier, Qsuper)
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 && !fnKeysym
=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 && [[theEvent characte= rs] length] !=3D 0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* XXX: the c= ode we get will be unshifted, so if we have
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0a shift modifier, must convert = ourselves */
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 i= f (!(flags & NSShiftKeyMask))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 code =3D [[theEvent characters] characterAtIndex= : 0];

One of the patches simply removes th= e `if (EQ(...))' statement. The other modifies the code to strip away= modifiers.

First question: What is the code in = the `if (EQ(...))' supposed to do? In other words, what will stop wor= king if it is removed?

Second question: if i= t is needed for the LEFT command key, should the corresponding code be ad= ded for the RIGHT?

I've tested removing the = `if' and Emacs still seems to be working as intended, both with a nor= mal key layout and when Dvorak is used. If no one comes up with a reason = to keep the code, I will remove it.

Third questi= on: Does anybody know of a good way to automatically test things like thi= s? What I'm looking for is a way to send keystrokes like Cmd-Alt-a to= Emacs, that way it could be possible to write tests ensuring that things= like this don't break in the future.

=C2=A0 =C2=A0 -- Anders Lindgren=