From unknown Fri Aug 15 15:30:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#21329 <21329@debbugs.gnu.org> To: bug#21329 <21329@debbugs.gnu.org> Subject: Status: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Reply-To: bug#21329 <21329@debbugs.gnu.org> Date: Fri, 15 Aug 2025 22:30:51 +0000 retitle 21329 25.0.50; Flyspell minor mode produces weird effects on keyboa= rd macros reassign 21329 emacs submitter 21329 Mark Karpov severity 21329 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 23 08:03:29 2015 Received: (at submit) by debbugs.gnu.org; 23 Aug 2015 12:03:29 +0000 Received: from localhost ([127.0.0.1]:35628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTTzl-0006kP-29 for submit@debbugs.gnu.org; Sun, 23 Aug 2015 08:03:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40059) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTTzj-0006kE-4T for submit@debbugs.gnu.org; Sun, 23 Aug 2015 08:03:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTTzh-0003Ke-DS for submit@debbugs.gnu.org; Sun, 23 Aug 2015 08:03:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTTzh-0003KZ-AF for submit@debbugs.gnu.org; Sun, 23 Aug 2015 08:03:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTTzf-0005pD-Jd for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 08:03:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTTzb-0003Hj-As for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 08:03:23 -0400 Received: from smtp11.openmailbox.org ([62.4.1.45]:36789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTTzb-0003Gi-02 for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2015 08:03:19 -0400 Received: by mail2.openmailbox.org (Postfix, from userid 1004) id EBEE02AC172A; Sun, 23 Aug 2015 14:03:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1440331396; bh=NZekckMo5VI2EMTN4OhGkAINmTucRCIVSEbYswWkGG8=; h=From:To:Subject:Date:From; b=a5bM+6RSnrfXFrf+xz8+BDFn028g4VeYzrzsRZR4Vmp673VuQpoyDVKJ8MEFFGf0W x09pJxrzZnNJ6wBs9/hHCmRLBplKXkOVMymbsb19fzifwsaUFbLUmuJ7KsSrs7mlkG GJQ6KfOOCDv3kDPSXJ9yKmoT9+TzOVZ2VbZrxtMc= From: Mark Karpov DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1440331384; bh=NZekckMo5VI2EMTN4OhGkAINmTucRCIVSEbYswWkGG8=; h=From:To:Subject:Date:From; b=LUdTLTsiVy5qjymfUnNZGRSkGIHIloc1Y1rn7aDntfrsKV7izaBrWNROOIYcrcnCB /DtE+qXaCGmplNvU3ROEMmFKoheICwQFipFoih1rI4pvYtg8EjzLGtpAv6Q48Gg5+B neAdtbyjQ2Z+GWTCA1LCrTEkoBMmfaatyXuZUwkg= To: bug-gnu-emacs@gnu.org Subject: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Date: Sun, 23 Aug 2015 17:57:44 +0600 Message-ID: <877fom5i9z.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) =E2=9D=A7 This is really strange. Here is how to reproduce it in development version of Emacs: 1. Start Emacs with =E2=80=98-Q=E2=80=99 flag. 2. Enable =E2=80=98flyspell-mode=E2=80=99 (M-x flyspell-mode RET). 3. Start recording keyboard macro with F3. 4. Type (pick one of these, they all produce different effects): * abc * prop_ 5. Finish recording of the keyboard macro with F4. 6. Hit F4 again to run the macro. If you chose =E2=80=9Cabc=E2=80=9D, you will get: abcabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccab= bccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccab= bccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccab= bccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccab= bccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccab= bccabbccabbccabbccabbcca And in =E2=80=98*Messages*=E2=80=99: For information about GNU Emacs and the GNU system, type C-h C-a. completing-read-default: Command attempted to use minibuffer while in minib= uffer Quit Starting new Ispell process /usr/bin/aspell with default dictionary... Defining kbd macro... Keyboard macro defined After 0 kbd macro iterations: run-hook-with-args: Variable binding depth ex= ceeds max-specpdl-size If you rather preferred =E2=80=9Cprop_=E2=80=9D: prop_prroopp__ Well. Some letters (all expect for the first one) are duplicated=E2=80=A6 In GNU Emacs 25.0.50.18 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6) of 2015-08-19 on arch Repository revision: 62661fe759dfc826f31b032e49f0f15b40a207d5 Windowing system distributor `The X.Org Foundation', version 11.0.11702000 Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: i=CE=B5 Minor modes in effect: rainbow-delimiters-mode: t hl-todo-mode: t flycheck-mode: t flyspell-mode: t whitespace-mode: t yas-global-mode: t yas-minor-mode: t show-paren-mode: t minibuffer-electric-default-mode: t ido-vertical-mode: t ido-ubiquitous-mode: t ido-everywhere: t highlight-line-mode: t global-auto-revert-mode: t global-aggressive-indent-mode: t aggressive-indent-mode: t display-time-mode: t delete-selection-mode: t ace-popup-menu-mode: t smartparens-global-mode: t smartparens-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t auto-fill-mode: 1 Recent messages: ad-handle-definition: `ido-completing-read' got redefined [yas] Loading compiled snippets from /home/mark/.emacs.d/elpa/common-lisp-s= nippets-20150603.944/snippets/lisp-mode [2 times] [yas] Prepared just-in-time loading for /home/mark/.emacs.d/snippets [yas] Prepared just-in-time loading for /home/mark/.emacs.d/elpa/common-lis= p-snippets-20150603.944/snippets [yas] Reloaded everything (snippets will load just-in-time).... Starting new Ispell process /usr/bin/aspell with en dictionary... [yas] Loading for `emacs-lisp-mode', just-in-time: (lambda nil (yas--load-d= irectory-1 (quote /home/mark/.emacs.d/snippets/emacs-lisp-mode) (quote emac= s-lisp-mode)))! [yas] Loading compiled snippets from /home/mark/.emacs.d/snippets/emacs-lis= p-mode Sunday, 23 August 2015 Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils rainbow-delimiters hl-todo flycheck-haskell haskell-cabal haskell-utils haskell-customize flycheck find-func rx flyspell ispell whitespace mk-visual solarized-dark-theme solarized mk-texinfo mk-tex mk-python mk-prolog mk-org mk-markdown mk-man mk-magit mk-lisp mk-ibuffer mk-haskell mk-gnus mk-eshell mk-erc mk-elisp mk-dired mk-diff mk-clojure kill-or-bury-alive mk-calendar mk-c mk-bookmark mk-minor-modes common-lisp-snippets yasnippet cl whole-line-or-region paren minibuf-eldef ido-vertical-mode ido-ubiquitous ido-completing-read+ cl-macs gv ido highlight-line autorevert filenotify cl-seq aggressive-indent easy-mmode time delsel ace-popup-menu smartparens-config smartparens byte-opt thingatpt mk-global edmacro kmacro ace-link avy ring misc server mk-utils subr-x f dash s ucs-normalize finder-inf tex-site fix-word advice slime-autoloads info bytecomp byte-compile cl-extra help-mode seq cl-loaddefs pcase cl-lib cconv package easymenu epg-config time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 350582 106916) (symbols 48 31571 7) (miscs 40 66 212) (strings 32 54146 56214) (string-bytes 1 1538038) (vectors 16 45028) (vector-slots 8 781772 45990) (floats 8 283 405) (intervals 56 248 35) (buffers 976 12) (heap 1024 60596 4785)) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 24 10:39:24 2015 Received: (at 21329) by debbugs.gnu.org; 24 Aug 2015 14:39:24 +0000 Received: from localhost ([127.0.0.1]:37058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTsuC-0008FW-1Y for submit@debbugs.gnu.org; Mon, 24 Aug 2015 10:39:24 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:59384) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTsuA-0008FO-21 for 21329@debbugs.gnu.org; Mon, 24 Aug 2015 10:39:23 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NTL00L00BYXWB00@mtaout24.012.net.il> for 21329@debbugs.gnu.org; Mon, 24 Aug 2015 17:31:23 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTL00GMICCBP670@mtaout24.012.net.il>; Mon, 24 Aug 2015 17:31:23 +0300 (IDT) Date: Mon, 24 Aug 2015 17:39:09 +0300 From: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros In-reply-to: <877fom5i9z.fsf@openmailbox.org> X-012-Sender: halo1@inter.net.il To: Mark Karpov Message-id: <83io84hhte.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <877fom5i9z.fsf@openmailbox.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21329 Cc: 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Mark Karpov > Date: Sun, 23 Aug 2015 17:57:44 +0600 > > This is really strange. Here is how to reproduce it in development > version of Emacs: > > 1. Start Emacs with ‘-Q’ flag. > > 2. Enable ‘flyspell-mode’ (M-x flyspell-mode RET). > > 3. Start recording keyboard macro with F3. > > 4. Type (pick one of these, they all produce different effects): > > * abc > * prop_ > > 5. Finish recording of the keyboard macro with F4. > > 6. Hit F4 again to run the macro. > > If you chose “abc”, you will get: > > abcabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbccabbcca > > And in ‘*Messages*’: > > For information about GNU Emacs and the GNU system, type C-h C-a. > completing-read-default: Command attempted to use minibuffer while in minibuffer > Quit This is a very old problem, I see it in Emacs 22. Here's a simple recipe to demonstrate what happens: emacs -Q Evaluate in *scratch*: (defun my-hook () "" (sit-for 1)) (add-hook 'post-command-hook 'my-hook t t) Now type "F3 abc F4 F4", and you will get the same problem as in the original report. Type "C-x C-k n foo RET" followed by "M-x insert-kbd-macro RET", and you will see that the macro is defined as a vector that includes F4 at its end, which is the cause of the unexpected recursive invocation of the macro by F4. The problem is that 'sit-for' calls 'read-event', and then "undoes" that by pushing the events it read onto unread-command-events. This evidently messes up keyboard macro recording. (It also runs afoul of the recent changes in keyboard.c related to recording events, which causes the characters to be duplicated in the macro.) The following band-aid fixes the problem, but I will wait for The Powers That Be to comment on this before pushing. Or maybe we should introduce an "unrecord-key" facility for use by code such as we have in sit-for? --- lisp/subr.el~ 2015-08-05 12:26:16.000000000 +0300 +++ lisp/subr.el 2015-08-24 13:53:09.858014100 +0300 @@ -2276,7 +2276,8 @@ t) ((input-pending-p t) nil) - ((<= seconds 0) + ((or (<= seconds 0) + defining-kbd-macro) (or nodisp (redisplay))) (t (or nodisp (redisplay)) From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 09:16:01 2015 Received: (at 21329) by debbugs.gnu.org; 25 Aug 2015 13:16:01 +0000 Received: from localhost ([127.0.0.1]:37673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUE53-0002Zz-13 for submit@debbugs.gnu.org; Tue, 25 Aug 2015 09:16:01 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:27865) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUE51-0002Zr-6e for 21329@debbugs.gnu.org; Tue, 25 Aug 2015 09:15:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A6FgA731xV/5P+d0tcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kiDcIzyMBAQEBAQEEAQEBAR6LOoUFB4QtBZ8XhmmNP4FFI4I7gVkigngBAQE X-IPAS-Result: A0A6FgA731xV/5P+d0tcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kiDcIzyMBAQEBAQEEAQEBAR6LOoUFB4QtBZ8XhmmNP4FFI4I7gVkigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161297086" Received: from 75-119-254-147.dsl.teksavvy.com (HELO ceviche.home) ([75.119.254.147]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Aug 2015 09:15:58 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 72C846610C; Tue, 25 Aug 2015 09:15:58 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Message-ID: References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> Date: Tue, 25 Aug 2015 09:15:58 -0400 In-Reply-To: <83io84hhte.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Aug 2015 17:39:09 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21329 Cc: Mark Karpov , 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The problem is that 'sit-for' calls 'read-event', and then "undoes" > that by pushing the events it read onto unread-command-events. Indeed, that's a problem. The right fix would be to change the code so as not to consume any event in the first place. > Or maybe we should introduce an "unrecord-key" facility for use by > code such as we have in sit-for? We could try, but I don't believe we can provide an "unrecord-key" that's actually reliable. AFAIK the act of taking an event out of the queue has too many effects to have a hope of properly reverting them all. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 11:27:06 2015 Received: (at 21329) by debbugs.gnu.org; 25 Aug 2015 15:27:06 +0000 Received: from localhost ([127.0.0.1]:38178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUG7u-0005dz-CK for submit@debbugs.gnu.org; Tue, 25 Aug 2015 11:27:06 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:35236) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUG7s-0005dr-G2 for 21329@debbugs.gnu.org; Tue, 25 Aug 2015 11:27:05 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NTN005009F5N200@mtaout25.012.net.il> for 21329@debbugs.gnu.org; Tue, 25 Aug 2015 18:23:34 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTN002TN9FAR020@mtaout25.012.net.il>; Tue, 25 Aug 2015 18:23:34 +0300 (IDT) Date: Tue, 25 Aug 2015 18:26:53 +0300 From: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83k2sjfkxu.fsf@gnu.org> References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21329 Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: Mark Karpov , 21329@debbugs.gnu.org > Date: Tue, 25 Aug 2015 09:15:58 -0400 > > > The problem is that 'sit-for' calls 'read-event', and then "undoes" > > that by pushing the events it read onto unread-command-events. > > Indeed, that's a problem. The right fix would be to change the code so > as not to consume any event in the first place. Any more specific advice? I'm afraid I'm otherwise not up to the job. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 12:31:24 2015 Received: (at 21329) by debbugs.gnu.org; 25 Aug 2015 16:31:24 +0000 Received: from localhost ([127.0.0.1]:38219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUH87-0007Kf-Rv for submit@debbugs.gnu.org; Tue, 25 Aug 2015 12:31:24 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:41426) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUH84-0007KV-OL for 21329@debbugs.gnu.org; Tue, 25 Aug 2015 12:31:22 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NTN00G00CI7O000@a-mtaout23.012.net.il> for 21329@debbugs.gnu.org; Tue, 25 Aug 2015 19:31:19 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTN00GLSCK6KY50@a-mtaout23.012.net.il>; Tue, 25 Aug 2015 19:31:18 +0300 (IDT) Date: Tue, 25 Aug 2015 19:31:08 +0300 From: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros In-reply-to: <83k2sjfkxu.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: monnier@iro.umontreal.ca Message-id: <83io83fhyr.fsf@gnu.org> References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21329 Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 25 Aug 2015 18:26:53 +0300 > From: Eli Zaretskii > Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org > > > The right fix would be to change the code so as not to consume any > > event in the first place. > > Any more specific advice? I'm afraid I'm otherwise not up to the job. Would it work to loop until input-pending-p returns non-nil? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 18:23:44 2015 Received: (at 21329) by debbugs.gnu.org; 25 Aug 2015 22:23:44 +0000 Received: from localhost ([127.0.0.1]:38349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUMd6-0007BV-5o for submit@debbugs.gnu.org; Tue, 25 Aug 2015 18:23:44 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:32870) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUMd5-0007BN-3o for 21329@debbugs.gnu.org; Tue, 25 Aug 2015 18:23:43 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A2FgA731xV/5P+d0tcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEBAQQBAQEBHos6hQUHhC0FnxeGaY0/gUUjgjuBWSKCeAEBAQ X-IPAS-Result: A0A2FgA731xV/5P+d0tcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEBAQQBAQEBHos6hQUHhC0FnxeGaY0/gUUjgjuBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161374333" Received: from 75-119-254-147.dsl.teksavvy.com (HELO ceviche.home) ([75.119.254.147]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Aug 2015 18:23:42 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 5CF1D6620D; Tue, 25 Aug 2015 18:23:42 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Message-ID: References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> <83io83fhyr.fsf@gnu.org> Date: Tue, 25 Aug 2015 18:23:42 -0400 In-Reply-To: <83io83fhyr.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Aug 2015 19:31:08 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21329 Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Would it work to loop until input-pending-p returns non-nil? Maybe that can be made to work, but it's likely to introduce other problems. I was thinking more about refactoring read-event so as to provide a new `wait-for-event` which stops just before we actually consume the event. Of course, since I'm sure you've already seen some part of read-event, you're probably already (and sanely) running away screaming, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 22:44:49 2015 Received: (at 21329) by debbugs.gnu.org; 26 Aug 2015 02:44:49 +0000 Received: from localhost ([127.0.0.1]:38472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUQhl-0004t0-9K for submit@debbugs.gnu.org; Tue, 25 Aug 2015 22:44:49 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:58455) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUQhj-0004sr-3f for 21329@debbugs.gnu.org; Tue, 25 Aug 2015 22:44:48 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NTO00B003O3O500@mtaout24.012.net.il> for 21329@debbugs.gnu.org; Wed, 26 Aug 2015 05:36:50 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTO0068U4LD7T90@mtaout24.012.net.il>; Wed, 26 Aug 2015 05:36:50 +0300 (IDT) Date: Wed, 26 Aug 2015 05:44:36 +0300 From: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83d1yag44r.fsf@gnu.org> References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> <83io83fhyr.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21329 Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org > Date: Tue, 25 Aug 2015 18:23:42 -0400 > > > Would it work to loop until input-pending-p returns non-nil? > > Maybe that can be made to work, but it's likely to introduce > other problems. Which ones, for example? > I was thinking more about refactoring read-event so as to provide a new > `wait-for-event` which stops just before we actually consume the event. How will it be different from what input-pending-p already does? > Of course, since I'm sure you've already seen some part of read-event, > you're probably already (and sanely) running away screaming, Yep. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 21:33:22 2015 Received: (at 21329) by debbugs.gnu.org; 28 Aug 2015 01:33:22 +0000 Received: from localhost ([127.0.0.1]:40671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV8Xh-0006Vh-M4 for submit@debbugs.gnu.org; Thu, 27 Aug 2015 21:33:21 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:50801) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZV8Xe-0006VX-2Y for 21329@debbugs.gnu.org; Thu, 27 Aug 2015 21:33:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A5FgA731xV/5P+d0tcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjEAs0EhQYDSSINwjPIwEBAQEBBQEBAQEeizqFBQeELQEEnxeGaYsrghSBRSOBZlWBWSKCeAEBAQ X-IPAS-Result: A0A5FgA731xV/5P+d0tcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjEAs0EhQYDSSINwjPIwEBAQEBBQEBAQEeizqFBQeELQEEnxeGaYsrghSBRSOBZlWBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161634205" Received: from 75-119-254-147.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([75.119.254.147]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Aug 2015 21:33:16 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 921EDAE0D6; Thu, 27 Aug 2015 21:33:16 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Message-ID: References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> <83io83fhyr.fsf@gnu.org> <83d1yag44r.fsf@gnu.org> Date: Thu, 27 Aug 2015 21:33:16 -0400 In-Reply-To: <83d1yag44r.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Aug 2015 05:44:36 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21329 Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> > Would it work to loop until input-pending-p returns non-nil? >> Maybe that can be made to work, but it's likely to introduce >> other problems. > Which ones, for example? Not sure. I just know that we've already tried various different alternatives for this code. All the problems have been "corner cases", IIRC, and many of them were nasty enough to make us rewrite the function completely. One possible problem is that input-pending-p might return t in cases where the pending input is "not significant", in the sense that read-event won't return it (maybe because it will consume it internally as in the case of event bounds to special-event-map, IIRC). >> I was thinking more about refactoring read-event so as to provide a new >> `wait-for-event` which stops just before we actually consume the event. > How will it be different from what input-pending-p already does? It will be different in that it will wait until an event arrives. But yes, maybe the implementation of the two can be shared. Stefan PS: I suggest you try and install your suggested patch, in the mean time. I don't understand enough of its impact to judge its quality, but it's worth a try. Just make sure you add a good comment in the code explaining the problem this is trying to fix. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 28 09:28:38 2015 Received: (at 21329-done) by debbugs.gnu.org; 28 Aug 2015 13:28:38 +0000 Received: from localhost ([127.0.0.1]:40901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVJht-0000t0-JY for submit@debbugs.gnu.org; Fri, 28 Aug 2015 09:28:37 -0400 Received: from mtaout29.012.net.il ([80.179.55.185]:52453) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVJhp-0000so-Ud for 21329-done@debbugs.gnu.org; Fri, 28 Aug 2015 09:28:34 -0400 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NTS00100NYKBH00@mtaout29.012.net.il> for 21329-done@debbugs.gnu.org; Fri, 28 Aug 2015 16:28:44 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTS00NO6O3UJI20@mtaout29.012.net.il>; Fri, 28 Aug 2015 16:28:42 +0300 (IDT) Date: Fri, 28 Aug 2015 16:28:33 +0300 From: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83613z4k5a.fsf@gnu.org> References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> <83io83fhyr.fsf@gnu.org> <83d1yag44r.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21329-done Cc: markkarpov@openmailbox.org, 21329-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org > Date: Thu, 27 Aug 2015 21:33:16 -0400 > > One possible problem is that input-pending-p might return t in cases where > the pending input is "not significant", in the sense that read-event > won't return it (maybe because it will consume it internally as in the > case of event bounds to special-event-map, IIRC). I thought about ignoring out these kinds of input in the loop that waits. > PS: I suggest you try and install your suggested patch, in the > mean time. I don't understand enough of its impact to judge its > quality, but it's worth a try. Just make sure you add a good comment in > the code explaining the problem this is trying to fix. Done. I'm therefore closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 11:31:38 2015 Received: (at 21329-done) by debbugs.gnu.org; 29 Aug 2015 15:31:38 +0000 Received: from localhost ([127.0.0.1]:42225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVi6U-0002Yf-Ct for submit@debbugs.gnu.org; Sat, 29 Aug 2015 11:31:38 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:30799) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVi6S-0002YX-3x for 21329-done@debbugs.gnu.org; Sat, 29 Aug 2015 11:31:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A1FgA731xV/8Fw3mhcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBViMQCzQSFBgNJIg3CM8jAQEBAQEBBAEBAQEeizqFBQeELQWfF4ZpiyuDWSOBZlWBWSKCeAEBAQ X-IPAS-Result: A0A1FgA731xV/8Fw3mhcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBViMQCzQSFBgNJIg3CM8jAQEBAQEBBAEBAQEeizqFBQeELQWfF4ZpiyuDWSOBZlWBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161793634" Received: from 104-222-112-193.cpe.teksavvy.com (HELO ceviche.home) ([104.222.112.193]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Aug 2015 11:31:35 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 4AC596615C; Sat, 29 Aug 2015 11:31:35 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Message-ID: References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> <83io83fhyr.fsf@gnu.org> <83d1yag44r.fsf@gnu.org> <83613z4k5a.fsf@gnu.org> Date: Sat, 29 Aug 2015 11:31:35 -0400 In-Reply-To: <83613z4k5a.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Aug 2015 16:28:33 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21329-done Cc: markkarpov@openmailbox.org, 21329-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> One possible problem is that input-pending-p might return t in cases where >> the pending input is "not significant", in the sense that read-event >> won't return it (maybe because it will consume it internally as in the >> case of event bounds to special-event-map, IIRC). > I thought about ignoring out these kinds of input in the loop that > waits. Then you have another side-effect, which is to delay the processing of those events. So instead of ignoring them it should process them. That's why I think we'd want to "simply" extract all that read-event does upto (not not including) the actual consumption (and return) of the event. >> PS: I suggest you try and install your suggested patch, in the >> mean time. I don't understand enough of its impact to judge its >> quality, but it's worth a try. Just make sure you add a good comment in >> the code explaining the problem this is trying to fix. > Done. > I'm therefore closing this bug. Thanks, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 12:22:04 2015 Received: (at 21329) by debbugs.gnu.org; 29 Aug 2015 16:22:04 +0000 Received: from localhost ([127.0.0.1]:42239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVitI-0003iR-7f for submit@debbugs.gnu.org; Sat, 29 Aug 2015 12:22:04 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:57748) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVitF-0003i1-Pj for 21329@debbugs.gnu.org; Sat, 29 Aug 2015 12:22:03 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NTU00L00QOSUD00@a-mtaout20.012.net.il> for 21329@debbugs.gnu.org; Sat, 29 Aug 2015 19:22:00 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTU00LP5QSNGIA0@a-mtaout20.012.net.il>; Sat, 29 Aug 2015 19:22:00 +0300 (IDT) Date: Sat, 29 Aug 2015 19:22:05 +0300 From: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <834mji2hg2.fsf@gnu.org> References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> <83io83fhyr.fsf@gnu.org> <83d1yag44r.fsf@gnu.org> <83613z4k5a.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21329 Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: markkarpov@openmailbox.org, 21329-done@debbugs.gnu.org > Date: Sat, 29 Aug 2015 11:31:35 -0400 > > >> One possible problem is that input-pending-p might return t in cases where > >> the pending input is "not significant", in the sense that read-event > >> won't return it (maybe because it will consume it internally as in the > >> case of event bounds to special-event-map, IIRC). > > I thought about ignoring out these kinds of input in the loop that > > waits. > > Then you have another side-effect, which is to delay the processing of > those events. But that's a problem we already have, since read-event doesn't return them, right? Or am I missing something? > So instead of ignoring them it should process them. If that's what read-event does, then yes. > That's why I think we'd want to "simply" extract all that read-event > does upto (not not including) the actual consumption (and return) of > the event. No sure I'm following you: the first thing read-event does is call read_char, so how can we avoid reading events that way? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 22:06:33 2015 Received: (at 21329) by debbugs.gnu.org; 30 Aug 2015 02:06:33 +0000 Received: from localhost ([127.0.0.1]:42375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVs0u-00014h-Na for submit@debbugs.gnu.org; Sat, 29 Aug 2015 22:06:32 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:62274) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVs0r-00014X-Tl for 21329@debbugs.gnu.org; Sat, 29 Aug 2015 22:06:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A1FgA731xV/8Fw3mhcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBViMQCzQSFBgNJIg3CM8jAQEBAQEFAQEBAR6LOoUFB4QtAQSfF4ZpjwQjgWZVgVkigngBAQE X-IPAS-Result: A0A1FgA731xV/8Fw3mhcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBViMQCzQSFBgNJIg3CM8jAQEBAQEFAQEBAR6LOoUFB4QtAQSfF4ZpjwQjgWZVgVkigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161825164" Received: from 104-222-112-193.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.222.112.193]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Aug 2015 22:06:29 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 07331AE0BA; Sat, 29 Aug 2015 22:06:27 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Message-ID: References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> <83io83fhyr.fsf@gnu.org> <83d1yag44r.fsf@gnu.org> <83613z4k5a.fsf@gnu.org> <834mji2hg2.fsf@gnu.org> Date: Sat, 29 Aug 2015 22:06:27 -0400 In-Reply-To: <834mji2hg2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Aug 2015 19:22:05 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21329 Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> >> One possible problem is that input-pending-p might return t in cases where >> >> the pending input is "not significant", in the sense that read-event >> >> won't return it (maybe because it will consume it internally as in the >> >> case of event bounds to special-event-map, IIRC). >> > I thought about ignoring out these kinds of input in the loop that >> > waits. >> Then you have another side-effect, which is to delay the processing of >> those events. > But that's a problem we already have, since read-event doesn't return > them, right? Or am I missing something? AFAI, read-event does process those events bound in special-event-map (and then keeps waiting for further events). >> That's why I think we'd want to "simply" extract all that read-event >> does upto (but not including) the actual consumption (and return) of >> the event. > No sure I'm following you: the first thing read-event does is call > read_char, so how can we avoid reading events that way? Right, we'd need to split read_char (and probably a good deal more). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 22:08:15 2015 Received: (at 21329) by debbugs.gnu.org; 30 Aug 2015 02:08:15 +0000 Received: from localhost ([127.0.0.1]:42379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVs2Z-00017D-8S for submit@debbugs.gnu.org; Sat, 29 Aug 2015 22:08:15 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26717) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZVs2X-000175-9v for 21329@debbugs.gnu.org; Sat, 29 Aug 2015 22:08:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A1FgA731xV/8Fw3mhcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQRWIxALNBIUGA0kiD/PIwEBAQEBAQQBAQEBAR2LOoUFB4QtAQS1BCOCO4FZIoJ4AQEB X-IPAS-Result: A0A1FgA731xV/8Fw3mhcgxCEAoVVu0CEfoJNBAICgTw7EgEBAQEBAQGBCkEFg10BAQRWIxALNBIUGA0kiD/PIwEBAQEBAQQBAQEBAR2LOoUFB4QtAQS1BCOCO4FZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161825237" Received: from 104-222-112-193.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.222.112.193]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Aug 2015 22:08:13 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 87433AE0BA; Sat, 29 Aug 2015 22:08:12 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Message-ID: References: <877fom5i9z.fsf@openmailbox.org> <83io84hhte.fsf@gnu.org> <83k2sjfkxu.fsf@gnu.org> <83io83fhyr.fsf@gnu.org> <83d1yag44r.fsf@gnu.org> <83613z4k5a.fsf@gnu.org> <834mji2hg2.fsf@gnu.org> Date: Sat, 29 Aug 2015 22:08:12 -0400 In-Reply-To: <834mji2hg2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Aug 2015 19:22:05 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21329 Cc: markkarpov@openmailbox.org, 21329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) BTW, another way to fix this bug is to change flyspell so as not to use sit-for like it does (which has other undesirable side-effects such as delaying execution of post-command-hooks and such). Stefan From unknown Fri Aug 15 15:30:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 27 Sep 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator