From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 22 01:38:36 2015 Received: (at submit) by debbugs.gnu.org; 22 Aug 2015 05:38:36 +0000 Received: from localhost ([127.0.0.1]:34943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZT1Vj-0000yt-MU for submit@debbugs.gnu.org; Sat, 22 Aug 2015 01:38:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34867) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZT0Rw-0006Ae-Vr for submit@debbugs.gnu.org; Sat, 22 Aug 2015 00:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZT0Rv-0001Z1-JG for submit@debbugs.gnu.org; Sat, 22 Aug 2015 00:30:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT0Rv-0001Yx-Gc for submit@debbugs.gnu.org; Sat, 22 Aug 2015 00:30:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT0Ru-00077a-EK for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 00:30:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZT0Rr-0001WA-8A for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 00:30:34 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:34250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT0Rr-0001Vp-4B for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 00:30:31 -0400 Received: by igui7 with SMTP id i7so30829400igu.1 for ; Fri, 21 Aug 2015 21:30:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to:content-type; bh=CqD3liGnSDux2ULo4eexBEnpMF0A0RcfvM1lagvzTew=; b=lQIzpjgzhLs6uo231qEeqR1fUpLzgD5Vs4ay4nmlSKM+3Qb5MH3Kf6tWoMOJxH3WC3 G/nPNh1e00SoR4lX+Lvrag76onxKWhfpax80RU+L2SPmOdvPOt17CRz95IFbyocd8aQN rBpd1rn6tws7PXAq0QMZ3Mo+J8ZuvxE9KzDZgE58JQjEWi93aRJMSdo13YbWNE55ev9y JisBEFmtatLjy0rnliuS0g7qm9832S1Yn/iURtTLkC50cf+eVRh86fvkzfcu1bjj54LI aFl0qjnIedribqcZ6Qu7yvSI5lbK7dIaASqVfbcnVNeWtlCMyUtvhQVD6IaH4BxOmIbu rv4A== X-Gm-Message-State: ALoCoQnV0Gcuj8Z3MsqROguJqFdORsY16MDTWgXc7shyn0COzGuxtYcO25RD/DftEGlvQwSsqMTb MIME-Version: 1.0 X-Received: by 10.50.50.174 with SMTP id d14mr6433564igo.84.1440217830108; Fri, 21 Aug 2015 21:30:30 -0700 (PDT) Received: by 10.64.11.232 with HTTP; Fri, 21 Aug 2015 21:30:30 -0700 (PDT) X-Originating-IP: [46.126.219.77] Date: Sat, 22 Aug 2015 06:30:30 +0200 X-Google-Sender-Auth: rIbyfnLYZNKx6-AHSoUTjZFTH88 Message-ID: Subject: `package-install-file' fails with CRLF (Windows) line endings From: steckerhalter To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 22 Aug 2015 01:38:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) package.el contains this code: (defun package-install-file (file) "Install a package from a file. The file can either be a tar file or an Emacs Lisp file." (interactive "fPackage file name: ") (with-temp-buffer (insert-file-contents-literally file) (when (string-match "\\.tar\\'" file) (tar-mode)) (package-install-from-buffer))) Since `insert-file-contents-literally' does not do any conversion `package-buffer-info' fails to parse the info if the file is .el and contains CRLF line endings. It then errors out with: Debugger entered--Lisp error: (error "Package lacks a \"Version\" or \"Package-Version\" header") signal(error ("Package lacks a \"Version\" or \"Package-Version\" header")) error("Package lacks a \"Version\" or \"Package-Version\" header") package-buffer-info() This affects all recent Emacs versions (including trunk). What we did now is to replace `insert-file-contents-literally' with `insert-file-contents' dynamically for non-tar files and that seems to work, although I'm not sure if that's a good solution since I don't know if there might be side-effects somewhere that can cause other problems. The other solution I can think of might be to adapt the regexp in `package-buffer-info` so that in can deal with CRLF. cheers, steckerhalter From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 02 08:12:06 2019 Received: (at control) by debbugs.gnu.org; 2 Aug 2019 12:12:06 +0000 Received: from localhost ([127.0.0.1]:55960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htWPk-00025g-Hh for submit@debbugs.gnu.org; Fri, 02 Aug 2019 08:12:06 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htWPi-00025Y-FW for control@debbugs.gnu.org; Fri, 02 Aug 2019 08:12:02 -0400 Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htWPf-0001qn-Ta for control@debbugs.gnu.org; Fri, 02 Aug 2019 14:12:01 +0200 Date: Fri, 02 Aug 2019 14:11:59 +0200 Message-Id: <87tvazrckw.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #21319 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: merge 21319 20309 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 21319 20309 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 21 21:05:21 2019 Received: (at 21319) by debbugs.gnu.org; 22 Oct 2019 01:05:21 +0000 Received: from localhost ([127.0.0.1]:58079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMibv-0002Zf-9h for submit@debbugs.gnu.org; Mon, 21 Oct 2019 21:05:21 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:45119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMibs-0002ZJ-A2; Mon, 21 Oct 2019 21:05:17 -0400 Received: by mail-pl1-f179.google.com with SMTP id y24so3546575plr.12; Mon, 21 Oct 2019 18:05:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=VyMgb0PU+JHT7zhaLPJd+NWsVVtYhUGBRYxXKGsa2tc=; b=eWtAvvTe8zvEEszvo0AckVQjEmFvr8gp9HXRX2WjojNfWuX9LVAGoZw1UYRzkp3bvi Ipd16lxS1USpRgKkdhtFLQMGuA6IO5YujMvmaZefMD6IgsgWQS17qPr8KPu7x/NC97va OiNhWePFPfxp5sJQY4bspCBNvT5VFGyUNKCg3PXgjP0ycwKu1yxmCWuxXs6Qqia/YlbR mLOSZjG+h0V9LPVvqveqTG01xbf749nS2MYEOSBDBk/Afnc8bfOSzqdf0WJlpL7w0egK CIJdtnkhyQ/oMnEDq+UceQe+6IKEeNDm4Zoce7IiNXd78i4zkTKi8SG4kyUSLeRQpRUu Eq0g== X-Gm-Message-State: APjAAAUjlFvOwhEHIf3dOxRUjkQH7+UPA/eVWuPS61oV0XY833hPCXnf Yi9ytC4s+04TDOG3S4JVgjr1G8HiQXHRdbitmp8= X-Google-Smtp-Source: APXvYqyPtXVnZM0Pxx8B5BKpxNa3mTMRWU/yFgKBkTtwmC0ml7bWXN2XjeCMIdgAeUFBPBebTyFc6/ofZ08ClwLRwo8= X-Received: by 2002:a17:902:a98c:: with SMTP id bh12mr920782plb.128.1571706310503; Mon, 21 Oct 2019 18:05:10 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 22 Oct 2019 03:04:59 +0200 Message-ID: Subject: Re: bug#21319: `package-install-file' fails with CRLF (Windows) line endings To: steckerhalter Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 21319 Cc: 20309@debbugs.gnu.org, 21319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) steckerhalter writes: > package.el contains this code: > > (defun package-install-file (file) > "Install a package from a file. > The file can either be a tar file or an Emacs Lisp file." > (interactive "fPackage file name: ") > (with-temp-buffer > (insert-file-contents-literally file) > (when (string-match "\\.tar\\'" file) (tar-mode)) > (package-install-from-buffer))) > > Since `insert-file-contents-literally' does not do any conversion > `package-buffer-info' fails to parse the info if the file is .el and > contains CRLF line endings. It then errors out with: > > Debugger entered--Lisp error: (error "Package lacks a \"Version\" or > \"Package-Version\" header") > signal(error ("Package lacks a \"Version\" or \"Package-Version\" header")) > error("Package lacks a \"Version\" or \"Package-Version\" header") > package-buffer-info() > > This affects all recent Emacs versions (including trunk). This was reported 4 years ago, but unfortunately never got a reply at the time. Are you still seeing this on a recent version of Emacs? If yes, could you please provide a minimal example file which fails to install? Also, why does your file have these line endings in the first place? Was this file written in Emacs? I'm trying to understand if this is an important use case or the common scenario for users of MS-Windows, since I don't use it myself. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 22 10:47:14 2019 Received: (at control) by debbugs.gnu.org; 22 Oct 2019 14:47:14 +0000 Received: from localhost ([127.0.0.1]:60277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvRK-0003Hp-7p for submit@debbugs.gnu.org; Tue, 22 Oct 2019 10:47:14 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:34216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvRI-0003Hc-6g for control@debbugs.gnu.org; Tue, 22 Oct 2019 10:47:12 -0400 Received: by mail-pf1-f179.google.com with SMTP id b128so10815497pfa.1 for ; Tue, 22 Oct 2019 07:47:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=15+xGIMMzcdjblgoPQhSzaNIpL0srStm66gfucoUSuI=; b=lkj152W9CGU0hcs+/gNWNz6TFoHsWd2UTuJQYDDMPzmV/bVL0/KusJL/d5Gj8vue+A RImFrctDrNV9biHltqgopyl2NHmQSGKPWciSS5sDri5h8oyK3TJOxHB0ArtnTsXpFkM7 VTpOpALOswC7ScnurHHONBg0+cG1Ws3DdkZH1EJ2BI+Y9SGKXzt8j6FzvruDJI76R3ET qV01TY4FWIDRSZYm1AkVUWfN8Ulu/rS0xR0jKW/nNmXlSoSTSI+4jwZxhNZr4+gIzXI/ 52B2LI9qQGa3UgCytxTX7me9yRlvEv7nI22wXqSB/8jRIWdR/w8E22s3mdflcudHWH86 UYZQ== X-Gm-Message-State: APjAAAXro5t9AvVJIldC/wns5y23YycJNCL1tLfFqllE0InCzmCuZqVe XN1dYGzAeT78vFS4DFikgp6/a4pjHpEvBJgv7tHvbiPd X-Google-Smtp-Source: APXvYqwKmZdBvrvvAHqdsvnXDIRPqHdxCR7rC0u2b70u/g9LPkRQPKqCCsyGHQkq/P5rNPG7+fEYkApCLjPkb9o62XY= X-Received: by 2002:aa7:80c6:: with SMTP id a6mr4664223pfn.107.1571755626050; Tue, 22 Oct 2019 07:47:06 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 22 Oct 2019 16:46:54 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: # probably not the same bug unmerge 21319 reopen 21319 close Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.179 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.210.179 listed in wl.mailspike.net] 2.0 BLANK_SUBJECT Subject is present but empty 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: # probably not the same bug unmerge 21319 reopen 21319 close Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.179 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.210.179 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.0 BLANK_SUBJECT Subject is present but empty 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders # probably not the same bug unmerge 21319 reopen 21319 close From unknown Sat Jun 21 03:29:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Tue, 22 Oct 2019 14:48:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 22 10:51:04 2019 Received: (at 21319) by debbugs.gnu.org; 22 Oct 2019 14:51:04 +0000 Received: from localhost ([127.0.0.1]:60291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvV2-0003Op-CC for submit@debbugs.gnu.org; Tue, 22 Oct 2019 10:51:04 -0400 Received: from mail-pg1-f177.google.com ([209.85.215.177]:45723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvUz-0003OH-Mz for 21319@debbugs.gnu.org; Tue, 22 Oct 2019 10:51:02 -0400 Received: by mail-pg1-f177.google.com with SMTP id r1so10081360pgj.12 for <21319@debbugs.gnu.org>; Tue, 22 Oct 2019 07:51:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=32dlg6m5wQ2r+DUc5z9szRqTwBf6xlqhvgjTqUJWvo8=; b=iH69W1I4NkjtEG6nQJhPmlGWWg1fu1E6osdQOH7MLVCJ+/7X6qpakERX09EgUeeGl8 1y9/794i4UO3vJfdop2pM0c+7d5Sh12XXFHPY8F8KZbEHvWG+CmeSRKOdLpHhw0Uz1sI 2tkiBVNQlemz+P95gu/85O+ozGRoP14OlXIYOls59kxQDbWdA60QR3cHJibKU6f5s/Ad fAE7LEKFVlcEuL69YQ+QHY8ecm41fbgA+TPUNRZEGKLvW0vgHKHJHsVUuhYCiW6Ii0V0 COSK5ycmSfqqq1QTkA6aT/zZLPI63Xh849z0OSan9C0ZeblIOaWnv3hcY3qnOv7o+gt0 iJfQ== X-Gm-Message-State: APjAAAVJSvFUtj+ow8d6Zprzn9ObEI6SAKcc6O5shAnFjJyPR+fu9nyE zf6lY4/r30IKNt1Zb6wSwlaYPYsu0zc+ZEnNqPE= X-Google-Smtp-Source: APXvYqy/HAYOiGSQwewiGO2yocjLRrXzY00i/jN+Vq6ehP2S3lqFzKl4nwk6VnTRtaMC4jX+idJ6iSHEBnGOLZHdSas= X-Received: by 2002:a17:90a:f491:: with SMTP id bx17mr5311348pjb.106.1571755855617; Tue, 22 Oct 2019 07:50:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Tue, 22 Oct 2019 16:50:44 +0200 Message-ID: Subject: Re: bug#21319: `package-install-file' fails with CRLF (Windows) line endings To: steckerhalter Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 21319 Cc: 21319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Stefan Kangas writes: > steckerhalter writes: > > > package.el contains this code: > > > > (defun package-install-file (file) > > "Install a package from a file. > > The file can either be a tar file or an Emacs Lisp file." > > (interactive "fPackage file name: ") > > (with-temp-buffer > > (insert-file-contents-literally file) > > (when (string-match "\\.tar\\'" file) (tar-mode)) > > (package-install-from-buffer))) > > > > Since `insert-file-contents-literally' does not do any conversion > > `package-buffer-info' fails to parse the info if the file is .el and > > contains CRLF line endings. It then errors out with: > > > > Debugger entered--Lisp error: (error "Package lacks a \"Version\" or > > \"Package-Version\" header") > > signal(error ("Package lacks a \"Version\" or \"Package-Version\" header")) > > error("Package lacks a \"Version\" or \"Package-Version\" header") > > package-buffer-info() > > > > This affects all recent Emacs versions (including trunk). > > This was reported 4 years ago, but unfortunately never got a reply at > the time. > > Are you still seeing this on a recent version of Emacs? If yes, could > you please provide a minimal example file which fails to install? > > Also, why does your file have these line endings in the first place? > Was this file written in Emacs? I'm trying to understand if this is > an important use case or the common scenario for users of MS-Windows, > since I don't use it myself. This was merged with Bug#20309, which was closed. I suspect that the bugs are most probably different, so I've unmerged this bug and reopened it. Please disregard any message saying that this bug is closed for now. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 07:58:26 2019 Received: (at 21319) by debbugs.gnu.org; 29 Nov 2019 12:58:26 +0000 Received: from localhost ([127.0.0.1]:59701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iafqs-0001xD-BJ for submit@debbugs.gnu.org; Fri, 29 Nov 2019 07:58:26 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:33048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iafqq-0001wz-0N for 21319@debbugs.gnu.org; Fri, 29 Nov 2019 07:58:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5v7SSxv5fD1TpgE3HHKw0Aljh3GIjaYzq3DCUnUqgt0=; b=PIBj7+OTYIA49z56kVTQcAp2ZL +utHDzYx5vzsxB8jpC/0HzmXVzAnlg/CHueYOxUiybmKMTaA26w6VL8InRXckmi2ZNnivK5BmmiQW 8US1BWVkqaWLAdJq0Gi2vSA3iJ9H6NIJVHnuae6zN86xQiKSKsrHRhptZ0M8k19RRE1XdYQwX36U8 fjPxbaiipNYZNxLQN09BRlCGl6WyIwDy44zl2DAfRA2u9atWtUUW6ikFwWXwWNxaY62rrXq2LtJnV gpqk8Vi8U1DcrLtkZm0UhfFoS2JCygR7dyoGKSraA81kFLbPfgDRLu5bLq4fUt0Pr8rrbqzxslO9o b6SoNs4A==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:36938 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iafqj-00185x-Rk; Fri, 29 Nov 2019 07:58:18 -0500 From: Stefan Kangas To: steckerhalter Subject: Re: bug#21319: `package-install-file' fails with CRLF (Windows) line endings In-Reply-To: (Stefan Kangas's message of "Tue, 22 Oct 2019 03:04:59 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Fri, 29 Nov 2019 13:58:15 +0100 Message-ID: <878snykffc.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21319 Cc: 21319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > steckerhalter writes: > >> package.el contains this code: >> >> (defun package-install-file (file) >> "Install a package from a file. >> The file can either be a tar file or an Emacs Lisp file." >> (interactive "fPackage file name: ") >> (with-temp-buffer >> (insert-file-contents-literally file) >> (when (string-match "\\.tar\\'" file) (tar-mode)) >> (package-install-from-buffer))) >> >> Since `insert-file-contents-literally' does not do any conversion >> `package-buffer-info' fails to parse the info if the file is .el and >> contains CRLF line endings. It then errors out with: >> >> Debugger entered--Lisp error: (error "Package lacks a \"Version\" or >> \"Package-Version\" header") >> signal(error ("Package lacks a \"Version\" or \"Package-Version\" header")) >> error("Package lacks a \"Version\" or \"Package-Version\" header") >> package-buffer-info() >> >> This affects all recent Emacs versions (including trunk). > > This was reported 4 years ago, but unfortunately never got a reply at > the time. > > Are you still seeing this on a recent version of Emacs? If yes, could > you please provide a minimal example file which fails to install? > > Also, why does your file have these line endings in the first place? > Was this file written in Emacs? I'm trying to understand if this is > an important use case or the common scenario for users of MS-Windows, > since I don't use it myself. We have gotten no more information within five weeks here. Does anyone think it's important to support CRLF line endings in package.el? I don't use Windows, so I'm not sure that I understand if this is an important use case or not. But AFAIK, and this might be completely wrong, you should be fine as long as you edit the file in Emacs? I'll give this a couple of weeks more, and if I don't hear anything else within that time, I'll just go ahead and assume that what I'm saying is correct and therefore close this bug report. Please speak up if any of the above is incorrect and this bug should remain open. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 08:29:56 2019 Received: (at 21319) by debbugs.gnu.org; 29 Nov 2019 13:29:56 +0000 Received: from localhost ([127.0.0.1]:59758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iagLM-0006dM-3X for submit@debbugs.gnu.org; Fri, 29 Nov 2019 08:29:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iagLJ-0006dA-Nc for 21319@debbugs.gnu.org; Fri, 29 Nov 2019 08:29:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iagLD-0007As-9i; Fri, 29 Nov 2019 08:29:47 -0500 Received: from [176.228.60.248] (port=1101 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iagL8-0000eY-4g; Fri, 29 Nov 2019 08:29:43 -0500 Date: Fri, 29 Nov 2019 15:29:55 +0200 Message-Id: <835zj2q08c.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: <878snykffc.fsf@marxist.se> (message from Stefan Kangas on Fri, 29 Nov 2019 13:58:15 +0100) Subject: Re: bug#21319: `package-install-file' fails with CRLF (Windows) line endings References: <878snykffc.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 21319 Cc: emacs@postmomentum.ch, 21319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) > From: Stefan Kangas > Date: Fri, 29 Nov 2019 13:58:15 +0100 > Cc: 21319@debbugs.gnu.org > > >> (defun package-install-file (file) > >> "Install a package from a file. > >> The file can either be a tar file or an Emacs Lisp file." > >> (interactive "fPackage file name: ") > >> (with-temp-buffer > >> (insert-file-contents-literally file) > >> (when (string-match "\\.tar\\'" file) (tar-mode)) > >> (package-install-from-buffer))) > >> > >> Since `insert-file-contents-literally' does not do any conversion > >> `package-buffer-info' fails to parse the info if the file is .el and > >> contains CRLF line endings. It then errors out with: > >> > >> Debugger entered--Lisp error: (error "Package lacks a \"Version\" or > >> \"Package-Version\" header") > >> signal(error ("Package lacks a \"Version\" or \"Package-Version\" header")) > >> error("Package lacks a \"Version\" or \"Package-Version\" header") > >> package-buffer-info() > >> > >> This affects all recent Emacs versions (including trunk). > > > > This was reported 4 years ago, but unfortunately never got a reply at > > the time. > > > > Are you still seeing this on a recent version of Emacs? If yes, could > > you please provide a minimal example file which fails to install? The code is still there. One can see if the problem happens by making a package that is a single .el file with CRLF EOL format. > > Also, why does your file have these line endings in the first place? > > Was this file written in Emacs? I'm trying to understand if this is > > an important use case or the common scenario for users of MS-Windows, > > since I don't use it myself. When a file is created on MS-Windows, even if it's a .el file, its EOL format is by default identical to that of the underlying platform's defaults. On MS-Windows, you will get CRLF, yes. > Does anyone think it's important to support CRLF line endings in > package.el? I don't know if this is important, but then fix is trivial: use insert-file-contents after binding coding-system-for-read to raw-text. > I don't use Windows, so I'm not sure that I understand if > this is an important use case or not. But AFAIK, and this might be > completely wrong, you should be fine as long as you edit the file in > Emacs? AFAIU, the problem is that one cannot install such a package, because the current code signals an error. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 14 23:29:50 2020 Received: (at control) by debbugs.gnu.org; 15 Jan 2020 04:29:50 +0000 Received: from localhost ([127.0.0.1]:34056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iraJS-0000Yu-Go for submit@debbugs.gnu.org; Tue, 14 Jan 2020 23:29:50 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:34246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iraJR-0000Yi-Aj for control@debbugs.gnu.org; Tue, 14 Jan 2020 23:29:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Subject:From:To:Date:Sender:Reply-To:Message-ID:Cc:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=djD4FF1OCsCLGHhCWD7IjlYiXHHQCgKGZIgMpHcxI20=; b=dSU/mhe1T4DVTlpoMKg1cA2C7P LpbmviKMtqHZgSK1dJuOWS4CqBF4lVTIWYS+9ZQN1fkwdYeeSacA3aFcfEQ9USMPbX1BwRy2C9cpw vvJstmnbEIQWgiKZEw7c8dkH67ltmZKO8Mn8YL9QnXlMIj7vk/HQtWD06m9cx1WDRAKIa50SVZ0IX Pa7uUYTur3QYfPCQECvlRIkxw38EcfEv3aJuCcj1C7DHx+xZoTUY9uCf5qj9eMsFvuLNQAjpGeF9z 12fcs0nThn608OX/ahD8+it5vLqpcNyn9brhKC0CE1VlLc3sIJS0edrOk08Vjj89LgOq3Ii3ZYF7s W9TC2fCg==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:59748 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iraJL-000D4H-Fp for control@debbugs.gnu.org; Tue, 14 Jan 2020 23:29:43 -0500 Date: Wed, 15 Jan 2020 05:29:41 +0100 To: control@debbugs.gnu.org From: Stefan Kangas Subject: control message for bug #21319 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" Message-Id: X-Spam-Score: -1.0 (-) severity 21319 minor quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 12:03:33 2022 Received: (at 21319) by debbugs.gnu.org; 29 Jan 2022 17:03:33 +0000 Received: from localhost ([127.0.0.1]:34626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDr8P-0003NK-FV for submit@debbugs.gnu.org; Sat, 29 Jan 2022 12:03:33 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDr8N-0003My-Nl for 21319@debbugs.gnu.org; Sat, 29 Jan 2022 12:03:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=in0xPsAmLPP6mwsmiqdjwoKCiyO2aHUxrigo/8P+Fdg=; b=lKqgcIcVvMZNjwf3yLipwBPssq pl+v/85KTpTXZUeA2iQaVx/wgdQmGB7hcJIkOXKavw4YNZOLlTkdvNSG1rzPEcdeIvJX5JLHe0ScI fbrsqLkIFGGX+mQ1jWOqOTe8N2bFOkdw6Jn3OH3GnlHsjd8u2Fpn2LVI8IasCoMnG9N8=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDr8E-0004px-Qd; Sat, 29 Jan 2022 18:03:25 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#21319: `package-install-file' fails with CRLF (Windows) line endings References: <878snykffc.fsf@marxist.se> <835zj2q08c.fsf@gnu.org> X-Now-Playing: Depeche Mode's _Stripped_: "Breathing in fumes" Date: Sat, 29 Jan 2022 18:03:18 +0100 In-Reply-To: <835zj2q08c.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 29 Nov 2019 15:29:55 +0200") Message-ID: <87bkzu79ux.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> Does anyone think it's important to support CRLF line endings in >> package.el? > > I don't know if this is important, but then fix is trivial: use > insert-file-contents after binding coding-syste [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21319 Cc: emacs@postmomentum.ch, Stefan Kangas , 21319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Does anyone think it's important to support CRLF line endings in >> package.el? > > I don't know if this is important, but then fix is trivial: use > insert-file-contents after binding coding-system-for-read to raw-text. I think I remember this being fixed recently? Anybody remember? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 12:03:39 2022 Received: (at control) by debbugs.gnu.org; 29 Jan 2022 17:03:39 +0000 Received: from localhost ([127.0.0.1]:34629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDr8U-0003Ne-Lh for submit@debbugs.gnu.org; Sat, 29 Jan 2022 12:03:38 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDr8S-0003N9-In for control@debbugs.gnu.org; Sat, 29 Jan 2022 12:03:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=G2Oan3BRdo/v7sH2aS7f0C0FKrw8y/SHY3xPvJnGPVU=; b=X02flwMAc0zT2fILdxOSFeWWrr ooLGbeiISh9bLRAmDprbxWaOtWTuaydcedLGyvHQLtQyCdKqSdWu9U8qZWbAejgvPz6rtDhdfZeHz vT9UDr93DVS2MYxdGVw8OHuZad6dae8ZToGY5JsaeX40TBfV4GkKCxzM6HhB9sPPuR7I=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDr8K-0004q7-RV for control@debbugs.gnu.org; Sat, 29 Jan 2022 18:03:30 +0100 Date: Sat, 29 Jan 2022 18:03:27 +0100 Message-Id: <87a6fe79uo.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #21319 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 21319 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 21319 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 12:08:24 2022 Received: (at 21319) by debbugs.gnu.org; 29 Jan 2022 17:08:24 +0000 Received: from localhost ([127.0.0.1]:34646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDrD5-0003XX-Sq for submit@debbugs.gnu.org; Sat, 29 Jan 2022 12:08:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDrD0-0003X9-CW for 21319@debbugs.gnu.org; Sat, 29 Jan 2022 12:08:22 -0500 Received: from [2001:470:142:3::e] (port=55294 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDrCu-0006i5-Pp; Sat, 29 Jan 2022 12:08:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Qw8XMbV9Yu8tlxkPihxG0ura0gh5MCp9HH6jHqRhzro=; b=L7ldqHQhDMWP k0KNyKeRcUcp4DVezxqBAibpDhCVmADCNNf8g/8gtHhrXkZ0urzh6WcZo/xDel90lQNp75XVZ1tau 3e650QucE5qXdH7glRTZaUSyuIY5yBRzNieSPNlqF7jW/6vL4uy7s+BWD/EEFsw9oNr1602JYAU0M ClYSqGNst/a0LIkDhorEKfQxPAD9U6Ven1voKIn2hIUIX91yqCY4ZyH7RmsMmK/dqox/wnXaGeDUg jLbA4YtqhAlMih2uibVc57b+RVmhZx5bGonWu32fQHUYymJC8k0aF5kx7FnNMWvITaMBTdDAed5N4 yvFBNWSo7eQwJxJS+h+Oxg==; Received: from [87.69.77.57] (port=1537 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDrCu-0003GB-4a; Sat, 29 Jan 2022 12:08:12 -0500 Date: Sat, 29 Jan 2022 19:07:54 +0200 Message-Id: <83k0eibhcl.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87bkzu79ux.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 29 Jan 2022 18:03:18 +0100) Subject: Re: bug#21319: `package-install-file' fails with CRLF (Windows) line endings References: <878snykffc.fsf@marxist.se> <835zj2q08c.fsf@gnu.org> <87bkzu79ux.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21319 Cc: emacs@postmomentum.ch, stefan@marxist.se, 21319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Stefan Kangas , emacs@postmomentum.ch, > 21319@debbugs.gnu.org > Date: Sat, 29 Jan 2022 18:03:18 +0100 > > Eli Zaretskii writes: > > >> Does anyone think it's important to support CRLF line endings in > >> package.el? > > > > I don't know if this is important, but then fix is trivial: use > > insert-file-contents after binding coding-system-for-read to raw-text. > > I think I remember this being fixed recently? Anybody remember? Yes, it should be fixed. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 12:09:16 2022 Received: (at 21319) by debbugs.gnu.org; 29 Jan 2022 17:09:16 +0000 Received: from localhost ([127.0.0.1]:34650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDrDw-0003ZA-6t for submit@debbugs.gnu.org; Sat, 29 Jan 2022 12:09:16 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDrDu-0003Yt-FF for 21319@debbugs.gnu.org; Sat, 29 Jan 2022 12:09:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MmavQL/AsOkyoYDZYBVAtEut9b7c4cuqteQQMHnIR4M=; b=kYHae5yveJrAKK4No91aR5VSsZ IkH8OGC/RZ3rYq5pDfMlb1P+g8e6CQ5qN7cWyRRGwvfNjwpj8s1EWtuU8VMKwTOgGj/QbTwAN0EFG cthBEtp4kMeV50YcrXOvfZY8pRizB8G4jWovyHGfMfEf5B93vQgGhjDx45eApu1J+pRY=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDrDl-0004tR-Ms; Sat, 29 Jan 2022 18:09:08 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#21319: `package-install-file' fails with CRLF (Windows) line endings References: <878snykffc.fsf@marxist.se> <835zj2q08c.fsf@gnu.org> <87bkzu79ux.fsf@gnus.org> <83k0eibhcl.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUnHCIDAwSfnZnK ubIiXps/SFnt6+NEcKRVjL2Jg32hWkWMHiNiHx66knD///9cMeLqAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+YBHREIMRc5t7gAAAGNSURBVDjL5dIxSyNBFAfwt8U0usUu+AlWr0h7G1YRrrgwIZZ7mscR sFuYs0kXGWsv51l7qIxYXgonpvKqnSk2hU3yCiFdDr+Ls6IgaworObg/U73fPIbHG/DCxYHwjRCt RlG0xtu8AkESx3FWPzjmrzuc1I8O61UQ4hFa36qQZCdRbe173K/C1ZVS6jfvvXojz7XWf5o/21UA nwjY5+bKmwd8X1DR4oB4yl4iXiaBRKyrU/y1n36VUh4cfpS815I9vgUia3oBgM+QN5G7bEV9LlsN EP00TCGlABE5nuN2tiokL2HjC0OWQgHA2piynQ941uOyAd376Acy39UBwXVtl4fzBmxO8zs2JSjC YIDMLaOjknV5lEDXGg98WxCAnsVu5Z/0fCRiAeJvDjC5JhqTnmXZXFtjp3PtYGiB8hKWjL4fGjM1 xpCDLvnWlB3esnkMkaV85GC8dF0sD5/BkosZ3gjIwoAmlLt7uqwacmjzmYBacbvb0ZOLDl5c4oA6 aoCnqGrqH/0M/y94i+vBAzsC5gfpP+ZRAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTAxLTI5VDE3 OjA4OjQ5KzAwOjAwHhBdwAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wMS0yOVQxNzowODo0OSsw MDowMG9N5XwAAAAASUVORK5CYII= X-Now-Playing: Depeche Mode's _Stripped_: "Fly on the windscreen" Date: Sat, 29 Jan 2022 18:09:04 +0100 In-Reply-To: <83k0eibhcl.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Jan 2022 19:07:54 +0200") Message-ID: <87zgne5v0v.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> I think I remember this being fixed recently? Anybody remember? > > Yes, it should be fixed. Thanks; closing this bug report, then. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 21319 Cc: emacs@postmomentum.ch, stefan@marxist.se, 21319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> I think I remember this being fixed recently? Anybody remember? > > Yes, it should be fixed. Thanks; closing this bug report, then. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 12:09:27 2022 Received: (at control) by debbugs.gnu.org; 29 Jan 2022 17:09:27 +0000 Received: from localhost ([127.0.0.1]:34653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDrE7-0003ZY-Dq for submit@debbugs.gnu.org; Sat, 29 Jan 2022 12:09:27 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDrE6-0003ZN-7J for control@debbugs.gnu.org; Sat, 29 Jan 2022 12:09:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z4YxGMHTFDoe0JzbyQhrBmMoxFuIj6IIH3c0faHrpB4=; b=uzdkrhXUhr1WJdSFzQxlC825fy kTdiA9SCoTsbQ2/8lK5F49nXMN7iaRzgU/aCMsl+/UeKLMgMwWrqKcu9qMFPE0xtu3reGuiNRLH8E L4xwAnrkwJozxsE4It7LsL6v0DCC93cToeBsVFq+f7rbNpK6xTtrfs6Evc6iUOAJri6w=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDrDy-0004vr-F1 for control@debbugs.gnu.org; Sat, 29 Jan 2022 18:09:20 +0100 Date: Sat, 29 Jan 2022 18:09:17 +0100 Message-Id: <87y22y5v0i.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #21319 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 21319 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 21319 29.1 quit From unknown Sat Jun 21 03:29:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 27 Feb 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator