GNU bug report logs - #21317
25.0.50; frame-resize-pixelwise has no effect (GTK, no window manager)

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Pip Cet <pipcet <at> gmail.com>
Cc: 21317 <at> debbugs.gnu.org
Subject: bug#21317: 25.0.50; frame-resize-pixelwise has no effect (GTK, no window manager)
Date: Sun, 23 Aug 2015 15:23:20 +0200

> I've attached a patch that combines your patch with the minor fixes I
> suggested in the previous email. It appears to work here.

Thanks.  This

+  lval = Qnil;
+  switch (f->want_fullscreen)
+    {
+    case FULLSCREEN_WIDTH:
+      lval = Qfullwidth;
+      break;
+    case FULLSCREEN_HEIGHT:
+      lval = Qfullheight;
+      break;
+    case FULLSCREEN_BOTH:
+      lval = Qfullboth;
+      break;
+    case FULLSCREEN_MAXIMIZED:
+      lval = Qmaximized;
+      break;
+    }

looks a bit ugly.  Can't we set lval in the switch above?
If f->want_fullscreen changed in between we'd get in hot water anyway.

(Also I'd like to keep the patch resonably small so I can install it as
a "tiny change".  Or do you have copyright papers signed for Emacs?)

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.