GNU bug report logs - #21273
[PATCH] grep: avoid use of uninitialized variable

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sun, 16 Aug 2015 02:19:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#21273: closed ([PATCH] grep: avoid use of uninitialized variable)
Date: Thu, 20 Aug 2015 00:02:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 19 Aug 2015 17:00:41 -0700
with message-id <CA+8g5KHQB_iS7OBSUcCtiPL31OK8z-rWTPHWer5F+N_qH8K17w <at> mail.gmail.com>
and subject line Re: bug#21273: [PATCH] grep: avoid use of uninitialized variable
has caused the debbugs.gnu.org bug report #21273,
regarding [PATCH] grep: avoid use of uninitialized variable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
21273: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21273
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: <bug-grep <at> gnu.org>
Subject: [PATCH] grep: avoid use of uninitialized variable
Date: Sun, 16 Aug 2015 11:17:52 +0900
[Message part 3 (text/plain, inline)]
Uninitialized value of variable BACKREF is referred in EGexecute.  It
does not cause wrong result, but regex may be used even when it is not
needed.  It may lead grep to slowdown.

By the way, gawk initializes the variable already, so it does not have
to be fixed.
[0001-grep-avoid-use-of-uninitialized-variable.patch (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 21273-done <at> debbugs.gnu.org
Subject: Re: bug#21273: [PATCH] grep: avoid use of uninitialized variable
Date: Wed, 19 Aug 2015 17:00:41 -0700
On Sat, Aug 15, 2015 at 7:17 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> Uninitialized value of variable BACKREF is referred in EGexecute.  It
> does not cause wrong result, but regex may be used even when it is not
> needed.  It may lead grep to slowdown.
>
> By the way, gawk initializes the variable already, so it does not have
> to be fixed.

Thank you for that fix. I have determined that the problem was
introduced since the latest release, so this does not require a
NEWS entry, then added that info and a paraphrasing of your
comment above to the commit log. Pushed here:

  http://git.savannah.gnu.org/cgit/grep.git/commit/?id=8a33cdeba4ba0


This bug report was last modified 9 years and 298 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.