From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 22:18:08 2015 Received: (at submit) by debbugs.gnu.org; 16 Aug 2015 02:18:08 +0000 Received: from localhost ([127.0.0.1]:57022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZQnWS-0002hG-1s for submit@debbugs.gnu.org; Sat, 15 Aug 2015 22:18:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38472) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZQnWQ-0002h9-9h for submit@debbugs.gnu.org; Sat, 15 Aug 2015 22:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQnWP-00019X-08 for submit@debbugs.gnu.org; Sat, 15 Aug 2015 22:18:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQnWO-00019T-TJ for submit@debbugs.gnu.org; Sat, 15 Aug 2015 22:18:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQnWN-0004na-U9 for bug-grep@gnu.org; Sat, 15 Aug 2015 22:18:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQnWI-00019J-Tq for bug-grep@gnu.org; Sat, 15 Aug 2015 22:18:03 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:49285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQnWI-00019C-KJ for bug-grep@gnu.org; Sat, 15 Aug 2015 22:17:58 -0400 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 3686C8058A for ; Sun, 16 Aug 2015 11:17:56 +0900 (JST) X-matriXscan-loop-detect: e0e2ff94bf9a2acc7a78a0c8ab9fd2129d61a40b Received: from mail05.kcn.ne.jp ([61.86.6.184]) by mxs01-s with ESMTP; Sun, 16 Aug 2015 11:17:55 +0900 (JST) Received: from [10.120.1.36] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail05.kcn.ne.jp (Postfix) with ESMTPA id 3AB417D009F for ; Sun, 16 Aug 2015 11:17:55 +0900 (JST) Date: Sun, 16 Aug 2015 11:17:52 +0900 From: Norihiro Tanaka To: Subject: [PATCH] grep: avoid use of uninitialized variable Message-Id: <20150816111741.DFB8.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_55CFF0B900000000DFA4_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_55CFF0B900000000DFA4_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Uninitialized value of variable BACKREF is referred in EGexecute. It does not cause wrong result, but regex may be used even when it is not needed. It may lead grep to slowdown. By the way, gawk initializes the variable already, so it does not have to be fixed. --------_55CFF0B900000000DFA4_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-avoid-use-of-uninitialized-variable.patch" Content-Disposition: attachment; filename="0001-grep-avoid-use-of-uninitialized-variable.patch" Content-Transfer-Encoding: base64 RnJvbSAxMTAzYjY3ZWI4Y2RmMDIwOThiMDlmNzlkNzNmMjZjODk3ZTRkYjk2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBUdWUsIDExIEF1ZyAyMDE1IDAwOjM3OjAwICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogYXZvaWQgdXNlIG9mIHVuaW5pdGlhbGl6ZWQgdmFyaWFibGUKCiogc3JjL2RmYXNlYXJjaC5j IChFR2V4ZWN1dGUpOiBJbml0aWFsaXplIGJhY2tyZWYuCi0tLQogc3JjL2RmYXNlYXJjaC5jIHwg MiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvc3JjL2RmYXNlYXJjaC5jIGIvc3JjL2RmYXNlYXJjaC5jCmluZGV4IDhiOGFmMDYu LmRlNTEzMjEgMTAwNjQ0Ci0tLSBhL3NyYy9kZmFzZWFyY2guYworKysgYi9zcmMvZGZhc2VhcmNo LmMKQEAgLTIwNyw3ICsyMDcsNiBAQCBFR2V4ZWN1dGUgKGNoYXIgY29uc3QgKmJ1Ziwgc2l6ZV90 IHNpemUsIHNpemVfdCAqbWF0Y2hfc2l6ZSwKIHsKICAgY2hhciBjb25zdCAqYnVmbGltLCAqYmVn LCAqZW5kLCAqcHRyLCAqbWF0Y2gsICpiZXN0X21hdGNoLCAqbWJfc3RhcnQ7CiAgIGNoYXIgZW9s ID0gZW9sYnl0ZTsKLSAgaW50IGJhY2tyZWY7CiAgIHJlZ29mZl90IHN0YXJ0OwogICBzaXplX3Qg bGVuLCBiZXN0X2xlbjsKICAgc3RydWN0IGt3c21hdGNoIGt3c207CkBAIC0yMjcsNiArMjI2LDcg QEAgRUdleGVjdXRlIChjaGFyIGNvbnN0ICpidWYsIHNpemVfdCBzaXplLCBzaXplX3QgKm1hdGNo X3NpemUsCiAgICAgICAgICAgY2hhciBjb25zdCAqbmV4dF9iZWcsICpkZmFfYmVnID0gYmVnOwog ICAgICAgICAgIHNpemVfdCBjb3VudCA9IDA7CiAgICAgICAgICAgYm9vbCBleGFjdF9rd3NldF9t YXRjaCA9IGZhbHNlOworICAgICAgICAgIGludCBiYWNrcmVmID0gMDsKIAogICAgICAgICAgIC8q IFRyeSBtYXRjaGluZyB3aXRoIEtXc2V0LCBpZiBpdCdzIGRlZmluZWQuICAqLwogICAgICAgICAg IGlmIChrd3NldCkKLS0gCjIuNC42Cgo= --------_55CFF0B900000000DFA4_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 20:01:05 2015 Received: (at 21273-done) by debbugs.gnu.org; 20 Aug 2015 00:01:05 +0000 Received: from localhost ([127.0.0.1]:33003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSDI0-0000uR-RO for submit@debbugs.gnu.org; Wed, 19 Aug 2015 20:01:05 -0400 Received: from mail-vk0-f43.google.com ([209.85.213.43]:34524) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSDHx-0000u8-TH for 21273-done@debbugs.gnu.org; Wed, 19 Aug 2015 20:01:02 -0400 Received: by vkm66 with SMTP id 66so9870039vkm.1 for <21273-done@debbugs.gnu.org>; Wed, 19 Aug 2015 17:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=x0kRUMU9ndfj+gT4jO9knboAJG0t3zyQ2Nc2j+yGW+c=; b=UsrWtZMEpRsNApGwSnRrk387qzvFzuNWT3AGrvciFft39+kLJA5/nNDlcS5ZRaVYXV 6AWAf/fgDG/MxqLQeSU42P5ZUxZis+ilPFST1d6SwDAMlyHP9JeFoCvu7Qt87sm7S23t rizazte9a35rm/d8bx8vRZrsRAA7FVFLFfQAP2RwywibUWGVjdxbazQKiFCmr5H2IjK+ vASg0JuB/2wyyLHjyRpsoOVndoB5IGFd/PYeW4krLoPFSk+qax0XxTjaDDiDY3PtY9XD Ba6ThPwqC2mRIifOP1T8z2ASIqp7HCC8LBYko515lVpRws57tCzUJEwzitmRvt2plgHY 3m4Q== X-Received: by 10.52.237.161 with SMTP id vd1mr270259vdc.65.1440028860918; Wed, 19 Aug 2015 17:01:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.61.8 with HTTP; Wed, 19 Aug 2015 17:00:41 -0700 (PDT) In-Reply-To: <20150816111741.DFB8.27F6AC2D@kcn.ne.jp> References: <20150816111741.DFB8.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Wed, 19 Aug 2015 17:00:41 -0700 X-Google-Sender-Auth: I8IktnImTddY4SJtJnHt8MkTU34 Message-ID: Subject: Re: bug#21273: [PATCH] grep: avoid use of uninitialized variable To: Norihiro Tanaka Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21273-done Cc: 21273-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Aug 15, 2015 at 7:17 PM, Norihiro Tanaka wrote: > Uninitialized value of variable BACKREF is referred in EGexecute. It > does not cause wrong result, but regex may be used even when it is not > needed. It may lead grep to slowdown. > > By the way, gawk initializes the variable already, so it does not have > to be fixed. Thank you for that fix. I have determined that the problem was introduced since the latest release, so this does not require a NEWS entry, then added that info and a paraphrasing of your comment above to the commit log. Pushed here: http://git.savannah.gnu.org/cgit/grep.git/commit/?id=8a33cdeba4ba0 From unknown Wed Jun 18 23:03:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Sep 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator