From unknown Sun Aug 10 07:38:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21249: "sed -i '...' -" in git head Resent-From: Stephane Chazelas Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Thu, 13 Aug 2015 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21249 X-GNU-PR-Package: sed X-GNU-PR-Keywords: To: 21249@debbugs.gnu.org, meyering@fb.com X-Debbugs-Original-To: bug-sed@gnu.org, Jim Meyering Received: via spool by submit@debbugs.gnu.org id=B.143947534520309 (code B ref -1); Thu, 13 Aug 2015 14:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Aug 2015 14:15:45 +0000 Received: from localhost ([127.0.0.1]:55082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPtIH-0005HV-FQ for submit@debbugs.gnu.org; Thu, 13 Aug 2015 10:15:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57747) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPtIE-0005HK-98 for submit@debbugs.gnu.org; Thu, 13 Aug 2015 10:15:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPtIA-0001D8-9d for submit@debbugs.gnu.org; Thu, 13 Aug 2015 10:15:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPtI9-0001Cv-MO for submit@debbugs.gnu.org; Thu, 13 Aug 2015 10:15:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPtI5-0008Tf-K3 for bug-sed@gnu.org; Thu, 13 Aug 2015 10:15:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPtI1-00011L-Ak for bug-sed@gnu.org; Thu, 13 Aug 2015 10:15:33 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:35685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPtI1-0000y9-3k for bug-sed@gnu.org; Thu, 13 Aug 2015 10:15:29 -0400 Received: by wicne3 with SMTP id ne3so141688786wic.0 for ; Thu, 13 Aug 2015 07:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=F6pJn2/GYpFgTBAT/qeMxWRjKx6UDDzDSbiSnJv7QuA=; b=Hbn4b/wPSXeiVpGqVsJLb7+jcFB6f4hnUoKuuO7Q02D5SpkCNx+luzedJP6s8qSI70 v0cEVVi1gz/eG+opi3ycgicYBUSenaSGKszLMUzhm+3zEc8+L0GQf1Vn9bgffLW/R66t kyRTheQG2SN32tQzYP1jO3KIIqCZBPXZliLQkeKuZycTaGtrFhpiEPCC/z8bfHBWAIZk gft5lgkRmyxaSsntlX4Rtj+Ybu2tPjsbcpP1Co+gwTMQu0jvJTXJTBbYjK7jumDK+34A 3hhKBsmDg1dPErpZOibnPiXdtd98Z5Zz28SWa1eFRsWV6uV6AOoeClF4nBSgzCAH1oJT bLOQ== X-Received: by 10.194.94.73 with SMTP id da9mr21231563wjb.97.1439475327627; Thu, 13 Aug 2015 07:15:27 -0700 (PDT) Received: from chaz.gmail.com (05448dab.skybroadband.com. [5.68.141.171]) by smtp.gmail.com with ESMTPSA id lq9sm3590330wjb.35.2015.08.13.07.15.26 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 13 Aug 2015 07:15:26 -0700 (PDT) Date: Thu, 13 Aug 2015 15:15:26 +0100 From: Stephane Chazelas Message-ID: <20150813141526.GA4313@chaz.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, about this commit: > commit c033bdee411128dfebfea1974d1ee3c1d9eac572 > Author: Jim Meyering > Date: Sat Jun 20 07:38:49 2015 -0700 > > sed -i: do not treat "-" as a file name the behaviour was aligned with perl's (where that syntax derives from). In perl, perl -pi -e 's/../../' -- * or perl -pi -e 's/../../' -- "$file" is known to be /reliable/ (work regardless of the value of $file (while without -i it's not, see https://unix.stackexchange.com/questions/170013/security-implications-of-running-perl-ne (-, cmd|, Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Sun, 03 Jan 2016 03:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21249 X-GNU-PR-Package: sed X-GNU-PR-Keywords: To: Stephane Chazelas Cc: Jim Meyering , 21249@debbugs.gnu.org Received: via spool by 21249-submit@debbugs.gnu.org id=B21249.145179157915474 (code B ref 21249); Sun, 03 Jan 2016 03:27:02 +0000 Received: (at 21249) by debbugs.gnu.org; 3 Jan 2016 03:26:19 +0000 Received: from localhost ([127.0.0.1]:35744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFZJD-00041V-1g for submit@debbugs.gnu.org; Sat, 02 Jan 2016 22:26:19 -0500 Received: from mail-io0-f175.google.com ([209.85.223.175]:35711) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFZJB-00041J-N1 for 21249@debbugs.gnu.org; Sat, 02 Jan 2016 22:26:18 -0500 Received: by mail-io0-f175.google.com with SMTP id 77so100382786ioc.2 for <21249@debbugs.gnu.org>; Sat, 02 Jan 2016 19:26:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=eNAg+1YI2hR2/Uk48eQzSRN2pCsYb95uh7DLGA1+ZkU=; b=vvJLLR2xX/HaqTzZAv0sVK8lztOL0j9tib7oni+y49V+TGWMq71yvYccniCLyVLTjt dyoc2Y1hG9+io2P9pZ2joOEfCCBvJ+zvA/N6jYZFGkAvhijOx985HVQxeLv2PYkrfTRL rxFmSz620B4dywvOjzv38fbqMnN0s3KpLIxmj226+rUT7Jj8nnXB+ohTXTh9kSEWnUlX mJgrKjfZ3su1BccRIEApCL1iXNXiJWjZNNRmaGpNPzZMj6Ad/kmv+QmXm5iD+XewgjvT H7EgZsj3YKLatLODA2QidCJHxNy+A5fOZMP1y1K2tzGudLMxurEFHZ0KAIM0oAAzTxXF RkZA== X-Received: by 10.107.27.6 with SMTP id b6mr76402783iob.163.1451791572216; Sat, 02 Jan 2016 19:26:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.36.10.18 with HTTP; Sat, 2 Jan 2016 19:25:52 -0800 (PST) In-Reply-To: <20150813141526.GA4313@chaz.gmail.com> References: <20150813141526.GA4313@chaz.gmail.com> From: Jim Meyering Date: Sat, 2 Jan 2016 19:25:52 -0800 X-Google-Sender-Auth: M1KrzU0Om3i5UtrpFv93HJvZK5I Message-ID: Content-Type: multipart/mixed; boundary=001a113fee44f3ff3b052865903c X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a113fee44f3ff3b052865903c Content-Type: text/plain; charset=UTF-8 On Thu, Aug 13, 2015 at 7:15 AM, Stephane Chazelas wrote: > Hello, > > about this commit: > >> commit c033bdee411128dfebfea1974d1ee3c1d9eac572 >> Author: Jim Meyering >> Date: Sat Jun 20 07:38:49 2015 -0700 >> >> sed -i: do not treat "-" as a file name > > the behaviour was aligned with perl's (where that syntax derives > from). > > In perl, perl -pi -e 's/../../' -- * > > or perl -pi -e 's/../../' -- "$file" > > is known to be /reliable/ (work regardless of the value of $file > (while without -i it's not, see > https://unix.stackexchange.com/questions/170013/security-implications-of-running-perl-ne > (-, cmd|, > That was also /safe/ in sed before that change. Treating "-" as > stdin with -i doesn't make sense as it doesn't make sense to > edit stdin "in-place". > > Now that means it breaks scripts that do: > sed -i '...' -- "$file" > expecting it modify $file regardless of the name of $file. Now, > one has to do: > > case $file in > -) file=./- > esac > sed -i '...' -- "$file" > > for no good reason. > > IMO, that change only has negative consequences. Thank you for the report and good argument. I plan to revert that change with the attached patch: --001a113fee44f3ff3b052865903c Content-Type: text/x-patch; charset=US-ASCII; name="0001-revert-v4.2.2-87-gc033bde-to-make-sed-i-treat-as-a-f.patch" Content-Disposition: attachment; filename="0001-revert-v4.2.2-87-gc033bde-to-make-sed-i-treat-as-a-f.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iixz71kl0 RnJvbSA2MWMwYTUzZWM5OTdlMTI4ZmU1Yzk3NmVkYTc0MTI1NzE0MDk0MTBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U3VuLCAyNyBEZWMgMjAxNSAxMDozMzowNiAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIHJldmVydCB2 NC4yLjItODctZ2MwMzNiZGUsIHRvIG1ha2Ugc2VkIC1pIHRyZWF0ICItIiBhcyBhIGZpbGUKIG5h bWUKClN0ZXBoYW5lIENoYXplbGFzIG1hZGUgYSBmaW5lIGNhc2UgZm9yIHdoeSBzZWQncyAtLWlu LXBsYWNlICgtaSkKc2hvdWxkIHRyZWF0ICItIiBhcyBhIGZpbGUgbmFtZSwgYW5kIG5vdCBhcyBz dGFuZGFyZCBpbnB1dCBpbgpodHRwOi8vZGViYnVncy5nbnUub3JnLzIxMjQ5CgpUaGVyZSB3YXMg bm8gc3BlY2lmaWMgdGVzdCBmb3IgdGhlIHByaW9yIGJlaGF2aW9yLCBzbyByYXRoZXIgdGhhbgps ZXR0aW5nIHRoZSByZXZlcnQgcmVtb3ZlIHRoZSBzb2xlIHRlc3QsIGFkYXB0IGFuZCByZXRhaW4g aXQ6CiogdGVzdHN1aXRlL2luLXBsYWNlLWh5cGhlbi5zaDogSG93ZXZlciwgcmV0YWluIGFuZCBh ZGFwdCB0aGlzCmZpbGUgdG8gdGVzdCBmb3IgdGhlIHJlc3RvcmVkIGJlaGF2aW9yLgoqIHRlc3Rz dWl0ZS9NYWtlZmlsZS5hbTogUmV0YWluIHRoaXMgY2hhbmdlLCB0b28uCi0tLQogTkVXUyAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAzIC0tLQogc2VkL2V4ZWN1dGUuYyAgICAgICAgICAgICAg ICB8ICA1ICstLS0tCiB0ZXN0c3VpdGUvaW4tcGxhY2UtaHlwaGVuLnNoIHwgMTEgKysrKysrLS0t LS0KIDMgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCA3YjVjNmY5Li40NWFlN2FlIDEwMDY0NAotLS0g YS9ORVdTCisrKyBiL05FV1MKQEAgLTU1LDkgKzU1LDYgQEAgR05VIHNlZCBORVdTICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgLSotIG91dGxpbmUgLSotCiAgIGhhcyBiZWVuIGxp c3RlZCBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhcyBhIGZhaWxlZCBleHBlcmltZW50IGZvciBhdAog ICBsZWFzdCAxMCB5ZWFycy4gIFRoYXQgY29tbWFuZCBpcyBub3cgcmVtb3ZlZC4KCi0gIHNlZCAt aSBzL2EvYi8gLSBub3cgZXZva2VzIGFuIGVycm9yLCByYXRoZXIgdGhhbiBhdHRlbXB0aW5nIHRv IG9wZXJhdGUKLSAgb24gdGhlIGZpbGUgbmFtZWQgLi8tCi0KICoqIEJ1aWxkLXJlbGF0ZWQKCiAg ICJtYWtlIGRpc3QiIG5vdyBidWlsZHMgLnRhci54eiBmaWxlcywgcmF0aGVyIHRoYW4gLnRhci5n eiBvbmVzLgpkaWZmIC0tZ2l0IGEvc2VkL2V4ZWN1dGUuYyBiL3NlZC9leGVjdXRlLmMKaW5kZXgg ZTViNjZjMi4uM2ZlMTVjYiAxMDA2NDQKLS0tIGEvc2VkL2V4ZWN1dGUuYworKysgYi9zZWQvZXhl Y3V0ZS5jCkBAIC01NTAsMTEgKzU1MCw4IEBAIG9wZW5fbmV4dF9maWxlKGNvbnN0IGNoYXIgKm5h bWUsIHN0cnVjdCBpbnB1dCAqaW5wdXQpCiAgIGJ1ZmZlci5sZW5ndGggPSAwOwoKICAgaW5wdXQt PmluX2ZpbGVfbmFtZSA9IG5hbWU7Ci0gIGlmIChuYW1lWzBdID09ICctJyAmJiBuYW1lWzFdID09 ICdcMCcpCisgIGlmIChuYW1lWzBdID09ICctJyAmJiBuYW1lWzFdID09ICdcMCcgJiYgIWluX3Bs YWNlX2V4dGVuc2lvbikKICAgICB7Ci0gICAgICBpZiAoaW5fcGxhY2VfZXh0ZW5zaW9uKQotICAg ICAgICBwYW5pYyhfKCJjb3VsZG4ndCBlZGl0ICVzOiBpcyBhIHRlcm1pbmFsIiksIG5hbWUpOwot CiAgICAgICBjbGVhcmVycihzdGRpbik7CS8qIGNsZWFyIGFueSBzdGFsZSBFT0YgaW5kaWNhdGlv biAqLwogI2lmIGRlZmluZWQgV0lOMzIgfHwgZGVmaW5lZCBfV0lOMzIgfHwgZGVmaW5lZCBfX0NZ R1dJTl9fIFwKICAgfHwgZGVmaW5lZCBNU0RPUyB8fCBkZWZpbmVkIF9fRU1YX18KZGlmZiAtLWdp dCBhL3Rlc3RzdWl0ZS9pbi1wbGFjZS1oeXBoZW4uc2ggYi90ZXN0c3VpdGUvaW4tcGxhY2UtaHlw aGVuLnNoCmluZGV4IGFlMTE1M2IuLmY0NGVmZDIgMTAwNzU1Ci0tLSBhL3Rlc3RzdWl0ZS9pbi1w bGFjZS1oeXBoZW4uc2gKKysrIGIvdGVzdHN1aXRlL2luLXBsYWNlLWh5cGhlbi5zaApAQCAtMSw1 ICsxLDUgQEAKICMhL2Jpbi9zaAotIyBWZXJpZnkgdGhhdCAiLSIgaXMgbm8gbG9uZ2VyIHRyZWF0 ZWQgYXMgYSBmaWxlIG5hbWUgd2l0aCAtLWluLXBsYWNlLgorIyBWZXJpZnkgdGhhdCAiLSIgaXMg dHJlYXRlZCBhcyBhIGZpbGUgbmFtZSB3aXRoIC0taW4tcGxhY2UuCgogIyBDb3B5cmlnaHQgKEMp IDIwMTUtMjAxNiBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KCkBAIC0xOCwxMiArMTgs MTMgQEAKIC4gIiR7c3JjZGlyPS59L2luaXQuc2giOyBwYXRoX3ByZXBlbmRfIC4uL3NlZAogcHJp bnRfdmVyXyBzZWQKCi1lY2hvICJzZWQ6IGNvdWxkbid0IGVkaXQgLTogaXMgYSB0ZXJtaW5hbCIg PiBleHAtZXJyIHx8IGZyYW1ld29ya19mYWlsdXJlXworZWNobyBhYmMgPiAuLy0gfHwgZnJhbWV3 b3JrX2ZhaWx1cmVfCitlY2hvIGFYYyA+IGV4cC1vdXQgfHwgZnJhbWV3b3JrX2ZhaWx1cmVfCgog ZmFpbD0wCi1zZWQgLWkgJ3MvYS9iLycgLSA+IG91dCAyPiBlcnIgJiYgZmFpbD0xCitzZWQgLWkg J3MvYi9YLycgLSA+IG91dCAyPiBlcnIgfHwgZmFpbD0xCgotY29tcGFyZSAvZGV2L251bGwgb3V0 IHx8IGZhaWw9MQotY29tcGFyZSBleHAtZXJyIGVyciB8fCBmYWlsPTEKK2NvbXBhcmUgZXhwLW91 dCAuLy0gfHwgZmFpbD0xCitjb21wYXJlIC9kZXYvbnVsbCBlcnIgfHwgZmFpbD0xCgogRXhpdCAk ZmFpbAotLSAKMi42LjIKCg== --001a113fee44f3ff3b052865903c-- From unknown Sun Aug 10 07:38:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stephane Chazelas Subject: bug#21249: closed (Re: bug#21249: "sed -i '...' -" in git head) Message-ID: References: <20150813141526.GA4313@chaz.gmail.com> X-Gnu-PR-Message: they-closed 21249 X-Gnu-PR-Package: sed Reply-To: 21249@debbugs.gnu.org Date: Sun, 03 Jan 2016 18:55:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1451847301-11674-1" This is a multi-part message in MIME format... ------------=_1451847301-11674-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #21249: "sed -i '...' -" in git head which was filed against the sed package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 21249@debbugs.gnu.org. --=20 21249: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21249 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1451847301-11674-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 21249-done) by debbugs.gnu.org; 3 Jan 2016 18:54:19 +0000 Received: from localhost ([127.0.0.1]:36883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFnnG-00031H-Vv for submit@debbugs.gnu.org; Sun, 03 Jan 2016 13:54:19 -0500 Received: from mail-ig0-f170.google.com ([209.85.213.170]:38129) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFnnF-000314-Vt for 21249-done@debbugs.gnu.org; Sun, 03 Jan 2016 13:54:18 -0500 Received: by mail-ig0-f170.google.com with SMTP id mw1so93864949igb.1 for <21249-done@debbugs.gnu.org>; Sun, 03 Jan 2016 10:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=TPHRYpNrJJ7Aa5VdG7vuh1qaV3GiKndSwYXQtpd8EMo=; b=tz9qGEo1MmdixiFEdgpMzzXINSJAYKoNpu2Jo1TDn5o+RhbA/DfaOtAInzqHaNz1FQ qIJfah7WaZqk+dLaSUt6Wn60A3bv2Hr64aGe7zIWDKLT12MQp8QtIKzoiY22Rj717kkU rqrzcyX5ALIXIsTqi/7D8miD7odZ5wDULlH+EDEj08/7kiBJswfT8PGdz/5bdMlI0ASt 68JnNjRhsGonHAT2dwVgsOcaz3bO4GGup5UQOrlNXJ95U/pYzvQ0Q76xaB1TSUtPQz9A AIMfW17TxeXlve7ZRhsa7IuOQlRaPlAMVsb01V97ySa83HYhiC0vYUm9QcJLog3cS7sQ n1Lg== X-Received: by 10.50.150.5 with SMTP id ue5mr64870460igb.50.1451847252402; Sun, 03 Jan 2016 10:54:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.36.10.18 with HTTP; Sun, 3 Jan 2016 10:53:52 -0800 (PST) In-Reply-To: References: <20150813141526.GA4313@chaz.gmail.com> From: Jim Meyering Date: Sun, 3 Jan 2016 10:53:52 -0800 X-Google-Sender-Auth: -IjLCMEkc-7zoH_uMV6IxABsdEU Message-ID: Subject: Re: bug#21249: "sed -i '...' -" in git head To: Stephane Chazelas Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 21249-done Cc: 21249-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sat, Jan 2, 2016 at 7:25 PM, Jim Meyering wrote: > On Thu, Aug 13, 2015 at 7:15 AM, Stephane Chazelas > wrote: >> Hello, >> >> about this commit: >> >>> commit c033bdee411128dfebfea1974d1ee3c1d9eac572 >>> Author: Jim Meyering >>> Date: Sat Jun 20 07:38:49 2015 -0700 >>> >>> sed -i: do not treat "-" as a file name >> >> the behaviour was aligned with perl's (where that syntax derives >> from). >> >> In perl, perl -pi -e 's/../../' -- * >> >> or perl -pi -e 's/../../' -- "$file" >> >> is known to be /reliable/ (work regardless of the value of $file >> (while without -i it's not, see >> https://unix.stackexchange.com/questions/170013/security-implications-of-running-perl-ne >> (-, cmd|, > >> That was also /safe/ in sed before that change. Treating "-" as >> stdin with -i doesn't make sense as it doesn't make sense to >> edit stdin "in-place". >> >> Now that means it breaks scripts that do: >> sed -i '...' -- "$file" >> expecting it modify $file regardless of the name of $file. Now, >> one has to do: >> >> case $file in >> -) file=./- >> esac >> sed -i '...' -- "$file" >> >> for no good reason. >> >> IMO, that change only has negative consequences. > > Thank you for the report and good argument. > I plan to revert that change with the attached patch: Pushed. ------------=_1451847301-11674-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Aug 2015 14:15:45 +0000 Received: from localhost ([127.0.0.1]:55082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPtIH-0005HV-FQ for submit@debbugs.gnu.org; Thu, 13 Aug 2015 10:15:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57747) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPtIE-0005HK-98 for submit@debbugs.gnu.org; Thu, 13 Aug 2015 10:15:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPtIA-0001D8-9d for submit@debbugs.gnu.org; Thu, 13 Aug 2015 10:15:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPtI9-0001Cv-MO for submit@debbugs.gnu.org; Thu, 13 Aug 2015 10:15:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPtI5-0008Tf-K3 for bug-sed@gnu.org; Thu, 13 Aug 2015 10:15:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPtI1-00011L-Ak for bug-sed@gnu.org; Thu, 13 Aug 2015 10:15:33 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:35685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPtI1-0000y9-3k for bug-sed@gnu.org; Thu, 13 Aug 2015 10:15:29 -0400 Received: by wicne3 with SMTP id ne3so141688786wic.0 for ; Thu, 13 Aug 2015 07:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=F6pJn2/GYpFgTBAT/qeMxWRjKx6UDDzDSbiSnJv7QuA=; b=Hbn4b/wPSXeiVpGqVsJLb7+jcFB6f4hnUoKuuO7Q02D5SpkCNx+luzedJP6s8qSI70 v0cEVVi1gz/eG+opi3ycgicYBUSenaSGKszLMUzhm+3zEc8+L0GQf1Vn9bgffLW/R66t kyRTheQG2SN32tQzYP1jO3KIIqCZBPXZliLQkeKuZycTaGtrFhpiEPCC/z8bfHBWAIZk gft5lgkRmyxaSsntlX4Rtj+Ybu2tPjsbcpP1Co+gwTMQu0jvJTXJTBbYjK7jumDK+34A 3hhKBsmDg1dPErpZOibnPiXdtd98Z5Zz28SWa1eFRsWV6uV6AOoeClF4nBSgzCAH1oJT bLOQ== X-Received: by 10.194.94.73 with SMTP id da9mr21231563wjb.97.1439475327627; Thu, 13 Aug 2015 07:15:27 -0700 (PDT) Received: from chaz.gmail.com (05448dab.skybroadband.com. [5.68.141.171]) by smtp.gmail.com with ESMTPSA id lq9sm3590330wjb.35.2015.08.13.07.15.26 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 13 Aug 2015 07:15:26 -0700 (PDT) Date: Thu, 13 Aug 2015 15:15:26 +0100 From: Stephane Chazelas To: bug-sed@gnu.org, Jim Meyering Subject: "sed -i '...' -" in git head Message-ID: <20150813141526.GA4313@chaz.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, about this commit: > commit c033bdee411128dfebfea1974d1ee3c1d9eac572 > Author: Jim Meyering > Date: Sat Jun 20 07:38:49 2015 -0700 > > sed -i: do not treat "-" as a file name the behaviour was aligned with perl's (where that syntax derives from). In perl, perl -pi -e 's/../../' -- * or perl -pi -e 's/../../' -- "$file" is known to be /reliable/ (work regardless of the value of $file (while without -i it's not, see https://unix.stackexchange.com/questions/170013/security-implications-of-running-perl-ne (-, cmd|,