From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 04:17:16 2015 Received: (at submit) by debbugs.gnu.org; 12 Aug 2015 08:17:16 +0000 Received: from localhost ([127.0.0.1]:53840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPRDm-0001Vm-QV for submit@debbugs.gnu.org; Wed, 12 Aug 2015 04:17:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38406) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPRDi-0001Vb-9I for submit@debbugs.gnu.org; Wed, 12 Aug 2015 04:17:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPRDe-0001ip-SB for submit@debbugs.gnu.org; Wed, 12 Aug 2015 04:17:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPRDe-0001ij-OB for submit@debbugs.gnu.org; Wed, 12 Aug 2015 04:17:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPRDb-00059L-If for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2015 04:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPRDW-0001h1-EV for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2015 04:17:03 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPRDW-0001gu-A9 for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2015 04:16:58 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id F231221756 for ; Wed, 12 Aug 2015 04:16:57 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Wed, 12 Aug 2015 04:16:57 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=CQ S4Ku9jHFKhrAaTyEdnAf1jjT0=; b=u3NmhjI9nqPAvQ+zp+gTnRFYrmcnis6dJU hXA/tTn0db3yCJe87Kv9xu9B1Rdwzww0y+1A7KXaGcGZ9lVWjubZMlxhPR8poCGP z+V4jRVLkLq4tdSLkifGXZvergTiXkhtWV9KqlOiWH72gVnYbvUSG+Jr3DZu/fPJ N/sLVNQVQ= X-Sasl-enc: JDrZlZjyFlgJQDvsCxvQF8t8CHrxDLDCt75S8rQd2yHx 1439367417 Received: from thinkpad-t440p (unknown [2.163.35.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 22F8E680147 for ; Wed, 12 Aug 2015 04:16:57 -0400 (EDT) From: Tassilo Horn To: bug-gnu-emacs@gnu.org Subject: 25.0.50; gfilenotify doesn't indicate when limits are reached Date: Wed, 12 Aug 2015 10:16:54 +0200 Message-ID: <878u9gly4p.fsf@gnu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) When acquiring many file/directory watches using file-notify-add-watch with file-notify--library being gfilenotify, there's no indication when the limit of watches a user is allowed to place is reached. You still get a valid descriptor but the provided callback function won't be called when the watched file/directory changes. I've looked at the code and saw that with inotify you'd get an error. Apparently, gfilenotify (aka glib) also uses inotify on my GNU/Linux box under the hoods. At least increasing the inotify limit for user watches made it work again. I tried looking at the GFileMonitor API docs. It seems that g_file_monitor should return NULL on errors (and I'd count a reached limit an error), and the fourth parameter should be initialized with the error. Emacs calls it with no error parameter: monitor = g_file_monitor (gfile, gflags, NULL, NULL); So I've tried the following: --8<---------------cut here---------------start------------->8--- diff --git a/src/gfilenotify.c b/src/gfilenotify.c index 08713a8..2ad2110 100644 --- a/src/gfilenotify.c +++ b/src/gfilenotify.c @@ -172,8 +172,9 @@ will be reported only in case of the 'moved' event. */) gflags |= G_FILE_MONITOR_SEND_MOVED; /* Enable watch. */ - monitor = g_file_monitor (gfile, gflags, NULL, NULL); - if (! monitor) + GError *err = NULL; + monitor = g_file_monitor (gfile, gflags, NULL, &err); + if (! monitor || err != NULL) xsignal2 (Qfile_notify_error, build_string ("Cannot watch file"), file); Lisp_Object watch_descriptor = make_pointer_integer (monitor); --8<---------------cut here---------------end--------------->8--- Unfortunately, the err variable won't be set in case the limit is reached, too. So it seems that we can't do much from Emacs land and this should be reported as a glib bug (which I'll do). Well, one thing we could do was preferring plain inotify over glib's GFileMonitor when both are available. On my GNU/Linux box both are available and configure chose gfilenotify as the default. In GNU Emacs 25.0.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6) of 2015-08-12 on thinkpad-t440p Repository revision: 197f280042a4d901ea94acdf10f1dc544fae4750 Windowing system distributor `The X.Org Foundation', version 11.0.11702000 System Description: Arch Linux Configured using: `configure 'CFLAGS=-g -ggdb3 -O1'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LC_MONETARY: de_DE.utf8 value of $LC_NUMERIC: de_DE.utf8 value of $LC_TIME: de_DE.utf8 value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix Major mode: Group Minor modes in effect: rcirc-track-minor-mode: t hl-line-mode: t gnus-topic-mode: t global-company-mode: t global-aggressive-indent-mode: t gnus-undo-mode: t pdf-occur-global-minor-mode: t recentf-mode: t global-undo-tree-mode: t global-subword-mode: t subword-mode: t save-place-mode: t savehist-mode: t show-paren-mode: t ivy-mode: t minibuffer-depth-indicate-mode: t diff-auto-refine-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t electric-pair-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent messages: 20150812T095021.253> Reading active file via nndraft... 20150812T095021.254> Reading active file via nndraft...done 20150812T095021.254> Reading active file from archive+nnml+archive:sent-postings via nnml... 20150812T095021.254> Opening nnml server on archive+nnml+archive:sent-postings... 20150812T095021.255> Opening nnml server on archive+nnml+archive:sent-postings...done 20150812T095021.255> nnml: Reading incoming mail (no new mail)...done 20150812T095021.255> Reading active file from archive+nnml+archive:sent-postings via nnml... 20150812T095021.256> Reading active file from archive+nnml+archive:sent-postings via nnml...done 20150812T095021.256> Checking new news...done 20150812T095021.257> No news is good news Load-path shadows: ~/Repos/el/auctex/lpath hides ~/Repos/el/gnus/lisp/lpath ~/Repos/el/highlight-symbol.el/highlight-symbol hides /home/horn/.emacs.d/elpa/highlight-symbol-20150805.806/highlight-symbol ~/Repos/el/gnus/lisp/md4 hides /home/horn/Repos/el/emacs/lisp/md4 ~/Repos/el/gnus/lisp/color hides /home/horn/Repos/el/emacs/lisp/color ~/Repos/el/gnus/lisp/format-spec hides /home/horn/Repos/el/emacs/lisp/format-spec ~/Repos/el/gnus/lisp/password-cache hides /home/horn/Repos/el/emacs/lisp/password-cache ~/Repos/el/gnus/lisp/hex-util hides /home/horn/Repos/el/emacs/lisp/hex-util ~/Repos/el/gnus/lisp/dns-mode hides /home/horn/Repos/el/emacs/lisp/textmodes/dns-mode ~/Repos/el/gnus/lisp/dig hides /home/horn/Repos/el/emacs/lisp/net/dig ~/Repos/el/gnus/lisp/hmac-md5 hides /home/horn/Repos/el/emacs/lisp/net/hmac-md5 ~/Repos/el/gnus/lisp/ntlm hides /home/horn/Repos/el/emacs/lisp/net/ntlm ~/Repos/el/gnus/lisp/hmac-def hides /home/horn/Repos/el/emacs/lisp/net/hmac-def ~/Repos/el/gnus/lisp/rfc2104 hides /home/horn/Repos/el/emacs/lisp/net/rfc2104 ~/Repos/el/gnus/lisp/sasl-ntlm hides /home/horn/Repos/el/emacs/lisp/net/sasl-ntlm ~/Repos/el/gnus/lisp/sasl-cram hides /home/horn/Repos/el/emacs/lisp/net/sasl-cram ~/Repos/el/gnus/lisp/dns hides /home/horn/Repos/el/emacs/lisp/net/dns ~/Repos/el/gnus/lisp/sasl hides /home/horn/Repos/el/emacs/lisp/net/sasl ~/Repos/el/gnus/lisp/tls hides /home/horn/Repos/el/emacs/lisp/net/tls ~/Repos/el/gnus/lisp/sasl-scram-rfc hides /home/horn/Repos/el/emacs/lisp/net/sasl-scram-rfc ~/Repos/el/gnus/lisp/netrc hides /home/horn/Repos/el/emacs/lisp/net/netrc ~/Repos/el/gnus/lisp/sasl-digest hides /home/horn/Repos/el/emacs/lisp/net/sasl-digest ~/Repos/el/gnus/lisp/uudecode hides /home/horn/Repos/el/emacs/lisp/mail/uudecode ~/Repos/el/gnus/lisp/binhex hides /home/horn/Repos/el/emacs/lisp/mail/binhex ~/Repos/el/gnus/lisp/hashcash hides /home/horn/Repos/el/emacs/lisp/mail/hashcash ~/Repos/el/gnus/lisp/canlock hides /home/horn/Repos/el/emacs/lisp/gnus/canlock ~/Repos/el/gnus/lisp/nneething hides /home/horn/Repos/el/emacs/lisp/gnus/nneething ~/Repos/el/gnus/lisp/mm-encode hides /home/horn/Repos/el/emacs/lisp/gnus/mm-encode ~/Repos/el/gnus/lisp/mm-util hides /home/horn/Repos/el/emacs/lisp/gnus/mm-util ~/Repos/el/gnus/lisp/rfc2047 hides /home/horn/Repos/el/emacs/lisp/gnus/rfc2047 ~/Repos/el/gnus/lisp/nnml hides /home/horn/Repos/el/emacs/lisp/gnus/nnml ~/Repos/el/gnus/lisp/gnus-cus hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-cus ~/Repos/el/gnus/lisp/gnus-range hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-range ~/Repos/el/gnus/lisp/gnus-int hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-int ~/Repos/el/gnus/lisp/gnus-cloud hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-cloud ~/Repos/el/gnus/lisp/spam-stat hides /home/horn/Repos/el/emacs/lisp/gnus/spam-stat ~/Repos/el/gnus/lisp/nnmh hides /home/horn/Repos/el/emacs/lisp/gnus/nnmh ~/Repos/el/gnus/lisp/gnus-mlspl hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-mlspl ~/Repos/el/gnus/lisp/deuglify hides /home/horn/Repos/el/emacs/lisp/gnus/deuglify ~/Repos/el/gnus/lisp/gnus-gravatar hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-gravatar ~/Repos/el/gnus/lisp/nngateway hides /home/horn/Repos/el/emacs/lisp/gnus/nngateway ~/Repos/el/gnus/lisp/ietf-drums hides /home/horn/Repos/el/emacs/lisp/gnus/ietf-drums ~/Repos/el/gnus/lisp/mail-parse hides /home/horn/Repos/el/emacs/lisp/gnus/mail-parse ~/Repos/el/gnus/lisp/gnus-salt hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-salt ~/Repos/el/gnus/lisp/nnimap hides /home/horn/Repos/el/emacs/lisp/gnus/nnimap ~/Repos/el/gnus/lisp/gnus-draft hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-draft ~/Repos/el/gnus/lisp/mail-source hides /home/horn/Repos/el/emacs/lisp/gnus/mail-source ~/Repos/el/gnus/lisp/messcompat hides /home/horn/Repos/el/emacs/lisp/gnus/messcompat ~/Repos/el/gnus/lisp/pop3 hides /home/horn/Repos/el/emacs/lisp/gnus/pop3 ~/Repos/el/gnus/lisp/nnmaildir hides /home/horn/Repos/el/emacs/lisp/gnus/nnmaildir ~/Repos/el/gnus/lisp/nnheader hides /home/horn/Repos/el/emacs/lisp/gnus/nnheader ~/Repos/el/gnus/lisp/gnus-cite hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-cite ~/Repos/el/gnus/lisp/nndiary hides /home/horn/Repos/el/emacs/lisp/gnus/nndiary ~/Repos/el/gnus/lisp/gnus-diary hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-diary ~/Repos/el/gnus/lisp/nnfolder hides /home/horn/Repos/el/emacs/lisp/gnus/nnfolder ~/Repos/el/gnus/lisp/gnus-art hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-art ~/Repos/el/gnus/lisp/gnus-demon hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-demon ~/Repos/el/gnus/lisp/mml-sec hides /home/horn/Repos/el/emacs/lisp/gnus/mml-sec ~/Repos/el/gnus/lisp/nnir hides /home/horn/Repos/el/emacs/lisp/gnus/nnir ~/Repos/el/gnus/lisp/mm-partial hides /home/horn/Repos/el/emacs/lisp/gnus/mm-partial ~/Repos/el/gnus/lisp/gnus-registry hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-registry ~/Repos/el/gnus/lisp/gnus-icalendar hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-icalendar ~/Repos/el/gnus/lisp/compface hides /home/horn/Repos/el/emacs/lisp/gnus/compface ~/Repos/el/gnus/lisp/gnus-fun hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-fun ~/Repos/el/gnus/lisp/gnus-start hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-start ~/Repos/el/gnus/lisp/smiley hides /home/horn/Repos/el/emacs/lisp/gnus/smiley ~/Repos/el/gnus/lisp/gnus-picon hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-picon ~/Repos/el/gnus/lisp/spam-report hides /home/horn/Repos/el/emacs/lisp/gnus/spam-report ~/Repos/el/gnus/lisp/nntp hides /home/horn/Repos/el/emacs/lisp/gnus/nntp ~/Repos/el/gnus/lisp/nnnil hides /home/horn/Repos/el/emacs/lisp/gnus/nnnil ~/Repos/el/gnus/lisp/nndir hides /home/horn/Repos/el/emacs/lisp/gnus/nndir ~/Repos/el/gnus/lisp/gnus-srvr hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-srvr ~/Repos/el/gnus/lisp/smime hides /home/horn/Repos/el/emacs/lisp/gnus/smime ~/Repos/el/gnus/lisp/nnvirtual hides /home/horn/Repos/el/emacs/lisp/gnus/nnvirtual ~/Repos/el/gnus/lisp/gnus-notifications hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-notifications ~/Repos/el/gnus/lisp/nnspool hides /home/horn/Repos/el/emacs/lisp/gnus/nnspool ~/Repos/el/gnus/lisp/gnus-group hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-group ~/Repos/el/gnus/lisp/gnus-bcklg hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-bcklg ~/Repos/el/gnus/lisp/gnus-util hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-util ~/Repos/el/gnus/lisp/gnus-sieve hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-sieve ~/Repos/el/gnus/lisp/nndraft hides /home/horn/Repos/el/emacs/lisp/gnus/nndraft ~/Repos/el/gnus/lisp/nnagent hides /home/horn/Repos/el/emacs/lisp/gnus/nnagent ~/Repos/el/gnus/lisp/gnus-spec hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-spec ~/Repos/el/gnus/lisp/gnus-bookmark hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-bookmark ~/Repos/el/gnus/lisp/mml1991 hides /home/horn/Repos/el/emacs/lisp/gnus/mml1991 ~/Repos/el/gnus/lisp/rfc2231 hides /home/horn/Repos/el/emacs/lisp/gnus/rfc2231 ~/Repos/el/gnus/lisp/yenc hides /home/horn/Repos/el/emacs/lisp/gnus/yenc ~/Repos/el/gnus/lisp/gnus-undo hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-undo ~/Repos/el/gnus/lisp/ecomplete hides /home/horn/Repos/el/emacs/lisp/gnus/ecomplete ~/Repos/el/gnus/lisp/legacy-gnus-agent hides /home/horn/Repos/el/emacs/lisp/gnus/legacy-gnus-agent ~/Repos/el/gnus/lisp/utf7 hides /home/horn/Repos/el/emacs/lisp/gnus/utf7 ~/Repos/el/gnus/lisp/rtree hides /home/horn/Repos/el/emacs/lisp/gnus/rtree ~/Repos/el/gnus/lisp/gnus-uu hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-uu ~/Repos/el/gnus/lisp/gnus-ml hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-ml ~/Repos/el/gnus/lisp/sieve hides /home/horn/Repos/el/emacs/lisp/gnus/sieve ~/Repos/el/gnus/lisp/gnus hides /home/horn/Repos/el/emacs/lisp/gnus/gnus ~/Repos/el/gnus/lisp/mml hides /home/horn/Repos/el/emacs/lisp/gnus/mml ~/Repos/el/gnus/lisp/message hides /home/horn/Repos/el/emacs/lisp/gnus/message ~/Repos/el/gnus/lisp/mml-smime hides /home/horn/Repos/el/emacs/lisp/gnus/mml-smime ~/Repos/el/gnus/lisp/gnus-eform hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-eform ~/Repos/el/gnus/lisp/gnus-agent hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-agent ~/Repos/el/gnus/lisp/gnus-logic hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-logic ~/Repos/el/gnus/lisp/mm-extern hides /home/horn/Repos/el/emacs/lisp/gnus/mm-extern ~/Repos/el/gnus/lisp/nndoc hides /home/horn/Repos/el/emacs/lisp/gnus/nndoc ~/Repos/el/gnus/lisp/sieve-manage hides /home/horn/Repos/el/emacs/lisp/gnus/sieve-manage ~/Repos/el/gnus/lisp/mm-decode hides /home/horn/Repos/el/emacs/lisp/gnus/mm-decode ~/Repos/el/gnus/lisp/starttls hides /home/horn/Repos/el/emacs/lisp/gnus/starttls ~/Repos/el/gnus/lisp/gnus-dired hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-dired ~/Repos/el/gnus/lisp/nnbabyl hides /home/horn/Repos/el/emacs/lisp/gnus/nnbabyl ~/Repos/el/gnus/lisp/nnmbox hides /home/horn/Repos/el/emacs/lisp/gnus/nnmbox ~/Repos/el/gnus/lisp/gnus-win hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-win ~/Repos/el/gnus/lisp/gnus-async hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-async ~/Repos/el/gnus/lisp/mm-url hides /home/horn/Repos/el/emacs/lisp/gnus/mm-url ~/Repos/el/gnus/lisp/gnus-html hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-html ~/Repos/el/gnus/lisp/gssapi hides /home/horn/Repos/el/emacs/lisp/gnus/gssapi ~/Repos/el/gnus/lisp/mml2015 hides /home/horn/Repos/el/emacs/lisp/gnus/mml2015 ~/Repos/el/gnus/lisp/nnrss hides /home/horn/Repos/el/emacs/lisp/gnus/nnrss ~/Repos/el/gnus/lisp/gnus-mh hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-mh ~/Repos/el/gnus/lisp/gnus-sum hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-sum ~/Repos/el/gnus/lisp/nnweb hides /home/horn/Repos/el/emacs/lisp/gnus/nnweb ~/Repos/el/gnus/lisp/mail-prsvr hides /home/horn/Repos/el/emacs/lisp/gnus/mail-prsvr ~/Repos/el/gnus/lisp/nnmairix hides /home/horn/Repos/el/emacs/lisp/gnus/nnmairix ~/Repos/el/gnus/lisp/plstore hides /home/horn/Repos/el/emacs/lisp/gnus/plstore ~/Repos/el/gnus/lisp/rfc2045 hides /home/horn/Repos/el/emacs/lisp/gnus/rfc2045 ~/Repos/el/gnus/lisp/gnus-msg hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-msg ~/Repos/el/gnus/lisp/spam-wash hides /home/horn/Repos/el/emacs/lisp/gnus/spam-wash ~/Repos/el/gnus/lisp/gnus-score hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-score ~/Repos/el/gnus/lisp/mm-uu hides /home/horn/Repos/el/emacs/lisp/gnus/mm-uu ~/Repos/el/gnus/lisp/spam hides /home/horn/Repos/el/emacs/lisp/gnus/spam ~/Repos/el/gnus/lisp/mm-view hides /home/horn/Repos/el/emacs/lisp/gnus/mm-view ~/Repos/el/gnus/lisp/sieve-mode hides /home/horn/Repos/el/emacs/lisp/gnus/sieve-mode ~/Repos/el/gnus/lisp/html2text hides /home/horn/Repos/el/emacs/lisp/gnus/html2text ~/Repos/el/gnus/lisp/gnus-ems hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-ems ~/Repos/el/gnus/lisp/registry hides /home/horn/Repos/el/emacs/lisp/gnus/registry ~/Repos/el/gnus/lisp/auth-source hides /home/horn/Repos/el/emacs/lisp/gnus/auth-source ~/Repos/el/gnus/lisp/gravatar hides /home/horn/Repos/el/emacs/lisp/gnus/gravatar ~/Repos/el/gnus/lisp/flow-fill hides /home/horn/Repos/el/emacs/lisp/gnus/flow-fill ~/Repos/el/gnus/lisp/gmm-utils hides /home/horn/Repos/el/emacs/lisp/gnus/gmm-utils ~/Repos/el/gnus/lisp/mailcap hides /home/horn/Repos/el/emacs/lisp/gnus/mailcap ~/Repos/el/gnus/lisp/gnus-delay hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-delay ~/Repos/el/gnus/lisp/mm-bodies hides /home/horn/Repos/el/emacs/lisp/gnus/mm-bodies ~/Repos/el/gnus/lisp/mm-archive hides /home/horn/Repos/el/emacs/lisp/gnus/mm-archive ~/Repos/el/gnus/lisp/rfc1843 hides /home/horn/Repos/el/emacs/lisp/gnus/rfc1843 ~/Repos/el/gnus/lisp/gnus-kill hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-kill ~/Repos/el/gnus/lisp/qp hides /home/horn/Repos/el/emacs/lisp/gnus/qp ~/Repos/el/gnus/lisp/score-mode hides /home/horn/Repos/el/emacs/lisp/gnus/score-mode ~/Repos/el/gnus/lisp/gnus-topic hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-topic ~/Repos/el/gnus/lisp/gnus-cache hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-cache ~/Repos/el/gnus/lisp/nnmail hides /home/horn/Repos/el/emacs/lisp/gnus/nnmail ~/Repos/el/gnus/lisp/gnus-vm hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-vm ~/Repos/el/gnus/lisp/gnus-sync hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-sync ~/Repos/el/gnus/lisp/nnoo hides /home/horn/Repos/el/emacs/lisp/gnus/nnoo ~/Repos/el/gnus/lisp/nnregistry hides /home/horn/Repos/el/emacs/lisp/gnus/nnregistry ~/Repos/el/gnus/lisp/gnus-dup hides /home/horn/Repos/el/emacs/lisp/gnus/gnus-dup ~/Repos/el/gnus/lisp/parse-time hides /home/horn/Repos/el/emacs/lisp/calendar/parse-time ~/Repos/el/gnus/lisp/time-date hides /home/horn/Repos/el/emacs/lisp/calendar/time-date Features: (shadow emacsbug sendmail browse-url hippie-exp eieio-opt speedbar sb-image ezimage dframe linum flow-fill misearch multi-isearch vc vc-dispatcher vc-git url-http url-gw url-auth sort gnus-cite mm-archive gnus-async gnus-bcklg qp gnus-ml smiley rcirc-color rcirc-controls rcirc-late-fix rcirc hl-line nndraft nnmh rot13 utf-7 gnutls network-stream nsm starttls nnml nnnil gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-cache gnus-demon nntp spam spam-stat gnus-uu yenc gnus-msg gnus-gravatar mail-extr gravatar gnus-topic nnir gnus-registry registry eieio-compat eieio-base th-private colir color smex ido company-files company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb company stratego-mode greql-mode tg-mode generic preview-latex tex-site auto-loads cider cider-debug cider-browse-ns cider-inspector cider-mode cider-repl cider-eldoc cider-interaction arc-mode archive-mode cider-overlays cider-doc org-table org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs cider-test cider-stacktrace cider-client nrepl-client queue cider-util ewoc etags xref project clojure-mode paredit aggressive-indent epa-file epa epg rdictcc google-contacts-message google-contacts derived xml url-cache google-oauth google-contacts-gnus gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source tls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems gnus-compat url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap nnheader dired-x em-term term ehelp esh-opt esh-ext esh-util highlight-symbol thingatpt boxquote rect ecomplete yasnippet disp-table noutline outline pdf-occur ibuf-ext ibuffer tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet pdf-isearch let-alist pdf-misc imenu pdf-tools compile cus-edit cus-start cus-load pdf-view bookmark pp jka-compr pdf-cache pdf-info tq pdf-util image-mode browse-kill-ring recentf tree-widget wid-edit highlight-parentheses cl undo-tree diff iedit iedit-lib hydra lv counsel swiper cap-words superword subword saveplace savehist paren ivy delsel icomplete mb-depth ace-window avy magit-filenotify filenotify magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode diff-mode magit-core magit-process magit-popup magit-mode magit-git crm magit-section magit-utils git-commit log-edit easy-mmode message dired rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async tramp-sh tramp tramp-compat auth-source eieio byte-opt bytecomp byte-compile cl-extra seq cconv eieio-core cl-macs gv gnus-util mm-util help-fns help-mode mail-prsvr password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color ring format-spec server dash smart-mode-line-respectful-theme smart-mode-line-light-theme cl-seq smart-mode-line rich-minority rx bs elec-pair edmacro kmacro cl-loaddefs cl-lib gnus-load subr-x pcase tsdh-light-theme finder-inf memory-usage-autoloads advice info package easymenu epg-config time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 2203543 130351) (symbols 48 58842 76) (miscs 40 808 1443) (strings 32 181035 59773) (string-bytes 1 6176131) (vectors 16 61077) (vector-slots 8 1970775 197250) (floats 8 963 1376) (intervals 56 18899 3078) (buffers 976 73) (heap 1024 134316 38901)) From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 04:34:55 2015 Received: (at 21241) by debbugs.gnu.org; 12 Aug 2015 08:34:55 +0000 Received: from localhost ([127.0.0.1]:53845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPRUt-0001w5-1l for submit@debbugs.gnu.org; Wed, 12 Aug 2015 04:34:55 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50998) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPRUp-0001vv-Um for 21241@debbugs.gnu.org; Wed, 12 Aug 2015 04:34:53 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AD88F20D66 for <21241@debbugs.gnu.org>; Wed, 12 Aug 2015 04:34:49 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Wed, 12 Aug 2015 04:34:49 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=vF4GtnmXkpRRyhYi1N/QIutrE8M=; b=kd8P5 z4wuF/c+ikmYOMOZhlbOOsBnPgtZnDdeHInMWpU0cG6/Gbr2grANtSBhKIMoPx6w Kn9VULVUOkEOGZ/xKAsr1Xs7BKb6d6PMFoUEcPFole1iWQUEBAocXhpCLA16Q2QG UJuvoKD7AKFNsMgFtOS1vOOaxcz8ER7MQx49HU= X-Sasl-enc: 2h1KaSqBxxtBCoo4yKgtyOK4OJEzBFRY8S2F9uktTQ9M 1439368488 Received: from thinkpad-t440p (unknown [2.163.35.251]) by mail.messagingengine.com (Postfix) with ESMTPA id B19D06800FF for <21241@debbugs.gnu.org>; Wed, 12 Aug 2015 04:34:48 -0400 (EDT) From: Tassilo Horn To: 21241@debbugs.gnu.org Subject: Re: 25.0.50; gfilenotify doesn't indicate when limits are reached References: <878u9gly4p.fsf@gnu.org> Date: Wed, 12 Aug 2015 10:34:45 +0200 In-Reply-To: (GNU bug Tracking System's message of "Wed, 12 Aug 2015 08:18:02 +0000") Message-ID: <871tf8lxay.fsf_-_@gnu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21241 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Here's the glib bug report I've just filed for this issue: https://bugzilla.gnome.org/show_bug.cgi?id=753549 Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 08:47:47 2015 Received: (at 21241) by debbugs.gnu.org; 12 Aug 2015 12:47:47 +0000 Received: from localhost ([127.0.0.1]:53940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPVRb-0002MS-6Y for submit@debbugs.gnu.org; Wed, 12 Aug 2015 08:47:47 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:47105) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPVRY-0002MI-3H for 21241@debbugs.gnu.org; Wed, 12 Aug 2015 08:47:44 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NSY00200Z97JH00@mtaout27.012.net.il> for 21241@debbugs.gnu.org; Wed, 12 Aug 2015 15:44:21 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NSY00IBZZDXD5B0@mtaout27.012.net.il>; Wed, 12 Aug 2015 15:44:21 +0300 (IDT) Date: Wed, 12 Aug 2015 15:47:00 +0300 From: Eli Zaretskii Subject: Re: bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached In-reply-to: <878u9gly4p.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: Tassilo Horn Message-id: <831tf8ptbv.fsf@gnu.org> References: <878u9gly4p.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21241 Cc: 21241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Tassilo Horn > Date: Wed, 12 Aug 2015 10:16:54 +0200 > > Well, one thing we could do was preferring plain inotify over glib's > GFileMonitor when both are available. On my GNU/Linux box both are > available and configure chose gfilenotify as the default. I wonder if we should revert our decision to prefer gfilenotify if available, and instead use it only if there's no other supported method. It begins to sound more and more like gfilenotify is more trouble than it's worth. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 09:27:37 2015 Received: (at 21241) by debbugs.gnu.org; 12 Aug 2015 13:27:37 +0000 Received: from localhost ([127.0.0.1]:53946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPW47-0003Fo-Me for submit@debbugs.gnu.org; Wed, 12 Aug 2015 09:27:36 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43673) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPW42-0003Fc-MF for 21241@debbugs.gnu.org; Wed, 12 Aug 2015 09:27:31 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3510322784 for <21241@debbugs.gnu.org>; Wed, 12 Aug 2015 09:27:30 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Wed, 12 Aug 2015 09:27:30 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=kLgpzszNYqij6CfwCOi4i6E5Mq0=; b=TvFIS kWLzNcQlheJtTwXexxq+5GfpFecJGXjOjifOr0VjsjjzhUOgtcB2JZN2XJw3BmaN EITiv2NKfIkFGkVeUlHtOJim+O8+nB+HnzTe6PBFBRnpXolSiX8qNOcHZJeqecGr 3R9h4K1QBQuElJWsK2jIM2uUeU8Lf9egV/Kxcg= X-Sasl-enc: lZu9XbPH0ignuGpeU/8Cbfkrlo99eyAzvwYUhw79BfRx 1439386049 Received: from thinkpad-t440p (unknown [2.163.35.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F9AA6800FF; Wed, 12 Aug 2015 09:27:29 -0400 (EDT) From: Tassilo Horn To: Eli Zaretskii Subject: Re: bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached References: <878u9gly4p.fsf@gnu.org> <831tf8ptbv.fsf@gnu.org> Date: Wed, 12 Aug 2015 15:27:26 +0200 In-Reply-To: <831tf8ptbv.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Aug 2015 15:47:00 +0300") Message-ID: <87tws4k56p.fsf_-_@gnu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 21241 Cc: 21241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Eli Zaretskii writes: >> Well, one thing we could do was preferring plain inotify over glib's >> GFileMonitor when both are available. On my GNU/Linux box both are >> available and configure chose gfilenotify as the default. > > I wonder if we should revert our decision to prefer gfilenotify if > available, and instead use it only if there's no other supported > method. It begins to sound more and more like gfilenotify is more > trouble than it's worth. You mean the other emacs-devel thread where it has been reported that gfile notifications might get delayed up to 30 seconds? I haven't seen that issue here but if it can happen and gfilenotify doesn't provide some clear benefit over plain inotify, I'd suggest to use the latter by default when it's available. Well, at least it seems that THIS issue is considered to be a bug also by one glib developer so chances are good that it'll be fixed eventually. But of course it may take some time until a fixed version is distributed to all users and until then users will have to learn the hard way why notifications don't work [1]. Bye, Tassilo [1] I've been working on magit-filenotify.el which automatically refreshes the magit status buffer when something in the git repository changes, and at some point it just didn't work anymore (no notifications) for repositories I've started working on later while it still worked for those I've had opened earlier. Well, that way I've at least learned about inotify limits and how to change them... :-) From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 10:17:25 2015 Received: (at 21241) by debbugs.gnu.org; 12 Aug 2015 14:17:25 +0000 Received: from localhost ([127.0.0.1]:54258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPWqL-0004QU-3Z for submit@debbugs.gnu.org; Wed, 12 Aug 2015 10:17:25 -0400 Received: from mtaout26.012.net.il ([80.179.55.182]:45764) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPWqH-0004QK-Vz for 21241@debbugs.gnu.org; Wed, 12 Aug 2015 10:17:23 -0400 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NSZ00K003NZ7Z00@mtaout26.012.net.il> for 21241@debbugs.gnu.org; Wed, 12 Aug 2015 17:19:53 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NSZ00BGT3T5O4C0@mtaout26.012.net.il>; Wed, 12 Aug 2015 17:19:53 +0300 (IDT) Date: Wed, 12 Aug 2015 17:16:12 +0300 From: Eli Zaretskii Subject: Re: bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached In-reply-to: <87tws4k56p.fsf_-_@gnu.org> X-012-Sender: halo1@inter.net.il To: Tassilo Horn Message-id: <83zj1woamr.fsf@gnu.org> References: <878u9gly4p.fsf@gnu.org> <831tf8ptbv.fsf@gnu.org> <87tws4k56p.fsf_-_@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 21241 Cc: 21241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Tassilo Horn > Cc: 21241@debbugs.gnu.org > Date: Wed, 12 Aug 2015 15:27:26 +0200 > > Eli Zaretskii writes: > > >> Well, one thing we could do was preferring plain inotify over glib's > >> GFileMonitor when both are available. On my GNU/Linux box both are > >> available and configure chose gfilenotify as the default. > > > > I wonder if we should revert our decision to prefer gfilenotify if > > available, and instead use it only if there's no other supported > > method. It begins to sound more and more like gfilenotify is more > > trouble than it's worth. > > You mean the other emacs-devel thread where it has been reported that > gfile notifications might get delayed up to 30 seconds? That, and this bug, and also the fact that it simply doesn't work on Windows (no notifications come in), although the corresponding glib tests all pass. There's also bug#20417, and I think someone also complained about gfilenotify on OS X. > Well, at least it seems that THIS issue is considered to be a bug also > by one glib developer so chances are good that it'll be fixed > eventually. Let's hope it will be. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 15:18:50 2015 Received: (at 21241) by debbugs.gnu.org; 12 Aug 2015 19:18:50 +0000 Received: from localhost ([127.0.0.1]:54389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPbY2-0006HF-BF for submit@debbugs.gnu.org; Wed, 12 Aug 2015 15:18:50 -0400 Received: from mout.gmx.net ([212.227.15.19]:49962) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPbY0-0006H7-2A for 21241@debbugs.gnu.org; Wed, 12 Aug 2015 15:18:48 -0400 Received: from detlef.gmx.de ([87.146.56.254]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Lz4KW-1YlxMU3u8u-014Enr; Wed, 12 Aug 2015 21:18:47 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached References: <878u9gly4p.fsf@gnu.org> <831tf8ptbv.fsf@gnu.org> <87tws4k56p.fsf_-_@gnu.org> <83zj1woamr.fsf@gnu.org> Date: Wed, 12 Aug 2015 21:18:45 +0200 In-Reply-To: <83zj1woamr.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Aug 2015 17:16:12 +0300") Message-ID: <87mvxw48oa.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:R+CsqT1G64RXphRDpYNtG7B5xgqI7Ktl6fkH7t+HMf2WQ2JwmP+ /RiOYvE++I/aFVUaa7sx9mL5kivyBYb0ecT+AkgXwczvnkq1e/XpaA0/+fp+ztS2qSdWu1s WjqFPF32/MDlCv9LBE7KlcMsXtN7tN/ZZ3CrHy9ytJvnIW7rp/GztTWSEYsdRGBvCAxiQYE zbIbKYFzeFGOgXkB1m7pw== X-UI-Out-Filterresults: notjunk:1;V01:K0:8yt+uKUxrtc=:Ah1nataiQKVECp3Vt36PmK 86UFgIvnGnTXfF107oXzGNWAEYDEdQh3UJW4rzhCg1DsI9dFicyH+iD4+KG5QPg641VwsH+o0 aKgxKNLSWyZFSO4uOuZo/T1EhDKA628Ok3rypizFkrGu+YpEwhKv7Wmkcw8y3hqLiI+dX7O4F e2rkmC1zSqarzBVt4bkTc9ssKukthP4SLDxVMpJx7DQ3Bl1d/Ke3kG3P2p/0hvvprRDPys5Ai ATLTOAXmrle2cdwqMMYXM0xXbU5Cgw/m9yxnoigVPPIvxQT+hrAcpZ2s85xiD2mepACkZJwQi xqRTaBGyTTZ7KuztthFhLfrM9pSFu8HzWlJK5XZkmL4EGXju3xxuH5IKyj8iqC8Ds1IEo6iga es9U/koDc+O35FrrpG8+Gck2JSsLXi5U3ieXTK4pGKa64tXJMp3RxMhZIoesSQlnXMKBX2ggq 4VP+VnKmbsTn8govxjRFWy5IaP4AVoPUwpIFZAXhL6TZwUWeEHVaxolNu0Ro6L1ZPrZANZww0 equc5asyt57kuYSHBbvRB68kuNy5o16U8tAQSXP9MO7rtWF7BSa+sPGzxkIqbaYWHdeMTRI72 +rUiiKzKYzMRfj9uAnZGj/wIiR/ZcKAHF6OLjhsV5/KONylRJbQREwiZc5zOrnJWQTXMbqQ0D ATu/y3ZmH83M2jnMgW6LfZW1BBbkF9qIkSprh59m6BBEZTX29B8s0dpLN65Hi7CZZMpKSJkYu 5eivuIraoXK3kfEp/myT/aoqVwlS6/ja8Iq9JA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21241 Cc: 21241@debbugs.gnu.org, Tassilo Horn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> > I wonder if we should revert our decision to prefer gfilenotify if >> > available, and instead use it only if there's no other supported >> > method. It begins to sound more and more like gfilenotify is more >> > trouble than it's worth. >> >> You mean the other emacs-devel thread where it has been reported that >> gfile notifications might get delayed up to 30 seconds? > > That, and this bug, and also the fact that it simply doesn't work on > Windows (no notifications come in), although the corresponding glib > tests all pass. There's also bug#20417, and I think someone also > complained about gfilenotify on OS X. I would also agree to favor inotify when available. On OS X (better: on systems which have defined HAVE_NS), we should disable gfilenotify, because the Glib main loop won't be used (ns_select is used rather than xg_select). Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 21:27:46 2015 Received: (at 21241) by debbugs.gnu.org; 15 Aug 2015 01:27:46 +0000 Received: from localhost ([127.0.0.1]:56149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZQQGA-0006IP-26 for submit@debbugs.gnu.org; Fri, 14 Aug 2015 21:27:46 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34441) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZQQG7-0006IH-J2 for 21241@debbugs.gnu.org; Fri, 14 Aug 2015 21:27:44 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F40F3160D55; Fri, 14 Aug 2015 18:27:42 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id pIwCc4jSAYqb; Fri, 14 Aug 2015 18:27:40 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 02A98160D56; Fri, 14 Aug 2015 18:27:40 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uCS5QDe9YMXf; Fri, 14 Aug 2015 18:27:39 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CB27B160D3C; Fri, 14 Aug 2015 18:27:39 -0700 (PDT) Message-ID: <55CE958B.1000006@cs.ucla.edu> Date: Fri, 14 Aug 2015 18:27:39 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Michael Albinus Subject: Re: 25.0.50; gfilenotify doesn't indicate when limits are reached Content-Type: multipart/mixed; boundary="------------070602040900090903000506" X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 21241 Cc: Eli Zaretskii , 21241@debbugs.gnu.org, Tassilo Horn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------070602040900090903000506 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Michael Albinus writes: > I would also agree to favor inotify when available. Let's give that a try, then. I installed the attached patch as master commit 200c2b10faf298bf65e8b6dbd0cb9ef00b2f95d6. > On OS X (better: on systems which have defined HAVE_NS), we should > disable gfilenotify, because the Glib main loop won't be used (ns_select > is used rather than xg_select). configure.ac was trying to do that, but there was a typo. Should also be fixed in the attached patch. --------------070602040900090903000506 Content-Type: text/x-diff; name="0001-Default-to-inotify-instead-of-gfile.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Default-to-inotify-instead-of-gfile.patch" >From 3f9999c2c0b0eb96c7e7e83fd5dd97da4ca301d1 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 14 Aug 2015 18:20:35 -0700 Subject: [PATCH] Default to inotify instead of gfile * configure.ac (with_file_notification): Fix typo that prevented suppression of file notification if HAVE_NS. (NOTIFY_OBJ): Prefer inotify to gfile if both exist and with_file_notification is 'yes' (Bug#21241). * etc/NEWS: Mention this. --- configure.ac | 34 ++++++++++++++++------------------ etc/NEWS | 4 ++++ 2 files changed, 20 insertions(+), 18 deletions(-) diff --git a/configure.ac b/configure.ac index 16d4484..9f8089f 100644 --- a/configure.ac +++ b/configure.ac @@ -365,7 +365,7 @@ AC_ARG_WITH([file-notification],[AS_HELP_STRING([--with-file-notification=LIB], * ) AC_MSG_ERROR(['--with-file-notification=$withval' is invalid; this option's value should be 'yes', 'no', 'gfile', 'inotify' or 'w32'. 'yes' is a synonym for 'w32' on MS-Windows, for 'no' on Nextstep, -otherwise for the first of 'gfile' or 'inotify' that is usable.]) +otherwise for the first of 'inotify' or 'gfile' that is usable.]) ;; esac with_file_notification=$val @@ -2674,7 +2674,7 @@ NOTIFY_SUMMARY=no dnl FIXME? Don't auto-detect on NS, but do allow someone to specify dnl a particular library. This doesn't make much sense? -if test "${HAVE_ns}" = yes && test ${with_file_notification} = yes; then +if test "${HAVE_NS}" = yes && test ${with_file_notification} = yes; then with_file_notification=no fi @@ -2694,22 +2694,7 @@ case $with_file_notification,$opsys in fi ;; esac -dnl g_file_monitor exists since glib 2.18. G_FILE_MONITOR_EVENT_MOVED -dnl has been added in glib 2.24. It has been tested under -dnl GNU/Linux only. We take precedence over inotify, but this makes -dnl only sense when glib has been compiled with inotify support. How -dnl to check? -case $with_file_notification,$NOTIFY_OBJ in - gfile, | yes,) - EMACS_CHECK_MODULES([GFILENOTIFY], [gio-2.0 >= 2.24]) - if test "$HAVE_GFILENOTIFY" = "yes"; then - AC_DEFINE(HAVE_GFILENOTIFY, 1, [Define to 1 if using GFile.]) - NOTIFY_OBJ=gfilenotify.o - NOTIFY_SUMMARY="yes -lgio (gfile)" - fi ;; -esac - -dnl inotify is only available on GNU/Linux. +dnl inotify is available only on GNU/Linux. case $with_file_notification,$NOTIFY_OBJ in inotify, | yes,) AC_CHECK_HEADER(sys/inotify.h) @@ -2723,6 +2708,19 @@ case $with_file_notification,$NOTIFY_OBJ in fi ;; esac +dnl g_file_monitor exists since glib 2.18. G_FILE_MONITOR_EVENT_MOVED +dnl has been added in glib 2.24. It has been tested under +dnl GNU/Linux only. +case $with_file_notification,$NOTIFY_OBJ in + gfile,* | yes,) + EMACS_CHECK_MODULES([GFILENOTIFY], [gio-2.0 >= 2.24]) + if test "$HAVE_GFILENOTIFY" = "yes"; then + AC_DEFINE(HAVE_GFILENOTIFY, 1, [Define to 1 if using GFile.]) + NOTIFY_OBJ=gfilenotify.o + NOTIFY_SUMMARY="yes -lgio (gfile)" + fi ;; +esac + case $with_file_notification,$NOTIFY_OBJ in yes,* | no,* | *,?*) ;; *) AC_MSG_ERROR([File notification '$with_file_notification' requested but requirements not found.]) ;; diff --git a/etc/NEWS b/etc/NEWS index f131981..bbcdc0c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -43,6 +43,10 @@ or by sticking with Emacs 24.4. If gnustep-config is not available, the old heuristics are used. --- +** 'configure' now prefers inotify to gfile for file notification, +unless gfile is explicitly requested via --with-file-notification='gfile'. + +--- ** The configure option '--with-pkg-config-prog' has been removed. Use './configure PKG_CONFIG=/full/name/of/pkg-config' if you need to. -- 2.1.0 --------------070602040900090903000506-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 10:34:00 2015 Received: (at 21241) by debbugs.gnu.org; 18 Aug 2015 14:34:00 +0000 Received: from localhost ([127.0.0.1]:59104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZRhxg-0001Cl-9K for submit@debbugs.gnu.org; Tue, 18 Aug 2015 10:34:00 -0400 Received: from deliver.uni-koblenz.de ([141.26.64.15]:54512) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZRhxd-0001Cc-Q6 for 21241@debbugs.gnu.org; Tue, 18 Aug 2015 10:33:58 -0400 Received: from thinkpad-t440p (dhcp163.uni-koblenz.de [141.26.71.163]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 1DD6E3D6005; Tue, 18 Aug 2015 16:33:57 +0200 (CEST) From: Tassilo Horn To: Paul Eggert Subject: Re: bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached References: <878u9gly4p.fsf@gnu.org> <55CE958B.1000006@cs.ucla.edu> Date: Tue, 18 Aug 2015 16:33:56 +0200 In-Reply-To: <55CE958B.1000006@cs.ucla.edu> (Paul Eggert's message of "Fri, 14 Aug 2015 18:27:39 -0700") Message-ID: <87614c1x9n.fsf@gnu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 21241 Cc: Michael Albinus , 21241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Paul Eggert writes: >> I would also agree to favor inotify when available. > > Let's give that a try, then. I installed the attached patch as master > commit 200c2b10faf298bf65e8b6dbd0cb9ef00b2f95d6. FWIW, all my file-notification needs are still satisfied with inotify as `file-notify--library', and now I also get an error when I run out of allowed used watches. So from my side, feel free to close this report as gfilenotify's broken behavior is glib's bug, not ours. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 13:09:08 2015 Received: (at 21241-done) by debbugs.gnu.org; 18 Aug 2015 17:09:08 +0000 Received: from localhost ([127.0.0.1]:59173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZRkNo-0006TN-Bo for submit@debbugs.gnu.org; Tue, 18 Aug 2015 13:09:08 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45986) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZRkNl-0006TF-VB for 21241-done@debbugs.gnu.org; Tue, 18 Aug 2015 13:09:06 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D5B3D160D94; Tue, 18 Aug 2015 10:09:04 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rXgBRZoNBr_R; Tue, 18 Aug 2015 10:09:04 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 08E1D160D93; Tue, 18 Aug 2015 10:09:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4ycUl6hjuNpD; Tue, 18 Aug 2015 10:09:03 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BAF29160D66; Tue, 18 Aug 2015 10:09:03 -0700 (PDT) Message-ID: <55D366AF.3000905@cs.ucla.edu> Date: Tue, 18 Aug 2015 10:09:03 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Tassilo Horn Subject: Re: bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached References: <878u9gly4p.fsf@gnu.org> <55CE958B.1000006@cs.ucla.edu> <87614c1x9n.fsf@gnu.org> In-Reply-To: <87614c1x9n.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 21241-done Cc: Michael Albinus , 21241-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Tassilo Horn wrote: > So from my side, feel free to close this report > as gfilenotify's broken behavior is glib's bug, not ours. Thanks for checking; closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 21 05:46:33 2015 Received: (at 21241) by debbugs.gnu.org; 21 Aug 2015 09:46:33 +0000 Received: from localhost ([127.0.0.1]:34156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSiu8-0001lW-Gz for submit@debbugs.gnu.org; Fri, 21 Aug 2015 05:46:32 -0400 Received: from mout.gmx.net ([212.227.15.19]:64849) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSiu7-0001lM-1Y for 21241@debbugs.gnu.org; Fri, 21 Aug 2015 05:46:31 -0400 Received: from detlef.gmx.de ([93.209.79.105]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LcSAg-1Z0VPv0xVu-00jt7M; Fri, 21 Aug 2015 11:46:29 +0200 From: Michael Albinus To: Tassilo Horn Subject: Re: bug#21241: 25.0.50; gfilenotify doesn't indicate when limits are reached References: <878u9gly4p.fsf@gnu.org> Date: Fri, 21 Aug 2015 11:46:28 +0200 In-Reply-To: <878u9gly4p.fsf@gnu.org> (Tassilo Horn's message of "Wed, 12 Aug 2015 10:16:54 +0200") Message-ID: <87a8tlm0sr.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:4DG3kYIKpzFth5Zsvwwlcd3KkNEFCLHFU8kS/SuKjST1n1aBxBy UdKxtSqvhHzxvS8G1ZYgoB5FTyBQUbXB3Au2Fp9PNB7NQkTkv2pYv6EnmNSXxDMwQfUla+u Mb0mC+tRqNnoK2xhJXFpu1fIb9KJxRZpMH+TI9W9lAbHy/XV5w46lkdKN5njwCgMD1wBV6N a0+lbJALwqXee3v2lVCzQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:tKgsxDChnDo=:74V5LWab7WJYl5+88FkvWY x7oDm6GZVfwc+VLHpjgRMsYW/wuMo9dV5D2zP/8+rKD6yYzoJgMyGZBSxhx664cGcYee6hpfw t/UXphf1dnxMOv2Vj8KzvjZWdOXM2dyOjFKLIWyaQ56xzxQXd9vfUIDM+x9vR0/jlLpBOLhDr NH7XlD4l5Dx9kcbr6hp4SOim3SoBTVBpwIuXUF9TyKwS7CCOyxK9UGEm9DoT5xsiWDJWH8zHN DLE26SXVWxyuAlrnGMmCn9Vp9Scpl/Z8vt+AoF2NXG/5Tlqb66rZHtnDqiYsjjInGIKXik0nj rGDZctoIMPVB+5w6aQDCD9kcrZVjTRAeMJkJQCkJ6cstYDvUD+da4YQm4tl/abfP2WM//HBAA 5nBJRWOPW82pzN3jGZdWez4dzNZHloEagkqdmRGRhbMcXgatqRDFH7c3hCyE7y/G1QY1qRxnc OCZBoVoHv2X7lBuehn25jPs0ulvx/umcoFCAtBs/pOeBPtfQOvUJbq3u12zr3j5fdHbieEQea W7g6iVYo1ZyE3aWC4+4W2kZbenqMJkSgz/1Kf+jJuYqbCeMoM+l8I1WN/VQtBJMjK07rxYwk4 QpgLdZLGP7YZHviShcPVSZngyv2s0YcDNNNpu5/ijGA8+hxUJc0PDwCbZl16YLWwQrLJgOJty nhHD7JaNZigPJbJTaAD0sU6oGkqkj20BntfqPxYXBDokyEwgmrHG0MxyUcazzMWxqlHMOvabZ FIotXZq4khejC4X0HQnJXaARzBBP8JXOtK087w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21241 Cc: 21241@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Tassilo Horn writes: > So I've tried the following: > > diff --git a/src/gfilenotify.c b/src/gfilenotify.c > index 08713a8..2ad2110 100644 > --- a/src/gfilenotify.c > +++ b/src/gfilenotify.c > @@ -172,8 +172,9 @@ will be reported only in case of the 'moved' event. */) > gflags |= G_FILE_MONITOR_SEND_MOVED; > > /* Enable watch. */ > - monitor = g_file_monitor (gfile, gflags, NULL, NULL); > - if (! monitor) > + GError *err = NULL; > + monitor = g_file_monitor (gfile, gflags, NULL, &err); > + if (! monitor || err != NULL) > xsignal2 (Qfile_notify_error, build_string ("Cannot watch file"), file); > > Lisp_Object watch_descriptor = make_pointer_integer (monitor); For the records, I've committed a modified version of this patch. It returns the error message from g_file_monitor, if present. Best regards, Michael. From unknown Sun Jun 22 22:45:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Sep 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator