From unknown Sun Jun 22 11:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Aug 2015 19:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21201@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: bruce.connor.am@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.143889046129026 (code B ref -1); Thu, 06 Aug 2015 19:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Aug 2015 19:47:41 +0000 Received: from localhost ([127.0.0.1]:41422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNR8f-0007Y6-Hx for submit@debbugs.gnu.org; Thu, 06 Aug 2015 15:47:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35433) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNR8d-0007Xy-99 for submit@debbugs.gnu.org; Thu, 06 Aug 2015 15:47:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNR8c-00011u-34 for submit@debbugs.gnu.org; Thu, 06 Aug 2015 15:47:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNR8c-00011q-0Y for submit@debbugs.gnu.org; Thu, 06 Aug 2015 15:47:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNR8b-0006bt-3M for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2015 15:47:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNR8a-00011c-7x for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2015 15:47:37 -0400 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:34149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNR8Z-00011W-VM for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2015 15:47:36 -0400 Received: by labow3 with SMTP id ow3so55825097lab.1 for ; Thu, 06 Aug 2015 12:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:date:message-id:subject:from:to :content-type; bh=+FdlEa6jdTicC9FNPFK/fDgxNcuNfZz+iGVCVmelEFI=; b=qtF1S2X49t+cIjJQg1IeJ0cM14YWgNOvWvTOOYrahAfSSQgBRqnkD1m3nS6+Iw8po4 aidLmvBjEWLBf1RBTsV8pLl7xzo1R8a3avt+JMQxB6RB6ufAiaKRniFv4F/ZlHFLRoXQ HNCw55vvH2/KeYB6Dvg9a29bSsM10u6o03zp4yWWINRsPP/IccG58Iu6YMZQ8ROFKe9E TODzXKeDGjvS2o8Xdym/MfWS8Gma0sZ5uvORTgPINZifezDydS7KVvlZjQWRlctUyBcE q1arR89H5sF6pogYcEgtlE/CbPuDyFmk+ZAUqr8IeKdQlH6ePLYgQa2P9Ct6ao70ht2k BBMQ== MIME-Version: 1.0 X-Received: by 10.112.210.137 with SMTP id mu9mr3938115lbc.95.1438890454101; Thu, 06 Aug 2015 12:47:34 -0700 (PDT) Received: by 10.25.134.139 with HTTP; Thu, 6 Aug 2015 12:47:34 -0700 (PDT) Date: Thu, 6 Aug 2015 20:47:34 +0100 X-Google-Sender-Auth: PQumtTqm1-PNAtdmiRWo8hUCchw Message-ID: From: Artur Malabarba Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) >From emacs -Q, run the following: (cl-letf (((buffer-modified-p))) (insert "ookok")) You'll get an error from trying to set a nil buffer. Using `(buffer-modified-p (current-buffer))' instead works. Backtrace: Debugger entered--Lisp error: (wrong-type-argument stringp nil) set-buffer(nil) (save-current-buffer (set-buffer nil) (set-buffer-modified-p old)) (unwind-protect (insert "ookok") (save-current-buffer (set-buffer nil) (set-buffer-modified-p old))) (let* ((old (buffer-modified-p))) (unwind-protect (insert "ookok") (save-current-buffer (set-buffer nil) (set-buffer-modified-p old)))) eval((let* ((old (buffer-modified-p))) (unwind-protect (insert "ookok") (save-current-buffer (set-buffer nil) (set-buffer-modified-p old)))) nil) elisp--eval-last-sexp(nil) eval-last-sexp(nil) funcall-interactively(eval-last-sexp nil) call-interactively(eval-last-sexp nil nil) command-execute(eval-last-sexp) From unknown Sun Jun 22 11:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Aug 2015 20:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Artur Malabarba Cc: 21201@debbugs.gnu.org Received: via spool by 21201-submit@debbugs.gnu.org id=B21201.143889164030772 (code B ref 21201); Thu, 06 Aug 2015 20:08:02 +0000 Received: (at 21201) by debbugs.gnu.org; 6 Aug 2015 20:07:20 +0000 Received: from localhost ([127.0.0.1]:41433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNRRg-00080G-04 for submit@debbugs.gnu.org; Thu, 06 Aug 2015 16:07:20 -0400 Received: from mxin.ulb.ac.be ([164.15.128.112]:36964) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNRRd-000805-Fb for 21201@debbugs.gnu.org; Thu, 06 Aug 2015 16:07:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag0FAM69w1WkD4Xx/2dsb2JhbABbgkmCD4JVpxEGmzECghQBAQEBAQGBC4QkAQEDASdSBQsIAw4TJQ8BBA08E4gZAwoIyQ4NhSwBAQEBAQUBAQEBHoYfhTCCT4I6B4QsAQSHHIU1iDCKbIo7iW6HMSaDfzwxAYJLAQEB Received: from mathsrv4.ulb.ac.be (HELO localhost) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 06 Aug 2015 22:07:15 +0200 From: Nicolas Richard References: Date: Thu, 06 Aug 2015 22:07:13 +0200 In-Reply-To: (Artur Malabarba's message of "Thu, 6 Aug 2015 20:47:34 +0100") Message-ID: <87lhdo41vy.fsf@members.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Artur Malabarba writes: > From emacs -Q, run the following: > > (cl-letf (((buffer-modified-p))) > (insert "ookok")) > > You'll get an error from trying to set a nil buffer. Here is a fix: --8<---------------cut here---------------start------------->8--- modified lisp/emacs-lisp/cl-lib.el @@ -634,8 +634,10 @@ If ALIST is non-nil, the new pairs are prepended to it." ;; Some more Emacs-related place types. (gv-define-simple-setter buffer-file-name set-visited-file-name t) (gv-define-setter buffer-modified-p (flag &optional buf) - `(with-current-buffer ,buf - (set-buffer-modified-p ,flag))) + (if buf + `(with-current-buffer ,buf + (set-buffer-modified-p ,flag)) + `(set-buffer-modified-p ,flag))) (gv-define-simple-setter buffer-name rename-buffer t) (gv-define-setter buffer-string (store) `(insert (prog1 ,store (erase-buffer)))) --8<---------------cut here---------------end--------------->8--- -- Nico From unknown Sun Jun 22 11:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Aug 2015 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicolas Richard Cc: 21201@debbugs.gnu.org Reply-To: bruce.connor.am@gmail.com Received: via spool by 21201-submit@debbugs.gnu.org id=B21201.14388974976931 (code B ref 21201); Thu, 06 Aug 2015 21:45:02 +0000 Received: (at 21201) by debbugs.gnu.org; 6 Aug 2015 21:44:57 +0000 Received: from localhost ([127.0.0.1]:41473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNSy8-0001ni-LO for submit@debbugs.gnu.org; Thu, 06 Aug 2015 17:44:56 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:35616) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNSy5-0001nZ-Uq for 21201@debbugs.gnu.org; Thu, 06 Aug 2015 17:44:54 -0400 Received: by lbbpo9 with SMTP id po9so50708409lbb.2 for <21201@debbugs.gnu.org>; Thu, 06 Aug 2015 14:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=IfP3isCrgoYqueGxO9F37oi6TTDFWI5uBxtr57A+K1w=; b=yhrPf9MFV3p8EPNDw56gPCrVrwzZPtFT0Cw8Gbj1jGQP9nUtxGJkTFFaKPwEZwft5F AcmPFqOEQyEDMQiN2n/xnDPb+VIYd63Lux7f773Ik3YdfTGCOTeffPPHI7QwQWFnbJ7/ oMvkoVleCkn107jHGepgD5+tSPXi33nuCeQYLvkz/3JugAcVH7mFd3fPUl6E/V7HLQ0a GQ+aY4UZUZ2HCDnPXunzsugILH8D1gkSPDJ1cucU7kU5rxnjb4xYKirIu5dydxNdbGeA RLirS91kFAT6NVFYTx6gd4F9m7AcgWbRir1br4GB+SRMt6NevBZTvBPJydn/Wli56HEr Sdcw== MIME-Version: 1.0 X-Received: by 10.112.145.169 with SMTP id sv9mr4419439lbb.73.1438897493009; Thu, 06 Aug 2015 14:44:53 -0700 (PDT) Received: by 10.25.134.139 with HTTP; Thu, 6 Aug 2015 14:44:52 -0700 (PDT) In-Reply-To: <87lhdo41vy.fsf@members.fsf.org> References: <87lhdo41vy.fsf@members.fsf.org> Date: Thu, 6 Aug 2015 22:44:52 +0100 X-Google-Sender-Auth: NVRv5NvJSo5ub6e6vfU52mjThGQ Message-ID: From: Artur Malabarba Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 2015-08-06 21:07 GMT+01:00 Nicolas Richard : > Artur Malabarba writes: > >> From emacs -Q, run the following: >> >> (cl-letf (((buffer-modified-p))) >> (insert "ookok")) >> >> You'll get an error from trying to set a nil buffer. > > Here is a fix: > --8<---------------cut here---------------start------------->8--- > modified lisp/emacs-lisp/cl-lib.el > @@ -634,8 +634,10 @@ If ALIST is non-nil, the new pairs are prepended to it." > ;; Some more Emacs-related place types. > (gv-define-simple-setter buffer-file-name set-visited-file-name t) > (gv-define-setter buffer-modified-p (flag &optional buf) > - `(with-current-buffer ,buf > - (set-buffer-modified-p ,flag))) > + (if buf > + `(with-current-buffer ,buf > + (set-buffer-modified-p ,flag)) > + `(set-buffer-modified-p ,flag))) Don't know if it's possible, but shouldn't it try to ensure that it's in the same buffer as before? From unknown Sun Jun 22 11:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Aug 2015 22:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Artur Malabarba Cc: 21201@debbugs.gnu.org Received: via spool by 21201-submit@debbugs.gnu.org id=B21201.143890145612632 (code B ref 21201); Thu, 06 Aug 2015 22:51:01 +0000 Received: (at 21201) by debbugs.gnu.org; 6 Aug 2015 22:50:56 +0000 Received: from localhost ([127.0.0.1]:41496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNU00-0003Hg-42 for submit@debbugs.gnu.org; Thu, 06 Aug 2015 18:50:56 -0400 Received: from nm15-vm5.bullet.mail.ir2.yahoo.com ([212.82.96.202]:47464) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZNTzx-0003HX-KR for 21201@debbugs.gnu.org; Thu, 06 Aug 2015 18:50:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1438901452; bh=ufy47Ixif4Kxc77vvJN/JOAhLy4XHhUfhEVhMT7U6Ro=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject; b=obA+CycWP2dr3TgfSeiF1laQuspOeN4b6MILjQNaOpEWd6eGxAb5tMmscOARYQ1xJakxDK/tsHXLHd25vTHleMvwgwD3kTOCDqPDz+7HRPsxtQcKwPhvdxRT5CXMItWNi2jekcqby6UoJCJgs1d7aKPGt44sY56CayqkkK6n71b/dOGzq+m2jwmLxrxJHiGROcm4J74FBErLkQxeY9J/OSv96hLkAyJo0gCGcivqKwh8Sp1VhWDAzryicZHtY3d/8Aj4VSX44HvTb8tpIYuCuNJ649gpxjenJxYhM5weV27cm+TuABoy2xwmjHW49RiZtba/AButborTF4UGQis16w== Received: from [212.82.98.48] by nm15.bullet.mail.ir2.yahoo.com with NNFMP; 06 Aug 2015 22:50:52 -0000 Received: from [46.228.39.85] by tm1.bullet.mail.ir2.yahoo.com with NNFMP; 06 Aug 2015 22:50:52 -0000 Received: from [127.0.0.1] by smtp122.mail.ir2.yahoo.com with NNFMP; 06 Aug 2015 22:50:52 -0000 X-Yahoo-Newman-Id: 465726.65484.bm@smtp122.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: PAgWexkVM1m8HVmzw.MZ4hKmH9kVaJodkQuE7z_Lpidr2_v BBS1TSLOrNQo.3BiYujfLu4bmR5.kel1J.3lOa2hGuZb06Wb5yeUdCrZmWVB e3VdlwMya_zZEiZsIgPxE.ssFNoM94TgHTMjJxstYTPeHf8WWrufCFRxjAq2 okYshd5v6_NokwHBp4JXp1eftVcUUoX0nJZdrnKTc5o6y909qdXyq7Yg8hp_ exv6i_3VNp.ggEXZ.OwO42j9KHxlQel4bDDIR.W4DaXE58uS880Eo3j3uj.. EON5QF1WR7dx3bP1Ryzf3sOZZ49MAvOXB..x._u37VHW3hd8hA5b7qp76K1L _tGBygnO8OEIsHgifUykMe17D0oa_PgKW9T_MI4bNruOZ2koXFT.U.Mv.9Fa 8qt4x78SUgQyFTkTGGM3AfZhiHq3NCX83vIn9RcQ2KT.BAtdx3i5XQPNpqtG Rohh6vwBl9AXejWJy3nun.iTEhdLO8Vt4FbJqM6vsxfgRZ2EET6oOZ6E.IPt dkFVqbnIRiZzBwtSb26qWLWRvtkufbjswa6tOmX7WC792xAHgr4HF3YcqES1 tasbB35MGVffWCToB X-Yahoo-SMTP: 62rWct2swBAqKO_y6KiyXe3pZRcxSSoYuFEwRLrH6M41hw-- From: Nicolas Richard In-Reply-To: (Artur Malabarba's message of "Thu, 6 Aug 2015 22:44:52 +0100") References: <87lhdo41vy.fsf@members.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Fri, 07 Aug 2015 00:50:45 +0200 Message-ID: <8637zwghfe.fsf@members.fsf.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Artur Malabarba writes: > 2015-08-06 21:07 GMT+01:00 Nicolas Richard : >> (gv-define-setter buffer-modified-p (flag &optional buf) >> - `(with-current-buffer ,buf >> - (set-buffer-modified-p ,flag))) >> + (if buf >> + `(with-current-buffer ,buf >> + (set-buffer-modified-p ,flag)) >> + `(set-buffer-modified-p ,flag))) > > Don't know if it's possible, but shouldn't it try to ensure that it's > in the same buffer as before? I agree with you, but I don't know how to do that. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 20 20:57:00 2017 Received: (at control) by debbugs.gnu.org; 21 Nov 2017 01:57:00 +0000 Received: from localhost ([127.0.0.1]:49700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGxo4-00035c-2G for submit@debbugs.gnu.org; Mon, 20 Nov 2017 20:57:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGxo3-00035P-3a for control@debbugs.gnu.org; Mon, 20 Nov 2017 20:56:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGxnx-0001zr-G7 for control@debbugs.gnu.org; Mon, 20 Nov 2017 20:56:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGxnx-0001zn-CG for control@debbugs.gnu.org; Mon, 20 Nov 2017 20:56:53 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eGxnx-0006Mj-3Q for control@debbugs.gnu.org; Mon, 20 Nov 2017 20:56:53 -0500 Subject: control message for bug 21201 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 20 Nov 2017 20:56:53 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 29371 21201 From unknown Sun Jun 22 11:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jul 2018 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicolas Richard Cc: 21201@debbugs.gnu.org, Artur Malabarba Received: via spool by 21201-submit@debbugs.gnu.org id=B21201.15318297791988 (code B ref 21201); Tue, 17 Jul 2018 12:17:02 +0000 Received: (at 21201) by debbugs.gnu.org; 17 Jul 2018 12:16:19 +0000 Received: from localhost ([127.0.0.1]:44543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffOtu-0000Vu-QB for submit@debbugs.gnu.org; Tue, 17 Jul 2018 08:16:19 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:36240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffOts-0000Va-R1; Tue, 17 Jul 2018 08:16:17 -0400 Received: by mail-it0-f42.google.com with SMTP id j185-v6so1544641ite.1; Tue, 17 Jul 2018 05:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qFKN96fCTEU8vWfrIMVm2ru3xanzHyFyFxm4W1iF/4A=; b=LX5Q0poL50VCiNSuA7NPFJb9qyNOd19P6+WGeyUdDkMQu7mqLiGdx9QpjfuPaAWqBj uV/qbTlqZzur+R3Bk0eGQ0qRliLD3Ni212B5m5+HxyKdGQkT5jGmdwUiXRFArua3FS0B 7A9mo2tKg9JZ29Y+Vq9zdbrEQ/L6zD4tfhp2NJIwn5TeNwN7hjknjHCVIQQTh6QOcjg7 oKdPdJRoDiXt/XvmVSo4E1gILOdvhB0PsFCHLE1GEQrqh0WzJzkEGB5njj3q8vrd1So7 hc4lmPpoKRWS4PxRl6dmVXssqc59byYj771RLmXvQQgnlIsCQy/fFx8BUIcFDLUC80sm 5zlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qFKN96fCTEU8vWfrIMVm2ru3xanzHyFyFxm4W1iF/4A=; b=b/mfX6xrt830mEu1a3Lkc1ZO4eGwN/WD9ztlhN8IKrwTWDBLJxBSFz7yTkpX75JEPK +YpJAEF2Ve3sGwbRlnbTPtR4HaqAGyCtlY1LvGmpzrOMcbYU2EpkBXXb7zIfJWuOk+Zb G717TucZx4TSeDdU4L6ivhWmd2UWl/+iZqNJsPsdiOPeD1UlZmnedm3++PqTEiJ8JrI4 GgESUxYwlmJ0vGRkK5JBBqMwe6nWV8CZOPXgOtd3NT4JUrGmw3WzaxekI7l4gcXDtq0d rJBO8YCRQAPuMI24AAmSgN36Tu96+TiwcrinC1tkqwluy+Fb9q+nHWYsXe4z+bMvmBOc 2bQA== X-Gm-Message-State: AOUpUlGQ8aOWAtVTw9UA/WbpfUw0Av4lvYrkgFKQtMHZ77b4tyFMrfgF WO6Jzi+SqvLdbbEPU7mP7jz/Fw== X-Google-Smtp-Source: AAOMgpdqcZAjQ3NLJAfXAj+l94vVC+VXQxqDEc5EYGYdhoCUttfLfSauKybZVBHNZx2wO1Iqqs+Kyg== X-Received: by 2002:a24:b34f:: with SMTP id z15-v6mr1329679iti.53.1531829771059; Tue, 17 Jul 2018 05:16:11 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 69-v6sm369378itk.3.2018.07.17.05.16.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jul 2018 05:16:10 -0700 (PDT) From: Noam Postavsky References: <87lhdo41vy.fsf@members.fsf.org> <8637zwghfe.fsf@members.fsf.org> Date: Tue, 17 Jul 2018 08:16:09 -0400 In-Reply-To: <8637zwghfe.fsf@members.fsf.org> (Nicolas Richard's message of "Fri, 07 Aug 2015 00:50:45 +0200") Message-ID: <87pnzm83cm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 21201 + patch quit Nicolas Richard writes: > Artur Malabarba writes: >> 2015-08-06 21:07 GMT+01:00 Nicolas Richard : >>> (gv-define-setter buffer-modified-p (flag &optional buf) >>> - `(with-current-buffer ,buf >>> - (set-buffer-modified-p ,flag))) >>> + (if buf >>> + `(with-current-buffer ,buf >>> + (set-buffer-modified-p ,flag)) >>> + `(set-buffer-modified-p ,flag))) >> >> Don't know if it's possible, but shouldn't it try to ensure that it's >> in the same buffer as before? > > I agree with you, but I don't know how to do that. This seems to work. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Allow-setf-of-buffer-modified-p-without-argument-Bug.patch Content-Description: patch >From 1481f8893ff04a83b578f403cd22c7bdd2ec65f0 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Mon, 16 Jul 2018 22:14:32 -0400 Subject: [PATCH] Allow setf of buffer-modified-p without argument (Bug#21201) * lisp/emacs-lisp/cl-lib.el (setf buffer-modified-p): Take current buffer if optional argument BUF is not passed. --- lisp/emacs-lisp/cl-lib.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el index 381784d1fd..ba5f9d64a1 100644 --- a/lisp/emacs-lisp/cl-lib.el +++ b/lisp/emacs-lisp/cl-lib.el @@ -521,8 +521,9 @@ cl-pairlis ;; Some more Emacs-related place types. (gv-define-simple-setter buffer-file-name set-visited-file-name t) (gv-define-setter buffer-modified-p (flag &optional buf) - `(with-current-buffer ,buf - (set-buffer-modified-p ,flag))) + (macroexp-let2 nil buffer `(or ,buf (current-buffer)) + `(with-current-buffer ,buffer + (set-buffer-modified-p ,flag)))) (gv-define-simple-setter buffer-name rename-buffer t) (gv-define-setter buffer-string (store) `(insert (prog1 ,store (erase-buffer)))) -- 2.11.0 --=-=-=-- From unknown Sun Jun 22 11:48:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Aug 2018 00:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Nicolas Richard Cc: 21201@debbugs.gnu.org, Artur Malabarba Received: via spool by 21201-submit@debbugs.gnu.org id=B21201.153541449631327 (code B ref 21201); Tue, 28 Aug 2018 00:02:02 +0000 Received: (at 21201) by debbugs.gnu.org; 28 Aug 2018 00:01:36 +0000 Received: from localhost ([127.0.0.1]:34603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuRRw-00088v-28 for submit@debbugs.gnu.org; Mon, 27 Aug 2018 20:01:36 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:40442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuRRu-00083s-OX; Mon, 27 Aug 2018 20:01:34 -0400 Received: by mail-it0-f43.google.com with SMTP id h23-v6so116124ita.5; Mon, 27 Aug 2018 17:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WL2hAqCTLbmIxD/Hd0w5YEpeBk1ru+vrWuCu3P8hcUI=; b=ugexWqk00Dwhzukq7mNi5foucDRJBEkum0YSLnbGAeRm+/sJWjS5JzxFb3mzkI/Cmb NMXXqIadcxS4Hbm+GYDueq5HhbckBe4utuKr9U1q7QU+WapDV6EEA8ciXPy5ZnTE+dRW LBy+FMU2NTgsaILUkL9wCyl5FQWtapSimpBBFLQZdkURNrVVT65dwyVHj1ftNRPy5q9B M229BV5vzzOFGsplVFtqF1Veewh3sbu+vXyXzy0SX6+UgE36qR1HaPjgHNsP+gWyx5xU LQ5AFth+TOUeUsTZBM4j6lL7PgkT52DhWmUHqQtOpt3M8d4TLLSI8vicd8VJBWKZF6wE P/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WL2hAqCTLbmIxD/Hd0w5YEpeBk1ru+vrWuCu3P8hcUI=; b=PVUluO2JUH9BZGDVNqUXisX+ybuyTtcbsm3lEzc1E1GpG29VQdEgN/m7eIA1MKYvBA cKlQY6/icderXpYdjAkRsS/2zMjvmkF8zxlbX6o5wy6lEDpvMwTaqdvuMOneTZPMoNjU 9itollLWY4qfW8jnDg1NcaV6fBP7L0yN8AYmHlEDwZtP1jF5aWoFckdF/3Lkl8Cu70Aj ATN7zptIbVGWkz7PIw7Yj53W3DWUTt0TgFAxt8I7B7GPLIR1FVgImv+oYEBIVvkw3jZm 3hjMJo+QFrIZCPezPAzzgVF2OGmq3XEVNNWwmYPYhVKHkXv9wLazxHR/Oy+jQdj5SjA2 QOlQ== X-Gm-Message-State: APzg51AJ0TF4lv2nyz0gFReIgzaXGK1WtxIRbcOqFmnY6kA1ccytH+fH kfvtlw5Z2cpSmGUV/7EmcPr8bgEC X-Google-Smtp-Source: ANB0VdYKTh7ZQVD1Scwy2I/Xhlh2lvccrEOSCGdI7IjXi9CLfe8cheeZmDFOLuWpN7tm7gX6OKlmlA== X-Received: by 2002:a02:5fcc:: with SMTP id x73-v6mr12803315jad.96.1535414488966; Mon, 27 Aug 2018 17:01:28 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e5-v6sm339170itf.0.2018.08.27.17.01.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Aug 2018 17:01:28 -0700 (PDT) From: Noam Postavsky References: <87lhdo41vy.fsf@members.fsf.org> <8637zwghfe.fsf@members.fsf.org> <87pnzm83cm.fsf@gmail.com> Date: Mon, 27 Aug 2018 20:01:26 -0400 In-Reply-To: <87pnzm83cm.fsf@gmail.com> (Noam Postavsky's message of "Tue, 17 Jul 2018 08:16:09 -0400") Message-ID: <87zhx7tl49.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 21201 fixed close 21201 27.1 quit Noam Postavsky writes: > (gv-define-setter buffer-modified-p (flag &optional buf) > - `(with-current-buffer ,buf > - (set-buffer-modified-p ,flag))) > + (macroexp-let2 nil buffer `(or ,buf (current-buffer)) > + `(with-current-buffer ,buffer > + (set-buffer-modified-p ,flag)))) Pushed to master. [1: c8b86362d4]: 2018-08-27 18:54:23 -0400 Allow setf of buffer-modified-p without argument (Bug#21201) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c8b86362d45a07e0aec0041cade551c3c663ea8c