From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 04 13:56:39 2015 Received: (at submit) by debbugs.gnu.org; 4 Aug 2015 17:56:39 +0000 Received: from localhost ([127.0.0.1]:39668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZMgS6-0000eB-Mk for submit@debbugs.gnu.org; Tue, 04 Aug 2015 13:56:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48656) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZMgS4-0000dy-1L for submit@debbugs.gnu.org; Tue, 04 Aug 2015 13:56:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMgS3-00043w-3n for submit@debbugs.gnu.org; Tue, 04 Aug 2015 13:56:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMgS3-00043r-1c for submit@debbugs.gnu.org; Tue, 04 Aug 2015 13:56:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMgS2-0000wf-7k for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2015 13:56:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMgRy-00043A-7W for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2015 13:56:34 -0400 Received: from plane.gmane.org ([80.91.229.3]:35819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMgRy-00042w-02 for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2015 13:56:30 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZMgRw-0008TG-Bp for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2015 19:56:28 +0200 Received: from interv03.i.subnet.rcn.com ([146.115.9.234]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 04 Aug 2015 19:56:28 +0200 Received: from flitterio by interv03.i.subnet.rcn.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 04 Aug 2015 19:56:28 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Fran Litterio Subject: erc-kill-channel-hook sometimes is not run during /QUIT Date: Tue, 4 Aug 2015 17:56:23 +0000 (UTC) Lines: 26 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 146.115.9.234 (Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.125 Safari/537.36) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Using Emacs built from the latest sources, when variable erc-kill-queries-on-quit is t (which causes ERC to kill channel buffers when quitting -- yes, the name is misleading), a /QUIT does not run the hooks on erc-kill-channel-hook, because erc-default-target returns nil due to the server being disconnected. This patch fixes that by falling back to examining the buffer name, which should be safe to do since we know the major mode is erc-mode. -- Fran flitterio gmail.com --- erc.el.orig 2015-08-04 13:38:04.602900800 -0400 +++ erc.el 2015-08-04 13:38:56.538768600 -0400 @@ -6698,7 +6698,7 @@ (cond ((eq (erc-server-buffer) (current-buffer)) (run-hooks 'erc-kill-server-hook)) - ((erc-channel-p (erc-default-target)) + ((erc-channel-p (or (erc-default-target) (buffer-name))) (run-hooks 'erc-kill-channel-hook)) (t (run-hooks 'erc-kill-buffer-hook))))) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 02:58:05 2015 Received: (at 21187) by debbugs.gnu.org; 27 Dec 2015 07:58:06 +0000 Received: from localhost ([127.0.0.1]:42377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aD6DN-0003TJ-OK for submit@debbugs.gnu.org; Sun, 27 Dec 2015 02:58:05 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:50294) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aD6DL-0003TA-R7 for 21187@debbugs.gnu.org; Sun, 27 Dec 2015 02:58:04 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aD6D0-0003gT-7K; Sun, 27 Dec 2015 08:57:42 +0100 From: Lars Ingebrigtsen To: Fran Litterio Subject: Re: bug#21187: erc-kill-channel-hook sometimes is not run during /QUIT References: Date: Sun, 27 Dec 2015 08:57:41 +0100 In-Reply-To: (Fran Litterio's message of "Tue, 4 Aug 2015 17:56:23 +0000 (UTC)") Message-ID: <87d1tsiaru.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aD6D0-0003gT-7K X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451807862.53135@bK9WJPAnTsMwe4uBkFtLmA X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21187 Cc: 21187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fran Litterio writes: > Using Emacs built from the latest sources, when variable > erc-kill-queries-on-quit is t (which causes ERC to kill channel > buffers when quitting -- yes, the name is misleading), a /QUIT > does not run the hooks on erc-kill-channel-hook, because > erc-default-target returns nil due to the server being > disconnected. > > This patch fixes that by falling back to examining the buffer > name, which should be safe to do since we know the major mode is > erc-mode. > -- > Fran > flitterio gmail.com > > --- erc.el.orig 2015-08-04 13:38:04.602900800 -0400 > +++ erc.el 2015-08-04 13:38:56.538768600 -0400 > @@ -6698,7 +6698,7 @@ > (cond > ((eq (erc-server-buffer) (current-buffer)) > (run-hooks 'erc-kill-server-hook)) > - ((erc-channel-p (erc-default-target)) > + ((erc-channel-p (or (erc-default-target) (buffer-name))) Thanks; applied to Emacs 25.1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 02:58:12 2015 Received: (at control) by debbugs.gnu.org; 27 Dec 2015 07:58:12 +0000 Received: from localhost ([127.0.0.1]:42380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aD6DT-0003Tb-VP for submit@debbugs.gnu.org; Sun, 27 Dec 2015 02:58:12 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:50304) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aD6DT-0003TU-9g for control@debbugs.gnu.org; Sun, 27 Dec 2015 02:58:11 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aD6D5-0003gc-BX for control@debbugs.gnu.org; Sun, 27 Dec 2015 08:57:47 +0100 Date: Sun, 27 Dec 2015 08:57:46 +0100 Message-Id: <87bn9ciarp.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #21187 X-MailScanner-ID: 1aD6D5-0003gc-BX X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451807867.96728@tL0wbKkR6i3BjUexf6vebQ X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 21187 fixed close 21187 25.1 From unknown Sun Jun 22 00:35:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 24 Jan 2016 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator