GNU bug report logs - #21152
emacs make system blocked if "Xft/DPI = -1" in xsettings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21152 in the body.
You can then email your comments to 21152 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xu Fasheng <fasheng.xu <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: emacs make system blocked if "Xft/DPI = -1" in xsettings
Date: Tue, 28 Jul 2015 13:58:28 +0800

Hi, everyone.

I found that emacs could not compute a right dpi value if "Xft/DPI =
-1" in xsettings. The document said "Xft/DPI" is an integer, and "-1"
is the default value [1].

And in the code of src/xsettings.c:parse_settings(), all the interger
value in xsettings are converted to CARD32(unsigned int). So if
Xft/DPI is "-1", emacs will convert it to uint(4294967295), and owns a
huge dpi(4294967295/1024=4194303). Its so huge that will make system
blocked.

Here is the code snippets in
emacs24-24.5+1/src/xsettings.c:parse_settings() from debian/sid:
    ....
    420: CARD32 vlen, ival = 0;
    ....
    544: else if (strcmp (name, "Xft/DPI") == 0)
    545:  {
    546:    settings->seen |= SEEN_DPI;
    547:    settings->dpi = (double)ival/1024.0;
    548:  }

[1] http://www.freedesktop.org/wiki/Specifications/XSettingsRegistry/

Message #8 received at 21152 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Xu Fasheng <fasheng.xu <at> gmail.com>
Cc: 21152 <at> debbugs.gnu.org
Subject: Re:  emacs make system blocked if "Xft/DPI = -1" in xsettings
Date: Sat, 08 Aug 2015 22:10:40 -0700

[Message part 1 (text/plain, inline)]

Thanks for the bug report.  Does the attached patch fix the problem for you?

[xftdpi.diff (text/x-diff, attachment)]

Message #13 received at 21152-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Xu Fasheng <fasheng.xu <at> gmail.com>
Cc: 21152-done <at> debbugs.gnu.org
Subject: Re: bug#21152: emacs make system blocked if "Xft/DPI = -1" in
 xsettings
Date: Sun, 09 Aug 2015 23:24:52 -0700

Xu Fasheng wrote:
> tha patch works. I rebuild emacs and tested ok.

Thanks, I installed it in the Emacs master and am marking this as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.