GNU bug report logs - #21147
readline history is stifled early so (readline-set! history-length nn) has no effect

Previous Next

Package: guile;

Reported by: Daniel Llorens <daniel.llorens <at> bluewin.ch>

Date: Tue, 28 Jul 2015 08:38:01 UTC

Severity: normal

Done: Andy Wingo <wingo <at> pobox.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21147 in the body.
You can then email your comments to 21147 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guile <at> gnu.org:
bug#21147; Package guile. (Tue, 28 Jul 2015 08:38:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Daniel Llorens <daniel.llorens <at> bluewin.ch>:
New bug report received and forwarded. Copy sent to bug-guile <at> gnu.org. (Tue, 28 Jul 2015 08:38:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Llorens <daniel.llorens <at> bluewin.ch>
To: bug-guile <at> gnu.org
Subject: readline history is stifled early so (readline-set! history-length
 nn) has no effect
Date: Tue, 28 Jul 2015 10:06:06 +0200

[Message part 1 (text/plain, inline)]
The default history-length is 200. When one imports (ice-9 readline), history is stifled to this value, so it doesn't matter if you set history-length to a larger value later on. I'm surprised that this has gone unnoticed up to now, since 200 is really small. I may be missing something...

The patch changes scm_readline_options() so that history is only stiffled when the options are actually set. This is rather clumsy since it means that if one doesn't set the options, history will never be stifled.

An alternative would be to add an optional readline-options argument to activate-readline. That way one would be able to increase history-length before the first time history is stifled, and otherwise things would work as they do now.

Regards
	
	Daniel



[0001-Avoid-stifling-readline-history-when-looking-up-opti.patch (application/octet-stream, attachment)]
Information forwarded to bug-guile <at> gnu.org:
bug#21147; Package guile. (Fri, 24 Jun 2016 08:24:02 GMT) Full text and rfc822 format available.

Message #8 received at 21147 <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: Daniel Llorens <daniel.llorens <at> bluewin.ch>
Cc: 21147 <at> debbugs.gnu.org
Subject: Re: bug#21147: readline history is stifled early so (readline-set!
 history-length nn) has no effect
Date: Fri, 24 Jun 2016 10:23:17 +0200

On Tue 28 Jul 2015 10:06, Daniel Llorens <daniel.llorens <at> bluewin.ch> writes:

> The default history-length is 200. When one imports (ice-9 readline),
> history is stifled to this value, so it doesn't matter if you set
> history-length to a larger value later on. I'm surprised that this has
> gone unnoticed up to now, since 200 is really small. I may be missing
> something...
>
> The patch changes scm_readline_options() so that history is only
> stiffled when the options are actually set. This is rather clumsy
> since it means that if one doesn't set the options, history will never
> be stifled.
>
> An alternative would be to add an optional readline-options argument
> to activate-readline. That way one would be able to increase
> history-length before the first time history is stifled, and otherwise
> things would work as they do now.

Thanks for the patch!  Well why not.  It's not perfect but it's an
improvement.  Thanks for giving this a poke; applied to master.

Andy
Reply sent to Andy Wingo <wingo <at> pobox.com>:
You have taken responsibility. (Fri, 24 Jun 2016 08:24:02 GMT) Full text and rfc822 format available.
Notification sent to Daniel Llorens <daniel.llorens <at> bluewin.ch>:
bug acknowledged by developer. (Fri, 24 Jun 2016 08:24:02 GMT) Full text and rfc822 format available.

Message #13 received at 21147-done <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: 21147-done <at> debbugs.gnu.org
Subject: Re: bug#21147: readline history is stifled early so (readline-set!
 history-length nn) has no effect
Date: Fri, 24 Jun 2016 10:23:36 +0200

thanks
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 22 Jul 2016 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 338 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.