From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jul 2015 21:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 21130@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1437774399680 (code B ref -1); Fri, 24 Jul 2015 21:47:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jul 2015 21:46:39 +0000 Received: from localhost ([127.0.0.1]:58237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIkne-0000Au-Eh for submit@debbugs.gnu.org; Fri, 24 Jul 2015 17:46:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49784) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIknc-0000Am-7t for submit@debbugs.gnu.org; Fri, 24 Jul 2015 17:46:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIkna-00026j-AO for submit@debbugs.gnu.org; Fri, 24 Jul 2015 17:46:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIkna-00026d-7J for submit@debbugs.gnu.org; Fri, 24 Jul 2015 17:46:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIknY-0000UX-Jh for bug-coreutils@gnu.org; Fri, 24 Jul 2015 17:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIknT-000235-IF for bug-coreutils@gnu.org; Fri, 24 Jul 2015 17:46:32 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:35714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIknT-00022n-Cf for bug-coreutils@gnu.org; Fri, 24 Jul 2015 17:46:27 -0400 Received: by qkbm65 with SMTP id m65so22201902qkb.2 for ; Fri, 24 Jul 2015 14:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=WkA32qRL0Y4hhPoi7fuvJNTekgSCCz6KoA8meWGL6To=; b=WlBMdKwMVcjPAHwHW4YzznRvvZr3qy8ARlj2sJwNw8FpyKxHTC4tYnVQCAB4QxF73l 6fYIeAXccBVZXKa1dpf1pyWbYq9SS6yk58dPOuq7RAjJeo6VvJ2Mk6QhWulVWKCW2lys MMKgO4zgtDWrFEknakL8H61fN2bhGP2H2KoHWHtYdObIWAfXdjRFhqUC4cZJRBNznzr6 HL6A2jTs6r4MpCzVF/0qAFU663kj0DSg69vEqLPhB4/3mArkfYQGA7WwvTf8lqwoFGrK eCSnUMfC2LHTV4lkQfEf1PqFyHzlvHLCuRdiqt2B9slPps04JZBfd1lkU1gkMmEPftdL FESQ== X-Received: by 10.55.27.9 with SMTP id b9mr23118336qkb.101.1437774386919; Fri, 24 Jul 2015 14:46:26 -0700 (PDT) Received: from disco.erlich.nygenome.org ([162.212.111.2]) by smtp.googlemail.com with ESMTPSA id 124sm4681305qhx.34.2015.07.24.14.46.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2015 14:46:26 -0700 (PDT) Message-ID: <55B2B23C.7000608@gmail.com> Date: Fri, 24 Jul 2015 17:46:36 -0400 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080706030308000208080308" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a multi-part message in MIME format. --------------080706030308000208080308 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, checking coreutils 8.24, running on NFS, the test 'ls/stat-failed' fails (log attached). If I understand correctly, The test creates a symlink to a directory then removes execute permissions: mkdir d ln -s / d/s chmod 600 d Then tries to dereference it: $ ls -Log d ls: cannot access d/s: Permission denied total 0 d????????? ? ? ? s The test expect 's' to have 'l' type, on my system it is 'd'. The attached patch avoids the failure, though I don't know if this is correct or not (perhaps this failure should not be avoided?). The system is: $ uname -a Linux XXX 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux $ gcc --version gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-4) The file system is NFS. regards, - assaf --------------080706030308000208080308 Content-Type: text/x-log; name="ls-stat-failed-test-suite.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ls-stat-failed-test-suite.log" ================================================ GNU coreutils 8.24: ./tests/test-suite.log ================================================ # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: tests/ls/stat-failed ========================== ++ initial_cwd_=/data/research/erlich_lab/gordon/sources/coreutils-8.24 ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /data/research/erlich_lab/gordon/sources/coreutils-8.24 gt-stat-failed.sh.XXXX +++ case $# in +++ destdir_=/data/research/erlich_lab/gordon/sources/coreutils-8.24 +++ template_=gt-stat-failed.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR +++ d=/data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ +++ case $d in +++ test -d /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ ++++ tr S - +++ perms='drwx------ 2 0 Jul 24 16:48 /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ' +++ case $perms in +++ test 0 = 0 +++ echo /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ +++ return ++ test_dir_=/data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ ++ cd /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/data/research/erlich_lab/gordon/sources/coreutils-8.24/./src + case $abs_path_dir_ in + PATH=/data/research/erlich_lab/gordon/sources/coreutils-8.24/./src:/data/research/erlich_lab/gordon/sources/coreutils-8.24/src:/nethome/agordon/usr/bin:/opt/sge/bin:/opt/sge/bin/lx-amd64:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin + create_exe_shims_ /data/research/erlich_lab/gordon/sources/coreutils-8.24/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ ls + test yes = yes + local i + for i in '$*' + env ls --version ls (GNU coreutils) 8.24 Copyright (C) 2015 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. + skip_if_root_ + uid_is_privileged_ ++ id -u + my_uid=10346 + case $my_uid in + return 1 + LS_MINOR_PROBLEM=1 + mkdir d + ln -s / d/s + chmod 600 d + ls -Log d ls: cannot access d/s: Permission denied + test 1 = 1 + cat + sed 's/^l/?/' out + compare exp - + compare_dev_null_ exp - + test 2 = 2 + test xexp = x/dev/null + test x- = x/dev/null + return 2 + case $? in + compare_ exp - + diff -u exp - --- exp 2015-07-24 16:48:36.152677768 -0400 +++ - 2015-07-24 16:48:36.172187132 -0400 @@ -1,2 +1,2 @@ total 0 -?????????? ? ? ? s +d????????? ? ? ? s + fail=1 + rm -f out exp + returns_ 1 ls --dired -l d ls: cannot access d/s: Permission denied + cat + sed 's/^ l/ ?/' out + compare exp - + compare_dev_null_ exp - + test 2 = 2 + test xexp = x/dev/null + test x- = x/dev/null + return 2 + case $? in + compare_ exp - + diff -u exp - --- exp 2015-07-24 16:48:36.262522027 -0400 +++ - 2015-07-24 16:48:36.270381375 -0400 @@ -1,4 +1,4 @@ total 0 - ?????????? ? ? ? ? ? s + d????????? ? ? ? ? ? s //DIRED// 44 45 //DIRED-OPTIONS// --quoting-style=literal + fail=1 + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /data/research/erlich_lab/gordon/sources/coreutils-8.24 + chmod -R u+rwx /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ + rm -rf /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ + exit 1 FAIL tests/ls/stat-failed.sh (exit status: 1) --------------080706030308000208080308 Content-Type: text/x-diff; name="ls-stat-failed.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ls-stat-failed.patch" >From 213564fc8c82cd5c48a1572b1a35e1780a4f245a Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Fri, 24 Jul 2015 17:27:04 -0400 Subject: [PATCH] tests: avoid test failure for ls/stat-failed.sh * tests/ls/stat-failed.sh: accept 'l' or 'd' as indication for a symlink for a directory inside a directory with no access on NFS. --- tests/ls/stat-failed.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ls/stat-failed.sh b/tests/ls/stat-failed.sh index 002b71c..f177ed17 100755 --- a/tests/ls/stat-failed.sh +++ b/tests/ls/stat-failed.sh @@ -36,7 +36,7 @@ total 0 ?????????? ? ? ? s EOF -sed 's/^l/?/' out | compare exp - || fail=1 +sed 's/^[ld]/?/' out | compare exp - || fail=1 # Ensure that the offsets in --dired output are accurate. rm -f out exp @@ -49,6 +49,6 @@ cat <<\EOF > exp || fail=1 //DIRED-OPTIONS// --quoting-style=literal EOF -sed 's/^ l/ ?/' out | compare exp - || fail=1 +sed 's/^ [ld]/ ?/' out | compare exp - || fail=1 Exit $fail -- 1.9.1 --------------080706030308000208080308-- From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jul 2015 05:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon , 21130@debbugs.gnu.org Received: via spool by 21130-submit@debbugs.gnu.org id=B21130.14378008459381 (code B ref 21130); Sat, 25 Jul 2015 05:08:02 +0000 Received: (at 21130) by debbugs.gnu.org; 25 Jul 2015 05:07:25 +0000 Received: from localhost ([127.0.0.1]:58290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIrgD-0002RD-7L for submit@debbugs.gnu.org; Sat, 25 Jul 2015 01:07:25 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:24802) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIrgB-0002R5-MI for 21130@debbugs.gnu.org; Sat, 25 Jul 2015 01:07:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoQJAFoYs1VtT5xy/2dsb2JhbABcgkNShGC9cIJWAoFFTAEBAQEBAYELhCQBAQQjBAsBVgsNCwICBRYLAgIJAwIBAgFFBgEMCAEBiC4BuRKFb5AeASuBIooshDxSgmmBQwEEhxIChliGfZUnkD4mg349gn0BAQE Received: from unknown (HELO localhost.localdomain) ([109.79.156.114]) by mail2.vodafone.ie with ESMTP; 25 Jul 2015 06:07:22 +0100 Message-ID: <55B31989.7010201@draigBrady.com> Date: Sat, 25 Jul 2015 06:07:21 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 References: <55B2B23C.7000608@gmail.com> In-Reply-To: <55B2B23C.7000608@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 24/07/15 22:46, Assaf Gordon wrote: > Hello, > > checking coreutils 8.24, running on NFS, the test 'ls/stat-failed' fails (log attached). > > If I understand correctly, > The test creates a symlink to a directory then removes execute permissions: > mkdir d > ln -s / d/s > chmod 600 d > > Then tries to dereference it: > $ ls -Log d > ls: cannot access d/s: Permission denied > total 0 > d????????? ? ? ? s > > The test expect 's' to have 'l' type, on my system it is 'd'. > > The attached patch avoids the failure, though I don't know if this is correct or not (perhaps this failure should not be avoided?). > > The system is: > $ uname -a > Linux XXX 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux > $ gcc --version > gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-4) > > The file system is NFS. Interesting. Is the NFS server RHEL6 too? With normal perms on 'd': On ext4 I get ^d With syscalls being: getdents(3, /* 3 entries */, 32768) = 72 stat("d/s", {st_mode=S_IFDIR|0555, st_size=4096, ...}) = 0 With -x perms on 'd': On nfsv4 here I get ^? On ext4 I get ^l With syscalls being: getdents(3, /* 3 entries */, 32768) = 72 stat("d/s", 0x7f634b9594a0) = -1 EACCES (Permission denied) So it seems you're getting next->d_type==DR_DIR in that case? That would be wrong, but a system issue rather than a problem in ls I think. The test adjustment looks OK but would benefit from a comment stating the first letter represents d_type and that on buggy systems may be 'd'. thanks! Pádraig From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jul 2015 05:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon , 21130@debbugs.gnu.org Received: via spool by 21130-submit@debbugs.gnu.org id=B21130.143780191811141 (code B ref 21130); Sat, 25 Jul 2015 05:26:02 +0000 Received: (at 21130) by debbugs.gnu.org; 25 Jul 2015 05:25:18 +0000 Received: from localhost ([127.0.0.1]:58296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIrxW-0002td-1l for submit@debbugs.gnu.org; Sat, 25 Jul 2015 01:25:18 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:43834) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIrxT-0002tS-Rs for 21130@debbugs.gnu.org; Sat, 25 Jul 2015 01:25:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoQJAPscs1VtT5xy/2dsb2JhbABcgkNShGC9cIJWAoFFTAEBAQEBAYELhCQBAQQjBAsBVgsNCwICBRYLAgIJAwIBAgFFBgEMCAEBiC4BuROFb5AeASuBIooshDxSgmmBQwEEhxIChliGfZUnkD4mg349gn0BAQE Received: from unknown (HELO localhost.localdomain) ([109.79.156.114]) by mail2.vodafone.ie with ESMTP; 25 Jul 2015 06:25:10 +0100 Message-ID: <55B31DB1.6080502@draigBrady.com> Date: Sat, 25 Jul 2015 06:25:05 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 References: <55B2B23C.7000608@gmail.com> <55B31989.7010201@draigBrady.com> In-Reply-To: <55B31989.7010201@draigBrady.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 25/07/15 06:07, Pádraig Brady wrote: > On 24/07/15 22:46, Assaf Gordon wrote: >> Hello, >> >> checking coreutils 8.24, running on NFS, the test 'ls/stat-failed' fails (log attached). >> >> If I understand correctly, >> The test creates a symlink to a directory then removes execute permissions: >> mkdir d >> ln -s / d/s >> chmod 600 d >> >> Then tries to dereference it: >> $ ls -Log d >> ls: cannot access d/s: Permission denied >> total 0 >> d????????? ? ? ? s >> >> The test expect 's' to have 'l' type, on my system it is 'd'. >> >> The attached patch avoids the failure, though I don't know if this is correct or not (perhaps this failure should not be avoided?). >> >> The system is: >> $ uname -a >> Linux XXX 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux >> $ gcc --version >> gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-4) >> >> The file system is NFS. > > Interesting. Is the NFS server RHEL6 too? > > With normal perms on 'd': > On ext4 I get ^d > With syscalls being: > getdents(3, /* 3 entries */, 32768) = 72 > stat("d/s", {st_mode=S_IFDIR|0555, st_size=4096, ...}) = 0 > > With -x perms on 'd': > On nfsv4 here I get ^? > On ext4 I get ^l > With syscalls being: > getdents(3, /* 3 entries */, 32768) = 72 > stat("d/s", 0x7f634b9594a0) = -1 EACCES (Permission denied) > > So it seems you're getting next->d_type==DR_DIR in that case? > That would be wrong, but a system issue rather than a problem in ls I think. > > The test adjustment looks OK but would benefit from a comment > stating the first letter represents d_type and that on buggy > systems may be 'd'. Another possibility might be that the chmod(1) and stat(2) are racy thus allowing the stat() to succeed? If that was the case then a stat d/s && skip_ ... would avoid the false failure? From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jul 2015 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , Assaf Gordon , 21130@debbugs.gnu.org Received: via spool by 21130-submit@debbugs.gnu.org id=B21130.14378367623999 (code B ref 21130); Sat, 25 Jul 2015 15:07:02 +0000 Received: (at 21130) by debbugs.gnu.org; 25 Jul 2015 15:06:02 +0000 Received: from localhost ([127.0.0.1]:58676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJ11W-00012G-3v for submit@debbugs.gnu.org; Sat, 25 Jul 2015 11:06:02 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41739) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJ11T-000120-F5 for 21130@debbugs.gnu.org; Sat, 25 Jul 2015 11:06:00 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9BF4A16099B; Sat, 25 Jul 2015 08:05:58 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YwCXDDesAP1V; Sat, 25 Jul 2015 08:05:57 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E6B81160CB6; Sat, 25 Jul 2015 08:05:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UG7kgOM7VQZy; Sat, 25 Jul 2015 08:05:57 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C7CDE16099B; Sat, 25 Jul 2015 08:05:57 -0700 (PDT) Message-ID: <55B3A5D0.5040302@cs.ucla.edu> Date: Sat, 25 Jul 2015 08:05:52 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 References: <55B2B23C.7000608@gmail.com> <55B31989.7010201@draigBrady.com> <55B31DB1.6080502@draigBrady.com> In-Reply-To: <55B31DB1.6080502@draigBrady.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) P=C3=A1draig Brady wrote: >> On 24/07/15 22:46, Assaf Gordon wrote: >>> If I understand correctly, >>> The test creates a symlink to a directory then removes execute permis= sions: >>> mkdir d >>> ln -s / d/s >>> chmod 600 d >>> >>> Then tries to dereference it: >>> $ ls -Log d >>> ls: cannot access d/s: Permission denied >>> total 0 >>> d????????? ? ? ? s > Another possibility might be that the chmod(1) and stat(2) are racy > thus allowing the stat() to succeed? If that was the case then > a stat d/s && skip_ ... would avoid the false failure? Sorry, I don't understand the scenario here. If the stat succeeds, why w= ould ls=20 output '????'? The '????' means that the stat failed. From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jul 2015 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert , Assaf Gordon , 21130@debbugs.gnu.org Received: via spool by 21130-submit@debbugs.gnu.org id=B21130.143784439815268 (code B ref 21130); Sat, 25 Jul 2015 17:14:02 +0000 Received: (at 21130) by debbugs.gnu.org; 25 Jul 2015 17:13:18 +0000 Received: from localhost ([127.0.0.1]:58704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJ30g-0003yB-1X for submit@debbugs.gnu.org; Sat, 25 Jul 2015 13:13:18 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:38342) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJ30d-0003y1-RU for 21130@debbugs.gnu.org; Sat, 25 Jul 2015 13:13:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoGAO3Cs1VtT5xy/2dsb2JhbABcDoI1UoJ8gWS9cIJWAoE6TAEBAQEBAYELhCQBAQQjDwFWCw0LAgIFFgsCAgkDAgECAUUGAQwIAQGILgG5YoVvkAQBK4EiiiyEPFKCaYFDBYcSAoZYhn2VKZA+JoM/Pz2CfQEBAQ Received: from unknown (HELO localhost.localdomain) ([109.79.156.114]) by mail2.vodafone.ie with ESMTP; 25 Jul 2015 18:13:12 +0100 Message-ID: <55B3C3A8.9000904@draigBrady.com> Date: Sat, 25 Jul 2015 18:13:12 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 References: <55B2B23C.7000608@gmail.com> <55B31989.7010201@draigBrady.com> <55B31DB1.6080502@draigBrady.com> <55B3A5D0.5040302@cs.ucla.edu> In-Reply-To: <55B3A5D0.5040302@cs.ucla.edu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 25/07/15 16:05, Paul Eggert wrote: > Pádraig Brady wrote: >>> On 24/07/15 22:46, Assaf Gordon wrote: >>>> If I understand correctly, >>>> The test creates a symlink to a directory then removes execute permissions: >>>> mkdir d >>>> ln -s / d/s >>>> chmod 600 d >>>> >>>> Then tries to dereference it: >>>> $ ls -Log d >>>> ls: cannot access d/s: Permission denied >>>> total 0 >>>> d????????? ? ? ? s > >> Another possibility might be that the chmod(1) and stat(2) are racy >> thus allowing the stat() to succeed? If that was the case then >> a stat d/s && skip_ ... would avoid the false failure? > > Sorry, I don't understand the scenario here. If the stat succeeds, why would ls > output '????'? The '????' means that the stat failed. Yes good point. So it must be that d_type is set to 'd' erroneously. What is the file system and operating system on the NFS server? From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jul 2015 22:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 21130@debbugs.gnu.org, Paul Eggert Received: via spool by 21130-submit@debbugs.gnu.org id=B21130.143786418324125 (code B ref 21130); Sat, 25 Jul 2015 22:44:01 +0000 Received: (at 21130) by debbugs.gnu.org; 25 Jul 2015 22:43:03 +0000 Received: from localhost ([127.0.0.1]:58775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJ89n-0006H3-2B for submit@debbugs.gnu.org; Sat, 25 Jul 2015 18:43:03 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:35445) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJ89k-0006Ge-W0 for 21130@debbugs.gnu.org; Sat, 25 Jul 2015 18:43:01 -0400 Received: by qkbm65 with SMTP id m65so28669278qkb.2 for <21130@debbugs.gnu.org>; Sat, 25 Jul 2015 15:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hDIYvFNSQBMUNdwC+GGDsIDp9OwzZtCHaxjhHxqaiaY=; b=u6Elbrl1FauUKwIUfasPlTg+RygoL9XUEn9RsULeg7teXNOgB6TPOH/Tj9W1X45TiZ oc1bUh1VNC4VY8T9zPKQ1XrqWvSmjNfbQAlFjqlF2pvRG4DiwxfsnCQALZ+3T9DOMN5A nVGl7tjXrP2fq1puxlZ0TUaBXQfYYCKTwi7YxGx10YtA7hc6dukOKlWbmJjNi1jQjqeD LsGpmiJGnuU7lIZ9zM72wh/pajMduY5YpIjAortHvTYVIZm38CrD3XJlam512w0C6wUg uGvHSL4BGpLRy8+WgQ/IrJkUPvSt6Bb3QfoejN2jUjPsCZvwZSqs83vVLiQ+G2EPBCOI PjOg== X-Received: by 10.55.33.92 with SMTP id h89mr30517946qkh.69.1437864180607; Sat, 25 Jul 2015 15:43:00 -0700 (PDT) Received: from [10.3.80.91] ([162.212.111.2]) by smtp.gmail.com with ESMTPSA id 128sm6300003qht.11.2015.07.25.15.42.59 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 25 Jul 2015 15:42:59 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) From: Assaf Gordon In-Reply-To: <55B3C3A8.9000904@draigBrady.com> Date: Sat, 25 Jul 2015 18:43:03 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <55B2B23C.7000608@gmail.com> <55B31989.7010201@draigBrady.com> <55B31DB1.6080502@draigBrady.com> <55B3A5D0.5040302@cs.ucla.edu> <55B3C3A8.9000904@draigBrady.com> X-Mailer: Apple Mail (2.2102) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello, > On Jul 25, 2015, at 13:13, P=C3=A1draig Brady = wrote: >>>> On 24/07/15 22:46, Assaf Gordon wrote: >>>>> Then tries to dereference it: >>>>> $ ls -Log d >>>>> ls: cannot access d/s: Permission denied >>>>> total 0 >>>>> d????????? ? ? ? s >=20 <...> > Yes good point. So it must be that d_type is set to 'd' erroneously. > What is the file system and operating system on the NFS server? The NFS server is an Isilon OneFS (not sure which model/version). strace gives: stat("d", {st_mode=3DS_IFDIR|0600, st_size=3D19, ...}) =3D 0 open("d", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) =3D 3 fcntl(3, F_GETFD) =3D 0x1 (flags FD_CLOEXEC) getdents(3, /* 3 entries */, 32768) =3D 72 stat("d/s", 0x1fc9690) =3D -1 EACCES (Permission denied)=20 Breaking in 'print_dir()' (ls.c:2612) gives: --- ## ## The code was "next =3D readdir(dirp)" ## (gdb) p *next $9 =3D {d_ino =3D 6682814318, d_off =3D 3, d_reclen =3D 24, d_type =3D 4 = '\004', d_name =3D "s\000\000\000\004", '\000' } ---- So it seems the filesystem reports d_type=3D=3DDT_DIR. For completeness, I've tested with other file types, and it seems that = the returned type is always 'directory': --- $ chmod 700 d $ ls -log d total 8 lrwxrwxrwx 1 9 Jul 25 18:29 blockdev -> /dev/sda1 lrwxrwxrwx 1 9 Jul 25 18:29 chardev -> /dev/tty0 lrwxrwxrwx 1 11 Jul 25 18:29 file -> /etc/passwd lrwxrwxrwx 1 1 Jul 24 17:41 s -> / $ ls -Log d total 8 brw-rw---- 1 8, 1 Dec 16 2014 blockdev crw--w---- 1 4, 0 Dec 16 2014 chardev -rw-r--r-- 1 1808 Jun 26 12:00 file dr-xr-xr-x 26 4096 Jan 29 15:06 s $ chmod 600 d $ ls -Log d ls: cannot access d/file: Permission denied ls: cannot access d/chardev: Permission denied ls: cannot access d/blockdev: Permission denied ls: cannot access d/s: Permission denied total 0 d????????? ? ? ? blockdev d????????? ? ? ? chardev d????????? ? ? ? file d????????? ? ? ? s --- regards, - assaf From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jul 2015 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon , =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 21130@debbugs.gnu.org Received: via spool by 21130-submit@debbugs.gnu.org id=B21130.143786863930619 (code B ref 21130); Sat, 25 Jul 2015 23:58:01 +0000 Received: (at 21130) by debbugs.gnu.org; 25 Jul 2015 23:57:19 +0000 Received: from localhost ([127.0.0.1]:58780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJ9Je-0007xn-TN for submit@debbugs.gnu.org; Sat, 25 Jul 2015 19:57:19 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49482) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJ9Jc-0007xe-HF for 21130@debbugs.gnu.org; Sat, 25 Jul 2015 19:57:17 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 68E0E16099B; Sat, 25 Jul 2015 16:57:15 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YAeM5ua4Wm4N; Sat, 25 Jul 2015 16:57:14 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6CBA3160CB6; Sat, 25 Jul 2015 16:57:14 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CaXopcWySUct; Sat, 25 Jul 2015 16:57:14 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 42F0416099B; Sat, 25 Jul 2015 16:57:14 -0700 (PDT) Message-ID: <55B4225A.4030400@cs.ucla.edu> Date: Sat, 25 Jul 2015 16:57:14 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 References: <55B2B23C.7000608@gmail.com> <55B31989.7010201@draigBrady.com> <55B31DB1.6080502@draigBrady.com> <55B3A5D0.5040302@cs.ucla.edu> <55B3C3A8.9000904@draigBrady.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) Assaf Gordon wrote: > it seems that the returned type is always 'directory': Wow,that's quite a bug. I imagine it affects programs other than 'ls'. Sounds like it needs to be fixed in the file system or kernel, as it's not realistic to install workarounds in every application that uses readdir. Is the bug reproducible on a more-modern Linux kernel? 2.6.32 is projected for end-of-life around now, according to . If the bug doesn't appear in 3.2 or newer, I wouldn't worry about it. I found a machine with an old kernel (RHEL 6.6 with kernel 2.6.32-504.12.2.el6.x86_64) and could not reproduce the bug with a Network Appliance NFS server. So perhaps the bug is Isilon-specific rather than kernel-specific. If so, Isilon should fix it. From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 26 Jul 2015 01:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert , =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 21130@debbugs.gnu.org Received: via spool by 21130-submit@debbugs.gnu.org id=B21130.14378729424510 (code B ref 21130); Sun, 26 Jul 2015 01:10:03 +0000 Received: (at 21130) by debbugs.gnu.org; 26 Jul 2015 01:09:02 +0000 Received: from localhost ([127.0.0.1]:58785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJAR4-0001AS-0b for submit@debbugs.gnu.org; Sat, 25 Jul 2015 21:09:02 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:33692) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJAR1-0001AF-OL for 21130@debbugs.gnu.org; Sat, 25 Jul 2015 21:09:00 -0400 Received: by qged69 with SMTP id d69so31293125qge.0 for <21130@debbugs.gnu.org>; Sat, 25 Jul 2015 18:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=OqjoBNVL7+tDDJ9AaJ8yFNMrh1yJ0b22wP2TdxIrsqU=; b=xIVkzuq4vrilQXC5FI/cwZUchlG/y/JXiZc7eefCdw4DHIst8NsqotzBn6UOM1XGcy hTSiy+sgJ+2wljO8cgEsC+uK9GZbcww1QhfDLCwUF5Itswd8ZfFS7a3ee1hyKL8SGUaa 55uOa578amAjm6syvfBP92E/FpskfFmVzcxh10RzGpzx5sBBS3dScSzHqvO1fDHstQJ3 07pXLubxMAj4HAR51/XY3vB8NSgr22jbeCTHj+V2EdXgYdmZpXX8Xlw0cKUMAoAsSP8q qDPuOzWvLnkDhCCJEf74KUFN50p9THuWoq3qhrRJEHbjTEdlMfH3f5ZeHfyDKOanaSQe SUpw== X-Received: by 10.140.101.132 with SMTP id u4mr30194188qge.48.1437872939190; Sat, 25 Jul 2015 18:08:59 -0700 (PDT) Received: from disco.erlich.nygenome.org ([162.212.111.2]) by smtp.googlemail.com with ESMTPSA id 74sm6538657qkx.4.2015.07.25.18.08.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Jul 2015 18:08:58 -0700 (PDT) Message-ID: <55B43337.9010003@gmail.com> Date: Sat, 25 Jul 2015 21:09:11 -0400 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 References: <55B2B23C.7000608@gmail.com> <55B31989.7010201@draigBrady.com> <55B31DB1.6080502@draigBrady.com> <55B3A5D0.5040302@cs.ucla.edu> <55B3C3A8.9000904@draigBrady.com> <55B4225A.4030400@cs.ucla.edu> In-Reply-To: <55B4225A.4030400@cs.ucla.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 07/25/2015 07:57 PM, Paul Eggert wrote: > Assaf Gordon wrote: >> it seems that the returned type is always 'directory': <...> > Is the bug reproducible on a more-modern Linux kernel? <...> > If the bug doesn't appear in 3.2 or newer, I wouldn't worry about it. Thanks for the pointer - on another machine with newer kernel (mounting the same NFS share) the reported type is 'unknown'. === $ uname -a Linux xxxx 3.10.0-229.el7.x86_64 #1 SMP Fri Mar 6 11:36:42 UTC 2015 x86_64 GNU/Linux $ ./src/ls -Log d ./src/ls: cannot access d/file: Permission denied ./src/ls: cannot access d/chardev: Permission denied ./src/ls: cannot access d/blockdev: Permission denied ./src/ls: cannot access d/s: Permission denied total 0 ?????????? ? ? ? blockdev ?????????? ? ? ? chardev ?????????? ? ? ? file ?????????? ? ? ? s === From unknown Sun Jun 22 07:55:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21130: test fail: 'tests/ls/stat-failed' Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 26 Jul 2015 01:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21130 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon , =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 21130@debbugs.gnu.org Received: via spool by 21130-submit@debbugs.gnu.org id=B21130.14378740126080 (code B ref 21130); Sun, 26 Jul 2015 01:27:02 +0000 Received: (at 21130) by debbugs.gnu.org; 26 Jul 2015 01:26:52 +0000 Received: from localhost ([127.0.0.1]:58789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJAiK-0001a0-0L for submit@debbugs.gnu.org; Sat, 25 Jul 2015 21:26:52 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50699) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJAiH-0001Zp-Lz for 21130@debbugs.gnu.org; Sat, 25 Jul 2015 21:26:50 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7944B16099B; Sat, 25 Jul 2015 18:26:48 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Di6E1pw_Y0oo; Sat, 25 Jul 2015 18:26:47 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C46F4160CB6; Sat, 25 Jul 2015 18:26:47 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PMiWUhKlM85T; Sat, 25 Jul 2015 18:26:47 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A4B4616099B; Sat, 25 Jul 2015 18:26:47 -0700 (PDT) Message-ID: <55B43757.2050003@cs.ucla.edu> Date: Sat, 25 Jul 2015 18:26:47 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 References: <55B2B23C.7000608@gmail.com> <55B31989.7010201@draigBrady.com> <55B31DB1.6080502@draigBrady.com> <55B3A5D0.5040302@cs.ucla.edu> <55B3C3A8.9000904@draigBrady.com> <55B4225A.4030400@cs.ucla.edu> <55B43337.9010003@gmail.com> In-Reply-To: <55B43337.9010003@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) Assaf Gordon wrote: > $ ./src/ls -Log d > ./src/ls: cannot access d/file: Permission denied > ./src/ls: cannot access d/chardev: Permission denied > ./src/ls: cannot access d/blockdev: Permission denied > ./src/ls: cannot access d/s: Permission denied > total 0 > ?????????? ? ? ? blockdev Arguably this is a better result than what we normally get, and our test framework should allow it. The argument is that if a directory is not searchable, an application should be able to discover its files' names (as they belong to the directory and not to the files), but not the files' attributes (as they belong to the files, not to the directory). Admittedly this is a fine distinction. From unknown Sun Jun 22 07:55:24 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Assaf Gordon Subject: bug#21130: closed (Re: bug#21130: test fail: 'tests/ls/stat-failed') Message-ID: References: <56504FF9.3070002@draigBrady.com> <55B2B23C.7000608@gmail.com> X-Gnu-PR-Message: they-closed 21130 X-Gnu-PR-Package: coreutils Reply-To: 21130@debbugs.gnu.org Date: Sat, 21 Nov 2015 11:07:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1448104022-4190-1" This is a multi-part message in MIME format... ------------=_1448104022-4190-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #21130: test fail: 'tests/ls/stat-failed' which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 21130@debbugs.gnu.org. --=20 21130: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21130 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1448104022-4190-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 21130-done) by debbugs.gnu.org; 21 Nov 2015 11:06:09 +0000 Received: from localhost ([127.0.0.1]:46638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a05zK-00013x-Ta for submit@debbugs.gnu.org; Sat, 21 Nov 2015 06:06:09 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:51865) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a05z0-00013W-9t for 21130-done@debbugs.gnu.org; Sat, 21 Nov 2015 06:05:48 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah8FAJdOUFZtT5v9/2dsb2JhbABegmlSU2kGwQEdhW8BAgKBNEwBAQEBAQGBC4Q0AQEBBBIRJEILDQQDAQIBCRYLAgIJAwIBAgE9CBMGAgEBHogQAQOlSoorhRpTihoBAQEBBgEBAQEBARQJhVmFeYR7LIJOgUQFh0EChw2HfIJYgWFqijKHEItQh0ZjhAQ+NIUrAQEB Received: from unknown (HELO localhost.localdomain) ([109.79.155.253]) by mail2.vodafone.ie with ESMTP; 21 Nov 2015 11:05:29 +0000 Subject: Re: bug#21130: test fail: 'tests/ls/stat-failed' To: 21130-done@debbugs.gnu.org References: <55B2B23C.7000608@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <56504FF9.3070002@draigBrady.com> Date: Sat, 21 Nov 2015 11:05:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <55B2B23C.7000608@gmail.com> Content-Type: multipart/mixed; boundary="------------060104090006010301060505" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21130-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------060104090006010301060505 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 24/07/15 22:46, Assaf Gordon wrote: > Hello, > > checking coreutils 8.24, running on NFS, the test 'ls/stat-failed' fails (log attached). > > If I understand correctly, > The test creates a symlink to a directory then removes execute permissions: > mkdir d > ln -s / d/s > chmod 600 d > > Then tries to dereference it: > $ ls -Log d > ls: cannot access d/s: Permission denied > total 0 > d????????? ? ? ? s > > The test expect 's' to have 'l' type, on my system it is 'd'. > > The attached patch avoids the failure, though I don't know if this is correct or not (perhaps this failure should not be avoided?). > > The system is: > $ uname -a > Linux XXX 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux > $ gcc --version > gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-4) > > The file system is NFS. False failure documented and avoided in the attached. thanks, Pádraig. --------------060104090006010301060505 Content-Type: text/x-patch; name="stat-false-fail.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="stat-false-fail.patch" >From 56d3269207db13b0f3a594d6d2cbc52913929d21 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Sat, 21 Nov 2015 10:59:37 +0000 Subject: [PATCH] tests: avoid false failure on older NFS implementations * tests/ls/stat-failed.sh: Skip the test if 'd' is returned as the type, and document where this was seen. Also flag failure to write small temp files during the test as an error rather than a failure. Fixes http://bugs.gnu.org/21130 --- tests/ls/stat-failed.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/ls/stat-failed.sh b/tests/ls/stat-failed.sh index 002b71c..32e8304 100755 --- a/tests/ls/stat-failed.sh +++ b/tests/ls/stat-failed.sh @@ -31,7 +31,11 @@ chmod 600 d || framework_failure_ ls -Log d > out test $? = 1 || fail=1 -cat <<\EOF > exp || fail=1 +# Linux 2.6.32 client with Isilon OneFS always returns d_type==DT_DIR ('d') +# Newer Linux 3.10.0 returns the more correct DT_UNKNOWN ('?') +grep '^[l?]?' out || skip_ 'unrecognized d_type returned' + +cat <<\EOF > exp || framework_failure_ total 0 ?????????? ? ? ? s EOF @@ -42,7 +46,7 @@ sed 's/^l/?/' out | compare exp - || fail=1 rm -f out exp returns_ $LS_MINOR_PROBLEM ls --dired -l d > out || fail=1 -cat <<\EOF > exp || fail=1 +cat <<\EOF > exp || framework_failure_ total 0 ?????????? ? ? ? ? ? s //DIRED// 44 45 -- 2.5.0 --------------060104090006010301060505-- ------------=_1448104022-4190-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Jul 2015 21:46:39 +0000 Received: from localhost ([127.0.0.1]:58237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIkne-0000Au-Eh for submit@debbugs.gnu.org; Fri, 24 Jul 2015 17:46:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49784) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIknc-0000Am-7t for submit@debbugs.gnu.org; Fri, 24 Jul 2015 17:46:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIkna-00026j-AO for submit@debbugs.gnu.org; Fri, 24 Jul 2015 17:46:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIkna-00026d-7J for submit@debbugs.gnu.org; Fri, 24 Jul 2015 17:46:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIknY-0000UX-Jh for bug-coreutils@gnu.org; Fri, 24 Jul 2015 17:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIknT-000235-IF for bug-coreutils@gnu.org; Fri, 24 Jul 2015 17:46:32 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:35714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIknT-00022n-Cf for bug-coreutils@gnu.org; Fri, 24 Jul 2015 17:46:27 -0400 Received: by qkbm65 with SMTP id m65so22201902qkb.2 for ; Fri, 24 Jul 2015 14:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=WkA32qRL0Y4hhPoi7fuvJNTekgSCCz6KoA8meWGL6To=; b=WlBMdKwMVcjPAHwHW4YzznRvvZr3qy8ARlj2sJwNw8FpyKxHTC4tYnVQCAB4QxF73l 6fYIeAXccBVZXKa1dpf1pyWbYq9SS6yk58dPOuq7RAjJeo6VvJ2Mk6QhWulVWKCW2lys MMKgO4zgtDWrFEknakL8H61fN2bhGP2H2KoHWHtYdObIWAfXdjRFhqUC4cZJRBNznzr6 HL6A2jTs6r4MpCzVF/0qAFU663kj0DSg69vEqLPhB4/3mArkfYQGA7WwvTf8lqwoFGrK eCSnUMfC2LHTV4lkQfEf1PqFyHzlvHLCuRdiqt2B9slPps04JZBfd1lkU1gkMmEPftdL FESQ== X-Received: by 10.55.27.9 with SMTP id b9mr23118336qkb.101.1437774386919; Fri, 24 Jul 2015 14:46:26 -0700 (PDT) Received: from disco.erlich.nygenome.org ([162.212.111.2]) by smtp.googlemail.com with ESMTPSA id 124sm4681305qhx.34.2015.07.24.14.46.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2015 14:46:26 -0700 (PDT) Message-ID: <55B2B23C.7000608@gmail.com> Date: Fri, 24 Jul 2015 17:46:36 -0400 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: bug-coreutils@gnu.org Subject: test fail: 'tests/ls/stat-failed' Content-Type: multipart/mixed; boundary="------------080706030308000208080308" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a multi-part message in MIME format. --------------080706030308000208080308 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, checking coreutils 8.24, running on NFS, the test 'ls/stat-failed' fails (log attached). If I understand correctly, The test creates a symlink to a directory then removes execute permissions: mkdir d ln -s / d/s chmod 600 d Then tries to dereference it: $ ls -Log d ls: cannot access d/s: Permission denied total 0 d????????? ? ? ? s The test expect 's' to have 'l' type, on my system it is 'd'. The attached patch avoids the failure, though I don't know if this is correct or not (perhaps this failure should not be avoided?). The system is: $ uname -a Linux XXX 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux $ gcc --version gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-4) The file system is NFS. regards, - assaf --------------080706030308000208080308 Content-Type: text/x-log; name="ls-stat-failed-test-suite.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ls-stat-failed-test-suite.log" ================================================ GNU coreutils 8.24: ./tests/test-suite.log ================================================ # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: tests/ls/stat-failed ========================== ++ initial_cwd_=/data/research/erlich_lab/gordon/sources/coreutils-8.24 ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /data/research/erlich_lab/gordon/sources/coreutils-8.24 gt-stat-failed.sh.XXXX +++ case $# in +++ destdir_=/data/research/erlich_lab/gordon/sources/coreutils-8.24 +++ template_=gt-stat-failed.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR +++ d=/data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ +++ case $d in +++ test -d /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ ++++ tr S - +++ perms='drwx------ 2 0 Jul 24 16:48 /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ' +++ case $perms in +++ test 0 = 0 +++ echo /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ +++ return ++ test_dir_=/data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ ++ cd /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/data/research/erlich_lab/gordon/sources/coreutils-8.24/./src + case $abs_path_dir_ in + PATH=/data/research/erlich_lab/gordon/sources/coreutils-8.24/./src:/data/research/erlich_lab/gordon/sources/coreutils-8.24/src:/nethome/agordon/usr/bin:/opt/sge/bin:/opt/sge/bin/lx-amd64:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin + create_exe_shims_ /data/research/erlich_lab/gordon/sources/coreutils-8.24/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ ls + test yes = yes + local i + for i in '$*' + env ls --version ls (GNU coreutils) 8.24 Copyright (C) 2015 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. + skip_if_root_ + uid_is_privileged_ ++ id -u + my_uid=10346 + case $my_uid in + return 1 + LS_MINOR_PROBLEM=1 + mkdir d + ln -s / d/s + chmod 600 d + ls -Log d ls: cannot access d/s: Permission denied + test 1 = 1 + cat + sed 's/^l/?/' out + compare exp - + compare_dev_null_ exp - + test 2 = 2 + test xexp = x/dev/null + test x- = x/dev/null + return 2 + case $? in + compare_ exp - + diff -u exp - --- exp 2015-07-24 16:48:36.152677768 -0400 +++ - 2015-07-24 16:48:36.172187132 -0400 @@ -1,2 +1,2 @@ total 0 -?????????? ? ? ? s +d????????? ? ? ? s + fail=1 + rm -f out exp + returns_ 1 ls --dired -l d ls: cannot access d/s: Permission denied + cat + sed 's/^ l/ ?/' out + compare exp - + compare_dev_null_ exp - + test 2 = 2 + test xexp = x/dev/null + test x- = x/dev/null + return 2 + case $? in + compare_ exp - + diff -u exp - --- exp 2015-07-24 16:48:36.262522027 -0400 +++ - 2015-07-24 16:48:36.270381375 -0400 @@ -1,4 +1,4 @@ total 0 - ?????????? ? ? ? ? ? s + d????????? ? ? ? ? ? s //DIRED// 44 45 //DIRED-OPTIONS// --quoting-style=literal + fail=1 + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /data/research/erlich_lab/gordon/sources/coreutils-8.24 + chmod -R u+rwx /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ + rm -rf /data/research/erlich_lab/gordon/sources/coreutils-8.24/gt-stat-failed.sh.LdZJ + exit 1 FAIL tests/ls/stat-failed.sh (exit status: 1) --------------080706030308000208080308 Content-Type: text/x-diff; name="ls-stat-failed.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ls-stat-failed.patch" >From 213564fc8c82cd5c48a1572b1a35e1780a4f245a Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Fri, 24 Jul 2015 17:27:04 -0400 Subject: [PATCH] tests: avoid test failure for ls/stat-failed.sh * tests/ls/stat-failed.sh: accept 'l' or 'd' as indication for a symlink for a directory inside a directory with no access on NFS. --- tests/ls/stat-failed.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ls/stat-failed.sh b/tests/ls/stat-failed.sh index 002b71c..f177ed17 100755 --- a/tests/ls/stat-failed.sh +++ b/tests/ls/stat-failed.sh @@ -36,7 +36,7 @@ total 0 ?????????? ? ? ? s EOF -sed 's/^l/?/' out | compare exp - || fail=1 +sed 's/^[ld]/?/' out | compare exp - || fail=1 # Ensure that the offsets in --dired output are accurate. rm -f out exp @@ -49,6 +49,6 @@ cat <<\EOF > exp || fail=1 //DIRED-OPTIONS// --quoting-style=literal EOF -sed 's/^ l/ ?/' out | compare exp - || fail=1 +sed 's/^ [ld]/ ?/' out | compare exp - || fail=1 Exit $fail -- 1.9.1 --------------080706030308000208080308-- ------------=_1448104022-4190-1--