GNU bug report logs - #21124
'invalid-mb-seq-UMR' test fails

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21124 in the body.
You can then email your comments to 21124 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: bug-sed <at> gnu.org
Subject: 'invalid-mb-seq-UMR' test fails
Date: Thu, 23 Jul 2015 17:47:07 -0400

[Message part 1 (text/plain, inline)]

Hello,

With sed from git (4.2.2.89-e387), I get one test failure in 'invalid-mb-seq-UMR' (log attached).

The error seem to be:
===
+valgrind --quiet --error-exitcode=1 sed -e 's/a/b\U\xb2c/' in
[...]
+ compare_ exp out
+ diff -u exp out
--- exp 2015-07-23 17:42:41.144358380 -0400
+++ out 2015-07-23 17:42:41.780358374 -0400
@@ -1 +1 @@
-bC
+b<FF>C
===

regards,
 - assaf

[test-suite.log (text/x-log, attachment)]

Message #8 received at 21124 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 21124 <at> debbugs.gnu.org
Subject: Re: bug#21124: 'invalid-mb-seq-UMR' test fails
Date: Mon, 27 Jul 2015 22:31:21 -0700

On Thu, Jul 23, 2015 at 2:47 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> With sed from git (4.2.2.89-e387), I get one test failure in
> 'invalid-mb-seq-UMR' (log attached).
>
> The error seem to be:
> ===
> +valgrind --quiet --error-exitcode=1 sed -e 's/a/b\U\xb2c/' in
> [...]
> + compare_ exp out
> + diff -u exp out
> --- exp 2015-07-23 17:42:41.144358380 -0400
> +++ out 2015-07-23 17:42:41.780358374 -0400
> @@ -1 +1 @@
> -bC
> +b<FF>C
> ===

Hi Assaf,
Thank you for the report.
What versions of valgrind and gcc are you using -- and what type of system?
On a fedora rawhide system with the following valgrind and gcc
versions, that test passes for me:

  valgrind-3.10.1
  gcc version 6.0.0 20150727 (experimental) (GCC)

I confirmed that it also passed with stock gcc:

  gcc version 5.1.1 20150618 (Red Hat 5.1.1-4) (GCC)

Message #11 received at 21124 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 21124 <at> debbugs.gnu.org
Subject: Re: bug#21124: 'invalid-mb-seq-UMR' test fails
Date: Thu, 30 Jul 2015 00:02:18 +0000

Hello,

On Mon, Jul 27, 2015 at 10:31:21PM -0700, Jim Meyering wrote:
>On Thu, Jul 23, 2015 at 2:47 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
>> With sed from git (4.2.2.89-e387), I get one test failure in
>> 'invalid-mb-seq-UMR' (log attached).
>>
>> The error seem to be:
>> ===
>> +valgrind --quiet --error-exitcode=1 sed -e 's/a/b\U\xb2c/' in
>
>What versions of valgrind and gcc are you using -- and what type of system?

I'm using:

    $ uname -a
    Linux XXX 3.13.0-58-generic #97-Ubuntu SMP Wed Jul 8 02:56:15 UTC 2015 x86_64 GNU/Linux
    $ gcc --version
    gcc (GCC) 5.2.0
    $ valgrind --version
    valgrind-3.10.0.SVN

But, looking deeper I've noticed the test uses a locale which is not 
available on my system (ja_JP.eucJP).
Here are couple of related tests:

    # (the extra commit .90 is the ununsed-code removal
    #  http://lists.gnu.org/archive/html/bug-sed/2015-07/msg00005.html)
    $ ./sed/sed --version | head -n1
    ./sed/sed (GNU sed) 4.2.2.90-9f3b

    # The locale I don't have produces 'ff'
    $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/' | od -tx1a
    0000000  62  ff  43  0a
              b del   C  nl
    0000004

    # A locale I do have works as expected
    $ echo a | LC_ALL=ja_JP.utf8 ./sed/sed -e 's/a/b\U\xb2c/' | od -tx1a
    0000000  62  43  0a
              b   C  nl
    0000003

For comparison, an older 'sed':

    $ sed --version
    sed (GNU sed) 4.2.2

    # Existing locale
    $ echo a | LC_ALL=ja_JP.utf8 sed -e 's/a/b\U\xb2c/' | od -tx1a
    0000000  62  00  43  0a
              b nul   C  nl
    0000004

    # non-existing locale
    $ echo a | LC_ALL=ja_JP.eucJP sed -e 's/a/b\U\xb2c/' | od -tx1a
    0000000  62  ff  43  0a
              b del   C  nl
    0000004

So perhaps the fix is simply to skip the test if the locale doesn't 
exist.

HTH,
-assaf

Message #14 received at 21124 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 21124 <at> debbugs.gnu.org
Subject: Re: bug#21124: 'invalid-mb-seq-UMR' test fails
Date: Thu, 30 Jul 2015 09:56:29 -0700

[Message part 1 (text/plain, inline)]

On Wed, Jul 29, 2015 at 5:02 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> Hello,
>
> On Mon, Jul 27, 2015 at 10:31:21PM -0700, Jim Meyering wrote:
>>
>> On Thu, Jul 23, 2015 at 2:47 PM, Assaf Gordon <assafgordon <at> gmail.com>
>> wrote:
>>>
>>> With sed from git (4.2.2.89-e387), I get one test failure in
>>> 'invalid-mb-seq-UMR' (log attached).
>>>
>>> The error seem to be:
>>> ===
>>> +valgrind --quiet --error-exitcode=1 sed -e 's/a/b\U\xb2c/' in
>>
>>
>> What versions of valgrind and gcc are you using -- and what type of
>> system?
>
>
> I'm using:
>
>     $ uname -a
>     Linux XXX 3.13.0-58-generic #97-Ubuntu SMP Wed Jul 8 02:56:15 UTC 2015
> x86_64 GNU/Linux
>     $ gcc --version
>     gcc (GCC) 5.2.0
>     $ valgrind --version
>     valgrind-3.10.0.SVN
>
> But, looking deeper I've noticed the test uses a locale which is not
> available on my system (ja_JP.eucJP).
> Here are couple of related tests:
>
>     # (the extra commit .90 is the ununsed-code removal
>     #  http://lists.gnu.org/archive/html/bug-sed/2015-07/msg00005.html)
>     $ ./sed/sed --version | head -n1
>     ./sed/sed (GNU sed) 4.2.2.90-9f3b
>
>     # The locale I don't have produces 'ff'
>     $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/' | od -tx1a
>     0000000  62  ff  43  0a
>               b del   C  nl
>     0000004
>
>     # A locale I do have works as expected
>     $ echo a | LC_ALL=ja_JP.utf8 ./sed/sed -e 's/a/b\U\xb2c/' | od -tx1a
>     0000000  62  43  0a
>               b   C  nl
>     0000003
>
> For comparison, an older 'sed':
>
>     $ sed --version
>     sed (GNU sed) 4.2.2
>
>     # Existing locale
>     $ echo a | LC_ALL=ja_JP.utf8 sed -e 's/a/b\U\xb2c/' | od -tx1a
>     0000000  62  00  43  0a
>               b nul   C  nl
>     0000004
>
>     # non-existing locale
>     $ echo a | LC_ALL=ja_JP.eucJP sed -e 's/a/b\U\xb2c/' | od -tx1a
>     0000000  62  ff  43  0a
>               b del   C  nl
>     0000004
>
> So perhaps the fix is simply to skip the test if the locale doesn't exist.

Thank you for investigating.

We already have a configure-time test to detect the desired
type of locale. The attached patch makes this test use
the configure-set variable, $LOCALE_JA, and skip the test
when its value is "none". Does that work for you?

[0001-tests-avoid-false-failure-on-system-with-no-ja_JP.eu.patch (text/x-patch, attachment)]

Message #17 received at 21124 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 21124 <at> debbugs.gnu.org
Subject: Re: bug#21124: 'invalid-mb-seq-UMR' test fails
Date: Fri, 31 Jul 2015 01:49:10 +0000

On Thu, Jul 30, 2015 at 09:56:29AM -0700, Jim Meyering wrote:

>We already have a configure-time test to detect the desired
>type of locale. The attached patch makes this test use
>the configure-set variable, $LOCALE_JA, and skip the test
>when its value is "none". Does that work for you?

Yes, the test pass with this patch.

regards, 
 assaf

Message #22 received at 21124-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 21124-done <at> debbugs.gnu.org
Subject: Re: bug#21124: 'invalid-mb-seq-UMR' test fails
Date: Thu, 30 Jul 2015 22:40:17 -0700

On Thu, Jul 30, 2015 at 6:49 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> On Thu, Jul 30, 2015 at 09:56:29AM -0700, Jim Meyering wrote:
>
>> We already have a configure-time test to detect the desired
>> type of locale. The attached patch makes this test use
>> the configure-set variable, $LOCALE_JA, and skip the test
>> when its value is "none". Does that work for you?
>
>
> Yes, the test pass with this patch.

Thanks.
I've pushed that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.