GNU bug report logs - #21122
compilation error (-Wunused-macros) with gcc-5.2

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Assaf Gordon <assafgordon <at> gmail.com>
Subject: bug#21122: closed (Re: bug#21122: compilation error
 (-Wunused-macros) with gcc-5.2)
Date: Sat, 01 Aug 2015 16:19:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#21122: compilation error (-Wunused-macros) with gcc-5.2

which was filed against the sed package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 21122 <at> debbugs.gnu.org.

-- 
21122: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21122
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 21122-done <at> debbugs.gnu.org
Subject: Re: bug#21122: compilation error (-Wunused-macros) with gcc-5.2
Date: Sat, 1 Aug 2015 09:17:54 -0700

On Thu, Jul 23, 2015 at 2:42 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> Hello,
>
> compiling sed from git (v4.2.2-89-ge387009) fails with gcd-5.2 due to
> -Wunused-macros (and -Werror):
>
> ===
> make[3]: Entering directory `/home/gordon/sources/sed/sed'
>   CC       compile.o
> compile.c:36:0: error: macro "OPEN_BRACE" is not used
> [-Werror=unused-macros]
>  #define OPEN_BRACE '{'
>  ^
> compile.c:183:0: error: macro "END_ERRORS" is not used
> [-Werror=unused-macros]
>  #define END_ERRORS (INCOMPLETE_CMD + sizeof(N_("incomplete command")))
>  ^
> cc1: all warnings being treated as errors
> make[3]: *** [compile.o] Error 1
> ===
>
> The attached patch comments-out the two macros. Alternatively they could be
> simply erased.

Thank you. I've pushed that with slight tweaks to the commit log.

> P.S.
> I don't yet have copyright assignment for sed, but I think this change is
> trivial enough.

Yes, that's fine.

[Message part 3 (message/rfc822, inline)]

From: Assaf Gordon <assafgordon <at> gmail.com>
To: bug-sed <at> gnu.org
Subject: compilation error (-Wunused-macros) with gcc-5.2
Date: Thu, 23 Jul 2015 17:42:19 -0400

[Message part 4 (text/plain, inline)]

Hello,

compiling sed from git (v4.2.2-89-ge387009) fails with gcd-5.2 due to -Wunused-macros (and -Werror):

===
make[3]: Entering directory `/home/gordon/sources/sed/sed'
  CC       compile.o
compile.c:36:0: error: macro "OPEN_BRACE" is not used [-Werror=unused-macros]
 #define OPEN_BRACE '{'
 ^
compile.c:183:0: error: macro "END_ERRORS" is not used [-Werror=unused-macros]
 #define END_ERRORS (INCOMPLETE_CMD + sizeof(N_("incomplete command")))
 ^
cc1: all warnings being treated as errors
make[3]: *** [compile.o] Error 1
===

The attached patch comments-out the two macros. Alternatively they could be simply erased.

regards,
 - assaf

P.S.
I don't yet have copyright assignment for sed, but I think this change is trivial enough.

[sed-unused-macros.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.