From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 17:42:19 2015 Received: (at submit) by debbugs.gnu.org; 23 Jul 2015 21:42:19 +0000 Received: from localhost ([127.0.0.1]:57561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIOFv-00014h-3f for submit@debbugs.gnu.org; Thu, 23 Jul 2015 17:42:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33651) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZIOFs-00014Y-Dm for submit@debbugs.gnu.org; Thu, 23 Jul 2015 17:42:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIOFr-0000s0-0a for submit@debbugs.gnu.org; Thu, 23 Jul 2015 17:42:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIOFq-0000rw-Tj for submit@debbugs.gnu.org; Thu, 23 Jul 2015 17:42:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIOFp-000166-VS for bug-sed@gnu.org; Thu, 23 Jul 2015 17:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIOFm-0000rI-Pm for bug-sed@gnu.org; Thu, 23 Jul 2015 17:42:13 -0400 Received: from mail-qk0-x235.google.com ([2607:f8b0:400d:c09::235]:36693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIOFm-0000rB-LA for bug-sed@gnu.org; Thu, 23 Jul 2015 17:42:10 -0400 Received: by qkdv3 with SMTP id v3so3638977qkd.3 for ; Thu, 23 Jul 2015 14:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=wz0v5R7JbHfT+Bd6A1pA4k5gwmWKkypUEtjin9yQxjM=; b=w9kzJRfNd0R9py1feQp5J7z5Wxq7TdwDrdCmkeJWSu/vrjSVZOr9ASP9RIfgiPva/4 x+cKbGnudEuv3zCiiN1pj2vOv91fvVrSyNpXEqUZSabcX46j77ANfVpEqkWnbJZ4E1gN pOlApKABco6ayJ0K5eYFJ1/O+cG8KtJWJQ9c4aPPzhX8k1CG/lX1qF6rrTsXwggsZG0N lRXx29oHZDpo/ciyYWR7ptkyYwSQ8qNUC+QTUjvxhygnO75wmUNlyPy3tfPIvULZe3Wg lM+1MuyP+C8VY4jGOGvZxvPdOfxaBq9Ym4DVY30ra5YsljYEV1DC57gugP+f55DnjGwD /UUA== X-Received: by 10.55.43.142 with SMTP id r14mr15643608qkr.42.1437687729956; Thu, 23 Jul 2015 14:42:09 -0700 (PDT) Received: from disco.erlich.nygenome.org ([162.212.111.2]) by smtp.googlemail.com with ESMTPSA id b196sm3059839qka.14.2015.07.23.14.42.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jul 2015 14:42:08 -0700 (PDT) Message-ID: <55B15FBB.5040805@gmail.com> Date: Thu, 23 Jul 2015 17:42:19 -0400 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: bug-sed@gnu.org Subject: compilation error (-Wunused-macros) with gcc-5.2 Content-Type: multipart/mixed; boundary="------------060508050101020704010707" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a multi-part message in MIME format. --------------060508050101020704010707 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, compiling sed from git (v4.2.2-89-ge387009) fails with gcd-5.2 due to -Wunused-macros (and -Werror): === make[3]: Entering directory `/home/gordon/sources/sed/sed' CC compile.o compile.c:36:0: error: macro "OPEN_BRACE" is not used [-Werror=unused-macros] #define OPEN_BRACE '{' ^ compile.c:183:0: error: macro "END_ERRORS" is not used [-Werror=unused-macros] #define END_ERRORS (INCOMPLETE_CMD + sizeof(N_("incomplete command"))) ^ cc1: all warnings being treated as errors make[3]: *** [compile.o] Error 1 === The attached patch comments-out the two macros. Alternatively they could be simply erased. regards, - assaf P.S. I don't yet have copyright assignment for sed, but I think this change is trivial enough. --------------060508050101020704010707 Content-Type: text/x-diff; name="sed-unused-macros.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="sed-unused-macros.patch" >From 9f3be7fc52f3b5b8f8dab5941f1173806526f786 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Thu, 23 Jul 2015 17:23:20 -0400 Subject: [PATCH] build: comment-out unused macros * sed/compile.c: comment-out OPEN_BRACE, END_ERRORS to prevent gcc-5.2 from failing with -Werror -Wunused-macros. --- sed/compile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sed/compile.c b/sed/compile.c index 51fd24d..51103e5 100644 --- a/sed/compile.c +++ b/sed/compile.c @@ -33,7 +33,7 @@ /* let's not confuse text editors that have only dumb bracket-matching... */ #define OPEN_BRACKET '[' #define CLOSE_BRACKET ']' -#define OPEN_BRACE '{' +/* #define OPEN_BRACE '{' */ #define CLOSE_BRACE '}' struct prog_info { @@ -180,7 +180,7 @@ static const char errors[] = #define UNKNOWN_CMD (INVALID_LINE_0 \ + sizeof(N_("invalid usage of line address 0"))) #define INCOMPLETE_CMD (UNKNOWN_CMD + sizeof(N_("unknown command: `%c'"))) -#define END_ERRORS (INCOMPLETE_CMD + sizeof(N_("incomplete command"))) +/* #define END_ERRORS (INCOMPLETE_CMD + sizeof(N_("incomplete command"))) */ static struct output *file_read = NULL; static struct output *file_write = NULL; -- 1.9.1 --------------060508050101020704010707-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 01 12:18:17 2015 Received: (at 21122-done) by debbugs.gnu.org; 1 Aug 2015 16:18:17 +0000 Received: from localhost ([127.0.0.1]:36752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZLZUG-0005qB-Rk for submit@debbugs.gnu.org; Sat, 01 Aug 2015 12:18:17 -0400 Received: from mail-ig0-f176.google.com ([209.85.213.176]:35634) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZLZUE-0005q3-Te for 21122-done@debbugs.gnu.org; Sat, 01 Aug 2015 12:18:15 -0400 Received: by igr7 with SMTP id 7so33190304igr.0 for <21122-done@debbugs.gnu.org>; Sat, 01 Aug 2015 09:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=t1fSurHF8cEIAC0rpsJL7Fz2fekHK1FwBTiUv4WHTbM=; b=UuqGyAVoDxZ/jU0JyxqGxCRwlX5xvNbtYmkbb1dyq14KNQXmg6/kUOJOmYGf8LPO3q z6THyN6oMHQTSH/ZscHnqbIagqotOACjQEu8PzY5vjD7Sw4J964GRlLfYXqurUybLJss pDsmDTxakYbpiVHApMh1O8Ec16WAyKkMqIMdM6u2eBK4HDyqc4TJaaIw9fplNa8Qh8lw ScpxDOSiAQDySotXNtSW79Tu1NzjhbRGxAMQy2Gvz2+uV20E1/jAtvMfFqQ54Po5HLEn nIQ3O6Mb+Dc/p357/trGGtTu+4eyq0iIknQbSfBjfvcdZ8PW28EwaJNlV6MWtyDgU8/u b/gg== X-Received: by 10.50.2.9 with SMTP id 9mr13077156igq.42.1438445894255; Sat, 01 Aug 2015 09:18:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.10.72 with HTTP; Sat, 1 Aug 2015 09:17:54 -0700 (PDT) In-Reply-To: <55B15FBB.5040805@gmail.com> References: <55B15FBB.5040805@gmail.com> From: Jim Meyering Date: Sat, 1 Aug 2015 09:17:54 -0700 X-Google-Sender-Auth: G5e7pZxFVjElD2vGiTIrL7VWFyc Message-ID: Subject: Re: bug#21122: compilation error (-Wunused-macros) with gcc-5.2 To: Assaf Gordon Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21122-done Cc: 21122-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, Jul 23, 2015 at 2:42 PM, Assaf Gordon wrote: > Hello, > > compiling sed from git (v4.2.2-89-ge387009) fails with gcd-5.2 due to > -Wunused-macros (and -Werror): > > === > make[3]: Entering directory `/home/gordon/sources/sed/sed' > CC compile.o > compile.c:36:0: error: macro "OPEN_BRACE" is not used > [-Werror=unused-macros] > #define OPEN_BRACE '{' > ^ > compile.c:183:0: error: macro "END_ERRORS" is not used > [-Werror=unused-macros] > #define END_ERRORS (INCOMPLETE_CMD + sizeof(N_("incomplete command"))) > ^ > cc1: all warnings being treated as errors > make[3]: *** [compile.o] Error 1 > === > > The attached patch comments-out the two macros. Alternatively they could be > simply erased. Thank you. I've pushed that with slight tweaks to the commit log. > P.S. > I don't yet have copyright assignment for sed, but I think this change is > trivial enough. Yes, that's fine. From unknown Sun Aug 17 10:17:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Aug 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator