Subject: bug#21117: closed (Re: bug#21117: [PATCH 4/4] Remove sigevent structure value definitions)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 29 Oct 2015 22:47:04 +0000

Your bug report

#21117: [PATCH 4/4] Remove sigevent structure value definitions

which was filed against the guile package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
21117: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21117
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#21117: [PATCH 4/4] Remove sigevent structure value definitions
From: [email-masked] (Ludovic Courtès)
To: David Michael <[email-masked]>
Cc: [email-masked]
Date: Thu, 29 Oct 2015 23:46:30 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

David Michael <[email-masked]> skribis:

> * libguile/Makefile.am (chknew-E chknew-SIG): Anchor the end of the
>   signal/error name pattern to only match alphanumeric symbols.
> * libguile/cpp-SIG.syms (SIGEV_MAX_SIZE, SIGEV_NONE): Remove.
>   (SIGEV_PAD_SIZE, SIGEV_SIGNAL, SIGEV_THREAD): Likewise.
>   (SIGEV_THREAD_ID): Likewise.
> ---
>
>
> I'm assuming those sigevent structure values weren't intended to have
> their definitions included with signals.  This patch removes them and
> adds stricter name matching to the regexp.

Good catch.  Pushed as c3f95ec.

Thanks!

Ludo’.

Subject: [PATCH 4/4] Remove sigevent structure value definitions
From: David Michael <[email-masked]>
To: [email-masked]
Date: Wed, 22 Jul 2015 12:54:32 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

* libguile/Makefile.am (chknew-E chknew-SIG): Anchor the end of the
  signal/error name pattern to only match alphanumeric symbols.
* libguile/cpp-SIG.syms (SIGEV_MAX_SIZE, SIGEV_NONE): Remove.
  (SIGEV_PAD_SIZE, SIGEV_SIGNAL, SIGEV_THREAD): Likewise.
  (SIGEV_THREAD_ID): Likewise.
---

I'm assuming those sigevent structure values weren't intended to have
their definitions included with signals.  This patch removes them and
adds stricter name matching to the regexp.

 libguile/Makefile.am  | 2 +-
 libguile/cpp-SIG.syms | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/libguile/Makefile.am b/libguile/Makefile.am
index dfa3be0..851799a 100644
--- a/libguile/Makefile.am
+++ b/libguile/Makefile.am
@@ -821,7 +821,7 @@ chknew-E chknew-SIG:
 	echo "#include <$${bit}.h>"				\
 	 | sed 's/E/errno/;s/SIG/signal/'			\
 	 | gcc -dM -E -						\
-	 | sed 's/^#define //;/^'$$bit'[0-9A-Z][0-9A-Z]*/!d;s/ .*//'	\
+	 | sed 's/^#define //;/^'$$bit'[0-9A-Z][0-9A-Z]* /!d;s/ .*//'	\
 	 | sort | diff -u $$old - | sed '1,2d;/^+/!d;s/^.//'	\
 	 > TMP ;						\
 	if [ -s TMP ] ; then new="$$old.NEW" ;			\
diff --git a/libguile/cpp-SIG.syms b/libguile/cpp-SIG.syms
index 2a619ce..728a294 100644
--- a/libguile/cpp-SIG.syms
+++ b/libguile/cpp-SIG.syms
@@ -6,12 +6,6 @@ SIGCHLD
 SIGCLD
 SIGCONT
 SIGEMT
-SIGEV_MAX_SIZE
-SIGEV_NONE
-SIGEV_PAD_SIZE
-SIGEV_SIGNAL
-SIGEV_THREAD
-SIGEV_THREAD_ID
 SIGFPE
 SIGHUP
 SIGILL
-- 
2.1.0