GNU bug report logs - #21117
[PATCH 4/4] Remove sigevent structure value definitions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21117 in the body.
You can then email your comments to 21117 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Michael <fedora.dm0 <at> gmail.com>
To: bug-guile <at> gnu.org
Subject: [PATCH 4/4] Remove sigevent structure value definitions
Date: Wed, 22 Jul 2015 12:54:32 -0400

* libguile/Makefile.am (chknew-E chknew-SIG): Anchor the end of the
  signal/error name pattern to only match alphanumeric symbols.
* libguile/cpp-SIG.syms (SIGEV_MAX_SIZE, SIGEV_NONE): Remove.
  (SIGEV_PAD_SIZE, SIGEV_SIGNAL, SIGEV_THREAD): Likewise.
  (SIGEV_THREAD_ID): Likewise.
---


I'm assuming those sigevent structure values weren't intended to have
their definitions included with signals.  This patch removes them and
adds stricter name matching to the regexp.


 libguile/Makefile.am  | 2 +-
 libguile/cpp-SIG.syms | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/libguile/Makefile.am b/libguile/Makefile.am
index dfa3be0..851799a 100644
--- a/libguile/Makefile.am
+++ b/libguile/Makefile.am
@@ -821,7 +821,7 @@ chknew-E chknew-SIG:
 	echo "#include <$${bit}.h>"				\
 	 | sed 's/E/errno/;s/SIG/signal/'			\
 	 | gcc -dM -E -						\
-	 | sed 's/^#define //;/^'$$bit'[0-9A-Z][0-9A-Z]*/!d;s/ .*//'	\
+	 | sed 's/^#define //;/^'$$bit'[0-9A-Z][0-9A-Z]* /!d;s/ .*//'	\
 	 | sort | diff -u $$old - | sed '1,2d;/^+/!d;s/^.//'	\
 	 > TMP ;						\
 	if [ -s TMP ] ; then new="$$old.NEW" ;			\
diff --git a/libguile/cpp-SIG.syms b/libguile/cpp-SIG.syms
index 2a619ce..728a294 100644
--- a/libguile/cpp-SIG.syms
+++ b/libguile/cpp-SIG.syms
@@ -6,12 +6,6 @@ SIGCHLD
 SIGCLD
 SIGCONT
 SIGEMT
-SIGEV_MAX_SIZE
-SIGEV_NONE
-SIGEV_PAD_SIZE
-SIGEV_SIGNAL
-SIGEV_THREAD
-SIGEV_THREAD_ID
 SIGFPE
 SIGHUP
 SIGILL
-- 
2.1.0

Message #10 received at 21117-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: David Michael <fedora.dm0 <at> gmail.com>
Cc: 21117-done <at> debbugs.gnu.org
Subject: Re: bug#21117: [PATCH 4/4] Remove sigevent structure value definitions
Date: Thu, 29 Oct 2015 23:46:30 +0100

David Michael <fedora.dm0 <at> gmail.com> skribis:

> * libguile/Makefile.am (chknew-E chknew-SIG): Anchor the end of the
>   signal/error name pattern to only match alphanumeric symbols.
> * libguile/cpp-SIG.syms (SIGEV_MAX_SIZE, SIGEV_NONE): Remove.
>   (SIGEV_PAD_SIZE, SIGEV_SIGNAL, SIGEV_THREAD): Likewise.
>   (SIGEV_THREAD_ID): Likewise.
> ---
>
>
> I'm assuming those sigevent structure values weren't intended to have
> their definitions included with signals.  This patch removes them and
> adds stricter name matching to the regexp.

Good catch.  Pushed as c3f95ec.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.