From unknown Tue Jun 17 20:39:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#21091 <21091@debbugs.gnu.org> To: bug#21091 <21091@debbugs.gnu.org> Subject: Status: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error Reply-To: bug#21091 <21091@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:39:26 +0000 retitle 21091 25.0.50; `isearch-done' called before `isearch-update' raises= wrong-type-arg error reassign 21091 emacs submitter 21091 Drew Adams severity 21091 minor tag 21091 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 23:58:07 2015 Received: (at submit) by debbugs.gnu.org; 19 Jul 2015 03:58:07 +0000 Received: from localhost ([127.0.0.1]:53452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZGfjr-0001o4-6Z for submit@debbugs.gnu.org; Sat, 18 Jul 2015 23:58:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60516) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZGfjp-0001na-6v for submit@debbugs.gnu.org; Sat, 18 Jul 2015 23:58:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGfji-0001Q8-Lh for submit@debbugs.gnu.org; Sat, 18 Jul 2015 23:57:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGfji-0001Px-JN for submit@debbugs.gnu.org; Sat, 18 Jul 2015 23:57:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGfjh-0006PD-9q for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2015 23:57:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGfja-0001PC-S1 for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2015 23:57:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGfja-0001P8-LL for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2015 23:57:50 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t6J3vmxx013166 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 19 Jul 2015 03:57:48 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t6J3vlSv018095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Sun, 19 Jul 2015 03:57:47 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t6J3vY3N011690 for ; Sun, 19 Jul 2015 03:57:34 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 18 Jul 2015 20:57:32 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Dunno whether I'll be able to convince you that this is a bug, but here goes. Recently someone added `isearch--current-buffer' to isearch.el. This is initially nil. It is given a string value (buffer name) only in `isearch-update'. But it is called in `isearch-done' and expected to have a string value there. If it does not, a wrong-type-arg error is raised. I have code that defines some Isearch commands that each start out by calling (isearch-done) - they can be called at top level or from `isearch-mode-map'. Here is the beginning of one: (defun foo (arg) (interactive "P") (bar 'isearch-forward arg)) (defun bar (arg) (isearch-done) (setq isearch-success t isearch-adjusted t) (let* ((enable-recursive-minibuffers t) ...) ... (setq isearch-filter-predicate ...) ...) (funcall search-fn)) When called at top level, `isearch--current-buffer' is nil, and the wrong-type arg error is raised. I can "fix" the problem that was introduced by wrapping the `isearch-done' call in `ignore-errors'. But I think it would be better for isearch.el not to assume that `isearch-done' is called after `isearch-update'. I don't think there is a reason why the two need to be coupled in that way. Adding variable `isearch--current-buffer' in the way it was done makes the isearch.el code more fragile than it needs to be, I think. Anyway, please consider somehow ensuring that `isearch-done' does not care whether `isearch--current-buffer' has a string value. Perhaps one possibility would be something like this - dunno. (when isearch--current-buffer (with-current-buffer isearch--current-buffer (setq isearch--current-buffer nil) (setq cursor-sensor-inhibit (delq 'isearch cursor-sensor-inhibit)))) Or maybe even: (when (and isearch--current-buffer (get-buffer isearch--current-buffer)) ...) In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2015-07-03 on LEG570 Bzr revision: 2b848fadd51e805b2f46da64c5958ea7f009048a Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --host=3Di686-pc-mingw32 --enable-checking=3Dyes,glyphs' From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 17:27:44 2016 Received: (at 21091) by debbugs.gnu.org; 30 Apr 2016 21:27:45 +0000 Received: from localhost ([127.0.0.1]:58589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awcQS-00024U-O1 for submit@debbugs.gnu.org; Sat, 30 Apr 2016 17:27:44 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:60601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awcQR-00024N-Nt for 21091@debbugs.gnu.org; Sat, 30 Apr 2016 17:27:44 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awcQP-0006uS-8X; Sat, 30 Apr 2016 23:27:43 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#21091: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error References: Date: Sat, 30 Apr 2016 23:27:39 +0200 In-Reply-To: (Drew Adams's message of "Sat, 18 Jul 2015 20:57:32 -0700 (PDT)") Message-ID: <87inyyait0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 21091 Cc: 21091@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > Dunno whether I'll be able to convince you that this is a bug, but here > goes. > > Recently someone added `isearch--current-buffer' to isearch.el. > > This is initially nil. It is given a string value (buffer name) only in > `isearch-update'. But it is called in `isearch-done' and expected to > have a string value there. If it does not, a wrong-type-arg error is > raised. If I understand you correctly, I don't think this is a bug. If somebody else disagrees, please reopen this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 17:27:49 2016 Received: (at control) by debbugs.gnu.org; 30 Apr 2016 21:27:49 +0000 Received: from localhost ([127.0.0.1]:58592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awcQX-00024m-0i for submit@debbugs.gnu.org; Sat, 30 Apr 2016 17:27:49 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:60608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awcQV-00024d-TR for control@debbugs.gnu.org; Sat, 30 Apr 2016 17:27:48 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awcQT-0006uY-NA for control@debbugs.gnu.org; Sat, 30 Apr 2016 23:27:47 +0200 Date: Sat, 30 Apr 2016 23:27:45 +0200 Message-Id: <87h9eiaisu.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #21091 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 21091 notabug close 21091 From unknown Tue Jun 17 20:39:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 29 May 2016 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 03 19:22:09 2016 Received: (at control) by debbugs.gnu.org; 3 Sep 2016 23:22:09 +0000 Received: from localhost ([127.0.0.1]:49022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgKGF-000797-Ej for submit@debbugs.gnu.org; Sat, 03 Sep 2016 19:22:09 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgKGD-00078b-C4 for control@debbugs.gnu.org; Sat, 03 Sep 2016 19:22:05 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u83NLxiU013419 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 3 Sep 2016 23:21:59 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u83NLw73013826 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 3 Sep 2016 23:21:59 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u83NLws2006209 for ; Sat, 3 Sep 2016 23:21:58 GMT MIME-Version: 1.0 Message-ID: <2c7fd4f3-5c05-47cb-a1ac-f159c7e48027@default> Date: Sat, 3 Sep 2016 16:21:56 -0700 (PDT) From: Drew Adams To: control@debbugs.gnu.org Subject: unarchive 21091 X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) unarchive 21091 thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 03 20:08:54 2016 Received: (at 21091) by debbugs.gnu.org; 4 Sep 2016 00:08:55 +0000 Received: from localhost ([127.0.0.1]:49028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgKzW-0001OW-Op for submit@debbugs.gnu.org; Sat, 03 Sep 2016 20:08:54 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgKzU-0001OI-TA for 21091@debbugs.gnu.org; Sat, 03 Sep 2016 20:08:53 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u8408ja8009526 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 4 Sep 2016 00:08:45 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u8408hdP010975 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 4 Sep 2016 00:08:44 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u8408gkh014086; Sun, 4 Sep 2016 00:08:43 GMT MIME-Version: 1.0 Message-ID: <37c2e51c-3593-4e67-ae29-ce8705a412bf@default> Date: Sat, 3 Sep 2016 17:08:41 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#21091: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error References: <87inyyait0.fsf@gnus.org> In-Reply-To: <87inyyait0.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 21091 Cc: 21091@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) > > Recently someone added `isearch--current-buffer' to isearch.el. > > > > This is initially nil. It is given a string value (buffer name) only i= n > > `isearch-update'. But it is called in `isearch-done' and expected to > > have a string value there. If it does not, a wrong-type-arg error is > > raised... > >=20 > > When called at top level, `isearch--current-buffer' is nil, and the > > wrong-type arg error is raised. > >=20 > > I can "fix" the problem that was introduced by wrapping the > > `isearch-done' call in `ignore-errors'. But I think it would be better > > for isearch.el not to assume that `isearch-done' is called after > > `isearch-update'. I don't think there is a reason why the two need to > > be coupled in that way. Adding variable `isearch--current-buffer' in > > the way it was done makes the isearch.el code more fragile than it need= s > > to be, I think. > >=20 > > Anyway, please consider somehow ensuring that `isearch-done' does not > > care whether `isearch--current-buffer' has a string value. >=20 > If I understand you correctly, I don't think this is a bug. If somebody > else disagrees, please reopen this bug report. No reason given? Why do you think it is not a bug? Why do you not think that "adding variable `isearch--current-buffer' in the way it was done makes the isearch.el code more fragile than it needs to be"? Why should the code assume that `isearch-done' is called only after `isearch-update'? There is nothing inherent in `isearch-done' that suggests that. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 03 23:44:55 2016 Received: (at 21091) by debbugs.gnu.org; 4 Sep 2016 03:44:55 +0000 Received: from localhost ([127.0.0.1]:49059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgOMZ-00073O-0D for submit@debbugs.gnu.org; Sat, 03 Sep 2016 23:44:55 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:34832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgOMX-000736-AO; Sat, 03 Sep 2016 23:44:53 -0400 Received: by mail-it0-f45.google.com with SMTP id e124so100460141ith.0; Sat, 03 Sep 2016 20:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SBLHm8EQsrXrR8QyRI19NrdaIrQw2beyk5igSV8Lk/s=; b=lzqY20CSBW83HdmHJ8Opl0QvtYydl6Y6tnK8JlPZXv95GPXeYxDIUZ0XUlLXJq959D iWetCRh+yRSorEpgEDXw2B2tIcx808mvcUCPCpyXJEkebs6+Ho491m61EexDz8AotuV0 UUPEjaDXgV1OA2cueC2Ole+avqPIUrn1o5ixtGEMcd0GuEPfqylEkCxys8klVU0UvIrH Ul4XRWN++vAh3NkuVbh5drPZdhCEq0s2eVQs/O4Xe8r5oN0pkSsT8IrQJZNnpc98HWiE zDBA+Z3m4GOztWsiMjrPog8TphaybzyNP5BeaqBADpOcAxbU33PsY6uFGr7drFLgoI/E gfpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=SBLHm8EQsrXrR8QyRI19NrdaIrQw2beyk5igSV8Lk/s=; b=TveqcvK2beAYROCpHxFiRr+qzdhw4ki1mNFCHMNqDtX6AzbnGib8cVUYcIrL0fv0Rw cIRJa74DDzvm4ht+qtLokHTtUyiCR2d/f3cZCIvRxVXEQzoFd0qgTamLhXS/3KzJAdJZ aT3teUcJMV8/JTorfv4ZAaL1wKxzH4KY1GOcIsQHlcP/7mRF3SUt6/jFE3GMfw1K7a8a CyysPihZ5oIJfI8EfvkRg4/qhvyTmDxdZ70T7jEKLwFrEkSjcFRAp+QNyO63JnxzHyuI 1NzzfO2unN48gkrR5aNiKbPYzrN7yOB08EdhFz9RAEfbAO2U+vHRYYkbnjuwYT9GrKZx /EpQ== X-Gm-Message-State: AE9vXwPFTE4VXIv9ezJ9Qmf/G+lzeHZG3GYLkE6iiMEAsgYSqtRRcMzBxk6BCl0mOq2pPw== X-Received: by 10.36.55.146 with SMTP id r140mr14417563itr.73.1472960687744; Sat, 03 Sep 2016 20:44:47 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id r123sm3002780ith.1.2016.09.03.20.44.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Sep 2016 20:44:47 -0700 (PDT) From: npostavs@users.sourceforge.net To: Drew Adams Subject: Re: bug#21091: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error References: Date: Sat, 03 Sep 2016 23:45:07 -0400 In-Reply-To: (Drew Adams's message of "Sat, 18 Jul 2015 20:57:32 -0700 (PDT)") Message-ID: <87h99w9vlo.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 21091 Cc: 21091@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain tags 21091 patch quit Drew Adams writes: > > Anyway, please consider somehow ensuring that `isearch-done' does not > care whether `isearch--current-buffer' has a string value. Make sense to me, I suggest the following (isearch-update checks for a buffer value, so I went with that to be consistent): --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=v1-0001-Don-t-require-isearch-update-before-isearch-done.patch Content-Description: patch >From 5d7697546800ad3494df1d06d24e12f2fe987350 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 3 Sep 2016 23:38:35 -0400 Subject: [PATCH v1] Don't require isearch-update before isearch-done It is useful to be able to call `isearch-done' unconditionally to ensure a non-isearching state. * lisp/isearch.el (isearch-done): Check that `isearch--current-buffer' is a live buffer before using it (Bug #21091). --- lisp/isearch.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/isearch.el b/lisp/isearch.el index b50379a..39ed8af 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -1045,9 +1045,10 @@ isearch-done (remove-hook 'mouse-leave-buffer-hook 'isearch-done) (remove-hook 'kbd-macro-termination-hook 'isearch-done) (setq isearch-lazy-highlight-start nil) - (with-current-buffer isearch--current-buffer - (setq isearch--current-buffer nil) - (setq cursor-sensor-inhibit (delq 'isearch cursor-sensor-inhibit))) + (when (buffer-live-p isearch--current-buffer) + (with-current-buffer isearch--current-buffer + (setq isearch--current-buffer nil) + (setq cursor-sensor-inhibit (delq 'isearch cursor-sensor-inhibit)))) ;; Called by all commands that terminate isearch-mode. ;; If NOPUSH is non-nil, we don't push the string on the search ring. -- 2.9.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 04 01:44:05 2016 Received: (at 21091) by debbugs.gnu.org; 4 Sep 2016 05:44:05 +0000 Received: from localhost ([127.0.0.1]:49090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgQDt-0004zs-8A for submit@debbugs.gnu.org; Sun, 04 Sep 2016 01:44:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgQDr-0004zE-Hd for 21091@debbugs.gnu.org; Sun, 04 Sep 2016 01:44:03 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u845htGr002447 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 4 Sep 2016 05:43:56 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u845htM7011054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 4 Sep 2016 05:43:55 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u845hs3V030047; Sun, 4 Sep 2016 05:43:55 GMT MIME-Version: 1.0 Message-ID: <947c6384-eeb3-475b-be8d-2277d0f799af@default> Date: Sat, 3 Sep 2016 22:43:54 -0700 (PDT) From: Drew Adams To: npostavs@users.sourceforge.net Subject: RE: bug#21091: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error References: <87h99w9vlo.fsf@users.sourceforge.net> In-Reply-To: <87h99w9vlo.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 21091 Cc: 21091@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) > > Anyway, please consider somehow ensuring that `isearch-done' does not > > care whether `isearch--current-buffer' has a string value. >=20 > Make sense to me, I suggest the following (isearch-update checks for a > buffer value, so I went with that to be consistent): Haven't tested, but it looks good to me. I think that's all that's needed. Thanks for doing this. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 04 16:47:47 2016 Received: (at 21091) by debbugs.gnu.org; 4 Sep 2016 20:47:47 +0000 Received: from localhost ([127.0.0.1]:49922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgeKR-0004Ow-8h for submit@debbugs.gnu.org; Sun, 04 Sep 2016 16:47:47 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:35576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgeKO-0004Oe-NY; Sun, 04 Sep 2016 16:47:45 -0400 Received: by mail-it0-f52.google.com with SMTP id e124so119903924ith.0; Sun, 04 Sep 2016 13:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XMe6Nuu+iTvqzeZiuvRWhDHMIR+3SjRekw5KCFT+jC0=; b=yPKtIcjqfZGGFqtv062OjBvZgo/EE22zpBxltzH32tnBbTVHcI7cHjgh0mUlaukWzm T3ef0oZ0CGHWtYuKHUa7hRvY9ht/AlQhA86IBBD4wR1OXZG9wTN06KfEbod/7J15eB3e zpuCdCRoO5JRoWFvmwWWh07jRtgmCkrRfcoSu4c90d+dJEvieFrK+/JEWdGY3b51Ou7I 5QhW8Qw/8z2dYgCa6U7+C2QRcmOQbMPEPjSq8MevJhj/KLt8hAaq59F+X431ZTx5cwQ6 nuwpn9YHXv4iDUMuXZMy433FeserX9TjHKB8Kr79pqMi9bzCpNSzgQ6KAWEvUti9ic4w Bz8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=XMe6Nuu+iTvqzeZiuvRWhDHMIR+3SjRekw5KCFT+jC0=; b=Ukbeme/yWhEuMAIK45wWdRwAIV8gijqPqvRsPvDucezi0Ulqw2QjEO0qKWOLqSWz1y JCJU4aPSTrME5Cmt5A8kMt88R07tqSXgzTDL2iEzXTydS2W+giMWJ6onpDHNzoNkFARY T2jbWgxV+4nKwOAbS5VrzV+FrX4V11eGMNp7wWnzS8aaJTBONJeHhGURdkK7mMQB+3dZ Tfd2SOywogIBfapzsg1jDEt0I/YFYmdic2c57pAnMiiHV/d+CF30o4+sKrQaoyPAPbDU udv2sJysZCMRmiL6RWo54p6u4APhKt2r2k7fsS83qkmkWpdu11sQeZWyI4AkYuIugehe ALkA== X-Gm-Message-State: AE9vXwPQlSvZAixGAuzOyuGpCv13FlABwwykOEiH1Yib5zOOsVQp09AkqiwNHzrXFz5BWg== X-Received: by 10.36.3.201 with SMTP id e192mr19684795ite.34.1473022059058; Sun, 04 Sep 2016 13:47:39 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id v7sm8182491ita.9.2016.09.04.13.47.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Sep 2016 13:47:38 -0700 (PDT) From: npostavs@users.sourceforge.net To: Drew Adams Subject: Re: bug#21091: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error References: <87h99w9vlo.fsf@users.sourceforge.net> <947c6384-eeb3-475b-be8d-2277d0f799af@default> Date: Sun, 04 Sep 2016 16:47:59 -0400 In-Reply-To: <947c6384-eeb3-475b-be8d-2277d0f799af@default> (Drew Adams's message of "Sat, 3 Sep 2016 22:43:54 -0700 (PDT)") Message-ID: <87bn039ytc.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 21091 - notabug found 21091 25.1 quit Drew Adams writes: >> > Anyway, please consider somehow ensuring that `isearch-done' does not >> > care whether `isearch--current-buffer' has a string value. >> >> Make sense to me, I suggest the following (isearch-update checks for a >> buffer value, so I went with that to be consistent): > > Haven't tested, but it looks good to me. I think that's all that's > needed. Thanks for doing this. [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.214.52 listed in dnsbl.sorbs.net] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.52 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.214.52 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 21091 Cc: 21091@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 21091 - notabug found 21091 25.1 quit Drew Adams writes: >> > Anyway, please consider somehow ensuring that `isearch-done' does not >> > care whether `isearch--current-buffer' has a string value. >> >> Make sense to me, I suggest the following (isearch-update checks for a >> buffer value, so I went with that to be consistent): > > Haven't tested, but it looks good to me. I think that's all that's > needed. Thanks for doing this. [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.214.52 listed in wl.mailspike.net] 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.214.52 listed in dnsbl.sorbs.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.52 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different --=-=-= Content-Type: text/plain tags 21091 - notabug found 21091 25.1 quit Drew Adams writes: >> > Anyway, please consider somehow ensuring that `isearch-done' does not >> > care whether `isearch--current-buffer' has a string value. >> >> Make sense to me, I suggest the following (isearch-update checks for a >> buffer value, so I went with that to be consistent): > > Haven't tested, but it looks good to me. I think that's all that's > needed. Thanks for doing this. Speaking of testing, I think this sort thing would benefit from a regression test, so I added that to the patch. I will to master push in a few days if there are no objections. --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=v2-0001-Don-t-require-isearch-update-before-isearch-done.patch Content-Description: patch v2 >From 2f00da3a255a2fb46ce4819a3153e04d9d9d59c9 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 3 Sep 2016 23:38:35 -0400 Subject: [PATCH v2] Don't require isearch-update before isearch-done It is useful to be able to call `isearch-done' unconditionally to ensure a non-isearching state. * lisp/isearch.el (isearch-done): Check that `isearch--current-buffer' is a live buffer before using it (Bug #21091). * test/lisp/isearch-tests.el (isearch--test-done): Test it. --- lisp/isearch.el | 7 ++++--- test/lisp/isearch-tests.el | 8 ++++++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/lisp/isearch.el b/lisp/isearch.el index b50379a..39ed8af 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -1045,9 +1045,10 @@ isearch-done (remove-hook 'mouse-leave-buffer-hook 'isearch-done) (remove-hook 'kbd-macro-termination-hook 'isearch-done) (setq isearch-lazy-highlight-start nil) - (with-current-buffer isearch--current-buffer - (setq isearch--current-buffer nil) - (setq cursor-sensor-inhibit (delq 'isearch cursor-sensor-inhibit))) + (when (buffer-live-p isearch--current-buffer) + (with-current-buffer isearch--current-buffer + (setq isearch--current-buffer nil) + (setq cursor-sensor-inhibit (delq 'isearch cursor-sensor-inhibit)))) ;; Called by all commands that terminate isearch-mode. ;; If NOPUSH is non-nil, we don't push the string on the search ring. diff --git a/test/lisp/isearch-tests.el b/test/lisp/isearch-tests.el index 48c3424..52f312d 100644 --- a/test/lisp/isearch-tests.el +++ b/test/lisp/isearch-tests.el @@ -28,5 +28,13 @@ (isearch-update) (should (equal isearch--current-buffer (current-buffer))))) +(ert-deftest isearch--test-done () + ;; Normal operation. + (isearch-update) + (isearch-done) + (should-not isearch--current-buffer) + ;; Bug #21091: let `isearch-done' work without `isearch-update'. + (isearch-done)) + (provide 'isearch-tests) ;;; isearch-tests.el ends here -- 2.9.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 10 09:50:46 2016 Received: (at control) by debbugs.gnu.org; 10 Sep 2016 13:50:46 +0000 Received: from localhost ([127.0.0.1]:55195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biigA-0006dX-Eh for submit@debbugs.gnu.org; Sat, 10 Sep 2016 09:50:46 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biig8-0006dL-G5 for control@debbugs.gnu.org; Sat, 10 Sep 2016 09:50:44 -0400 Received: by mail-oi0-f45.google.com with SMTP id m11so204727555oif.1 for ; Sat, 10 Sep 2016 06:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FY/gpwmzvsJ/TQXqPZUObgQbY/5dANV8kio/Ytcl9X0=; b=NYxbwbQFX5eHEKwFTvrg03cL/W9eb8pqFQB4dpd07nySZxe/raC7z3B3ZKvaCHjgoB 5WA9UyMlIfvb5h569pxM+dpUjy5oVRxCQGQlrrhFaKkDYG4BqZ1OzMJItagIk1fXewcH +QJG7qKLviCky7/6sgMpPW1IzvnIIPJ35nuJEWcr9qDakJdmEs7kr3Ze/tmXtXzLnnUM 1niMn8ZHarK8pMQAYArjgtLBisBrKsYHjwQ1wS32/0INdSqsXARfwWe8B6i1F/mVEY2l FF4+42eIUs70a7Tevs/bBxPCx6wDcJDe9YkEn2JGgTl/7hc7EjxGFSI5T9D3L0R2e8i6 a+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=FY/gpwmzvsJ/TQXqPZUObgQbY/5dANV8kio/Ytcl9X0=; b=muq09D1atNASXOJN3xkInANjGuy/qkI2a5WMu8DLuMe1G4CFSnI2ExrzXTaGbIpIm8 XdwCw+Ogdt6s1Bizikvfsoo2UQ8K1HYy7C0ImkVSc14gvkMXkV3t2h3inLmIGJSTGdCM h8IihDo/0t3NOZgxVTaBlKgNEu3zGxVpdl0+lBIer0T39Nuhc9v0t6y+3g5wHu9cvrqJ T9J0MzQTLPA+EE/Lc+GHifLNVm+IXS/9BmsmGYqUzoXjTZ48J0c9OdzDQBL/KYSCJ5jo QkJHl0RBIYggyXKhvrLSq0trGmZkXbeeuxv8wLH1QTeYirSDRWAUWrug/E/GLXio9tlJ 2NsA== X-Gm-Message-State: AE9vXwNcFl4zv7abzK/2HpTx0dU119RDcUENTslpZCkNBLwt2ohDvR+jkIUhYm5koYZGtQ== X-Received: by 10.202.170.199 with SMTP id t190mr14057155oie.120.1473515438780; Sat, 10 Sep 2016 06:50:38 -0700 (PDT) Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id z125sm9599797itc.0.2016.09.10.06.50.38 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Sep 2016 06:50:38 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: Re: bug#21091: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error References: <87h99w9vlo.fsf@users.sourceforge.net> <947c6384-eeb3-475b-be8d-2277d0f799af@default> <87bn039ytc.fsf@users.sourceforge.net> Date: Sat, 10 Sep 2016 09:51:00 -0400 In-Reply-To: <87bn039ytc.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sun, 04 Sep 2016 16:47:59 -0400") Message-ID: <87lgyz2797.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 21091 fixed close 21091 25.2 quit npostavs@users.sourceforge.net writes: > > Speaking of testing, I think this sort thing would benefit from a > regression test, so I added that to the patch. I will to master push in > a few days if there are no objections. [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.218.45 listed in dnsbl.sorbs.net] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.218.45 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.45 listed in wl.mailspike.net] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 21091 fixed close 21091 25.2 quit npostavs@users.sourceforge.net writes: > > Speaking of testing, I think this sort thing would benefit from a > regression test, so I added that to the patch. I will to master push in > a few days if there are no objections. [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.218.45 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.45 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.218.45 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid tags 21091 fixed close 21091 25.2 quit npostavs@users.sourceforge.net writes: > > Speaking of testing, I think this sort thing would benefit from a > regression test, so I added that to the patch. I will to master push in > a few days if there are no objections. Pushed as 68f4b529 From unknown Tue Jun 17 20:39:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 09 Oct 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator