GNU bug report logs - #21086
24.5; python.el: python-shell-buffer-substring fails under certain circumstances

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: fgallina <at> gnu.org (Fabián Ezequiel Gallina)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#21086: closed (24.5; python.el: python-shell-buffer-substring
 fails under certain circumstances)
Date: Sun, 23 Aug 2015 23:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 23 Aug 2015 20:01:15 -0300
with message-id <874mjpip8k.fsf <at> gnu.org>
and subject line 24.5; python.el: python-shell-buffer-substring fails under certain circumstances
has caused the debbugs.gnu.org bug report #21086,
regarding 24.5; python.el: python-shell-buffer-substring fails under certain circumstances
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
21086: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21086
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yuri D'Elia <wavexx <at> thregr.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; python.el: python-shell-buffer-substring fails under certain
 circumstances
Date: Sat, 18 Jul 2015 18:13:33 +0200

[Message part 3 (text/plain, inline)]

Assuming some python buffer like:

#....
if 1:
    print 1

where the selected region is "print \"1\"" (mark before "p"),
`python-shell-send-region' would fail with:

File "test.py", line 3
    print 1
        ^
IndentationError: expected an indented block

The reason lies within `python-shell-buffer-substring', which assumes
that a region always starts with the correct indentation.

The attached patch fixes the above behavior: when the region doesn't
start with indentation, but the current block does (looking at
(current-indentation)), we prefix the fillstr with the correct amount of
indent.

[python-buffer-substring.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: fgallina <at> gnu.org (Fabián Ezequiel Gallina)
To: 21086-done <at> debbugs.gnu.org
Subject: 24.5; python.el: python-shell-buffer-substring fails under certain
 circumstances
Date: Sun, 23 Aug 2015 20:01:15 -0300

Fixed in master at af013e0.

I installed a different patch that seems to be more robust on various
conditions (see tests).


Thanks for such detailed report,
Fabián.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.