GNU bug report logs - #21071
Gnus message flags must be set before expiration, not afterwards

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 21071 <at> debbugs.gnu.org
Cc: Nikolaus Rath <Nikolaus <at> rath.org>, ding <ding <at> gnus.org>
Subject: bug#21071: Gnus message flags must be set before expiration, not afterwards
Date: Thu, 26 Jan 2017 20:43:53 +0100

Nikolaus Rath <Nikolaus <at> rath.org> writes:

> I did not find any specific guarantees on when
> gnus-summary-prepare-exit-hook is called in the documentation, but that
> doesn't mean that people are not relying on the current calling
> order. Would a change like that nevertheless be acceptable?
>
> Alternatively, is what do people think about removing
> gnus-summary-expire-articles from the default value of
> gnus-summary-prepare-exit-hook and explicitly calling
> gnus-summary-expire-articles from gnus-summary-exit?

I don't know why that function is in that hook by default; it seems
kinda messy.  But removing things from hooks isn't that easy since
people add things, or set values explicitly.

But we could call gnus-summary-expire-articles in the natural place
unless it's in that hook, perhaps?  And then remove it from the default
value and hope for the best.

Patches welcome.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.