GNU bug report logs -
#21067
25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob
Previous Next
Reported by: Wolfgang Jenkner <wjenkner <at> inode.at>
Date: Wed, 15 Jul 2015 18:25:01 UTC
Severity: normal
Tags: moreinfo, patch
Found in version 25.0.50
Fixed in version 26.2
Done: Dmitry Gutov <dgutov <at> yandex.ru>
Bug is archived. No further changes may be made.
Full log
Message #8 received at 21067 <at> debbugs.gnu.org (full text, mbox):
On 07/15/2015 02:09 PM, Wolfgang Jenkner wrote:
> So I wonder whether it wouldn't be worthwile to make their job easier
> (and thereby avoid bugs like the one described above) by handling async
> and sync processes alike in this respect. The condition for this to
> work is that backend functions don't expect point to be preserved,
> except, of course, if it is actually their purpose to compute point
> (like for vc-git-show-log-entry).
I like the idea, but FWIW the patch breaks diff-hl-revert-hunk (diff-hl
is in GNU ELPA). Haven't investigated it further yet.
And the particular bug you've described, naturally, can also be fixed by
making vc-hg-print-log asynchronous:
diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index 556174a..f634e2e 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -272,7 +272,7 @@ If LIMIT is non-nil, show no more than this many
entries."
(let ((inhibit-read-only t))
(with-current-buffer
buffer
- (apply 'vc-hg-command buffer 0 files "log"
+ (apply 'vc-hg-command buffer 'async files "log"
(nconc
(when start-revision (list (format "-r%s:0" start-revision)))
(when limit (list "-l" (format "%s" limit)))
This bug report was last modified 4 years and 43 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.