GNU bug report logs - #21057
[PATCH] nnimap.el: add support for IMAP namespaces

Previous Next

Packages: emacs, gnus;

Reported by: Nikolaus Rath <Nikolaus <at> rath.org>

Date: Wed, 15 Jul 2015 02:17:02 UTC

Severity: wishlist

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nikolaus Rath <Nikolaus <at> rath.org>
Cc: Andreas Schwab <schwab <at> suse.de>, 21057 <at> debbugs.gnu.org
Subject: bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces
Date: Wed, 27 Dec 2017 22:10:36 +0100

Nikolaus Rath <Nikolaus <at> rath.org> writes:

>> Looks good to me.  It needs to be documented in the manual, though, and
>> perhaps a NEWS entry...
>
> Updated patch is attached.

Looks good, but a couple of niggles:

> +(setq nnimap-namespaces nil)

This should be a defvar, or rather, a defvoo.

[...]

> +  (let* ((prefix (cadr (assoc (nnoo-current-server 'nnimap)
> +                              nnimap-namespaces)))
> +         (inbox (substring prefix 0 -1)))

And then you could just set nnimap-namespaces without maintaining a
per-server alist, since that's what the voo machinery does for you
(switching out variables on a per-server basis).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 6 years and 290 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.