Subject: Re: bug#21057: [PATCH] nnimap.el: add support for IMAP namespaces

From: Lars Ingebrigtsen <[email-masked]>
Date: Wed, 27 Dec 2017 22:10:36 +0100

Nikolaus Rath <[email-masked]> writes:

>> Looks good to me.  It needs to be documented in the manual, though, and
>> perhaps a NEWS entry...
>
> Updated patch is attached.

Looks good, but a couple of niggles:

> +(setq nnimap-namespaces nil)

This should be a defvar, or rather, a defvoo.

[...]

> +  (let* ((prefix (cadr (assoc (nnoo-current-server 'nnimap)
> +                              nnimap-namespaces)))
> +         (inbox (substring prefix 0 -1)))

And then you could just set nnimap-namespaces without maintaining a
per-server alist, since that's what the voo machinery does for you
(switching out variables on a per-server basis).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no