GNU bug report logs - #21054
25.0.50; Can't edit SES documents: Not at cell

Previous Next

Package: emacs;

Reported by: Óscar Fuentes <ofv <at> wanadoo.es>

Date: Tue, 14 Jul 2015 10:40:03 UTC

Severity: normal

Merged with 22082

Fixed in version 25.0.50

Done: Óscar Fuentes <ofv <at> wanadoo.es>

Bug is archived. No further changes may be made.

Full log


Message #44 received at 21054 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Óscar Fuentes <ofv <at> wanadoo.es>, 21054 <at> debbugs.gnu.org
Subject: Re: bug#21054: Reopen
Date: Thu, 19 Nov 2015 11:37:26 -0600
Stephen Leake <stephen_leake <at> stephe-leake.org> writes:

> Stephen Leake <stephen_leake <at> stephe-leake.org> writes:

> I spoke too soon; this allows hitting <return> on cell A1. But hitting
> <return> on cell C8 shows the contents of A1. So I missed something.

Found it; the change deleted (ses-set-curcell) from ses-command-hook, I
assume because it was in a section labeled "update mode line". But it
also updates ses--curcell, so I put it back, and things seem to work:

diff --git a/lisp/ses.el b/lisp/ses.el
index ec1359b..564d2a5 100644
--- a/lisp/ses.el
+++ b/lisp/ses.el
@@ -1905,6 +1905,8 @@ Narrows the buffer to show only the print area.  Gives it `read-only' and
                           (forward-char)
                           (point))))
             (put-text-property pos end 'cursor-intangible sym))))))
+  (goto-char (point-min))
+  (ses-set-curcell))
   ;; Create the underlining overlay.  It's impossible for (point) to be 2,
   ;; because column A must be at least 1 column wide.
   (setq ses--curcell-overlay (make-overlay (1+ (point-min)) (1+ (point-min))))
@@ -2063,7 +2065,11 @@ narrows the buffer now."
 	  ;; read the local variables at the end of the file.  Now it's safe to
 	  ;; do the narrowing.
 	  (narrow-to-region (point-min) ses--data-marker)
-	  (setq ses--deferred-narrow nil)))
+	  (setq ses--deferred-narrow nil))
+
+        ;; Update the current cell
+        (ses-set-curcell))
+
     ;; Prevent errors in this post-command-hook from silently erasing the hook!
     (error
      (unless executing-kbd-macro

-- 
-- Stephe




This bug report was last modified 9 years and 142 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.