GNU bug report logs - #21052
[PATCH] tests: fix $? typo in null-byte

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 21052 <at> debbugs.gnu.org
Cc: Paul Eggert <eggert <at> cs.ucla.edu>
Subject: bug#21052: [PATCH] tests: fix $? typo in null-byte
Date: Mon, 13 Jul 2015 16:11:11 -0700

* tests/null-byte: Don't assume $? survives an invocation of 'test'.
---
 tests/null-byte | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/null-byte b/tests/null-byte
index 27be99e..2419667 100755
--- a/tests/null-byte
+++ b/tests/null-byte
@@ -39,7 +39,9 @@ for left in '' a '#' '\0'; do
           printf "$pat\\n" >pat || framework_failure_
           for locale in $locales; do
             LC_ALL=$locale grep -f pat in
-            test $? -eq 0 || test $? -eq 1 || fail_ "'$pat' caused an error"
+            status=$?
+            test $status -eq 0 || test $status -eq 1 ||
+              fail_ "'$pat' caused an error"
             LC_ALL=$locale grep -a -f pat in | cmp -s - in ||
               fail_ "-a '$pat' does not match '$data'"
           done
-- 
2.1.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.