GNU bug report logs - #21047
25.0.50; Make M-x woman respect display-buffer-alist

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21047 in the body.
You can then email your comments to 21047 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>, 
 "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Mon, 13 Jul 2015 15:06:10 +0000

[Message part 1 (text/plain, inline)]

Hi,

This was posted on the emacs-devel list a while back and it was suggested
that this be posted on bug-gnu-emacs.

The aim of this patch is that opening M-x woman buffers be controlled using
display-buffer-alist. Using display-buffer function instead of
switch-to-buffer function will allow the user to control how they want to
open the WoMan buffers (same window, other window, popup, etc)

The patch is below:

Date: Mon, 13 Jul 2015 11:00:39 -0400
Subject: [PATCH] Allow display-buffer-alist to control woman bufs

---
 lisp/woman.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/woman.el b/lisp/woman.el
index 75c3d2e..e903caa 100644
--- a/lisp/woman.el
+++ b/lisp/woman.el
@@ -1651,7 +1651,7 @@ Do not call directly!"
      (setq woman-frame (make-frame)))))
     (set-buffer (get-buffer-create bufname))
     (condition-case nil
-        (switch-to-buffer (current-buffer))
+        (display-buffer (current-buffer))
       (error (pop-to-buffer (current-buffer))))
     (buffer-disable-undo)
     (setq buffer-read-only nil)
@@ -2061,14 +2061,14 @@ alist in `woman-buffer-alist' and return nil."
   (if (zerop woman-buffer-number)
       (let ((buffer (get-buffer (cdr (car woman-buffer-alist)))))
  (if buffer
-    (switch-to-buffer buffer)
+    (display-buffer buffer)
   ;; Delete alist element:
   (setq woman-buffer-alist (cdr woman-buffer-alist))
   nil))
     (let* ((prev-ptr (nthcdr (1- woman-buffer-number) woman-buffer-alist))
    (buffer (get-buffer (cdr (car (cdr prev-ptr))))))
       (if buffer
-  (switch-to-buffer buffer)
+  (display-buffer buffer)
  ;; Delete alist element:
  (setcdr prev-ptr (cdr (cdr prev-ptr)))
  (if (>= woman-buffer-number (length woman-buffer-alist))
-- 
1.9.2


On Wed, Jun 24, 2015 at 12:03 PM Michael Heerdegen <michael_heerdegen <at> web.de>
wrote:

> Hi Kaushal,
>
> > I was trying to make the WoMan buffers open as I intend to using
> > display-buffer-alist. But that was not working.
>
> I guess your message got lost here, better make a bug report, and
> better include a patch than the whole changed code.
>
> > can that change be made in the master?
>
> I think it would be an improvement.
>
> The very same applies to eww:
>
> --8<---------------cut here---------------start------------->8---
> (defun eww-setup-buffer ()
>   (switch-to-buffer (get-buffer-create "*eww*")) ; <-----
>   (let ((inhibit-read-only t))
>     (remove-overlays)
>     (erase-buffer))
>   (unless (eq major-mode 'eww-mode)
>     (eww-mode)))
> --8<---------------cut here---------------end--------------->8---
>
> Maybe there are more cases.  It's surely worth discussing.
>
>
> Regards,
>
> Michael.
>

[Message part 2 (text/html, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>, 
 "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Re: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Thu, 20 Aug 2015 17:35:55 +0000

[Message part 1 (text/plain, inline)]

Can someone please review this?

On Mon, Jul 13, 2015 at 11:06 AM Kaushal <kaushal.modi <at> gmail.com> wrote:

> Hi,
>
> This was posted on the emacs-devel list a while back and it was suggested
> that this be posted on bug-gnu-emacs.
>
> The aim of this patch is that opening M-x woman buffers be controlled
> using display-buffer-alist. Using display-buffer function instead of
> switch-to-buffer function will allow the user to control how they want to
> open the WoMan buffers (same window, other window, popup, etc)
>
> The patch is below:
>
> Date: Mon, 13 Jul 2015 11:00:39 -0400
> Subject: [PATCH] Allow display-buffer-alist to control woman bufs
>
> ---
>  lisp/woman.el | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/woman.el b/lisp/woman.el
> index 75c3d2e..e903caa 100644
> --- a/lisp/woman.el
> +++ b/lisp/woman.el
> @@ -1651,7 +1651,7 @@ Do not call directly!"
>       (setq woman-frame (make-frame)))))
>      (set-buffer (get-buffer-create bufname))
>      (condition-case nil
> -        (switch-to-buffer (current-buffer))
> +        (display-buffer (current-buffer))
>        (error (pop-to-buffer (current-buffer))))
>      (buffer-disable-undo)
>      (setq buffer-read-only nil)
> @@ -2061,14 +2061,14 @@ alist in `woman-buffer-alist' and return nil."
>    (if (zerop woman-buffer-number)
>        (let ((buffer (get-buffer (cdr (car woman-buffer-alist)))))
>   (if buffer
> -    (switch-to-buffer buffer)
> +    (display-buffer buffer)
>    ;; Delete alist element:
>    (setq woman-buffer-alist (cdr woman-buffer-alist))
>    nil))
>      (let* ((prev-ptr (nthcdr (1- woman-buffer-number) woman-buffer-alist))
>     (buffer (get-buffer (cdr (car (cdr prev-ptr))))))
>        (if buffer
> -  (switch-to-buffer buffer)
> +  (display-buffer buffer)
>   ;; Delete alist element:
>   (setcdr prev-ptr (cdr (cdr prev-ptr)))
>   (if (>= woman-buffer-number (length woman-buffer-alist))
> --
> 1.9.2
>
>
> On Wed, Jun 24, 2015 at 12:03 PM Michael Heerdegen <
> michael_heerdegen <at> web.de> wrote:
>
>> Hi Kaushal,
>>
>> > I was trying to make the WoMan buffers open as I intend to using
>> > display-buffer-alist. But that was not working.
>>
>> I guess your message got lost here, better make a bug report, and
>> better include a patch than the whole changed code.
>>
>> > can that change be made in the master?
>>
>> I think it would be an improvement.
>>
>> The very same applies to eww:
>>
>> --8<---------------cut here---------------start------------->8---
>> (defun eww-setup-buffer ()
>>   (switch-to-buffer (get-buffer-create "*eww*")) ; <-----
>>   (let ((inhibit-read-only t))
>>     (remove-overlays)
>>     (erase-buffer))
>>   (unless (eq major-mode 'eww-mode)
>>     (eww-mode)))
>> --8<---------------cut here---------------end--------------->8---
>>
>> Maybe there are more cases.  It's surely worth discussing.
>>
>>
>> Regards,
>>
>> Michael.
>>
>

[Message part 2 (text/html, inline)]

Message #11 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kaushal <kaushal.modi <at> gmail.com>
Cc: michael_heerdegen <at> web.de, 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 01:42:23 -0400

> Can someone please review this?

Looks OK to me,


        Stefan

Message #14 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 07:17:29 -0400

[Message part 1 (text/plain, inline)]

Thanks!

I don't have the commit rights. Can you please apply this patch to the
master?

--
Kaushal Modi
On Aug 21, 2015 1:42 AM, "Stefan Monnier" <monnier <at> iro.umontreal.ca> wrote:

> > Can someone please review this?
>
> Looks OK to me,
>
>
>         Stefan
>

[Message part 2 (text/html, inline)]

Message #17 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Kaushal <kaushal.modi <at> gmail.com>, 
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 14:25:38 +0200

> I don't have the commit rights. Can you please apply this patch to the
> master?

Pushed as 8c01e88..244a008  master -> master.

Thanks, martin

Message #20 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 21047 <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 08:30:57 -0400

[Message part 1 (text/plain, inline)]

Thanks! There goes my first little patch. :)

--
Kaushal Modi
On Aug 21, 2015 8:25 AM, "martin rudalics" <rudalics <at> gmx.at> wrote:

> > I don't have the commit rights. Can you please apply this patch to the
> > master?
>
> Pushed as 8c01e88..244a008  master -> master.
>
> Thanks, martin
>

[Message part 2 (text/html, inline)]

Message #23 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 21047 <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 09:36:10 -0400

[Message part 1 (text/plain, inline)]

I apologize for this maintenance type of request. I saw that my patch was
associated with just my first name "Kaushal" instead of my full name
"Kaushal Modi". I then noticed that that's perhaps because I have probably
unintentionally hidden my last name in the emacs-devel list.

While I figure out and fix this, is it possible to correct the author name
from "Kaushal" to "Kaushal Modi" to be consistent with the first and last
name author convention as seen on all other commits?

Thanks.

Kaushal Modi
On Aug 21, 2015 8:30 AM, "Kaushal" <kaushal.modi <at> gmail.com> wrote:

> Thanks! There goes my first little patch. :)
>
> --
> Kaushal Modi
> On Aug 21, 2015 8:25 AM, "martin rudalics" <rudalics <at> gmx.at> wrote:
>
>> > I don't have the commit rights. Can you please apply this patch to the
>> > master?
>>
>> Pushed as 8c01e88..244a008  master -> master.
>>
>> Thanks, martin
>>
>

[Message part 2 (text/html, inline)]

Message #26 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Kaushal <kaushal.modi <at> gmail.com>
Cc: 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 17:11:36 +0200

> I apologize for this maintenance type of request. I saw that my patch was
> associated with just my first name "Kaushal" instead of my full name
> "Kaushal Modi". I then noticed that that's perhaps because I have probably
> unintentionally hidden my last name in the emacs-devel list.

My bad.  I really should have asked before committing.  But I was
distracted that your patch didn't apply.  Kindly send the next patch as
an attachment to your mail.

> While I figure out and fix this, is it possible to correct the author name
> from "Kaushal" to "Kaushal Modi" to be consistent with the first and last
> name author convention as seen on all other commits?

I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2.
As for the commit message there's hardly anything we can do now.

martin

Message #29 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 15:13:19 +0000

[Message part 1 (text/plain, inline)]

> Kindly send the next patch as an attachment to your mail.

Will do so, thanks.

> I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2.

Thanks.

On Fri, Aug 21, 2015 at 11:11 AM martin rudalics <rudalics <at> gmx.at> wrote:

>  > I apologize for this maintenance type of request. I saw that my patch
> was
>  > associated with just my first name "Kaushal" instead of my full name
>  > "Kaushal Modi". I then noticed that that's perhaps because I have
> probably
>  > unintentionally hidden my last name in the emacs-devel list.
>
> My bad.  I really should have asked before committing.  But I was
> distracted that your patch didn't apply.  Kindly send the next patch as
> an attachment to your mail.
>
>  > While I figure out and fix this, is it possible to correct the author
> name
>  > from "Kaushal" to "Kaushal Modi" to be consistent with the first and
> last
>  > name author convention as seen on all other commits?
>
> I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2.
> As for the commit message there's hardly anything we can do now.
>
> martin
>

[Message part 2 (text/html, inline)]

Message #32 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 15:16:22 +0000

[Message part 1 (text/plain, inline)]

One more thing.. also this bug now needs to be closed, right? And also
referenced in that commit message.

On Fri, Aug 21, 2015 at 11:13 AM Kaushal <kaushal.modi <at> gmail.com> wrote:

> > Kindly send the next patch as an attachment to your mail.
>
> Will do so, thanks.
>
> > I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2.
>
> Thanks.
>
> On Fri, Aug 21, 2015 at 11:11 AM martin rudalics <rudalics <at> gmx.at> wrote:
>
>>  > I apologize for this maintenance type of request. I saw that my patch
>> was
>>  > associated with just my first name "Kaushal" instead of my full name
>>  > "Kaushal Modi". I then noticed that that's perhaps because I have
>> probably
>>  > unintentionally hidden my last name in the emacs-devel list.
>>
>> My bad.  I really should have asked before committing.  But I was
>> distracted that your patch didn't apply.  Kindly send the next patch as
>> an attachment to your mail.
>>
>>  > While I figure out and fix this, is it possible to correct the author
>> name
>>  > from "Kaushal" to "Kaushal Modi" to be consistent with the first and
>> last
>>  > name author convention as seen on all other commits?
>>
>> I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2.
>> As for the commit message there's hardly anything we can do now.
>>
>> martin
>>
>

[Message part 2 (text/html, inline)]

Message #35 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Kaushal <kaushal.modi <at> gmail.com>
Cc: 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 17:30:03 +0200

> One more thing.. also this bug now needs to be closed, right?

Please do that.

> And also
> referenced in that commit message.

I'll do that.  Please remind me as soon as you see the commit in
ChangeLog.2.

martin

Message #38 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 15:33:05 +0000

[Message part 1 (text/plain, inline)]

I don't know how to close a debbugs. I believe only a debbugs admin can do
that?

On Fri, Aug 21, 2015 at 11:30 AM martin rudalics <rudalics <at> gmx.at> wrote:

> > One more thing.. also this bug now needs to be closed, right?
>
> Please do that.
>
> > And also
> > referenced in that commit message.
>
> I'll do that.  Please remind me as soon as you see the commit in
> ChangeLog.2.
>
> martin
>
>

[Message part 2 (text/html, inline)]

Message #43 received at 21047-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Kaushal <kaushal.modi <at> gmail.com>, 
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 21047-done <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 17:58:40 +0200

> I don't know how to close a debbugs. I believe only a debbugs admin can do
> that?

It's easy.  You have to append -done to the bug number in the recipient.
As I'm doing just now ...

martin

Message #46 received at 21047-done <at> debbugs.gnu.org (full text, mbox):

From: Kaushal <kaushal.modi <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 21047-done <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Fri, 21 Aug 2015 16:00:02 +0000

[Message part 1 (text/plain, inline)]

Noted that for the next time. Thanks!

On Fri, Aug 21, 2015 at 11:58 AM martin rudalics <rudalics <at> gmx.at> wrote:

> > I don't know how to close a debbugs. I believe only a debbugs admin can
> do
> > that?
>
> It's easy.  You have to append -done to the bug number in the recipient.
> As I'm doing just now ...
>
> martin
>
>
>

[Message part 2 (text/html, inline)]

Message #49 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Kaushal <kaushal.modi <at> gmail.com>
Cc: 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Mon, 24 Aug 2015 10:16:44 +0200

>> I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2.
>
> Thanks.

Should be done now.  Please have a look.

Thanks again, martin

Message #52 received at 21047 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 21047 <at> debbugs.gnu.org
Subject: Re: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist
Date: Mon, 24 Aug 2015 06:46:07 -0400

[Message part 1 (text/plain, inline)]

Looks good.

Thank you.

--
Kaushal Modi
On Aug 24, 2015 4:16 AM, "martin rudalics" <rudalics <at> gmx.at> wrote:

> >> I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2.
> >
> > Thanks.
>
> Should be done now.  Please have a look.
>
> Thanks again, martin
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.