GNU bug report logs - #21043
[PATCH] nnimap.el: make capability parsing more robust.

Previous Next

Full log

Message #8 received at 21043 <at> debbugs.gnu.org (full text, mbox):

From: Nikolaus Rath <Nikolaus <at> rath.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 21043 <at> debbugs.gnu.org, ding <at> gnus.org, emacs-devel <at> gnu.org
Subject: Re: bug#21043: [PATCH] nnimap.el: make capability parsing more robust.
Date: Mon, 13 Jul 2015 12:00:19 -0700

[Message part 1 (text/plain, inline)]

On Jul 13 2015, Eric Abrahamsen <eric <at> ericabrahamsen.net> wrote:
> Nikolaus Rath <Nikolaus <at> rath.org> writes:
>
>> Package: gnus
>> Tags: patch
>
> There was no patch!

Oops. Here it is.

-- 
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«

[0001-nnimap.el-make-capability-parsing-more-robust.patch (text/x-diff, inline)]

From 241812047dedb1ba7d362c4211a06bf506d37237 Mon Sep 17 00:00:00 2001
From: Nikolaus Rath <Nikolaus <at> rath.org>
Date: Sun, 12 Jul 2015 18:42:48 -0700
Subject: [PATCH] nnimap.el: make capability parsing more robust.

* lisp/nnimap.el (nnimap-open-connection-1): explicitly ask server for
capabilities instead of relying on LOGIN response.
---
 lisp/ChangeLog | 5 +++++
 lisp/nnimap.el | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index d8ab42e..83ac4c4 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,10 @@
 2015-07-12 Nikolaus Rath <Nikolaus <at> rath.org>
 
+	* nnimap.el (nnimap-open-connection-1): explicitly ask server for
+	capabilities instead of relying on LOGIN response.
+
+2015-07-12 Nikolaus Rath <Nikolaus <at> rath.org>
+
 	* nnimap.el (nnimap-request-group-scan)
 	(nnimap-request-create-group, nnimap-request-delete-group)
 	(nnimap-request-rename-group, nnimap-request-move-article)
diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index d11b3a2..19632ad 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -520,7 +520,7 @@ If non-nil, articles flagged as deleted (using the IMAP
 			(funcall (nth 2 credentials)))
 		      ;; See if CAPABILITY is set as part of login
 		      ;; response.
-		      (dolist (response (cddr login-result))
+		      (dolist (response (cddr (nnimap-command "CAPABILITY")))
 			(when (string= "CAPABILITY" (upcase (car response)))
 			  (setf (nnimap-capabilities nnimap-object)
 				(mapcar #'upcase (cdr response))))))
-- 
2.1.4

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.