GNU bug report logs - #21006
25.0.50; xref-quit doesn't restore changes in window scrolling position

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21006 in the body.
You can then email your comments to 21006 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 xref-quit doesn't restore changes in window scrolling position
Date: Wed, 08 Jul 2015 03:46:21 +0300

1. Open lisp/progmodes/elisp-mode.el.

2. M-x xref-find-regexp, type 'defun elisp-[a-z]' (without quotes) when
prompted, press RET.

3. In the xref buffer, press `n' a couple of times, see the window
displaying elisp-mode.el scroll to show the definitions.

4. Press `q', see the previous window configuration restored, but the
scrolling position of the elisp-mode.el window remains changed.

I wonder if we can do anything about that.

While there's nothing surprising in this behavior given the
implementation, the user did lose their position in the buffer, train of
thought, etc.

Message #8 received at 21006 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 21006 <at> debbugs.gnu.org
Subject: Re: bug#21006: 25.0.50; xref-quit doesn't restore changes in window
 scrolling position
Date: Thu, 03 Dec 2020 12:30:09 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> 1. Open lisp/progmodes/elisp-mode.el.
>
> 2. M-x xref-find-regexp, type 'defun elisp-[a-z]' (without quotes) when
> prompted, press RET.

This function no longer exists, so the recipe no longer works.

Is this problem still present in the current Emacs version?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 21006-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 21006-done <at> debbugs.gnu.org
Subject: Re: bug#21006: 25.0.50; xref-quit doesn't restore changes in window
 scrolling position
Date: Thu, 3 Dec 2020 15:38:46 +0200

On 03.12.2020 13:30, Lars Ingebrigtsen wrote:
> This function no longer exists, so the recipe no longer works.
> 
> Is this problem still present in the current Emacs version?

Yes, sure. You can repeat the scenario with 'M-x project-find-regexp'.

The crux is doesn't restore the previous window scroll positions.

This especially cut against the mental model of the older version of the 
UI which presented locations in a more "transient" fashion. But the 
model has changed, and there haven't been any complaints like this 
recently, so let's close it.

Thanks.

Message #16 received at 21006 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 21006 <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#21006: 25.0.50; xref-quit doesn't restore changes in window
 scrolling position
Date: Thu, 3 Dec 2020 16:44:31 +0100

> The crux is doesn't restore the previous window scroll positions.

What are the "previous window scroll positions"?  Note that

  As a special exception, the window configuration does not record the
  value of point in the selected window for the current buffer.

(section 28.26 of the Elisp manual) so if a caller wants that restored,
it has to do it separately.

martin

Message #19 received at 21006 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: martin rudalics <rudalics <at> gmx.at>, 21006 <at> debbugs.gnu.org
Subject: Re: bug#21006: 25.0.50; xref-quit doesn't restore changes in window
 scrolling position
Date: Fri, 4 Dec 2020 02:07:03 +0200

On 03.12.2020 17:44, martin rudalics wrote:
>  > The crux is doesn't restore the previous window scroll positions.
> 
> What are the "previous window scroll positions"?  Note that
> 
>    As a special exception, the window configuration does not record the
>    value of point in the selected window for the current buffer.
> 
> (section 28.26 of the Elisp manual) so if a caller wants that restored,
> it has to do it separately.

That's it.

I wasn't saying it is necessarily a bug in quit-window. Just something 
that would have to be implemented in xref, to have a more consistent 
experience (the bug was for a "future me" or somebody else who had the 
time to look into it).

Not necessary anymore, anyway.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.