From unknown Wed Aug 20 03:37:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20993: 25.0.50; virtual-dired problems Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jul 2015 18:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20993@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14362057248208 (code B ref -1); Mon, 06 Jul 2015 18:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jul 2015 18:02:04 +0000 Received: from localhost ([127.0.0.1]:42381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZCAiR-00028K-Tq for submit@debbugs.gnu.org; Mon, 06 Jul 2015 14:02:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38929) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZCAiP-00027p-Eb for submit@debbugs.gnu.org; Mon, 06 Jul 2015 14:02:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCAiJ-0002Uj-Ad for submit@debbugs.gnu.org; Mon, 06 Jul 2015 14:01:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAiJ-0002Uf-7r for submit@debbugs.gnu.org; Mon, 06 Jul 2015 14:01:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAiF-0006Z9-1e for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:01:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCAi3-0002QJ-Gw for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:01:44 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAi3-0002PW-Ao for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:01:39 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t66I1aB3007184 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 6 Jul 2015 18:01:36 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t66I1ZKn031521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Mon, 6 Jul 2015 18:01:36 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t66I1ZdT008639 for ; Mon, 6 Jul 2015 18:01:35 GMT MIME-Version: 1.0 Message-ID: <55a5f28c-d18e-4d55-a242-71be42c45294@default> Date: Mon, 6 Jul 2015 11:01:34 -0700 (PDT) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) A followup to bug #20992. Here are some other problems noticed immediately, besides the lack of clarity and the nature of the "mode", lighter/menu, etc.: 1. The prompt uses `read-string'. It should use `read-directory-name' or `read-file-name', to provide completion. In fact, given that the parameter list is the same as for `dired', why doesn't `virtual-dired' use `dired-read-dir-and-switches'? OK, presumably it is because you want to use `dired-virtual-guess-dir'. But that doesn't proscribe providing completion etc. 2. It seems that `virtual-dired' tries to reuse the current buffer. But it makes no attempt to ensure that this buffer is in a mode derived from Dired mode - it does not raise an error if not. For example, `M-x virtual-dired' from a buffer showing dired-x.el in read-only mode raises an error because that buffer is read-only. The doc string of `virtual-dired' says nothing about what mode the current buffer must be in, or the fact that the buffer is not switched but instead its mode is changed. You would need to consult the doc string of `dired-virtual-guess-dir' to discover this constraint/assumption: "The buffer is assumed to be in Dired or ls -lR format" That should be tested for. Dunno how the latter can be tested for, but some test should be used to make sure the buffer is appropriate for the kind of changes `virtual-dired' will make to it. As it is now, the code just willy nilly tries to modify the buffer text. 3. Defaulting to `default-directory' should be done in the interactive spec (also). 4. Overall, I'd say that someone should take a look at this `virtual-dired' feature and polish it up a bit. It seems a bit rough, so far. In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' From unknown Wed Aug 20 03:37:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20993: 25.0.50; virtual-dired problems In-Reply-To: <55a5f28c-d18e-4d55-a242-71be42c45294@default> Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jul 2015 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20993@debbugs.gnu.org Received: via spool by 20993-submit@debbugs.gnu.org id=B20993.143628420513436 (code B ref 20993); Tue, 07 Jul 2015 15:51:02 +0000 Received: (at 20993) by debbugs.gnu.org; 7 Jul 2015 15:50:05 +0000 Received: from localhost ([127.0.0.1]:43595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZCV8G-0003Ud-If for submit@debbugs.gnu.org; Tue, 07 Jul 2015 11:50:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38986) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZCV8E-0003U6-Uy for 20993@debbugs.gnu.org; Tue, 07 Jul 2015 11:50:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCV85-00042M-6J for 20993@debbugs.gnu.org; Tue, 07 Jul 2015 11:49:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCV85-000420-1E for 20993@debbugs.gnu.org; Tue, 07 Jul 2015 11:49:53 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ZCV84-0006Nd-Ey; Tue, 07 Jul 2015 11:49:52 -0400 From: Glenn Morris References: <55a5f28c-d18e-4d55-a242-71be42c45294@default> X-Spook: Drug cartel Hail E. Coli White Powder TSA Montenegro X-Ran: *,~E-qzm&U)J0~4W&u~j@At9+HIw(^^^#:6GhQ$|*uJaZ-ev(8G}mPCcB]UyK)!D(Ka:KT X-Hue: cyan X-Attribution: GM Date: Tue, 07 Jul 2015 11:49:52 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.8 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.8 (-----) > It seems a bit rough, so far. Welcome to dired-x. From unknown Wed Aug 20 03:37:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20993: 25.0.50; virtual-dired problems Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 May 2021 23:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 20993@debbugs.gnu.org Received: via spool by 20993-submit@debbugs.gnu.org id=B20993.162207030227168 (code B ref 20993); Wed, 26 May 2021 23:06:02 +0000 Received: (at 20993) by debbugs.gnu.org; 26 May 2021 23:05:02 +0000 Received: from localhost ([127.0.0.1]:50270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm2a9-00073j-3W for submit@debbugs.gnu.org; Wed, 26 May 2021 19:05:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm2a7-00073W-Ov for 20993@debbugs.gnu.org; Wed, 26 May 2021 19:04:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FfQsjfsvhBVvtI0S+laSrtHurUFUJ5ptySTCGDgCJ2g=; b=FLq/7D/gR7vvmt+4QeUH53G+pt ViPuaw98djcI6K+m7klI8sp5kZpQ5UQ7Jru8cMITbzeWktyswdFnU9FbvfTXDD4az50a/i5RyjURZ 5MSrv8dEkkQ2SRXuVF06VFW8+qtWMWowEeN5IWic3TD2tESDCWcOyeGzX0cTNMjLndEE=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm2Zz-0004Ll-KF; Thu, 27 May 2021 01:04:49 +0200 From: Lars Ingebrigtsen References: <55a5f28c-d18e-4d55-a242-71be42c45294@default> X-Now-Playing: Bufiman's _Fabriclive 96 Mixed by Skream_: "Peace Moves" Date: Thu, 27 May 2021 01:04:47 +0200 In-Reply-To: <55a5f28c-d18e-4d55-a242-71be42c45294@default> (Drew Adams's message of "Mon, 6 Jul 2015 11:01:34 -0700 (PDT)") Message-ID: <87k0nl6qr4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > A followup to bug #20992. Here are some other problems noticed > immediately, besides the lack of clarity and the nature of the "mode", > lighter/menu, etc.: > > 1. The prompt uses `read-string'. It [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > A followup to bug #20992. Here are some other problems noticed > immediately, besides the lack of clarity and the nature of the "mode", > lighter/menu, etc.: > > 1. The prompt uses `read-string'. It should use `read-directory-name' > or `read-file-name', to provide completion. Yup; fixed now. > The doc string of `virtual-dired' says nothing about what mode the > current buffer must be in, or the fact that the buffer is not switched > but instead its mode is changed. Ditto. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 19:06:25 2021 Received: (at control) by debbugs.gnu.org; 26 May 2021 23:06:25 +0000 Received: from localhost ([127.0.0.1]:50274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm2bZ-00076G-FO for submit@debbugs.gnu.org; Wed, 26 May 2021 19:06:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm2bY-000761-8g for control@debbugs.gnu.org; Wed, 26 May 2021 19:06:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FKHscgir9y1lQ2bcvWXEWcgL3p//1t9qxSjnhJb8RNU=; b=FnQnyRaHNQrDjoOPCz22CTInyP a3xOkM/x+DXbmXGaTpG+whHStfZjq3xhhUIXnLX+AARyWiKc/RdXDc4Bjk5Kgtc2OqtOFIpx8B155 059kaOxQbjfebigs+lkHxGetW9V/KiC2yF2FEJHw9vm4IETAzESogOUplBmCjXbEnILY=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm2bQ-0004MY-Ie for control@debbugs.gnu.org; Thu, 27 May 2021 01:06:18 +0200 Date: Thu, 27 May 2021 01:06:16 +0200 Message-Id: <87im356qon.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #20993 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 20993 fixed close 20993 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 20993 fixed close 20993 28.1 quit