From unknown Tue Jun 24 17:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode' undeclared Resent-From: John David Anglin Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jul 2015 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20979 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 20979@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.143602540629337 (code B ref -1); Sat, 04 Jul 2015 15:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jul 2015 15:56:46 +0000 Received: from localhost ([127.0.0.1]:39862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBPo5-0007d7-Ic for submit@debbugs.gnu.org; Sat, 04 Jul 2015 11:56:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38832) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBPo4-0007ct-5h for submit@debbugs.gnu.org; Sat, 04 Jul 2015 11:56:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBPnx-0003N1-KB for submit@debbugs.gnu.org; Sat, 04 Jul 2015 11:56:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: *** X-Spam-Status: No, score=3.3 required=5.0 tests=BAYES_50, RECEIVED_FROM_WINDOWS_HOST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:32800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBPnx-0003Mv-Gp for submit@debbugs.gnu.org; Sat, 04 Jul 2015 11:56:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBPnw-0000o3-HM for bug-coreutils@gnu.org; Sat, 04 Jul 2015 11:56:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBPnr-0003Jp-Gz for bug-coreutils@gnu.org; Sat, 04 Jul 2015 11:56:36 -0400 Received: from blu004-omc3s26.hotmail.com ([65.55.116.101]:53503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBPnr-0003J4-DB for bug-coreutils@gnu.org; Sat, 04 Jul 2015 11:56:31 -0400 Received: from BLU436-SMTP112 ([65.55.116.72]) by BLU004-OMC3S26.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Sat, 4 Jul 2015 08:32:32 -0700 X-TMN: [ybK5NDygY5EuplZXqYPbQcteLcJwFkKo] X-Originating-Email: [dave.anglin@bell.net] Message-ID: From: John David Anglin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Sat, 4 Jul 2015 11:32:30 -0400 MIME-Version: 1.0 (Apple Message framework v1085) X-Mailer: Apple Mail (2.1085) X-OriginalArrivalTime: 04 Jul 2015 15:32:31.0529 (UTC) FILETIME=[A4714990:01D0B66E] X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The following error occurs building coreutils-8.24 on = hppa2.0w-hp-hpux11.11 with gcc-5: CC lib/set-permissions.o../lib/set-permissions.c: In function = 'context_acl_from_mode': ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use in = this function) ctx->entries[0].mode =3D (mode >> 6) & 7; ^ ../lib/set-permissions.c:288:27: note: each undeclared identifier is = reported on ly once for each function it appears in ../lib/set-permissions.c: In function 'context_aclv_from_mode': ../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use in = this fun ction) ctx->aclv_entries[0].a_perm =3D (mode >> 6) & 7; ^ ../lib/set-permissions.c:319:26: error: 'entries' undeclared (first use = in this=20 function) ret =3D aclsort (sizeof (entries) / sizeof (struct acl), 1, entries); ^ ../lib/set-permissions.c: In function 'set_acls': ../lib/set-permissions.c:660:69: error: 'source_statbuf' undeclared = (first use in this function) && (from_mode || !acl_nontrivial (ctx->count, ctx->entries, = &source_statbuf))) ^ ../lib/set-permissions.c:660:26: error: too many arguments to function = 'acl_nontrivial' && (from_mode || !acl_nontrivial (ctx->count, ctx->entries, = &source_statbuf))) ^ In file included from ../lib/set-permissions.c:24:0: ../lib/acl-internal.h:215:12: note: declared here extern int acl_nontrivial (int count, struct acl_entry *entries); ^ make[2]: *** [lib/set-permissions.o] Error 1 make[2]: Leaving directory `/xxx/gnu/coreutils-8.24/objdir' make[1]: *** [all-recursive] Error 1 Dave -- John David Anglin dave.anglin@bell.net From unknown Tue Jun 24 17:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode' undeclared Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jul 2015 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20979 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: Gnulib bugs , Andreas Gruenbacher , 20979@debbugs.gnu.org Received: via spool by 20979-submit@debbugs.gnu.org id=B20979.143603343912156 (code B ref 20979); Sat, 04 Jul 2015 18:11:02 +0000 Received: (at 20979) by debbugs.gnu.org; 4 Jul 2015 18:10:39 +0000 Received: from localhost ([127.0.0.1]:39898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBRtd-00039x-Ti for submit@debbugs.gnu.org; Sat, 04 Jul 2015 14:10:39 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50706) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBRta-00039g-JH for 20979@debbugs.gnu.org; Sat, 04 Jul 2015 14:10:36 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CD4F5160919; Sat, 4 Jul 2015 11:10:28 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XfMd5fpoZltL; Sat, 4 Jul 2015 11:10:27 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A172716091C; Sat, 4 Jul 2015 11:10:27 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Vql5ep0CTI4g; Sat, 4 Jul 2015 11:10:27 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 74D2C160919; Sat, 4 Jul 2015 11:10:27 -0700 (PDT) Message-ID: <55982193.6090206@cs.ucla.edu> Date: Sat, 04 Jul 2015 11:10:27 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------080601060908090108010303" X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) This is a multi-part message in MIME format. --------------080601060908090108010303 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit John David Anglin wrote: > The following error occurs building coreutils-8.24 on hppa2.0w-hp-hpux11.11 with gcc-5: > > CC lib/set-permissions.o../lib/set-permissions.c: In function 'context_acl_from_mode': > ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use in this function) > ctx->entries[0].mode = (mode >> 6) & 7; ... Thanks for reporting that. There are some obvious typos in the recent ACL-related patches when compiled on HP-UX. I installed the attached patch into gnulib; can you please give it a try on coreutils 8.24? I don't have access to an HP-UX box to test it myself. I'll CC: this to Andreas Gruenbacher, the author of the recent patches, to give him a heads-up. --------------080601060908090108010303 Content-Type: text/x-diff; name="0001-file-has-acl-acl-permissions-fix-HP-UX-typos.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-file-has-acl-acl-permissions-fix-HP-UX-typos.patch" >From 9d6bb056bf71db9c377a7da616fe24f0ea393057 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 4 Jul 2015 11:05:00 -0700 Subject: [PATCH] file-has-acl, acl-permissions: fix HP-UX typos Problem reported by John David Anglin in: http://bugs.gnu.org/20979 * lib/file-has-acl.c (file_has_acl): * lib/set-permissions.c (context_acl_from_mode) (context_aclv_from_mode, set_acls): Fix some obvious typos when HAVE_GETCL /* HP-UX */. They were introduced by the recent ACL changes. --- ChangeLog | 8 ++++++++ lib/file-has-acl.c | 2 +- lib/set-permissions.c | 20 ++++++++++---------- 3 files changed, 19 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4931868..d6b184a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2015-07-04 Paul Eggert + file-has-acl, acl-permissions: fix HP-UX typos + Problem reported by John David Anglin in: http://bugs.gnu.org/20979 + * lib/file-has-acl.c (file_has_acl): + * lib/set-permissions.c (context_acl_from_mode) + (context_aclv_from_mode, set_acls): + Fix some obvious typos when HAVE_GETCL /* HP-UX */. + They were introduced by the recent ACL changes. + regex: match current GNU grep behavior These symbols have not matched GNU grep behavior for quite some time. Fix prompted by Balazs Kezes bug report at: http://bugs.gnu.org/20974 diff --git a/lib/file-has-acl.c b/lib/file-has-acl.c index 8488b7e..b78a879 100644 --- a/lib/file-has-acl.c +++ b/lib/file-has-acl.c @@ -349,7 +349,7 @@ file_has_acl (char const *name, struct stat const *sb) if (stat (name, &statbuf) < 0) return -1; - return acl_nontrivial (count, entries, &statbuf); + return acl_nontrivial (count, entries); } } } diff --git a/lib/set-permissions.c b/lib/set-permissions.c index a96b86c..41f6cb2 100644 --- a/lib/set-permissions.c +++ b/lib/set-permissions.c @@ -288,13 +288,13 @@ context_acl_from_mode (struct permission_context *ctx, const char *name, int des ctx->entries[0].uid = statbuf.st_uid; ctx->entries[0].gid = ACL_NSGROUP; - ctx->entries[0].mode = (mode >> 6) & 7; + ctx->entries[0].mode = (ctx->mode >> 6) & 7; ctx->entries[1].uid = ACL_NSUSER; ctx->entries[1].gid = statbuf.st_gid; - ctx->entries[1].mode = (mode >> 3) & 7; + ctx->entries[1].mode = (ctx->mode >> 3) & 7; ctx->entries[2].uid = ACL_NSUSER; ctx->entries[2].gid = ACL_NSGROUP; - ctx->entries[2].mode = mode & 7; + ctx->entries[2].mode = ctx->mode & 7; ctx->count = 3; return 0; } @@ -319,7 +319,7 @@ context_aclv_from_mode (struct permission_context *ctx) ctx->aclv_entries[3].a_perm = mode & 7; ctx->aclv_count = 4; - ret = aclsort (sizeof (entries) / sizeof (struct acl), 1, entries); + ret = aclsort (ctx->aclv_count, 1, entries); if (ret > 0) abort (); return ret; @@ -461,19 +461,19 @@ context_acl_from_mode (struct permission_context *ctx) ctx->entries[0].a_type = USER_OBJ; ctx->entries[0].a_id = 0; /* irrelevant */ - ctx->entries[0].a_perm = (mode >> 6) & 7; + ctx->entries[0].a_perm = (ctx->mode >> 6) & 7; ctx->entries[1].a_type = GROUP_OBJ; ctx->entries[1].a_id = 0; /* irrelevant */ - ctx->entries[1].a_perm = (mode >> 3) & 7; + ctx->entries[1].a_perm = (ctx->mode >> 3) & 7; ctx->entries[2].a_type = CLASS_OBJ; ctx->entries[2].a_id = 0; - ctx->entries[2].a_perm = (mode >> 3) & 7; + ctx->entries[2].a_perm = (ctx->mode >> 3) & 7; ctx->entries[3].a_type = OTHER_OBJ; ctx->entries[3].a_id = 0; - ctx->entries[3].a_perm = mode & 7; + ctx->entries[3].a_perm = ctx->mode & 7; ctx->count = 4; - ret = aclsort (sizeof (entries) / sizeof (struct acl), 1, entries); + ret = aclsort (ctx->count, 1, entries); if (ret > 0) abort (); return ret; @@ -660,7 +660,7 @@ set_acls (struct permission_context *ctx, const char *name, int desc, if (ret < 0) { if ((errno == ENOSYS || errno == EOPNOTSUPP || errno == ENOTSUP) - && (from_mode || !acl_nontrivial (ctx->count, ctx->entries, &source_statbuf))) + && (from_mode || !acl_nontrivial (ctx->count, ctx->entries))) ret = 0; } else -- 2.1.0 --------------080601060908090108010303-- From unknown Tue Jun 24 17:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode' undeclared Resent-From: Andreas =?UTF-8?Q?Gr=C3=BCnbacher?= Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jul 2015 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20979 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert Cc: Gnulib bugs , John David Anglin , 20979@debbugs.gnu.org Received: via spool by 20979-submit@debbugs.gnu.org id=B20979.143603599616847 (code B ref 20979); Sat, 04 Jul 2015 18:54:02 +0000 Received: (at 20979) by debbugs.gnu.org; 4 Jul 2015 18:53:16 +0000 Received: from localhost ([127.0.0.1]:39938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBSYu-0004Nf-AC for submit@debbugs.gnu.org; Sat, 04 Jul 2015 14:53:16 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:37129) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBSYs-0004NP-5D for 20979@debbugs.gnu.org; Sat, 04 Jul 2015 14:53:14 -0400 Received: by wicgi11 with SMTP id gi11so122553903wic.0 for <20979@debbugs.gnu.org>; Sat, 04 Jul 2015 11:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=iwDe6RWrAwRLTykCMiUjfI3pR5IfgXm6BXB0kcUK/fs=; b=oo2X/MRoUcw2ZCoAud05wZb45AzwWrReZFoXTf/7YOh93icrsdtzI76CwUbz3jQpkE ni7px5brLTiFi8HOT8T4/zkgBqdLFGqwMgPsi38evZql7Y+EdFzFc8Bw0SSvGsfa4LCo aHeYfBhqS2m3hv9GB2Ot0V2mdsyH2JkdCOeXhNMOCsxB+8nbQGfoIKMBB473tV+bdlNZ lSrbAV8jSjtpzTVWvTmn6AvsDj3drSruI2mSwY4wUQnGZPZeIE+yieZtPO22ewWZc+QB uFiC5HejAtunckGaoTXCGjqbkmj34yx522qp3g4sfzVORQRxYH/ws5j0hrcbI/PLhwBy PIOg== MIME-Version: 1.0 X-Received: by 10.194.91.193 with SMTP id cg1mr38996180wjb.86.1436035988214; Sat, 04 Jul 2015 11:53:08 -0700 (PDT) Received: by 10.28.8.4 with HTTP; Sat, 4 Jul 2015 11:53:08 -0700 (PDT) In-Reply-To: <55982193.6090206@cs.ucla.edu> References: <55982193.6090206@cs.ucla.edu> Date: Sat, 4 Jul 2015 20:53:08 +0200 Message-ID: From: Andreas =?UTF-8?Q?Gr=C3=BCnbacher?= Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Paul, 2015-07-04 20:10 GMT+02:00 Paul Eggert : > John David Anglin wrote: >> >> The following error occurs building coreutils-8.24 on >> hppa2.0w-hp-hpux11.11 with gcc-5: >> >> CC lib/set-permissions.o../lib/set-permissions.c: In function >> 'context_acl_from_mode': >> ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use in >> this function) >> ctx->entries[0].mode = (mode >> 6) & 7; > > ... > > Thanks for reporting that. There are some obvious typos in the recent > ACL-related patches when compiled on HP-UX. I installed the attached patch > into gnulib; can you please give it a try on coreutils 8.24? I don't have > access to an HP-UX box to test it myself. > > I'll CC: this to Andreas Gruenbacher, the author of the recent patches, to > give him a heads-up. thanks for fixing this. Andreas From unknown Tue Jun 24 17:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode' undeclared Resent-From: John David Anglin Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jul 2015 22:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20979 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert Cc: Gnulib bugs , Andreas Gruenbacher , 20979@debbugs.gnu.org Received: via spool by 20979-submit@debbugs.gnu.org id=B20979.143604897413900 (code B ref 20979); Sat, 04 Jul 2015 22:30:05 +0000 Received: (at 20979) by debbugs.gnu.org; 4 Jul 2015 22:29:34 +0000 Received: from localhost ([127.0.0.1]:40021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBVwE-0003c8-41 for submit@debbugs.gnu.org; Sat, 04 Jul 2015 18:29:34 -0400 Received: from blu004-omc2s19.hotmail.com ([65.55.111.94]:62834) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBVwC-0003bt-0b for 20979@debbugs.gnu.org; Sat, 04 Jul 2015 18:29:32 -0400 Received: from BLU437-SMTP85 ([65.55.111.73]) by BLU004-OMC2S19.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Sat, 4 Jul 2015 15:29:26 -0700 X-TMN: [VMzYVS5n3+a7CqAE+FXsAVdr4ha1vzMe] X-Originating-Email: [dave.anglin@bell.net] Message-ID: MIME-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset="us-ascii" From: John David Anglin In-Reply-To: <55982193.6090206@cs.ucla.edu> Date: Sat, 4 Jul 2015 18:29:23 -0400 Content-Transfer-Encoding: quoted-printable References: <55982193.6090206@cs.ucla.edu> X-Mailer: Apple Mail (2.1085) X-OriginalArrivalTime: 04 Jul 2015 22:29:25.0359 (UTC) FILETIME=[E1D8D7F0:01D0B6A8] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) We know have: CC lib/set-permissions.o ../lib/set-permissions.c: In function 'context_aclv_from_mode': ../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use in = this function) ctx->aclv_entries[0].a_perm =3D (mode >> 6) & 7; ^ ../lib/set-permissions.c:307:34: note: each undeclared identifier is = reported only once for each function it appears in ../lib/set-permissions.c:319:38: error: 'entries' undeclared (first use = in this function) ret =3D aclsort (ctx->aclv_count, 1, entries); ^ On 2015-07-04, at 2:10 PM, Paul Eggert wrote: > John David Anglin wrote: >> The following error occurs building coreutils-8.24 on = hppa2.0w-hp-hpux11.11 with gcc-5: >>=20 >> CC lib/set-permissions.o../lib/set-permissions.c: In function = 'context_acl_from_mode': >> ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use = in this function) >> ctx->entries[0].mode =3D (mode >> 6) & 7; > ... >=20 > Thanks for reporting that. There are some obvious typos in the recent = ACL-related patches when compiled on HP-UX. I installed the attached = patch into gnulib; can you please give it a try on coreutils 8.24? I = don't have access to an HP-UX box to test it myself. >=20 > I'll CC: this to Andreas Gruenbacher, the author of the recent = patches, to give him a heads-up. >=20 > <0001-file-has-acl-acl-permissions-fix-HP-UX-typos.patch> CC lib/set-permissions.o ../lib/set-permissions.c: In function 'context_aclv_from_mode': ../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use in = this function) ctx->aclv_entries[0].a_perm =3D (mode >> 6) & 7; ^ ../lib/set-permissions.c:307:34: note: each undeclared identifier is = reported only once for each function it appears in ../lib/set-permissions.c:319:38: error: 'entries' undeclared (first use = in this function) ret =3D aclsort (ctx->aclv_count, 1, entries); ^ -- John David Anglin dave.anglin@bell.net From unknown Tue Jun 24 17:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode' undeclared Resent-From: John David Anglin Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jul 2015 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20979 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: Gnulib bugs , Andreas Gruenbacher , Paul Eggert , 20979@debbugs.gnu.org Received: via spool by 20979-submit@debbugs.gnu.org id=B20979.143604965615157 (code B ref 20979); Sat, 04 Jul 2015 22:41:02 +0000 Received: (at 20979) by debbugs.gnu.org; 4 Jul 2015 22:40:56 +0000 Received: from localhost ([127.0.0.1]:40025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBW77-0003wG-IU for submit@debbugs.gnu.org; Sat, 04 Jul 2015 18:40:56 -0400 Received: from blu004-omc2s25.hotmail.com ([65.55.111.100]:63689) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBW74-0003vy-Fj for 20979@debbugs.gnu.org; Sat, 04 Jul 2015 18:40:47 -0400 Received: from BLU436-SMTP187 ([65.55.111.71]) by BLU004-OMC2S25.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Sat, 4 Jul 2015 15:40:40 -0700 X-TMN: [I+VNPZVwN63vfppRu0/PbNRKEBNWu71p] X-Originating-Email: [dave.anglin@bell.net] Message-ID: MIME-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset="us-ascii" From: John David Anglin In-Reply-To: Date: Sat, 4 Jul 2015 18:40:38 -0400 Content-Transfer-Encoding: quoted-printable References: <55982193.6090206@cs.ucla.edu> X-Mailer: Apple Mail (2.1085) X-OriginalArrivalTime: 04 Jul 2015 22:40:40.0076 (UTC) FILETIME=[74027CC0:01D0B6AA] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) In this function, "mode" needs to be "ctx->mode" and "entries" needs to = be "ctx->aclv_entries". It then compiles okay. Dave On 2015-07-04, at 6:29 PM, John David Anglin wrote: > We know have: >=20 > CC lib/set-permissions.o > ../lib/set-permissions.c: In function 'context_aclv_from_mode': > ../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use = in this function) > ctx->aclv_entries[0].a_perm =3D (mode >> 6) & 7; > ^ > ../lib/set-permissions.c:307:34: note: each undeclared identifier is = reported only once for each function it appears in > ../lib/set-permissions.c:319:38: error: 'entries' undeclared (first = use in this function) > ret =3D aclsort (ctx->aclv_count, 1, entries); > ^ >=20 > On 2015-07-04, at 2:10 PM, Paul Eggert wrote: >=20 >> John David Anglin wrote: >>> The following error occurs building coreutils-8.24 on = hppa2.0w-hp-hpux11.11 with gcc-5: >>>=20 >>> CC lib/set-permissions.o../lib/set-permissions.c: In function = 'context_acl_from_mode': >>> ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use = in this function) >>> ctx->entries[0].mode =3D (mode >> 6) & 7; >> ... >>=20 >> Thanks for reporting that. There are some obvious typos in the = recent ACL-related patches when compiled on HP-UX. I installed the = attached patch into gnulib; can you please give it a try on coreutils = 8.24? I don't have access to an HP-UX box to test it myself. >>=20 >> I'll CC: this to Andreas Gruenbacher, the author of the recent = patches, to give him a heads-up. >>=20 >> <0001-file-has-acl-acl-permissions-fix-HP-UX-typos.patch> >=20 >=20 > CC lib/set-permissions.o > ../lib/set-permissions.c: In function 'context_aclv_from_mode': > ../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use = in this function) > ctx->aclv_entries[0].a_perm =3D (mode >> 6) & 7; > ^ > ../lib/set-permissions.c:307:34: note: each undeclared identifier is = reported only once for each function it appears in > ../lib/set-permissions.c:319:38: error: 'entries' undeclared (first = use in this function) > ret =3D aclsort (ctx->aclv_count, 1, entries); > ^ >=20 > -- > John David Anglin dave.anglin@bell.net >=20 >=20 >=20 >=20 -- John David Anglin dave.anglin@bell.net From unknown Tue Jun 24 17:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode' undeclared Resent-From: Andreas =?UTF-8?Q?Gr=C3=BCnbacher?= Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 05 Jul 2015 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20979 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: John David Anglin Cc: Gnulib bugs , Paul Eggert , 20979@debbugs.gnu.org Received: via spool by 20979-submit@debbugs.gnu.org id=B20979.14360932592909 (code B ref 20979); Sun, 05 Jul 2015 10:48:02 +0000 Received: (at 20979) by debbugs.gnu.org; 5 Jul 2015 10:47:39 +0000 Received: from localhost ([127.0.0.1]:40163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBhSU-0000kq-Je for submit@debbugs.gnu.org; Sun, 05 Jul 2015 06:47:38 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:34637) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBhSQ-0000kY-4D for 20979@debbugs.gnu.org; Sun, 05 Jul 2015 06:47:34 -0400 Received: by wifm2 with SMTP id m2so6191752wif.1 for <20979@debbugs.gnu.org>; Sun, 05 Jul 2015 03:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ur4xblv1BkJ0RoqswUKV6hBIIfcR4E/nHqP8y3duZsY=; b=KnL1Vup4nuSMk3JVDTnOfiQ05gQa6mN7h1kJ41U0A2e4g+CM34CVQj37+qvLcc7pG2 VtPGUEdO961YYOfw3Kb7JkZQqtynyn8987JA0gPgrY5gmOQ+oYMZ5lUkK7EPt3OJ/2qo Dohu9zLLmQLMRyiVHzGK8Ni6JSKM+nxS8dHIOL0kNR6w5/UNN8A5fs7SBcam/BCE6ip5 w+QAFugzVLkVl90KwRZILpQ9MAou3UUDJuO3nNlG4W3S5FM+kl+DC9Yvmm4ORhDi95am eQadDUXmoVT2orhmeE0Cdr1eXeO1XpYoDNJ/et2MSTs3IYxrNaaeWyTw2O/tiM20uaT3 MHJQ== MIME-Version: 1.0 X-Received: by 10.180.90.228 with SMTP id bz4mr44209497wib.69.1436093248488; Sun, 05 Jul 2015 03:47:28 -0700 (PDT) Received: by 10.28.8.4 with HTTP; Sun, 5 Jul 2015 03:47:28 -0700 (PDT) In-Reply-To: References: <55982193.6090206@cs.ucla.edu> Date: Sun, 5 Jul 2015 12:47:28 +0200 Message-ID: From: Andreas =?UTF-8?Q?Gr=C3=BCnbacher?= Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) David, 2015-07-05 0:40 GMT+02:00 John David Anglin : > In this function, "mode" needs to be "ctx->mode" and "entries" needs to be "ctx->aclv_entries". > It then compiles okay. thanks, I've fixed this in gnulib. Still needs to be pulled into coreutils. Andreas From unknown Tue Jun 24 17:24:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode' undeclared Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 23 Oct 2018 02:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20979 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 20979@debbugs.gnu.org Received: via spool by 20979-submit@debbugs.gnu.org id=B20979.154026222412173 (code B ref 20979); Tue, 23 Oct 2018 02:38:01 +0000 Received: (at 20979) by debbugs.gnu.org; 23 Oct 2018 02:37:04 +0000 Received: from localhost ([127.0.0.1]:36841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEmZ6-0003AB-6Q for submit@debbugs.gnu.org; Mon, 22 Oct 2018 22:37:04 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:42795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEmZ3-00039Y-T8; Mon, 22 Oct 2018 22:37:02 -0400 Received: by mail-io1-f53.google.com with SMTP id n18-v6so28327300ioa.9; Mon, 22 Oct 2018 19:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=s3INGGovBFVhmX7QtTFnrO+FkS94X+2A6b2Y+zQS7qY=; b=igUrq8jTZam6dF6v0S7ExISwIG8PwKvUGTA5uTvcr0mw4wDZcSDUvVoeqSFFd6TmeW Wp/m5gmF4Uxs1qVWmH04Nh8v/sgjc/6qiGdRVFWpagMUP7IJQQcB7Vhl83vqB3cMijD3 qE/GXJTgXp6zoxC/zg0ulphpueWOqVmcbR9zuLHuh1iRXvbpIv4l0mM9Tbit4sNeiC++ Zl8y21Kzc++Go1lJCtccqM9fVSVDBTDCXFdbi/ZzgkNqqzMtXNrBfLl5gI6HYJRQKdv5 uXAlT86OBTbGugD5UXm2tCV89cuNB50Srbmrgw/HoUmNjTD/yNV2o0c8I7iB11qu5v2N fZ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s3INGGovBFVhmX7QtTFnrO+FkS94X+2A6b2Y+zQS7qY=; b=r25EOeCDgioXKSVUGj/HAJeY2GkoWhMfnlRtg1GXh8VdEOtscwWeDIT32CVBdikUgS WNMtY9xChXL1jHA5UjMlSz+RJCMAmCweqPnl+sOUuU+rxihRc6Dr1TMNa+CIQL0C2svB LN0PjDgPM1w5pe5xsrl0j+moMuhXU5MvKV2UbnTCnw1TEckpZxdL5gryDLUouR3MZfPo 3hHsuNgi2qaJvv688hkqbebwVXCMiuUyaVX0ClLIhcCvrqo6uync3IAr3oumcafhdR5j VKilp4om/yhSFnY+psvKa67TTHch3eFW0T9ULvhRc21zgFsarOGTyuAAbVQmic49j+uu ENeg== X-Gm-Message-State: AGRZ1gI0leYNlfgeDrAtMkQbDFJz1tchEHXgHlkpLlAM+sFvJyOq27Sg WwxD9ExcFrIs8hmEpktW00bY39Km X-Google-Smtp-Source: AJdET5cpxKcSSRPRAHLdjbgjUiZXATdv6GQRkJtvsWz6SZUigv9nZ7GaJOs9f2etT/TyZuFvOx2/3w== X-Received: by 2002:a5e:8c03:: with SMTP id n3-v6mr6208127ioj.122.1540262215917; Mon, 22 Oct 2018 19:36:55 -0700 (PDT) Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38]) by smtp.googlemail.com with ESMTPSA id z191-v6sm61262itb.31.2018.10.22.19.36.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 19:36:54 -0700 (PDT) References: <55982193.6090206@cs.ucla.edu> From: Assaf Gordon Message-ID: Date: Mon, 22 Oct 2018 20:36:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 20979 fixed close 20979 stop (triaging old bugs) On 04/07/15 12:53 PM, Andreas Grünbacher wrote: > 2015-07-04 20:10 GMT+02:00 Paul Eggert : >> John David Anglin wrote: >>> The following error occurs building coreutils-8.24 on >>> hppa2.0w-hp-hpux11.11 with gcc-5: >>> >> >> Thanks for reporting that. There are some obvious typos in the >> recent ACL-related patches when compiled on HP-UX. I installed the >> attached patch >> into gnulib; can you please give it a try on coreutils 8.24? I >> don't have access to an HP-UX box to test it myself. >> > thanks for fixing this. On 05/07/15 04:47 AM, Andreas Grünbacher wrote: > David, > > 2015-07-05 0:40 GMT+02:00 John David Anglin : >> In this function, "mode" needs to be "ctx->mode" and "entries" needs to be "ctx->aclv_entries". >> It then compiles okay. > > thanks, I've fixed this in gnulib. Still needs to be pulled into coreutils. > marking as "fixed" and closing. -assaf