GNU bug report logs - #20979
../lib/set-permissions.c:288:27: error: 'mode' undeclared

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20979 in the body.
You can then email your comments to 20979 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John David Anglin <dave.anglin <at> bell.net>
To: bug-coreutils <at> gnu.org
Subject: ../lib/set-permissions.c:288:27: error: 'mode' undeclared
Date: Sat, 4 Jul 2015 11:32:30 -0400

The following error occurs building coreutils-8.24 on hppa2.0w-hp-hpux11.11 with gcc-5:

  CC       lib/set-permissions.o../lib/set-permissions.c: In function 'context_acl_from_mode':
../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use in this function)
   ctx->entries[0].mode = (mode >> 6) & 7;
                           ^
../lib/set-permissions.c:288:27: note: each undeclared identifier is reported on
ly once for each function it appears in
../lib/set-permissions.c: In function 'context_aclv_from_mode':
../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use in this fun
ction)
   ctx->aclv_entries[0].a_perm = (mode >> 6) & 7;
                                  ^
../lib/set-permissions.c:319:26: error: 'entries' undeclared (first use in this 
function)
   ret = aclsort (sizeof (entries) / sizeof (struct acl), 1, entries);
                          ^
../lib/set-permissions.c: In function 'set_acls':
../lib/set-permissions.c:660:69: error: 'source_statbuf' undeclared (first use in this function)
        && (from_mode || !acl_nontrivial (ctx->count, ctx->entries, &source_statbuf)))
                                                                     ^
../lib/set-permissions.c:660:26: error: too many arguments to function 'acl_nontrivial'
        && (from_mode || !acl_nontrivial (ctx->count, ctx->entries, &source_statbuf)))
                          ^
In file included from ../lib/set-permissions.c:24:0:
../lib/acl-internal.h:215:12: note: declared here
 extern int acl_nontrivial (int count, struct acl_entry *entries);
            ^
make[2]: *** [lib/set-permissions.o] Error 1
make[2]: Leaving directory `/xxx/gnu/coreutils-8.24/objdir'
make[1]: *** [all-recursive] Error 1

Dave
--
John David Anglin	dave.anglin <at> bell.net

Message #8 received at 20979 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: John David Anglin <dave.anglin <at> bell.net>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>,
 Andreas Gruenbacher <andreas.gruenbacher <at> gmail.com>, 20979 <at> debbugs.gnu.org
Subject: Re: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode'
 undeclared
Date: Sat, 04 Jul 2015 11:10:27 -0700

[Message part 1 (text/plain, inline)]

John David Anglin wrote:
> The following error occurs building coreutils-8.24 on hppa2.0w-hp-hpux11.11 with gcc-5:
>
>    CC       lib/set-permissions.o../lib/set-permissions.c: In function 'context_acl_from_mode':
> ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use in this function)
>     ctx->entries[0].mode = (mode >> 6) & 7;
...

Thanks for reporting that.  There are some obvious typos in the recent 
ACL-related patches when compiled on HP-UX.  I installed the attached patch into 
gnulib; can you please give it a try on coreutils 8.24?  I don't have access to 
an HP-UX box to test it myself.

I'll CC: this to Andreas Gruenbacher, the author of the recent patches, to give 
him a heads-up.

[0001-file-has-acl-acl-permissions-fix-HP-UX-typos.patch (text/x-diff, attachment)]

Message #11 received at 20979 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Grünbacher <andreas.gruenbacher <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>, John David Anglin <dave.anglin <at> bell.net>,
 20979 <at> debbugs.gnu.org
Subject: Re: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode'
 undeclared
Date: Sat, 4 Jul 2015 20:53:08 +0200

Paul,

2015-07-04 20:10 GMT+02:00 Paul Eggert <eggert <at> cs.ucla.edu>:
> John David Anglin wrote:
>>
>> The following error occurs building coreutils-8.24 on
>> hppa2.0w-hp-hpux11.11 with gcc-5:
>>
>>    CC       lib/set-permissions.o../lib/set-permissions.c: In function
>> 'context_acl_from_mode':
>> ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use in
>> this function)
>>     ctx->entries[0].mode = (mode >> 6) & 7;
>
> ...
>
> Thanks for reporting that.  There are some obvious typos in the recent
> ACL-related patches when compiled on HP-UX.  I installed the attached patch
> into gnulib; can you please give it a try on coreutils 8.24?  I don't have
> access to an HP-UX box to test it myself.
>
> I'll CC: this to Andreas Gruenbacher, the author of the recent patches, to
> give him a heads-up.

thanks for fixing this.

Andreas

Message #14 received at 20979 <at> debbugs.gnu.org (full text, mbox):

From: John David Anglin <dave.anglin <at> bell.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>,
 Andreas Gruenbacher <andreas.gruenbacher <at> gmail.com>, 20979 <at> debbugs.gnu.org
Subject: Re: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode'
 undeclared
Date: Sat, 4 Jul 2015 18:29:23 -0400

We know have:

  CC       lib/set-permissions.o
../lib/set-permissions.c: In function 'context_aclv_from_mode':
../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use in this function)
   ctx->aclv_entries[0].a_perm = (mode >> 6) & 7;
                                  ^
../lib/set-permissions.c:307:34: note: each undeclared identifier is reported only once for each function it appears in
../lib/set-permissions.c:319:38: error: 'entries' undeclared (first use in this function)
   ret = aclsort (ctx->aclv_count, 1, entries);
                                      ^

On 2015-07-04, at 2:10 PM, Paul Eggert wrote:

> John David Anglin wrote:
>> The following error occurs building coreutils-8.24 on hppa2.0w-hp-hpux11.11 with gcc-5:
>> 
>>   CC       lib/set-permissions.o../lib/set-permissions.c: In function 'context_acl_from_mode':
>> ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use in this function)
>>    ctx->entries[0].mode = (mode >> 6) & 7;
> ...
> 
> Thanks for reporting that.  There are some obvious typos in the recent ACL-related patches when compiled on HP-UX.  I installed the attached patch into gnulib; can you please give it a try on coreutils 8.24?  I don't have access to an HP-UX box to test it myself.
> 
> I'll CC: this to Andreas Gruenbacher, the author of the recent patches, to give him a heads-up.
> 
> <0001-file-has-acl-acl-permissions-fix-HP-UX-typos.patch>


  CC       lib/set-permissions.o
../lib/set-permissions.c: In function 'context_aclv_from_mode':
../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use in this function)
   ctx->aclv_entries[0].a_perm = (mode >> 6) & 7;
                                  ^
../lib/set-permissions.c:307:34: note: each undeclared identifier is reported only once for each function it appears in
../lib/set-permissions.c:319:38: error: 'entries' undeclared (first use in this function)
   ret = aclsort (ctx->aclv_count, 1, entries);
                                      ^

--
John David Anglin	dave.anglin <at> bell.net

Message #17 received at 20979 <at> debbugs.gnu.org (full text, mbox):

From: John David Anglin <dave.anglin <at> bell.net>
To: John David Anglin <dave.anglin <at> bell.net>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>,
 Andreas Gruenbacher <andreas.gruenbacher <at> gmail.com>,
 Paul Eggert <eggert <at> cs.ucla.edu>, 20979 <at> debbugs.gnu.org
Subject: Re: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode'
 undeclared
Date: Sat, 4 Jul 2015 18:40:38 -0400

In this function, "mode" needs to be "ctx->mode" and "entries" needs to be "ctx->aclv_entries".
It then compiles okay.

Dave

On 2015-07-04, at 6:29 PM, John David Anglin wrote:

> We know have:
> 
>  CC       lib/set-permissions.o
> ../lib/set-permissions.c: In function 'context_aclv_from_mode':
> ../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use in this function)
>   ctx->aclv_entries[0].a_perm = (mode >> 6) & 7;
>                                  ^
> ../lib/set-permissions.c:307:34: note: each undeclared identifier is reported only once for each function it appears in
> ../lib/set-permissions.c:319:38: error: 'entries' undeclared (first use in this function)
>   ret = aclsort (ctx->aclv_count, 1, entries);
>                                      ^
> 
> On 2015-07-04, at 2:10 PM, Paul Eggert wrote:
> 
>> John David Anglin wrote:
>>> The following error occurs building coreutils-8.24 on hppa2.0w-hp-hpux11.11 with gcc-5:
>>> 
>>>  CC       lib/set-permissions.o../lib/set-permissions.c: In function 'context_acl_from_mode':
>>> ../lib/set-permissions.c:288:27: error: 'mode' undeclared (first use in this function)
>>>   ctx->entries[0].mode = (mode >> 6) & 7;
>> ...
>> 
>> Thanks for reporting that.  There are some obvious typos in the recent ACL-related patches when compiled on HP-UX.  I installed the attached patch into gnulib; can you please give it a try on coreutils 8.24?  I don't have access to an HP-UX box to test it myself.
>> 
>> I'll CC: this to Andreas Gruenbacher, the author of the recent patches, to give him a heads-up.
>> 
>> <0001-file-has-acl-acl-permissions-fix-HP-UX-typos.patch>
> 
> 
>  CC       lib/set-permissions.o
> ../lib/set-permissions.c: In function 'context_aclv_from_mode':
> ../lib/set-permissions.c:307:34: error: 'mode' undeclared (first use in this function)
>   ctx->aclv_entries[0].a_perm = (mode >> 6) & 7;
>                                  ^
> ../lib/set-permissions.c:307:34: note: each undeclared identifier is reported only once for each function it appears in
> ../lib/set-permissions.c:319:38: error: 'entries' undeclared (first use in this function)
>   ret = aclsort (ctx->aclv_count, 1, entries);
>                                      ^
> 
> --
> John David Anglin	dave.anglin <at> bell.net
> 
> 
> 
> 

--
John David Anglin	dave.anglin <at> bell.net

Message #20 received at 20979 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Grünbacher <andreas.gruenbacher <at> gmail.com>
To: John David Anglin <dave.anglin <at> bell.net>
Cc: Gnulib bugs <bug-gnulib <at> gnu.org>, Paul Eggert <eggert <at> cs.ucla.edu>,
 20979 <at> debbugs.gnu.org
Subject: Re: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode'
 undeclared
Date: Sun, 5 Jul 2015 12:47:28 +0200

David,

2015-07-05 0:40 GMT+02:00 John David Anglin <dave.anglin <at> bell.net>:
> In this function, "mode" needs to be "ctx->mode" and "entries" needs to be "ctx->aclv_entries".
> It then compiles okay.

thanks, I've fixed this in gnulib. Still needs to be pulled into coreutils.

Andreas

Message #23 received at 20979 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: 20979 <at> debbugs.gnu.org
Subject: Re: bug#20979: ../lib/set-permissions.c:288:27: error: 'mode'
 undeclared
Date: Mon, 22 Oct 2018 20:36:53 -0600

tags 20979 fixed
close 20979
stop

(triaging old bugs)

On 04/07/15 12:53 PM, Andreas Grünbacher wrote:
> 2015-07-04 20:10 GMT+02:00 Paul Eggert <eggert <at> cs.ucla.edu>:
>> John David Anglin wrote:
>>> The following error occurs building coreutils-8.24 on 
>>> hppa2.0w-hp-hpux11.11 with gcc-5: >>>
>>
>> Thanks for reporting that. There are some obvious typos in the
>> recent ACL-related patches when compiled on HP-UX. I installed the
>> attached  patch
>> into gnulib; can you please give it a try on coreutils 8.24? I
>> don't have access to an HP-UX box to test it myself.
>> 
> thanks for fixing this.


On 05/07/15 04:47 AM, Andreas Grünbacher wrote:
> David,
> 
> 2015-07-05 0:40 GMT+02:00 John David Anglin <dave.anglin <at> bell.net>:
>> In this function, "mode" needs to be "ctx->mode" and "entries" needs to be "ctx->aclv_entries".
>> It then compiles okay.
> 
> thanks, I've fixed this in gnulib. Still needs to be pulled into coreutils.
> 

marking as "fixed" and closing.


-assaf

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.