GNU bug report logs - #20976
25.0.50; [PATCH] Fix too high return in some cases of status_notify

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20976: closed (25.0.50; [PATCH] Fix too high return in some
 cases of status_notify)
Date: Sun, 05 Jul 2015 22:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 05 Jul 2015 15:16:22 -0700
with message-id <5599ACB6.5010403 <at> cs.ucla.edu>
and subject line Re:  25.0.50; [PATCH] Fix too high return in some cases of status_notify
has caused the debbugs.gnu.org bug report #20976,
regarding 25.0.50; [PATCH] Fix too high return in some cases of status_notify
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20976: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20976
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ian Kelling <ian <at> iankelling.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; [PATCH] Fix too high return in some cases of status_notify
Date: Sat, 04 Jul 2015 02:13:32 -0700

* src/process.c (status_notify): Fix too high return in some
cases.
---
This was clearly intended to be part of the patch for debbugs:17647 (git
05d2821). The same pattern used elsewhere and wait_proc is an an unused
parameter added in that patch.

diff --git a/src/process.c b/src/process.c
index 3132f19..5272792 100644
--- a/src/process.c
+++ b/src/process.c
@@ -6714,7 +6714,8 @@ status_notify (struct Lisp_Process *deleting_process,
                 && p != deleting_process)
            {
              int nread = read_process_output (proc, p->infd);
-	      if (got_some_input < nread)
+	      if ((!wait_proc || wait_proc == XPROCESS (proc))
+                  && got_some_input < nread)
                got_some_input = nread;
              if (nread <= 0)
                break;
--
1.9.1

[Message part 3 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Ian Kelling <ian <at> iankelling.org>
Cc: 20976-done <at> debbugs.gnu.org
Subject: Re:  25.0.50;
 [PATCH] Fix too high return in some cases of status_notify
Date: Sun, 05 Jul 2015 15:16:22 -0700

Thanks, I installed that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.