From unknown Mon Jun 23 18:27:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20976: 25.0.50; [PATCH] Fix too high return in some cases of status_notify Resent-From: Ian Kelling Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jul 2015 09:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 20976@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.143600123312271 (code B ref -1); Sat, 04 Jul 2015 09:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jul 2015 09:13:53 +0000 Received: from localhost ([127.0.0.1]:39226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBJWC-0003Br-NM for submit@debbugs.gnu.org; Sat, 04 Jul 2015 05:13:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40913) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBJWB-0003Bc-1W for submit@debbugs.gnu.org; Sat, 04 Jul 2015 05:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBJW5-0005Wk-3f for submit@debbugs.gnu.org; Sat, 04 Jul 2015 05:13:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBJW5-0005We-0Q for submit@debbugs.gnu.org; Sat, 04 Jul 2015 05:13:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBJW4-0002zU-3p for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 05:13:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBJW0-0005VZ-3g for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 05:13:44 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBJVz-0005Uu-TJ for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 05:13:40 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 38C8E20B29; Sat, 4 Jul 2015 05:13:38 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 04 Jul 2015 05:13:38 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=iankelling.org; h= content-type:date:from:message-id:mime-version:subject:to :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=CyotL8dfWYqm7uPSpkQCRjtMVxs =; b=hFt1gYIhiRDYzytACsPf07Zf924EojvBc3xiaLA0TOGAG9aZc9cK0qu/R5J IBwP3j2upo1a5gCZHtO0g1sLnjXte1ZI7TFrkunLoKxzLg6sukl/lvBDKjmFr0E1 O+7KdoUVpKE/fbpg1cWi/HpO4WYXFInWI91moRg+sfYCbYrk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=Cy otL8dfWYqm7uPSpkQCRjtMVxs=; b=fB/J+CQPCgwgs4YOAvW1ymE9XlT2HWcP8r tkq2m+HyK5SUd1pBJx0dgfpm7KcumSjiNmL/QHFoX4LKDdKoDEx5AToabp12nL4F YDlMe+MeVAihxh0EvXCrOdoAwBYNfJecSM8lhsDzBfvrEp20WEs7eXgWUAqycovL A2nliwT88= X-Sasl-enc: u+P/rXu+wFJKaJ4U1DwSEU6wiqhj7tnLWqmzj4mGkbhC 1436001217 Received: from treetowl.lan (c-73-53-70-213.hsd1.wa.comcast.net [73.53.70.213]) by mail.messagingengine.com (Postfix) with ESMTPA id E1F5668012A for ; Sat, 4 Jul 2015 05:13:37 -0400 (EDT) Received: by treetowl.lan (Postfix, from userid 1000) id 1B1801FE26; Sat, 4 Jul 2015 02:13:32 -0700 (PDT) From: Ian Kelling Date: Sat, 04 Jul 2015 02:13:32 -0700 Message-ID: <87vbe0s2tf.fsf@iankelling.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * src/process.c (status_notify): Fix too high return in some cases. --- This was clearly intended to be part of the patch for debbugs:17647 (git 05d2821). The same pattern used elsewhere and wait_proc is an an unused parameter added in that patch. diff --git a/src/process.c b/src/process.c index 3132f19..5272792 100644 --- a/src/process.c +++ b/src/process.c @@ -6714,7 +6714,8 @@ status_notify (struct Lisp_Process *deleting_process, && p != deleting_process) { int nread = read_process_output (proc, p->infd); - if (got_some_input < nread) + if ((!wait_proc || wait_proc == XPROCESS (proc)) + && got_some_input < nread) got_some_input = nread; if (nread <= 0) break; -- 1.9.1 From unknown Mon Jun 23 18:27:26 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ian Kelling Subject: bug#20976: closed (Re: 25.0.50; [PATCH] Fix too high return in some cases of status_notify) Message-ID: References: <5599ACB6.5010403@cs.ucla.edu> <87vbe0s2tf.fsf@iankelling.org> X-Gnu-PR-Message: they-closed 20976 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 20976@debbugs.gnu.org Date: Sun, 05 Jul 2015 22:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1436134622-22635-1" This is a multi-part message in MIME format... ------------=_1436134622-22635-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20976: 25.0.50; [PATCH] Fix too high return in some cases of status_notify which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20976@debbugs.gnu.org. --=20 20976: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20976 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1436134622-22635-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20976-done) by debbugs.gnu.org; 5 Jul 2015 22:16:37 +0000 Received: from localhost ([127.0.0.1]:41176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBsDE-0005sH-08 for submit@debbugs.gnu.org; Sun, 05 Jul 2015 18:16:36 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41432) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBsDB-0005rz-I6 for 20976-done@debbugs.gnu.org; Sun, 05 Jul 2015 18:16:34 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BCF641601E5; Sun, 5 Jul 2015 15:16:27 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id FYfNf65F5kmf; Sun, 5 Jul 2015 15:16:27 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 24B1B160952; Sun, 5 Jul 2015 15:16:27 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fm1CzzoTQi5b; Sun, 5 Jul 2015 15:16:27 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0860A1601E5; Sun, 5 Jul 2015 15:16:27 -0700 (PDT) Message-ID: <5599ACB6.5010403@cs.ucla.edu> Date: Sun, 05 Jul 2015 15:16:22 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ian Kelling Subject: Re: 25.0.50; [PATCH] Fix too high return in some cases of status_notify Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20976-done Cc: 20976-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Thanks, I installed that. ------------=_1436134622-22635-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jul 2015 09:13:53 +0000 Received: from localhost ([127.0.0.1]:39226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBJWC-0003Br-NM for submit@debbugs.gnu.org; Sat, 04 Jul 2015 05:13:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40913) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBJWB-0003Bc-1W for submit@debbugs.gnu.org; Sat, 04 Jul 2015 05:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBJW5-0005Wk-3f for submit@debbugs.gnu.org; Sat, 04 Jul 2015 05:13:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBJW5-0005We-0Q for submit@debbugs.gnu.org; Sat, 04 Jul 2015 05:13:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBJW4-0002zU-3p for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 05:13:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBJW0-0005VZ-3g for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 05:13:44 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBJVz-0005Uu-TJ for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 05:13:40 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 38C8E20B29; Sat, 4 Jul 2015 05:13:38 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 04 Jul 2015 05:13:38 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=iankelling.org; h= content-type:date:from:message-id:mime-version:subject:to :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=CyotL8dfWYqm7uPSpkQCRjtMVxs =; b=hFt1gYIhiRDYzytACsPf07Zf924EojvBc3xiaLA0TOGAG9aZc9cK0qu/R5J IBwP3j2upo1a5gCZHtO0g1sLnjXte1ZI7TFrkunLoKxzLg6sukl/lvBDKjmFr0E1 O+7KdoUVpKE/fbpg1cWi/HpO4WYXFInWI91moRg+sfYCbYrk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=Cy otL8dfWYqm7uPSpkQCRjtMVxs=; b=fB/J+CQPCgwgs4YOAvW1ymE9XlT2HWcP8r tkq2m+HyK5SUd1pBJx0dgfpm7KcumSjiNmL/QHFoX4LKDdKoDEx5AToabp12nL4F YDlMe+MeVAihxh0EvXCrOdoAwBYNfJecSM8lhsDzBfvrEp20WEs7eXgWUAqycovL A2nliwT88= X-Sasl-enc: u+P/rXu+wFJKaJ4U1DwSEU6wiqhj7tnLWqmzj4mGkbhC 1436001217 Received: from treetowl.lan (c-73-53-70-213.hsd1.wa.comcast.net [73.53.70.213]) by mail.messagingengine.com (Postfix) with ESMTPA id E1F5668012A for ; Sat, 4 Jul 2015 05:13:37 -0400 (EDT) Received: by treetowl.lan (Postfix, from userid 1000) id 1B1801FE26; Sat, 4 Jul 2015 02:13:32 -0700 (PDT) From: Ian Kelling To: bug-gnu-emacs@gnu.org Subject: 25.0.50; [PATCH] Fix too high return in some cases of status_notify Date: Sat, 04 Jul 2015 02:13:32 -0700 Message-ID: <87vbe0s2tf.fsf@iankelling.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * src/process.c (status_notify): Fix too high return in some cases. --- This was clearly intended to be part of the patch for debbugs:17647 (git 05d2821). The same pattern used elsewhere and wait_proc is an an unused parameter added in that patch. diff --git a/src/process.c b/src/process.c index 3132f19..5272792 100644 --- a/src/process.c +++ b/src/process.c @@ -6714,7 +6714,8 @@ status_notify (struct Lisp_Process *deleting_process, && p != deleting_process) { int nread = read_process_output (proc, p->infd); - if (got_some_input < nread) + if ((!wait_proc || wait_proc == XPROCESS (proc)) + && got_some_input < nread) got_some_input = nread; if (nread <= 0) break; -- 1.9.1 ------------=_1436134622-22635-1--