GNU bug report logs - #20956
[PATCH] Fix imap message size parsing

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20956 in the body.
You can then email your comments to 20956 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nikolaus Rath <Nikolaus <at> rath.org>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] Fix imap message size parsing
Date: Wed, 01 Jul 2015 19:45:05 -0700

[Message part 1 (text/plain, inline)]

Package: gnus
Tags: patch

IMAP servers may sent the data items in a FETCH response in arbitrary
order. However, currently Gnus assumes that the UID item is sent before
the RFC822.SIZE item. If this assumption is wrong, Gnus is unable to
determine the message size.

The attached patch fixes this issue.

Best,
-Nikolaus

-- 
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«

[transform_headers.patch (text/x-diff, inline)]

--- nnimap.el.bak1	2015-05-26 19:26:56.646513004 -0700
+++ nnimap.el.bak2	2015-07-01 19:39:26.057089923 -0700
@@ -230,6 +230,7 @@
 				      t)
 		   (match-string 1)))
 	(setq lines nil)
+	(beginning-of-line)
 	(setq size
 	      (and (re-search-forward "RFC822.SIZE \\([0-9]+\\)"
 				      (line-end-position)

Message #8 received at 20956 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Nikolaus Rath <Nikolaus <at> rath.org>
Cc: 20956 <at> debbugs.gnu.org, ding <at> gnus.org
Subject: Re: bug#20956: [PATCH] Fix imap message size parsing
Date: Tue, 07 Jul 2015 10:53:02 +0800

Nikolaus Rath <Nikolaus <at> rath.org> writes:

> Package: gnus
> Tags: patch
>
> IMAP servers may sent the data items in a FETCH response in arbitrary
> order. However, currently Gnus assumes that the UID item is sent before
> the RFC822.SIZE item. If this assumption is wrong, Gnus is unable to
> determine the message size.
>
> The attached patch fixes this issue.
>
> Best,
> -Nikolaus

Hi Nikolaus,

Would you please resend the patch using git format-patch, and I'll apply
it? With just this patch file, I'd have to manually re-create the
commit, which would lose your metadata as author. Same for your other
two patches, if you don't mind.

Thanks!
Eric

Message #13 received at 20956-done <at> debbugs.gnu.org (full text, mbox):

From: Nikolaus Rath <Nikolaus <at> rath.org>
To: 20956-done <at> debbugs.gnu.org
Subject: Fixed
Date: Sun, 01 Jan 2017 11:02:59 -0800

Fixed in commit 1f1d39c3bcaed9870ab7f13c3c0369f17a16cee2.

-- 
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.