GNU bug report logs - #20943
25.0.50; Dired buffers are not always auto-reverterd

Previous Next

Package: emacs;

Reported by: Mark Karpov <markkarpov <at> openmailbox.org>

Date: Tue, 30 Jun 2015 18:24:02 UTC

Severity: normal

Found in version 25.0.50

Done: Mark Karpov <markkarpov <at> openmailbox.org>

Bug is archived. No further changes may be made.

Full log

Message #101 received at 20943 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Mark Karpov <markkarpov <at> openmailbox.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 20943 <at> debbugs.gnu.org
Subject: Re: bug#20943: 25.0.50; Dired buffers are not always auto-reverted
Date: Thu, 09 Jul 2015 20:41:50 +0200

Mark Karpov <markkarpov <at> openmailbox.org> writes:

> 1. In ‘auto-revert-handler’, autorevert modified files if current buffer
> is a Dired buffer:
>
> (defun auto-revert-handler ()
>   "Revert current buffer, if appropriate.
> This is an internal function used by Auto-Revert Mode."
>   (when (or auto-revert-tail-mode
>             (eq major-mode dired-mode)
>             (not (buffer-modified-p)))
>     ...))

I fear this is the wrong direction to fix it. `auto-revert-handler' shall
not know about major modes. All what a buffer has to say to
`auto-revert-handler' must be in `buffer-stale-function', which is set to
`dired-buffer-stale-p' here.

What happens, if you remove the test for `buffer-read-only' from that
function?

Best regards, Michael.
This bug report was last modified 9 years and 310 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.