From nickrob@snap.net.nz Tue Jan 27 23:05:25 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 28 Jan 2009 07:05:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0S75LAn030628 for ; Tue, 27 Jan 2009 23:05:22 -0800 Received: from mail.gnu.org ([199.232.76.166]:60245 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LS4Sc-0006no-1b for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:03:42 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LS4U8-0007Rw-HU for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:05:19 -0500 Received: from viper.snap.net.nz ([202.37.101.23]:50958) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LS4U8-0007R5-47 for emacs-pretest-bug@gnu.org; Wed, 28 Jan 2009 02:05:16 -0500 Received: from kahikatea.snap.net.nz (unknown [123.255.31.95]) by viper.snap.net.nz (Postfix) with ESMTP id 0DAD73DA8C9 for ; Wed, 28 Jan 2009 19:35:46 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 74C018FC6D; Wed, 28 Jan 2009 19:34:34 +1300 (NZDT) From: Nick Roberts To: emacs-pretest-bug@gnu.org Subject: 23.0.60; vc-svn-diff Message-Id: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> Date: Wed, 28 Jan 2009 19:34:34 +1300 (NZDT) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 vc-svn-diff fails when oldvers equals (vc-working-revision f). In that case "svn diff" executes with no -r argument and only gives a diff if the file is locally modified. To see this bug, do vc-print-log on a file under Subversion control that needs an update (newer revisions have been committed by someone else). Place the cursor over the revision after (in time) the working-revision (the revison with the number in the modeline) and press d (log-viw-diff). I think this clause needs to be removed: (and oldvers files (catch 'no (dolist (f files) (or (equal oldvers (vc-working-revision f)) (throw 'no nil))) t) ;; Use nil rather than the current revision because svn handles ;; it better (i.e. locally). Note that if _any_ of the files ;; has a different revision, we fetch the lot, which is ;; obviously sub-optimal. (setq oldvers nil)) I don't see how it could ever work (please note that I'm not saying that it could never work just that I don't see how it could). -- Nick http://www.inet.net.nz/~nickrob From monnier@iro.umontreal.ca Mon Feb 2 09:09:44 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 2 Feb 2009 17:09:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER,XIRONPORT autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12H9fJR002082 for ; Mon, 2 Feb 2009 09:09:43 -0800 Received: from mx10.gnu.org ([199.232.76.166]:39694) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LU2H4-0008Bm-W8 for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 12:07:55 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LU2Ij-0000e5-LH for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 12:09:40 -0500 Received: from ironport2-out.pppoe.ca ([206.248.154.182]:15942 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LU2Ii-0000dB-Kc for emacs-pretest-bug@gnu.org; Mon, 02 Feb 2009 12:09:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AswEAD+3hknO+IQk/2dsb2JhbACBbsozhBQGgmw X-IronPort-AV: E=Sophos;i="4.37,366,1231131600"; d="scan'208";a="33208424" Received: from 206-248-132-36.dsl.teksavvy.com (HELO ceviche.home) ([206.248.132.36]) by ironport2-out.teksavvy.com with ESMTP; 02 Feb 2009 12:09:17 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 061EAB4060; Sun, 1 Feb 2009 17:39:37 -0500 (EST) From: Stefan Monnier To: Nick Roberts Cc: 2092@debbugs.gnu.org, emacs-pretest-bug@gnu.org Subject: Re: bug#2092: 23.0.60; vc-svn-diff Message-ID: References: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> Date: Sun, 01 Feb 2009 17:39:37 -0500 In-Reply-To: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> (Nick Roberts's message of "Wed, 28 Jan 2009 19:34:34 +1300 (NZDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. > vc-svn-diff fails when oldvers equals (vc-working-revision f). > In that case "svn diff" executes with no -r argument and only gives > a diff if the file is locally modified. That's the right behavior when newvers is nil, isn't it? > I don't see how it could ever work (please note that I'm not saying that > it could never work just that I don't see how it could). I think it was written assuming (incorrectly) that "newvers == nil". Is the bug fixed if you add (null newvers) to the conjunction? Stefan PS: I see you've already removed this code, but I remember we added specifically upon request from some users, so it would be better to fix it than to remove it. From nickrob@snap.net.nz Wed Feb 4 03:03:14 2009 Received: (at 2092-done) by emacsbugs.donarmstrong.com; 4 Feb 2009 11:03:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from viper.snap.net.nz (viper.snap.net.nz [202.37.101.23]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n14B3A9s017418 for <2092-done@emacsbugs.donarmstrong.com>; Wed, 4 Feb 2009 03:03:11 -0800 Received: from kahikatea.snap.net.nz (113.29.255.123.dynamic.snap.net.nz [123.255.29.113]) by viper.snap.net.nz (Postfix) with ESMTP id 628F73D9F9A; Thu, 5 Feb 2009 00:03:04 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 7759D8FC6D; Thu, 5 Feb 2009 00:03:02 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18825.30181.243954.921791@kahikatea.snap.net.nz> Date: Thu, 5 Feb 2009 00:03:01 +1300 To: Stefan Monnier Cc: 2092-done@debbugs.gnu.org, emacs-pretest-bug@gnu.org Subject: Re: bug#2092: 23.0.60; vc-svn-diff In-Reply-To: References: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.3.1 > > vc-svn-diff fails when oldvers equals (vc-working-revision f). > > In that case "svn diff" executes with no -r argument and only gives > > a diff if the file is locally modified. > > That's the right behavior when newvers is nil, isn't it? > > > I don't see how it could ever work (please note that I'm not saying that > > it could never work just that I don't see how it could). > > I think it was written assuming (incorrectly) that "newvers == nil". > Is the bug fixed if you add (null newvers) to the conjunction? > > > Stefan > > > PS: I see you've already removed this code, but I remember we added > specifically upon request from some users, so it would be better to fix > it than to remove it. OK, I've looked through the archives. I find it odd because: 1) I think that svn should be able to work out whether it can handle a request locally (a bug in svn?). 2) If you do "C-x v =" there is no problem. 3) I can only see a problem with "C-u C-x v =" with the default values which is eqivalent to 2). So it looks very much like a corner case. Anyway I've done as you say. -- Nick http://www.inet.net.nz/~nickrob From monnier@IRO.UMontreal.CA Wed Feb 4 11:42:58 2009 Received: (at 2092) by emacsbugs.donarmstrong.com; 4 Feb 2009 19:42:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n14Jgsq2020045 for <2092@emacsbugs.donarmstrong.com>; Wed, 4 Feb 2009 11:42:55 -0800 Received: from alfajor.home (vpn-132-204-232-41.acd.umontreal.ca [132.204.232.41]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n14JgrkW027140; Wed, 4 Feb 2009 14:42:53 -0500 Received: by alfajor.home (Postfix, from userid 20848) id CA682A22D8; Wed, 4 Feb 2009 14:42:52 -0500 (EST) From: Stefan Monnier To: Nick Roberts Cc: 2092@debbugs.gnu.org Subject: Re: bug#2092: 23.0.60; vc-svn-diff Message-ID: References: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> <18825.30181.243954.921791@kahikatea.snap.net.nz> Date: Wed, 04 Feb 2009 14:42:52 -0500 In-Reply-To: <18825.30181.243954.921791@kahikatea.snap.net.nz> (Nick Roberts's message of "Thu, 5 Feb 2009 00:03:01 +1300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3204=0 > OK, I've looked through the archives. I find it odd because: > 1) I think that svn should be able to work out whether it can handle a > request locally (a bug in svn?). Agreed. > 2) If you do "C-x v =" there is no problem. Yes, in that case OLDVERS is nil. > 3) I can only see a problem with "C-u C-x v =" with the default values which > is eqivalent to 2). Indeed. Basically, `svn diff foo' works locally, whereas `svn diff -r REV foo' never works locally, even if VERS is the current working revision (in which case the result should be identical to `svn diff foo'). It's arguably a misfeature of `svn'. > So it looks very much like a corner case. It is. > Anyway I've done as you say. Thank you. Stefan From unknown Fri Jun 20 05:35:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Mar 2009 15:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator