From unknown Mon Aug 18 18:03:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20916: 25.0.50; [PATCH] Calc `s p' glitch Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: jay.p.belanger@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 14:05:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20916 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 20916@debbugs.gnu.org Cc: Jay Belanger X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Jay Belanger Received: via spool by submit@debbugs.gnu.org id=B.143550026732138 (code B ref -1); Sun, 28 Jun 2015 14:05:03 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jun 2015 14:04:27 +0000 Received: from localhost ([127.0.0.1]:60479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9DC6-0008MG-66 for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:04:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43821) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9DC4-0008M2-E9 for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:04:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9DBy-000401-Dp for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:04:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9DBy-0003zx-BS for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:04:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9DBx-0001Uc-GN for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2015 10:04:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9DBu-0003yV-Aa for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2015 10:04:17 -0400 Received: from b2bfep12.mx.upcmail.net ([62.179.121.57]:43727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9DBu-0003yO-0d for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2015 10:04:14 -0400 Received: from edge11.upcmail.net ([192.168.13.81]) by b2bfep16.mx.upcmail.net (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20150628140208.IJUI21885.b2bfep16-int.chello.at@edge11.upcmail.net> for ; Sun, 28 Jun 2015 16:02:08 +0200 Received: from iznogoud.viz ([91.119.85.218]) by edge11.upcmail.net with edge id lq2c1q00P4ieVW30Bq2c74; Sun, 28 Jun 2015 16:02:36 +0200 X-SourceIP: 91.119.85.218 Received: from wolfgang by iznogoud.viz with local (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Z9DAK-00038f-7V for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2015 16:02:36 +0200 From: Wolfgang Jenkner Date: Sun, 28 Jun 2015 15:57:57 +0200 Message-ID: <85egkwylqb.fsf@iznogoud.viz> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) May I push the following patch? -- >8 -- >From 4c78b6aa26675f980d37fca7c0924f5219a4edb6 Mon Sep 17 00:00:00 2001 From: Wolfgang Jenkner Date: Sun, 28 Jun 2015 15:46:57 +0200 Subject: [PATCH] * lisp/calc-store.el (calc-insert-permanent-variable): Heed case. Otherwise `s p' of f and F will stomp on each other's value. --- lisp/calc/calc-store.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/calc/calc-store.el b/lisp/calc/calc-store.el index 11bf964..91b927a 100644 --- a/lisp/calc/calc-store.el +++ b/lisp/calc/calc-store.el @@ -609,7 +609,8 @@ (defun calc-insert-permanent-variable (var) (goto-char (point-min)) - (if (search-forward (concat "(setq " (symbol-name var) " '") nil t) + (if (let (case-fold-search) + (search-forward (concat "(setq " (symbol-name var) " '") nil t)) (progn (setq calc-pv-pos (point-marker)) (forward-line -1) -- 2.4.2 From unknown Mon Aug 18 18:03:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Wolfgang Jenkner Subject: bug#20916: closed (Re: bug#20916: 25.0.50; [PATCH] Calc `s p' glitch) Message-ID: References: <85oajyad3p.fsf@iznogoud.viz> <85egkwylqb.fsf@iznogoud.viz> X-Gnu-PR-Message: they-closed 20916 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 20916@debbugs.gnu.org Date: Mon, 29 Jun 2015 12:56:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1435582563-18425-1" This is a multi-part message in MIME format... ------------=_1435582563-18425-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20916: 25.0.50; [PATCH] Calc `s p' glitch which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20916@debbugs.gnu.org. --=20 20916: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20916 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1435582563-18425-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20916-done) by debbugs.gnu.org; 29 Jun 2015 12:55:17 +0000 Received: from localhost ([127.0.0.1]:60967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Yai-0004mD-Oq for submit@debbugs.gnu.org; Mon, 29 Jun 2015 08:55:17 -0400 Received: from b2bfep12.mx.upcmail.net ([62.179.121.57]:37973) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Yag-0004lz-57 for 20916-done@debbugs.gnu.org; Mon, 29 Jun 2015 08:55:15 -0400 Received: from edge11.upcmail.net ([192.168.13.81]) by b2bfep12.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150629125507.YNWH604.b2bfep12-int.chello.at@edge11.upcmail.net> for <20916-done@debbugs.gnu.org>; Mon, 29 Jun 2015 14:55:07 +0200 Received: from iznogoud.viz ([91.119.119.243]) by edge11.upcmail.net with edge id mCv61q02C5FActn0BCv7rU; Mon, 29 Jun 2015 14:55:07 +0200 X-SourceIP: 91.119.119.243 Received: from wolfgang by iznogoud.viz with local (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Z9YaY-0003Au-K7; Mon, 29 Jun 2015 14:55:06 +0200 From: Wolfgang Jenkner To: 20916-done@debbugs.gnu.org Subject: Re: bug#20916: 25.0.50; [PATCH] Calc `s p' glitch Date: Mon, 29 Jun 2015 14:54:32 +0200 References: <85egkwylqb.fsf@iznogoud.viz> Message-ID: <85oajyad3p.fsf@iznogoud.viz> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20916-done Cc: jay.p.belanger@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Version: 25.1 The Calc maintainer kindly replied in private email. Pushed. ------------=_1435582563-18425-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jun 2015 14:04:27 +0000 Received: from localhost ([127.0.0.1]:60479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9DC6-0008MG-66 for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:04:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43821) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9DC4-0008M2-E9 for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:04:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9DBy-000401-Dp for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:04:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9DBy-0003zx-BS for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:04:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9DBx-0001Uc-GN for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2015 10:04:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9DBu-0003yV-Aa for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2015 10:04:17 -0400 Received: from b2bfep12.mx.upcmail.net ([62.179.121.57]:43727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9DBu-0003yO-0d for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2015 10:04:14 -0400 Received: from edge11.upcmail.net ([192.168.13.81]) by b2bfep16.mx.upcmail.net (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20150628140208.IJUI21885.b2bfep16-int.chello.at@edge11.upcmail.net> for ; Sun, 28 Jun 2015 16:02:08 +0200 Received: from iznogoud.viz ([91.119.85.218]) by edge11.upcmail.net with edge id lq2c1q00P4ieVW30Bq2c74; Sun, 28 Jun 2015 16:02:36 +0200 X-SourceIP: 91.119.85.218 Received: from wolfgang by iznogoud.viz with local (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Z9DAK-00038f-7V for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2015 16:02:36 +0200 From: Wolfgang Jenkner To: bug-gnu-emacs@gnu.org Subject: 25.0.50; [PATCH] Calc `s p' glitch Date: Sun, 28 Jun 2015 15:57:57 +0200 X-Debbugs-CC: Jay Belanger Message-ID: <85egkwylqb.fsf@iznogoud.viz> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) May I push the following patch? -- >8 -- >From 4c78b6aa26675f980d37fca7c0924f5219a4edb6 Mon Sep 17 00:00:00 2001 From: Wolfgang Jenkner Date: Sun, 28 Jun 2015 15:46:57 +0200 Subject: [PATCH] * lisp/calc-store.el (calc-insert-permanent-variable): Heed case. Otherwise `s p' of f and F will stomp on each other's value. --- lisp/calc/calc-store.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/calc/calc-store.el b/lisp/calc/calc-store.el index 11bf964..91b927a 100644 --- a/lisp/calc/calc-store.el +++ b/lisp/calc/calc-store.el @@ -609,7 +609,8 @@ (defun calc-insert-permanent-variable (var) (goto-char (point-min)) - (if (search-forward (concat "(setq " (symbol-name var) " '") nil t) + (if (let (case-fold-search) + (search-forward (concat "(setq " (symbol-name var) " '") nil t)) (progn (setq calc-pv-pos (point-marker)) (forward-line -1) -- 2.4.2 ------------=_1435582563-18425-1--